[Koha-bugs] [Bug 26121] When using CodeMirror in News Tool DatePicker is hard to see

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26121

Lucas Gass  changed:

   What|Removed |Added

Summary|When using CodeMirror in|When using CodeMirror in
   |News Tool DatePicker cant   |News Tool DatePicker is
   |be seen |hard to see

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields"

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields"

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420

--- Comment #1 from Lucas Gass  ---
Created attachment 107662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107662=edit
Bug 23420: Add OPACSuggestionUnwantedFields option

To test:
-Apply patch
-Check OPACSuggestionUnwantedFields
-Check some fields as unwanted
-Go to the OPAC suggestion page and make sure these correct fields are hidden
-Go through each option and make sure it hides properly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26121] When using CodeMirror in News Tool DatePicker cant be seen

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26121

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25270] Physical description/format is inconsistent between MARC21slim2OPACResults.xsl and MARC21slim2intranetResults.xsl

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25270

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26011] Remove unused jQuery plugin jquery.metadata.min.js from the OPAC

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26011

Lucas Gass  changed:

   What|Removed |Added

 Attachment #107046|0   |1
is obsolete||

--- Comment #3 from Lucas Gass  ---
Created attachment 107661
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107661=edit
Bug 26011: Remove unused jQuery plugin jquery.metadata.min.js from the OPAC

The jQuery plugin jquery.metadata.min.js hasn't been used in
Koha in long time. This patch removes it from the OPAC.

To test, apply the patch and search for instances of "jquery.metadata."
There should be none.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26011] Remove unused jQuery plugin jquery.metadata.min.js from the OPAC

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26011

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26011] Remove unused jQuery plugin jquery.metadata.min.js from the OPAC

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26011

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #2 from Lucas Gass  ---
cant find any instances of 'jquery.metadata.' with grep

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26004] Remove unused jQuery plugin jquery.hoverIntent.minified.js from the OPAC

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26004

Lucas Gass  changed:

   What|Removed |Added

 Attachment #107011|0   |1
is obsolete||

--- Comment #3 from Lucas Gass  ---
Created attachment 107660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107660=edit
Bug 26004: Remove unused jQuery plugin jquery.hoverIntent.minified.js from the
OPAC

The jQuery plugin jquery.hoverIntent.minified.js hasn't been used in
Koha in long time. This patch removes it from the OPAC.

To test, apply the patch and search for instances of "hoverIntent."
There should be none.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26004] Remove unused jQuery plugin jquery.hoverIntent.minified.js from the OPAC

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26004

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26004] Remove unused jQuery plugin jquery.hoverIntent.minified.js from the OPAC

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26004

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #2 from Lucas Gass  ---
The only instance of 'hoverIntent' after applying the patch is:

root@a7d585cbab0d:koha(master)$ git grep hoverIntent
misc/release_notes/release_notes_3_16_0.txt:11749   minor   Remove unused
jQuery plugin jquery.hoverIntent.minified.js from the staff client


So I think that's OK!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25744] Replace tags with AND tags with in the staff interface

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25744

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26121] When using CodeMirror in News Tool DatePicker cant be seen

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26121

--- Comment #1 from Lucas Gass  ---
Created attachment 107659
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107659=edit
Bug 26121: Add z-index for CodeMirror

To test:
1. Make sure the system preference 'NewsToolEditor' is set to CodeMirror
2. Go add or edit some News content.
3. Add some content to the News section
4. Use the datepicker to pick a Publication date/Expiration date
5. Notice its very hard to see your dates overlapping with CodeMirror.
6. Apply patch
7. Much easier to see the dates!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26121] When using CodeMirror in News Tool DatePicker cant be seen

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26121

Lucas Gass  changed:

   What|Removed |Added

 Depends on||22660


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660
[Bug 22660] Allow use of CodeMirror for editing HTML in the news editor
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in the news editor

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660

Lucas Gass  changed:

   What|Removed |Added

 Blocks||26121


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26121
[Bug 26121] When using CodeMirror in News Tool DatePicker cant be seen
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26121] New: When using CodeMirror in News Tool DatePicker cant be seen

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26121

Bug ID: 26121
   Summary: When using CodeMirror in News Tool DatePicker cant be
seen
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

If you set the sys pref 'NewsToolEditor' to CodeMirror and go to the News tool
and edit a some news the DatePicker is overlapped by CodeMirror making it
difficult to see which dates you are picking:

https://snipboard.io/cRQsdN.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25477] The responsive design in opac-main.tt should be correct

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25477

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #16 from Lucas Gass  ---
Hi Timothy,

Two things, firstly this patch no longer cleanly applies to master and is in
need of a rebase.

Secondly, I worry that changing bootstrap classes like this will be problematic
for existing Koha users who have their OPAC's set up in a certain way. Is this
a consideration? Keep in mind I say that without having tested this patch
because it won't clean apply.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26037] openlibrary.org is hit on every Koha requests

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26037

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26037] openlibrary.org is hit on every Koha requests

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26037

Lucas Gass  changed:

   What|Removed |Added

 Attachment #107429|0   |1
is obsolete||

--- Comment #10 from Lucas Gass  ---
Created attachment 107658
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107658=edit
Bug 26037: openlibrary.org is hit on every Koha requests

This patch moves the inclusion of Open Library JavaScript from
opac-bottom.inc to the three templates where it might be used.

In addition, the Open Library JS has been modified to check for the
existence of the relevant markup on the page before executing a query.

Unrelated: The Open Library label is now hidden when the status returned
is "Not found." Previously this information was displayed.

To test, apply the patch and enable the OpenLibrarySearch system
preference.

 - Perform a search in the OPAC which will return results from Open
   Library. Some ISBNs: 0140423826, 0395082552, 0679436405.
   - On the search result page there should be an Open Library "Read
 now" button for each result that can be opened for reading in Open
 Library.
 - Add these titles to a list and view the list.
   - The "Read now" button should appear on the list page.
 - View the details for one of these titles.
   - The "Read now" button should appear on the page below the holdings.
 - Watch the browser's developer tools on these and other pages in the
   OPAC. There should be no errors in the console and no 404 errors in
   the network tab.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26098] JS error on the fund list view if no fund displayed

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26098

Lucas Gass  changed:

   What|Removed |Added

 Attachment #107566|0   |1
is obsolete||

--- Comment #2 from Lucas Gass  ---
Created attachment 107657
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107657=edit
Bug 26098: Fix JS error on the fund list view when no fund displayed

TypeError: this.data(...) is undefined
in jquery.treetable.js

Test plan:
Go to the fund list view
Select a filter that will return no result
=> With this patch applied there is no JS error in the console

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26098] JS error on the fund list view if no fund displayed

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26098

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21468] Plugins need hooks for checkin and checkout actions

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21468

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #27 from Lucas Gass  ---
enhancement will not be backported to 20.05.x series

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24031] Add plugin hook after_hold_create

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24031

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #22 from Lucas Gass  ---
enhancement not backported to 20.05.x series

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #32 from Lucas Gass  ---
I will backport this but first I will wait until bZ26108 is pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26109] Update list-deps for Koha 19.05.x to support Debian 8 and 10

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26109

--- Comment #2 from Victor Grousset/tuxayo  ---
I'm out of the loop about this. So 19.05.x will be able to support Debian 10
now? :D

About Debian 8 the support has been dropped, should this be tested even though
not advertised?
Should it be done for the existing installs that might break (if a bug goes
undetected)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25961] Add hooks for plugins to inject variables to XSLT

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25961

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable
 Version(s)|20.11.00|20.11.00, 20.05.03
released in||

--- Comment #19 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24157] Additional acquisitions permissions

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #45 from Lucas Gass  ---
enhancement will not be backported to 20.05.x series

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25709] Rename systempreference from NotesBlacklist to NotesToHide

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.03
released in||
 CC||lu...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable

--- Comment #18 from Lucas Gass  ---
I feel like this enhancement should be backported 

backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25811] authentication.t is failing randomly

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25811

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #14 from Lucas Gass  ---
I'm not too sure whats going on here. I see this bug has a status of assigned
and its dependency, 25824, is set to NEW. 

not backporting, yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23086] Search for collection is broken

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23086

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||lu...@bywatersolutions.com

--- Comment #19 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25940] Two separate print dialogs when checking in/transferring an item

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25940

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|20.11.00|20.11.00, 20.05.03
released in||

--- Comment #7 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25724] Transferred item checked in to shelving cart has cart location removed when transfer is filled

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25724

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.03
released in||
 Status|Pushed to master|Pushed to stable
 CC||lu...@bywatersolutions.com

--- Comment #8 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24279] Claims Returned does not work when set from moredetail.pl or additem.pl

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24279

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #37 from Lucas Gass  ---
Doesn't apply clean to 20.05.x branch, if needed please rebase :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25729] Charges/Fees.t is failing on slow servers due to wrong date comparison

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25729

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable
 Version(s)|20.11.00|20.11.00, 20.05.03
released in||

--- Comment #6 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25889] Increase performance of debian/list-deps script

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25889

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Version(s)|20.11.00|20.11.00, 20.05.03
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #7 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26033] framapic is closing

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26033

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable
 Version(s)|20.11.00|20.11.00, 20.05.03
released in||

--- Comment #7 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26016] Capitalization: MARC Preview

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26016

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable
 Version(s)|20.11.00|20.11.00, 20.05.03
released in||

--- Comment #5 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20799] Add a link from biblio detail view to ILL request detail view, if a biblio has an ILL request

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20799

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #17 from Lucas Gass  ---
not backporting enhancement to 20.05.x series

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #23 from Lucas Gass  ---
not backporting enhancement to 20.05.x series

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23696] build_oai_sets.pl should take biblios from deletedbiblio_metadata too

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23696

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.03
released in||
 Status|Pushed to master|Pushed to stable
 CC||lu...@bywatersolutions.com

--- Comment #9 from Lucas Gass  ---
small enchacement, choosing to backport to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25031] Improve handling of multiple covers on the biblio detail page in the staff client

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25031

--- Comment #21 from Lucas Gass  ---
This is awesome but I will not backport the enhancement to 20.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23797] Convert OpacLoginInstructions system preference to news block

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23797

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.03
released in||
 Status|Pushed to master|Pushed to stable
 CC||lu...@bywatersolutions.com

--- Comment #17 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25758] Items scheduled for automatic renewal do not show that they will not renew due to a hold

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758

--- Comment #27 from Barbara Johnson  ---
Jonathan - I retested with a new sandbox and the test plan worked.  
https://snipboard.io/vzET9N.jpg

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26118] Move translatable strings out of tags/review.tt and into tags-review.js

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26118

Owen Leonard  changed:

   What|Removed |Added

 Blocks||26120


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26120
[Bug 26120] Remove the use of jquery.checkboxes plugin from tags review
template
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26120] Remove the use of jquery.checkboxes plugin from tags review template

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26120

Owen Leonard  changed:

   What|Removed |Added

 Depends on||26118


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26118
[Bug 26118] Move translatable strings out of tags/review.tt and into
tags-review.js
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006

Owen Leonard  changed:

   What|Removed |Added

 Depends on||26120


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26120
[Bug 26120] Remove the use of jquery.checkboxes plugin from tags review
template
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26120] New: Remove the use of jquery.checkboxes plugin from tags review template

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26120

Bug ID: 26120
   Summary: Remove the use of jquery.checkboxes plugin from tags
review template
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Blocks: 26006

As described in Bug 26006 the jquery.checkboxes plugin is old and unmaintained. 

Its use should replaced in the staff interface tags review template.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006
[Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26118] Move translatable strings out of tags/review.tt and into tags-review.js

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26118

--- Comment #1 from Owen Leonard  ---
Created attachment 107656
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107656=edit
Bug 26118: Move translatable strings out of tags/review.tt and into
tags-review.js

This patch removes the section of the tags review template which defined
strings for translation. They can now be embedded in the JavaScript
file, wrapped in the __() function.

To test, apply the patch and clear your browser cache if necessary.

- Go to Tools -> Tags and perform some actions which will trigger the
  use of translated strings in the interface. For instance:
  - Approving and rejecting tags
  - Testing tags which are approved, rejected, or unclassified.
- Status messages for these operations should work correctly.

TESTING TRANSLATABILITY

- Update a translation, e.g. fr-FR:

> cd misc/translator
> perl translate update fr-FR

- Open the corresponding .po file for JavaScript strings, e.g.
  misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from
  koha-tmpl/intranet-tmpl/prog/js/pages/tags-review.js for
  translation, e.g.:

  msgid "Both subfield values should be filled or empty."
  msgstr ""

- Edit the "msgstr" string however you want (it's just for testing).
- Install the updated translation:

> perl translate install fr-FR

- Switch to your newly translated language in the staff client and
  repeat the test plan above. The translated strings should appear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26118] Move translatable strings out of tags/review.tt and into tags-review.js

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26118

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25969] Checking in a found hold at a different branch then confirming the hold causes internal server error

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25969

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com
 Status|Needs Signoff   |Failed QA

--- Comment #4 from Andrew Fuerste-Henry  ---
I'm still getting an error with the patch applied. "Can't call method "biblio"
on an undefined value at /kohadevbox/koha/circ/returns.pl line 148"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23678] Cancel Holds in bulk

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678

Michelle Carrillo  changed:

   What|Removed |Added

 CC||mcarri...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26119] New: Patron Attribute Option to Display in OPAC Not Compatible with PatronSelfRegistrationVerifyByEmail

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26119

Bug ID: 26119
   Summary: Patron Attribute Option to Display in OPAC Not
Compatible with PatronSelfRegistrationVerifyByEmail
 Change sponsored?: ---
   Product: Koha
   Version: 20.05
  Hardware: PC
OS: Windows
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: eroh...@equinoxinitiative.org
QA Contact: testo...@bugs.koha-community.org

Within the Patron Attribute Type User Interface (Home › Administration › Patron
attribute types), there is a parenthetical note indicating that the option to
Editable in OPAC "does not work with [System Preference]
PatronSelfRegistrationVerifyByEmail."

The patron attribute option to Display in OPAC also does not work with System
Preference PatronSelfRegistrationVerifyByEmail.

It would be ideal for the attribute to display. However, the quicker
alternative would be to include the same parenthetical warning to users that
the display will not work with the system preference (like the Editable in OPAC
value indicates).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26035] AutoMemberNum fails on very large cardnumbers

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26035

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #107522|0   |1
is obsolete||

--- Comment #6 from ByWater Sandboxes  ---
Created attachment 107655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107655=edit
Bug 26035: AutoMemberNum should support cardnumbers up to 32 characters

To test:
1- create a patron with cardnumber 12345678901234567890123456789012 (or any 32
character number)
2- turn on AutoMemberNum
3- create a new patron, save without a cardnumber
4- confirm that new patron has a cardnumber one more than the number from step
1

Signed-off-by: Donna Bachowski 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26035] AutoMemberNum fails on very large cardnumbers

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26035

Donna  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||bwsdo...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25762] Typo in linkitem.tt

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25762

Nick Clemens  changed:

   What|Removed |Added

 Attachment #107634|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 107654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107654=edit
Bug 25762: Typo in linkitem.tt

This patch corrects the same typo in two different templates:

 -> 

If you want to test beyond examining the patch, apply the patch
and go to Tools -> Rotating collections.

- Add an item to a rotating collection.
- In the browser's title bar (or the tab title if the title bar isn't
  shown) the separator between the rotating collection name and "Add or
  remove items" should be ">" instead of "`"
- Enable the EasyAnalyticalRecords system preference.
- View the detail page for a bibliographic record.
- From the "Edit" menu, choose "Link to host record"
- Check the title bar as you did previously.

Signed-off-by: Sally 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25762] Typo in linkitem.tt

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25762

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25867] Label holdingbranch as Current library rather than Current location

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25867

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Signed Off  |In Discussion

--- Comment #4 from Nick Clemens  ---
Would it be worth a database update to correct frameworks for existing
installations?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25879] Improve display of guarantor information in the patron entry form

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25879

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||n...@bywatersolutions.com

--- Comment #3 from Nick Clemens  ---
This looks good Owen, but if I start from an adult patron and click 'Add
guarantee' I still get the problem in the initial comment

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156

Owen Leonard  changed:

   What|Removed |Added

 Blocks||26118


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26118
[Bug 26118] Move translatable strings out of tags/review.tt and into
tags-review.js
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26118] New: Move translatable strings out of tags/review.tt and into tags-review.js

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26118

Bug ID: 26118
   Summary: Move translatable strings out of tags/review.tt and
into tags-review.js
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr, testo...@bugs.koha-community.org
Depends on: 21156

Strings defined for translation in tags/review.tt can now be wrapped in the new
translation function and put in tags-review.js


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156
[Bug 21156] Internationalization: plural forms, context, and more for JS files
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26118] Move translatable strings out of tags/review.tt and into tags-review.js

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26118

Owen Leonard  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #37 from Nick Clemens  ---
This works as described, I do see that we have checks for this in reserve.pl
and opac-reserve.pl - can they be removed now that they are being added to the
modules?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24134] Add placeholder for 2 digit years to allow autogeneration of dates in 008

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24134

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #10 from Nick Clemens  ---
(In reply to Katrin Fischer from comment #9)
> Unblocking as dependency is in now.

With Lucas SO and your SO, should it be PQA?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24610] Let user switch between 'Pay' and 'Write off' mode

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24610

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24610] Let user switch between 'Pay' and 'Write off' mode

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24610

Nick Clemens  changed:

   What|Removed |Added

 Attachment #102006|0   |1
is obsolete||

--- Comment #9 from Nick Clemens  ---
Created attachment 107653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107653=edit
Bug 24610: Let user switch between 'Pay' and 'Write off' mode

In patron's accounting section, under 'Make a payment' tab, you have the
choice between 'Pay' and 'Write off'. It takes you to another form, but
once there you cannot change mode. You have to click on Cancel,
re-select the lines you had selected (if you made a selection) and click
on the right button.

This patch adds link above the form to easily switch between the two
modes.

Also fixes a CSS bug to be able to use Bootstrap's nav pills inside
.statictabs

Test plan:
1. Create some manual invoices
2. Go to 'Make a payment' tab
3. Click on the 'Pay' button in a table row
4. Above the form you should see two links ('Pay' and 'Write off').
   Click on 'Write off', confirm the write off and verify that it did
   make a 'write off'.
5. Go to 'Make a payment' tab
6. Click on the 'Write off' button in a table row
7. Click 'Pay', confirm the pay and verify that it did make a 'pay'
8. Go to 'Make a payment' tab
9. Select some lines and click on 'Pay selected'
10. Click on 'Write off', confirm the 'write off' and verify that it did
make a 'write off'
11. Go to 'Make a payment' tab
12. Select some lines and click on 'Write off selected'
13. Click on 'Pay', confirm the pay and verify that it did make a 'pay'

Signed-off-by: Christofer 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26085] Add the copy, print and export DataTables buttons to lost items report

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26085

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26085] Add the copy, print and export DataTables buttons to lost items report

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26085

Nick Clemens  changed:

   What|Removed |Added

 Attachment #107636|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 107652
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107652=edit
Bug 26085: Add the copy, print and export DataTables buttons to lost items
report

This patch removes the in-page DataTables DOM configuration option so
that the default option is used. This will allow all the standard
controls to appear, including copy/print/export.

Since the default DataTables information includes the number of results
in the table, the template markup showing this information is removed.

To test, apply the patch and go to Reports.

- Run the "Items lost" report using parameters which will return
  multiple results.
- On the results page confirm that the standard controls are present:
  Result count, search form, columns filter, export buttons.
- Confirm that the "Activate filters" feature works, and that selecting
  results activates the option to download a CSV using a CSV export
  profile.

  Note that the "Activate filters" feature doesn't play well with hidden
  columns. However this issue predates the patch.

Signed-off-by: Sally 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26117] New: itemlost_on value should be updated when item changes from one lost value to another

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26117

Bug ID: 26117
   Summary: itemlost_on value should be updated when item changes
from one lost value to another
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

To recreate:
- set an item to lost=1
- get the itemlost_on value for your item from the database
- change the item to lost=2
- get the itemlost_on value again, confirm that the time hasn't changed

I'm sort of torn on this. Just now, we ran into an issue where it we needed to
know when a lost value was changed. But I can also imagine a situation where
one would want to know when an item became lost originally.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26062] Membership Expiry can not be limited by Patron Category

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26062

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com

--- Comment #3 from Liz Rea  ---
I agree with Katrin here - from a sysadmin standpoint it's much better for
libraries to be able to configure these from the interface (it's easier for
package maintenance/upgrades too, since users won't be inclined to modify the
default cron files and then have to resolve those differences at upgrade time
in apt)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25112] Koha::CirculationRules->set_rules should handle scopes per rule

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25112

Lari Taskula  changed:

   What|Removed |Added

 Attachment #105788|0   |1
is obsolete||

--- Comment #10 from Lari Taskula  ---
Created attachment 107651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107651=edit
Bug 25112: Make set_rules() handle rule scopes

Koha::CirculationRules->set_rules is currently too complicated to use.
Right now, in order to specify multiple rules at once, they must all
be rules that accept the same set of scopes. Otherwise we can get this
type of errors:

1/9 set_rule cannot set 'holds_per_record' for a 'checkout_type'!
  at t/db_dependent/Circulation/GetHardDueDate.t line 215.

Validating scopes at set_rule() is good, but set_rules() should examine
each rule and pass the correct scope to set_rule() instead of passing
all scopes to every rule like it is doing now.

To test:
1. prove t/db_dependent/Koha/CirculationRules.t
2. Observe success

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25112] Koha::CirculationRules->set_rules should handle scopes per rule

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25112

Lari Taskula  changed:

   What|Removed |Added

 Attachment #105787|0   |1
is obsolete||

--- Comment #9 from Lari Taskula  ---
Created attachment 107650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107650=edit
Bug 25112: Add a failing test for CirculationRules.t

To reproduce the problem, do:
1. prove t/db_dependent/Koha/CirculationRules.t
2. Observe a failing test

set_rule cannot set 'holdallowed' for a 'categorycode'! at
  t/db_dependent/Koha/CirculationRules.t line 304.

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26094] "Suggest for Purchase" button missing unique CSS class

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26094

Nick Clemens  changed:

   What|Removed |Added

 Attachment #107622|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 107649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107649=edit
Bug 26094: Add class to the "Suggest for purchase" button

Bug 14963 added a new "Suggest for purchase" button on the detail page
of bibliographic records at the OPAC.
This patch adds a specific CSS class to make it reachable easily

Like others button in this action list

Test plan:
Go to the detail page of a bibliographic record at the OPAc
Notice the new CSS class

Signed-off-by: Sally 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26094] "Suggest for Purchase" button missing unique CSS class

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26094

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946

Sally  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #6 from Sally  ---
Sorry, couldn't get this one to work - it fails at step 7 below:  

To reproduce (borrowerRelationship can be empty):
5) Apply the patch.
6) Repeat steps above.
7) Observe that it allows you to save the form now.

Invalid relationship passed, '' is not defined. at
/usr/share/perl5/Exception/Class/Base.pm line 88

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26008] Remove the use of jquery.checkboxes plugin from OPAC cart

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26008

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #107024|0   |1
is obsolete||

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 107648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107648=edit
Bug 26008: Remove the use of jquery.checkboxes plugin from OPAC cart

This patch removes the use of the jquery.checkboxes plugin from the OPAC
cart and replaces its functionality with "plain" jQuery.

To test, apply the patch and add some items to the Cart in the OPAC.

 - Open the Cart window in the OPAC by clicking the "Cart" link in the
   header.
 - Test that the "Select all" and "Clear all" links work correctly to
   check and uncheck all checkboxes.
   - Controls like "Remove" and "Place hold" should be enabled or
 disabled according to whether there are any checked checkboxes.
 - Test that manually checking a checkbox correctly enables or disables
   the link options too.
 - Test that the "Remove" or "Place hold" controls work correctly,
   applying to only the checked checkboxes.

Signed-off-by: Sally 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26008] Remove the use of jquery.checkboxes plugin from OPAC cart

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26008

Sally  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26010] Remove the use of jquery.checkboxes plugin from staff interface cart

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26010

Sally  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26010] Remove the use of jquery.checkboxes plugin from staff interface cart

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26010

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #107045|0   |1
is obsolete||

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 107647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107647=edit
Bug 26010: Remove the use of jquery.checkboxes plugin from staff interface cart

This patch removes the use of the jquery.checkboxes plugin from the
staff interface cart and replaces its functionality with "plain" jQuery.

To test, apply the patch and add some items to the Cart in the staff
interface.

- Open the Cart window in the staff interface by clicking the "Cart"
  link in the header.
- Test that the "Select all" and "Clear all" links work correctly to
  check and uncheck all checkboxes.
- Test that the "Remove" or "Place hold" controls work correctly,
  applying to only the checked checkboxes whether they were checked
  using "Select all" or by manually checking them.

Signed-off-by: Sally 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26012] Date in 'Paid for' information not formatted to Time/DateFormat system preferences

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26012

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #107513|0   |1
is obsolete||

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 107646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107646=edit
Bug 26012: Correctly format "paid for" info on the item details view

The string is built controller side, which does not let the template
format the info nicely.
We want to display patron's info using patron-title.inc and the date
with the KohaDates plugin

Test plan:
- Make sure there is a replacement cost in the item
- check it out
- Mark it lost
- Pay the lost item fee
- Go to the detail page and look on the items tab for the item
- It will show an entry with "Paid for?" label
The patron's info and date must be correctly formatted

Signed-off-by: Sally 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26012] Date in 'Paid for' information not formatted to Time/DateFormat system preferences

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26012

Sally  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26114] ILL should mark status=RET only if a return happened

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26114

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26114] ILL should mark status=RET only if a return happened

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26114

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 107645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107645=edit
Bug 26114: ILL should mark status=RET only if a return happened

The original code assumed every codepath should be trated as a
successful check-in. Such is not the case and the regression tests
verify that the code acknowledges this.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Illrequests.t
=> FAIL: Tests fail
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26114] ILL should mark status=RET only if a return happened

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26114

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 107644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107644=edit
Bug 26114: Regression tests

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26114] ILL should mark status=RET only if a return happened

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26114

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||andrew.isherwood@ptfs-europ
   ||e.com,
   ||katrin.fisc...@bsz-bw.de,
   ||martin.renvoize@ptfs-europe
   ||.com
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26015] Terminology: staff interface should be used everywhere

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26015

Joonas Kylmälä  changed:

   What|Removed |Added

 Attachment #107226|0   |1
is obsolete||

--- Comment #4 from Joonas Kylmälä  ---
Created attachment 107643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107643=edit
Bug 26015: Terminology: Use staff interface instead of staff client

We have agreed to use 'staff interface' instead of 'staff client'
and similar terms. This fixes the template files where staff client
appears:

To test:
- Check Administration > Patron categories
- Check the title of the staff interface start page in your
  browser tab
- Check the description of hte catalogue permission
- One more: this changes the message shown when someone managed
  to log in as the database user - as we no longer allow that, I am
  not sure if it can be triggered.

Signed-off-by: Owen Leonard 
Signed-off-by: Joonas Kylmälä 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26015] Terminology: staff interface should be used everywhere

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26015

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26116] Allow multiple suppression values

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26116

--- Comment #1 from George Williams (NEKLS)  ---
+1 - good idea

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26116] Allow multiple suppression values

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26116

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25532] Add a wikipedia-style search suggestion feature to the OPAC

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25532

Joonas Kylmälä  changed:

   What|Removed |Added

 CC||joonas.kylm...@helsinki.fi

--- Comment #10 from Joonas Kylmälä  ---
Instead of depending on Wikipedia being online and transferring users' queries
there I think we should use instead one of the search engines Koha supports to
do this, Elasticsearch seems to have support for auto completion and
correction:
https://www.elastic.co/guide/en/elasticsearch/reference/current/search-suggesters.html

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25335] Use of an authorised value in a marc subfield causes strict mode SQL error

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25335

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Blocks|23406   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23406
[Bug 23406] Authorized Value for Suppression when added to Frameworks doesn't
show Suppress in Staff Client
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26116] Allow multiple suppression values

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26116

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Blocks||23406


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23406
[Bug 23406] Authorized Value for Suppression when added to Frameworks doesn't
show Suppress in Staff Client
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23406] Authorized Value for Suppression when added to Frameworks doesn't show Suppress in Staff Client

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23406

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Depends on|25335   |26116


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25335
[Bug 25335] Use of an authorised value in a marc subfield causes strict mode
SQL error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26116
[Bug 26116] Allow multiple suppression values
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26115] Remove leftover Carp::Always

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26115

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 107642
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107642=edit
Bug 26115: Remove leftover Carp::Always

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26115] Remove leftover Carp::Always

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26115

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26116] New: Allow multiple suppression values

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26116

Bug ID: 26116
   Summary: Allow multiple suppression values
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Right now, Koha will only suppress records where 942$n=1. It would be good to
be able to suppress on multiple values in order to reflect a variety of reasons
for suppression.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23112] Add circulation process to inter-library loans

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||26115


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26115
[Bug 26115] Remove leftover Carp::Always
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26115] New: Remove leftover Carp::Always

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26115

Bug ID: 26115
   Summary: Remove leftover Carp::Always
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

There's a leftover from bug 23112 on t/db_dependent/Illrequests.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26115] Remove leftover Carp::Always

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26115

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|tomasco...@gmail.com
 Depends on||23112


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
[Bug 23112] Add circulation process to inter-library loans
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23112] Add circulation process to inter-library loans

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||26114


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26114
[Bug 26114] ILL should mark status=RET only if a return happened
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

2020-07-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

--- Comment #11 from Owen Leonard  ---
I've rebased and updated the remote branch with some fixes:

 - Fixed markup of navbar item "Log in to create your own lists"
 - Improved consistency of input and link focus borders (needs
   more improvement).
 - Corrected style of disabled link buttons in the Cart.

(In reply to Lucas Gass from comment #10)

> On the item details page the More Searches dropdown (inside
> #ulactioncontainer) is not a dropdown.

This is a problem because the Bootstrap dropdown markup changed in version 4.
I'm still puzzling over this... There is probably a CSS solution, preferable to
trying to add a db update which tries to correct existing values in the system
preference.

Currently for it to work properly you have to update the  OPACSearchForTitleIn
preference with this text, removing the 's and adding a "dropdown-item"
class to the links:


https://worldcat.org/search?q={TITLE};
target="_blank">Other Libraries (WorldCat)
https://scholar.google.com/scholar?q={TITLE};
target="_blank">Other Databases (Google Scholar)
https://www.bookfinder.com/search/?author={AUTHOR}title={TITLE}st=xlac=qr;
target="_blank">Online Stores (Bookfinder.com)
https://openlibrary.org/search?author=({AUTHOR})=({TITLE})"
target="_blank">Open Library (openlibrary.org)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >