[Koha-bugs] [Bug 18349] Possibility to checkout/renew bypassing the circ rules using SCO
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18349 --- Comment #20 from David Cook --- This patch blocks the "OverduesBlockRenewing" system preference. That may or may not be intentional. But in any case we should alert the user that they're forbidden from doing what they're trying to do... or not show them the option at all... it's not clear what Koha is trying to do here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18349] Possibility to checkout/renew bypassing the circ rules using SCO
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18349 Martin Renvoize changed: What|Removed |Added Target Milestone|Oldversions |--- David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #19 from David Cook --- The downside of this code is that it traps the user in a loop. They keep pressing "Renew item" in the "Please confirm the checkout" box, and it just loops back to the same screen prompting them to do the same thing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16357] Plack error logs are not time stamped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #65 from Joonas Kylmälä --- (In reply to David Cook from comment #64) > Which patch set did you try? Your comment isn't clear. I tried to apply the patches from Jonathan, and then I thought incorrectly your alternative patches were for just the last one or two patches from Jonathan given the patches from Joubu had that sha1 informations is lacking error. I now looked at this again and I understand that your patches were meant to be used standalone. I will let you know my updated comments on the approach now that have this working. > Re: debian/control, I hadn't heard definitively from the QA/Release team > about that. I notice you were added to the QA team for 20.05. Can you > confirm that all dependencies should be added via the cpanfile? I'm happy to > resubmit moving the debian/control change to the cpanfile. This seems to be a recent thing and I only I heard about this in comment https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25723#c79 I couldn't find any wiki documentation for this, so all I know is that and git log debian/control, and the comment on top of debian/control file. We could ping maybe Mason or Martin on IRC to clarify this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16357] Plack error logs are not time stamped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #64 from David Cook --- (In reply to Joonas Kylmälä from comment #63) > even if I apply the patches on top of the Koha version from the day the > patches were submitted I get: > > Applying: Bug 16357: (follow-up) Use Koha::Logger and add fatal errors > error: sha1 information is lacking or useless (debian/templates/plack.psgi). > error: could not build fake ancestor > Patch failed at 0001 Bug 16357: (follow-up) Use Koha::Logger and add fatal > errors Which patch set did you try? Your comment isn't clear. > Also the dependency is unclear in both alternative patches for > libplack-middleware-logwarn-perl, does the latter alternative need it also? > Either way, the dependency should be probably added to cpanfile since > debian/control is autogenerated and should not be tweaked manually. I'm fine > with the latter alternative approach btw, so please just resubmit that since > I was under the impression David preferred that too. Yes, both patches marked [Alternative] are part of the same patch set. I think the dependency is clear. They both must be applied as per the test plan below: To Test: 0) apt-get install libplack-middleware-logwarn-perl 1) Apply "Alternative" patches 2) Copy PLACK block from etc/log4perl.conf to /etc/koha/sites/kohadev/log4perl.conf and replace __LOG_DIR__ appropriately 3) Copy debian/templates/plack.psgi to /etc/koha/sites/kohadev/plack.psgi 4) Temporarily add 'warn "TEST"' to opac-main.pl and mainpage.pl 5) koha-plack --restart kohadev 6) Go to /cgi-bin/koha/mainpage.pl and /cgi-bin/koha/opac-main.pl 7) Open /var/log/koha/kohadev/plack-opac-error.log and /var/log/koha/kohadev/plack-intranet-error.log 7) Observe a log line like the following: [2020/06/22 03:51:23] [WARN] TEST at
[Koha-bugs] [Bug 26285] Use country code + number (E.164) validation for SMS numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26285 --- Comment #5 from David Cook --- (In reply to Sally from comment #3) > This is valid for UK patrons too - our mobile numbers also start with zero. > > Test plan works, signed off! Thanks Sally (and Katrin)! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26184] Wrap opac-reserve.tt note text in HTML element
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 Lucas Gass changed: What|Removed |Added Summary|Wrap|Wrap opac-reserve.tt note |at_least_one_library_not_av |text in HTML element |ailable_for_pickup text in | |HTML element| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25712] Add plugin hooks to transform patron and item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25712 --- Comment #11 from Lucas Gass --- Created attachment 109052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109052=edit Bug 25712: (QA follow-up) Fix QA script warnings Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25712] Add plugin hooks to transform patron and item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25712 Lucas Gass changed: What|Removed |Added Attachment #107125|0 |1 is obsolete|| Attachment #108831|0 |1 is obsolete|| --- Comment #10 from Lucas Gass --- Created attachment 109051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109051=edit Bug 25712: Add plugin hooks to transform patron and item barcodes Some of our partners have unusual barcode requirements that have required us to transform scanned barcodes using javascript. This is not the most reliable method. It would make more sense to have Koha transform the barcodes on the backend using a plugin. We should add hooks to transform and generate new item and patron barcodes. Test Plan: 1) Apply this patch 2) Download and install the Barcode Transformer plugin https://github.com/bywatersolutions/koha-plugin-barcode-transformer/releases/ 3) Go to the plugin configuration page, set the configuration to the example configuration from the same page 4) In the patron search and anywhere else you can scan a patron cardnumber, type in some cardnumbers but prefix them with A and postfix them with A or B, e.g. A12345A, A12345B 5) Note the letters are removed by Koha! 6) Try a cardnumber like X123456Y 7) Note Koha converts it to Z13456Z 8) Try an item barcode now with the same A A|B format from step 4 9) The item barcode should have the letters removed by Koha as well! Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25712] Add plugin hooks to transform patron and item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25712 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26294] Add a print or download button to Purchase Suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26294 --- Comment #1 from Katrin Fischer --- Would adding the column config + and export options work? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 --- Comment #55 from Katrin Fischer --- Sounds good and I can stop to stare at this because I am getting nowhere tonight :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26294] Add a print or download button to Purchase Suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26294 Margaret changed: What|Removed |Added CC||margaret@bywatersolutions.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26294] New: Add a print or download button to Purchase Suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26294 Bug ID: 26294 Summary: Add a print or download button to Purchase Suggestions management Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: marga...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Purchase Suggestions management page doesn't have a convenient way to download or print a list of the purchase suggestions that are pending, or any other category for that matter. To replicate: Go to cgi-bin/koha/suggestion/suggestion.pl#ASKED and have purchase suggestions in a variety of statues: pending, approved, rejected, etc. If you try using file>print or CNTL P it prints everything that has ever been suggested (and not yet deleted); the pending, approved, rejected, etc categories all just pile up even though that shouldn't be on the print out. So a good solution would be a download to CSV option for the tab/status you're currently looking at. Or just having the web page just print the 20 or so suggestions on the tab you are looking at. Side note, giving libraries a way to download accepted or rejected purchase suggestions would be a nice thing to do since Koha doesn't have a deleted_suggestions table and some libraries need to keep track of suggestions and still delete them eventually. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 --- Comment #54 from Joonas Kylmälä --- (In reply to Katrin Fischer from comment #39) > we usually don't remove the sign-off lines - that's one reason we prefer > follow-ups - because it allows to see the changes, but also because that > means you don't change what has been signed off by someone. sorry for the mess! I was working on signing-off the patches the same time as Nick and hadn't noticed he had submitted his signed-off-by lines just some minutes earlier so when I ran git-bz attach with my patches it overrode his signed-off-by lines with mine. And then Nick had noticed the QA tool failure after his sign-off and put the bug to FQA state so I thought it would be best to wait for him to sign-off again, which also prompted for me to remove my own SO lines. Anyhow, Nick signed-off this now and I added my QA sign-off so ready for RM to merge :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 --- Comment #52 from Joonas Kylmälä --- Created attachment 109049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109049=edit Bug 23166: Call the methods from the .inc We do not longer need the order variables to be passed from the controllers, we can call the methods on the biblio object instead. There is something wrong with our ->search method and TT behaviours, it is hard to retrieve object list in a scalar context. If [% objects.method.count %] is called, objects.method will get the first object of the list and count will explode (Koha::Object->count does not exist) We need to force the call in a scalar context to retrieve an iterator and prevent to fetch all the objects (we could have called all then size, but it's not efficient) If adopted I will move the plugin on a separate bug report to ease backport Signed-off-by: Nick Clemens Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 --- Comment #53 from Joonas Kylmälä --- Created attachment 109050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109050=edit Bug 23166: (QA follow-up) Add POD text Signed-off-by: Nick Clemens Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 --- Comment #49 from Joonas Kylmälä --- Created attachment 109046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109046=edit Bug 23166: Replace the count of orders with Koha::Acq::Orders Signed-off-by: Nick Clemens Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 --- Comment #50 from Joonas Kylmälä --- Created attachment 109047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109047=edit Bug 23166: Remove filtering from controllers Signed-off-by: Nick Clemens Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 --- Comment #51 from Joonas Kylmälä --- Created attachment 109048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109048=edit Bug 23166: Add filter_by_current and _cancelled Koha::Acq::Orders methods Signed-off-by: Nick Clemens Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 Joonas Kylmälä changed: What|Removed |Added Attachment #109037|0 |1 is obsolete|| Attachment #109038|0 |1 is obsolete|| Attachment #109039|0 |1 is obsolete|| Attachment #109040|0 |1 is obsolete|| Attachment #109041|0 |1 is obsolete|| Attachment #109042|0 |1 is obsolete|| Attachment #109043|0 |1 is obsolete|| --- Comment #47 from Joonas Kylmälä --- Created attachment 109044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109044=edit Bug 23166: Remove baskets_orders code This is never used. Signed-off-by: Nick Clemens Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 --- Comment #48 from Joonas Kylmälä --- Created attachment 109045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109045=edit Bug 23166: Remove baskets_deletedorders code This is never used. Signed-off-by: Nick Clemens Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 Nick Clemens changed: What|Removed |Added Attachment #109025|0 |1 is obsolete|| --- Comment #45 from Nick Clemens --- Created attachment 109042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109042=edit Bug 23166: Call the methods from the .inc We do not longer need the order variables to be passed from the controllers, we can call the methods on the biblio object instead. There is something wrong with our ->search method and TT behaviours, it is hard to retrieve object list in a scalar context. If [% objects.method.count %] is called, objects.method will get the first object of the list and count will explode (Koha::Object->count does not exist) We need to force the call in a scalar context to retrieve an iterator and prevent to fetch all the objects (we could have called all then size, but it's not efficient) If adopted I will move the plugin on a separate bug report to ease backport Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 Nick Clemens changed: What|Removed |Added Attachment #109023|0 |1 is obsolete|| --- Comment #43 from Nick Clemens --- Created attachment 109040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109040=edit Bug 23166: Remove filtering from controllers Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 Nick Clemens changed: What|Removed |Added Attachment #109026|0 |1 is obsolete|| --- Comment #46 from Nick Clemens --- Created attachment 109043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109043=edit Bug 23166: (QA follow-up) Add POD text Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 Nick Clemens changed: What|Removed |Added Attachment #109024|0 |1 is obsolete|| --- Comment #44 from Nick Clemens --- Created attachment 109041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109041=edit Bug 23166: Add filter_by_current and _cancelled Koha::Acq::Orders methods Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 Nick Clemens changed: What|Removed |Added Attachment #109022|0 |1 is obsolete|| --- Comment #42 from Nick Clemens --- Created attachment 109039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109039=edit Bug 23166: Replace the count of orders with Koha::Acq::Orders Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 Nick Clemens changed: What|Removed |Added Attachment #109020|0 |1 is obsolete|| --- Comment #40 from Nick Clemens --- Created attachment 109037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109037=edit Bug 23166: Remove baskets_orders code This is never used. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 Nick Clemens changed: What|Removed |Added Attachment #109021|0 |1 is obsolete|| --- Comment #41 from Nick Clemens --- Created attachment 109038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109038=edit Bug 23166: Remove baskets_deletedorders code This is never used. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 --- Comment #39 from Katrin Fischer --- (In reply to Joonas Kylmälä from comment #37) > I attached a follow-up for the POD and removed the sign-offs given the other > issue Nick pointed out still remains: > > > FAIL koha-tmpl/intranet-tmpl/prog/en/includes/catalog-strings.inc > > FAIL valid_template > > Can't call method "filter_by_current" without a package or > > object reference at /kohadevbox/koha/Koha/Template/Plugin/Context.pm line > > 43. Hi Joonas, we usually don't remove the sign-off lines - that's one reason we prefer follow-ups - because it allows to see the changes, but also because that means you don't change what has been signed off by someone. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26290] Allow setting default SMTP parameters in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26290 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 109036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109036=edit Bug 26290: Make Koha::SMTP::Servers->get_default use koha-conf.xml This patch makes the mentioned method use the configured entry in koha-conf.xml if present, instead of the hardcoded one, which is kept for people that carries an old koha-conf.xml -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26290] Allow setting default SMTP parameters in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26290 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 109035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109035=edit Bug 26290: Add option forsetting default SMTP parameters in koha-conf.xml This patch adds an entry to koha-conf.xml for setting a default SMTP server config. 'koha-create' gets option switches for all options. To test: 1. Use the tweaked script to crete a new instance 2. Notice it contains entries for smtp_server and they respect your options. 3. If you don't choose any option, it sets the current default. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26290] Allow setting default SMTP parameters in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26290 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi changed: What|Removed |Added Blocks||26290 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26290 [Bug 26290] Allow setting default SMTP parameters in koha-conf.xml -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26290] Allow setting default SMTP parameters in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26290 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Depends on||22343 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 [Bug 22343] Add SMTP configuration options to Administration -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26285] Use country code + number (E.164) validation for SMS numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26285 Katrin Fischer changed: What|Removed |Added Attachment #108979|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 109034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109034=edit Bug 26285: Follow E.164 pattern for validating SMS numbers Currently, Koha is not correctly validating SMS numbers using E.164. This causes Australian phone numbers without a country code to fail validation. This patch uses the E.164 pattern of 1-3 digits for country code, prefixed by a + symbol, and followed by up to 12 digits for the remainder of the phone number. To test: 0. Don't apply patch yet 1. Set "SMSSendDriver" to "Anything" 2. Go to http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify=circ=51 3. Type in 04 and note "Please enter a valid phone number." message in browser 6. Apply the patch 7. Go to http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify=circ=51 8. Type in 04 and note no validation error 9. Type in +614 and note no validation error 10. Type in 123456789012 and note no validation error 11. Type in 1234567890123 and note "Please enter a valid phone number." error 12. Type in +900123456789012 and note no validation error 13. Type in 900123456789012 and note "Please enter a valid phone number." error Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26285] Use country code + number (E.164) validation for SMS numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26285 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5927] Show series information in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5927 Rogan Hamby changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5927] Show series information in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5927 Rogan Hamby changed: What|Removed |Added CC||rogan.ha...@gmail.com --- Comment #6 from Rogan Hamby --- Created attachment 109033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109033=edit patch to display 440$a a nd 490$a in results -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26289] Deleting biblio in labeled MARC view doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26289 Owen Leonard changed: What|Removed |Added Attachment #109027|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26289] Deleting biblio in labeled MARC view doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26289 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26291] Move translatable strings out of z3950_search.inc into z3950_search.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26291 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26291] Move translatable strings out of z3950_search.inc into z3950_search.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26291 --- Comment #1 from Owen Leonard --- Created attachment 109032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109032=edit Bug 26291: Move translatable strings out of z3950_search.inc into z3950_search.js This patch moves translatable strings out of z3950_search.inc into z3950_search.js, wrapped in the double-underscore function for translation. To test, apply the patch and go to Cataloging. - Click "New from Z39.50/SRU" - In the search form, uncheck all search targets and submit the form. You should get an error: "Please choose at least one external target" - Peform a search which will return multiple pages of results. - Test that you can enter a number in the "Go to page" form to navigate to a specific page. - Enter a non-number in the field and submit. You should get an error, "The page entered is not a number." - Enter a number in the field which is greater than the number of pages of results. Submitting the form should trigger an error, "The page should be a number between 1 and 10." - Perform the same tests from the other Z39.50 search results interfaces: - Acquisitions -> Add to basket -> From an external source. - Authorities -> New authority -> New from Z39.50/SRU. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/z3950_search.js for translation, e.g.: msgid "The page entered is not a number." msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26293] New: Allow libraries to write off all fines in a range of dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26293 Bug ID: 26293 Summary: Allow libraries to write off all fines in a range of dates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: wizzy...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Libraries should be able to write off fines accrued between a range of dates in bulk. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26292] New: HTML5 Media doesn't display in 19.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26292 Bug ID: 26292 Summary: HTML5 Media doesn't display in 19.11 Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org -Add a YouTube video to the 856u of a record -Make sure HTML5MediaEnabled is turned on -Go to the item record in both the OPAC and staff client/ -There is no "Play media" tab -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23682] Add ability to manually import EDI invoices as an alternative to automatic importing on download
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23682 --- Comment #9 from Katrin Fischer --- I'll still need some data to test with please :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26291] New: Move translatable strings out of z3950_search.inc into z3950_search.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26291 Bug ID: 26291 Summary: Move translatable strings out of z3950_search.inc into z3950_search.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 21156 Strings defined for translation in z3950_search.inc can now be wrapped in the new translation function and put in z3950_search.js. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Owen Leonard changed: What|Removed |Added Blocks||26291 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26291 [Bug 26291] Move translatable strings out of z3950_search.inc into z3950_search.js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26290] New: Allow setting default SMTP parameters in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26290 Bug ID: 26290 Summary: Allow setting default SMTP parameters in koha-conf.xml Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org This way people installing Koha can set their SMTP on deployment. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25321] Move translatable strings out of strings.inc into the corresponding JavaScript
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25321 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25321] Move translatable strings out of strings.inc into the corresponding JavaScript
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25321 --- Comment #4 from Owen Leonard --- Created attachment 109031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109031=edit Bug 25321: Move translatable strings out of strings.inc into the corresponding JavaScript This patch moves string definitions out of strings.inc and into the corresponding JavaScript files. To test, apply the patch and test various pages in the staff interface: A few suggestions: - Perform a catalog search and view the detail page for a bibliographic record. - Confirm that the search results browser in the left-hand sidebar work correctly and that the title attributes of the controls are correct. - Locate a patron with multiple checkouts. View the checkout page and test the various controls in the table of checkouts: Renew, check in, return claims, etc. - View the list of holds on a patron's account. Test suspending and resuming holds. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/checkouts.js for translation, e.g.: msgid "Checked in" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25112] Koha::CirculationRules->set_rules should handle scopes per rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25112 Lari Taskula changed: What|Removed |Added Blocks|25089 | --- Comment #13 from Lari Taskula --- (In reply to Joonas Kylmälä from comment #12) > I agree with Jonathan that this change would make the code > confusing and also I think it would make it error prone because the coder > could think the scope is more restricted than what it in reality will be. I > wonder if there would be any other way to make the rule setting more > intuitive. Thanks for the feedback Jonathan and Joonas. It seems we need more opinions and some support before this can move forward. I'll leave this to "In Discussion" status. Since this is not a critical change, the dependency chain that it was built for, and is currently part of, can use the original set_rules() behavior. So I'm removing Bug 25089 from the blocker list. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 [Bug 25089] Add checkout_type to circulation rules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Depends on|25112 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25112 [Bug 25112] Koha::CirculationRules->set_rules should handle scopes per rule -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Kyle M Hall changed: What|Removed |Added Assignee|k...@bywatersolutions.com |n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19382] Add ability to block guarantees based on fees owed by guarantor and other guarantees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment #15 from Kyle M Hall ---
(In reply to Katrin Fischer from comment #14)
> Hi Kyle,
>
> I spotted an unresolved TODO:
>
> +my $guarantees_fines_amount = $flags->{CHARGES_GUARANTEES} ?
> $flags->{CHARGES_GUARANTEES}->{amount} : 0; #TODO: Replace with
> $patron->relationships_debt
>
> Do you want to fix this?
Those are really just ideas for future backend enhancements. I'd be happy to
file them!
> The "blocking" worked this time for me. :)
Excellent!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23682] Add ability to manually import EDI invoices as an alternative to automatic importing on download
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23682 --- Comment #8 from Kyle M Hall --- Created attachment 109030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109030=edit Bug 23682: (QA follow-up) Fix typo in syspref description -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23682] Add ability to manually import EDI invoices as an alternative to automatic importing on download
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23682 --- Comment #7 from Kyle M Hall --- (In reply to Katrin Fischer from comment #6) > Hi Kyle, > > can you please help me with testing this? I don't have any invoice data to > use. > > From review: > > 1) Pref description > " automatically import EDIFACT invoice message file when they are > downloaded." > Small typo, I think it should read "files"? You are correct! > 2) Why pref driven and not an EDI account option? > From looking at the options available, I was wondering why this is our first > EDIFACT preference. I would have expected this on the EDI account level, > where we also have the "Automatic ordering:" and other workflow relevant > options. This was a sponsored development and the spec was decided upon my the sponsor. I think as a general rule, if a library wants to manually import invoices from one vendor, they want to manually import invoices from *all* vendors. This change would be out of scope for the development. That being said, I think it would make a fine future enhancement. The syspref value could be imported into a new column in the vendors table and then removed from the database. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11583] Add WYSIWYG editor for HTML notices/letters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11583 Martha Fuerst changed: What|Removed |Added CC||mfue...@hmcpl.org --- Comment #2 from Martha Fuerst --- We're interested in this as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25958] Allow LongOverdue cron to exclude specified lost values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25958 Kyle M Hall changed: What|Removed |Added Attachment #109028|0 |1 is obsolete|| --- Comment #10 from Kyle M Hall --- Created attachment 109029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109029=edit Bug 25958: (QA follow-up) Implement filter in database query instead of in loop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25958] Allow LongOverdue cron to exclude specified lost values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25958 --- Comment #9 from Kyle M Hall --- Created attachment 109028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109028=edit Bug 25958: (QA follow-up) Implement filter in database query instead of in loop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26289] Deleting biblio in labeled MARC view doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26289 --- Comment #1 from Owen Leonard --- Created attachment 109027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109027=edit Bug 26289: Add missing variable definition to templates This patch adds definition of the missing "searchid" variable to three bibliographic detail pages. The variable is required by several JavaScript functions. To test, apply the patch and locate or create a record with no items. Open the labeled MARC view and choose Edit -> Delete record. Confirm the deletion. The deletion should complete correctly. Perform the same test with the ISBD view and the MARC view. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26289] Deleting biblio in labeled MARC view doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26289 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26289] Deleting biblio in labeled MARC view doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26289 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #38 from Joonas Kylmälä ---
There seems to be nothing wrong with the code, it is just that the QA tool
doesn't add the "orders" object because this is not being executed from the
real .pl script, so therefore the $set variable is undef. I think we could say
this is false positive then, right? Or if we want to prevent the QA tool
failing maybe such a check can be added:
sub Scalar {
my ( $self, $set, $method ) = @_;
+ return undef unless $set;
$set = $set->$method;
return $set;
}
What do you think? I think it is safe to ignore this here and we could go ahead
with the current patches.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 --- Comment #37 from Joonas Kylmälä --- I attached a follow-up for the POD and removed the sign-offs given the other issue Nick pointed out still remains: > FAIL koha-tmpl/intranet-tmpl/prog/en/includes/catalog-strings.inc > FAIL valid_template > Can't call method "filter_by_current" without a package or > object reference at /kohadevbox/koha/Koha/Template/Plugin/Context.pm line 43. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 --- Comment #36 from Joonas Kylmälä --- Created attachment 109026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109026=edit Bug 23166: (QA follow-up) Add POD text -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 --- Comment #35 from Joonas Kylmälä --- Created attachment 109025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109025=edit Bug 23166: Call the methods from the .inc We do not longer need the order variables to be passed from the controllers, we can call the methods on the biblio object instead. There is something wrong with our ->search method and TT behaviours, it is hard to retrieve object list in a scalar context. If [% objects.method.count %] is called, objects.method will get the first object of the list and count will explode (Koha::Object->count does not exist) We need to force the call in a scalar context to retrieve an iterator and prevent to fetch all the objects (we could have called all then size, but it's not efficient) If adopted I will move the plugin on a separate bug report to ease backport -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 --- Comment #34 from Joonas Kylmälä --- Created attachment 109024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109024=edit Bug 23166: Add filter_by_current and _cancelled Koha::Acq::Orders methods -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 --- Comment #33 from Joonas Kylmälä --- Created attachment 109023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109023=edit Bug 23166: Remove filtering from controllers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 --- Comment #32 from Joonas Kylmälä --- Created attachment 109022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109022=edit Bug 23166: Replace the count of orders with Koha::Acq::Orders -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 --- Comment #31 from Joonas Kylmälä --- Created attachment 109021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109021=edit Bug 23166: Remove baskets_deletedorders code This is never used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 Joonas Kylmälä changed: What|Removed |Added Attachment #108997|0 |1 is obsolete|| Attachment #108998|0 |1 is obsolete|| Attachment #108999|0 |1 is obsolete|| Attachment #109000|0 |1 is obsolete|| Attachment #109001|0 |1 is obsolete|| Attachment #109002|0 |1 is obsolete|| Attachment #109019|0 |1 is obsolete|| --- Comment #30 from Joonas Kylmälä --- Created attachment 109020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109020=edit Bug 23166: Remove baskets_orders code This is never used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Blou changed: What|Removed |Added Assignee|bouzid.ferg...@gmail.com|n...@bywatersolutions.com CC|bouzid.ferg...@gmail.com| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|k...@bywatersolutions.com |testo...@bugs.koha-communit ||y.org --- Comment #122 from Tomás Cohen Arazi --- Ok, I almost started over with this one. I separated the information about SMTP server from the libraries themselves, which are now linked using a separate table. Added an accessor to Koha::Library so we don't need to search for SMTP servers and things got cleaner. Any gentle QA feedback is welcome. This has taken too long already. TODO (separate bugs): - Ability to set a default other than the hardcoded one, in koha-conf.xml - (Maybe, if someone takes the time to ask for it) display information about the libraries that use the server, on the SMTP servers table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 --- Comment #29 from Joonas Kylmälä --- Created attachment 109019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109019=edit Bug 23166: (QA follow-up) Add POD text -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #120 from Tomás Cohen Arazi --- Created attachment 109017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109017=edit Bug 22343: Prevent passing password to the UI -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #121 from Tomás Cohen Arazi --- Created attachment 109018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109018=edit Bug 22343: Allow choosing an SMTP server in branches.pl The missing piece on this patchset is choosing the desired SMTP server for each library. This patch adds the option on editing the library. The default one is picked for existing libraries, and you can pick the one you want. To test: 1. Apply the patchset 2. Run: $ updatedatabase => SUCCESS: Things go smooth 3. Notice the new permission for managing SMTP servers 4. Notice the entry in the admin page 5. Add/have a few SMTP servers defined. 6. Edit a library => SUCCESS: The 'Default' SMTP server is picked 7. Choose any server and save => SUCCESS: Saving doesn't explode 8. Edit the server => SUCCESS: Your selection is kept (this can also be checked on the DB, the library_smtp_server table) 9. Try (7) with many different options => SUCCESS: It works 10. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #119 from Tomás Cohen Arazi --- Created attachment 109016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109016=edit Bug 22343: Adapt runreport.pl This script gets adapted to use the new Koha::Email syntax and SMTP transport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #116 from Tomás Cohen Arazi --- Created attachment 109013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109013=edit Bug 22343: Make C4::Letters use the new SMTP server config This patch makes the different methods in C4::Letters use: - Koha::SMTP::Servers: to get the effective SMTP server for the library or the fallback default if no library in context. - New Koha::Email->create method for crafting the email envelope for sending. The tests are adapted so they behave the same way, but the trapped (in the mock) $email object has the right type and its attributes are accessed correctly. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Letters.t => SUCCESS: Tests pass. YAY! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #118 from Tomás Cohen Arazi --- Created attachment 109015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109015=edit Bug 22343: Adapt controller scripts This patch adapts controller scripts that used sendmail. Also the syntax for Koha::Email has changed and this patch adapts it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #115 from Tomás Cohen Arazi --- Created attachment 109012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109012=edit Bug 22343: Revamped Koha::Email class This patch completely rewrites the Koha::Email class, inheriting from Email::Stuffer. The latter suits well the use by Email::Sender, which is to replace Mail::Sendmail on this patchset. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/Email.t => SUCCESS: Tests pass! 3. Verify all conditional codepaths are covered 4. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #117 from Tomás Cohen Arazi --- Created attachment 109014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109014=edit Bug 22343: Adapt Koha::Illrequest This patch makes Koha::Illrequest use the new syntax for Koha::Email and sending the email. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #114 from Tomás Cohen Arazi --- Created attachment 109011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109011=edit Bug 22343: Add CRUD page for SMTP servers This patch introduces a way to define SMTP servers either globally or per-library. To test: 1. Apply this patch 2. Find the SMTP servers entry in the admin page 3. Play with adding/removing SMTP servers => SUCCESS: All works as expected 4. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #112 from Tomás Cohen Arazi --- Created attachment 109009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109009=edit Bug 22343: Update cpanfile -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #111 from Tomás Cohen Arazi --- Created attachment 109008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109008=edit Bug 22343: Add Koha::Library->smtp_server -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #110 from Tomás Cohen Arazi --- Created attachment 109007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109007=edit Bug 22343: Add classes for handling SMTP servers This patch introduces classes to handle SMTP servers. It is done in a way that a default server can be set, and then per-library ones can be set. All should be done with Koha::SMTP::Servers methods, that take care of overwriting library-specific configs, and handle the defaults retrieval and setting correctly. To test: 1. Apply this patches 2. Run: $ kshell $ perl installer/data/mysql/updatedatabase.pl => SUCCESS: Atomic update is ok, smtp_servers table created 3. Run: k$ prove t/db_dependent/Koha/SMTP/ => SUCCESS: Tests pass! 4. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #113 from Tomás Cohen Arazi --- Created attachment 109010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109010=edit Bug 22343: API routes for SMTP servers CRUD This patch introduces API routes for handling SMTP servers. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #107 from Tomás Cohen Arazi --- Created attachment 109004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109004=edit Bug 22343: Add parameters => manage_smtp_servers subpermission This patch introduces a new subpermission for managing SMTP servers, for granularity. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #108 from Tomás Cohen Arazi --- Created attachment 109005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109005=edit Bug 22343: Add new tables schema file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #109 from Tomás Cohen Arazi --- Created attachment 109006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109006=edit Bug 22343: DBIx::Class schema updates [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi changed: What|Removed |Added Attachment #108716|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi changed: What|Removed |Added Attachment #108715|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #106 from Tomás Cohen Arazi --- Created attachment 109003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109003=edit Bug 22343: Add a new table to store SMTP servers configs This patch adds a new table to store SMTP servers configs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi changed: What|Removed |Added Attachment #108654|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi changed: What|Removed |Added Attachment #108655|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi changed: What|Removed |Added Attachment #108653|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi changed: What|Removed |Added Attachment #108652|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
