[Koha-bugs] [Bug 27661] Clarify error for message broker

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #116856|0   |1
is obsolete||

--- Comment #18 from Marcel de Rooy  ---
Created attachment 117024
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117024=edit
Bug 27661: (QA follow-up) Capitalization

Signed-off-by: Katrin Fischer 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27661] Clarify error for message broker

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #116855|0   |1
is obsolete||

--- Comment #17 from Marcel de Rooy  ---
Created attachment 117023
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117023=edit
Bug 27661: Update about for message broker status

This patch updates the about page with regards to the message broker
status and adds some small formatting improvements for displaying the
status.

Test plan
1/ Run through the yarn build process to update the CSS file.
2/ View the about page without RabbitMQ installed
3/ View the about page with RabbitMQ installed
4/ Note the formatting and message change and signoff

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27661] Clarify error for message broker

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27661] Clarify error for message broker

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661

--- Comment #16 from Jonathan Druart  
---
Created attachment 117022
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117022=edit
Bug 27661: Use td.bg-success for ES and memcached as well

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27058] Cannot place hold to ordered item when on shelf holds are not allowed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058

--- Comment #16 from Joonas Kylmälä  ---
(In reply to Joonas Kylmälä from comment #14)
> (In reply to Marcel de Rooy from comment #13)
> >  my $biblionumber1 = $biblio2->biblionumber;
> > 
> > Obscure way of coding
> 
> Thanks for spotting. There is a similarly named global variable so I
> probably just wanted to get rid of those conflicts... Follow-up coming in 5.

Done. I fixed the other instance of same problem in the file as well while I
was it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27058] Cannot place hold to ordered item when on shelf holds are not allowed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058

--- Comment #15 from Joonas Kylmälä  ---
Created attachment 117021
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117021=edit
Bug 27058: Remove confusing and unnecessary $biblionumber1 variable

The code is much more understandable now because with $biblio2 and
$biblionumber1 variables use to point to the same biblio one might
have thought $biblionumber1 points to $biblio1 which in this case is
not true. Let's just drop the extra variable because the object
notation of accessing is just as simple.

To test:
 1) prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t => passes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27661] Clarify error for message broker

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661

Marcel de Rooy  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

--- Comment #15 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #14)
> (In reply to Marcel de Rooy from comment #13)
> > We are advertizing here that we support SQL polling and Rabbit MQ.
> > Is that really the way we want to go? Support both ways for any new case
> > where we would like to use RabbitMQ?
> > The SQL polling has been added to the initial use of RabbitMQ as a fallback
> > and probably for building some confidence.
> > 
> > Since I doubt that we will be supporting both ways, I would propose
> > rewording.
> > Any thoughts?
> 
> See misc/background_jobs_worker.pl lines 58-63, there is no additional code,
> and it applies to all jobs. It shouldn't hurt to have it and keep it.

Thx for clarifying. Had the impression that it was written for a specific job.
Which is not the case. Revisiting.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26997] Database Mysql Version 8.0.22 failed to Update During Upgrade

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26997

Jonathan Druart  changed:

   What|Removed |Added

   Severity|normal  |major

--- Comment #12 from Jonathan Druart  
---
Upping priority, this needs to be pushed and backported ASAP.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27058] Cannot place hold to ordered item when on shelf holds are not allowed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058

--- Comment #14 from Joonas Kylmälä  ---
(In reply to Marcel de Rooy from comment #13)
>  my $biblionumber1 = $biblio2->biblionumber;
> 
> Obscure way of coding

Thanks for spotting. There is a similarly named global variable so I probably
just wanted to get rid of those conflicts... Follow-up coming in 5.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27661] Clarify error for message broker

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661

--- Comment #14 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #13)
> We are advertizing here that we support SQL polling and Rabbit MQ.
> Is that really the way we want to go? Support both ways for any new case
> where we would like to use RabbitMQ?
> The SQL polling has been added to the initial use of RabbitMQ as a fallback
> and probably for building some confidence.
> 
> Since I doubt that we will be supporting both ways, I would propose
> rewording.
> Any thoughts?

See misc/background_jobs_worker.pl lines 58-63, there is no additional code,
and it applies to all jobs. It shouldn't hurt to have it and keep it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27058] Cannot place hold to ordered item when on shelf holds are not allowed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #13 from Marcel de Rooy  ---
 my $biblionumber1 = $biblio2->biblionumber;

Obscure way of coding

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27714] Koha::NewsItem->author explodes if the author has been removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27714

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27714] Koha::NewsItem->author explodes if the author has been removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27714

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #117005|0   |1
is obsolete||

--- Comment #3 from Marcel de Rooy  ---
Created attachment 117019
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117019=edit
Bug 27714: Prevent Koha::NewsItem->author to explode

If the author of a news has been removed, Koha::NewsItem->author must
not explode

DBIC result _type  isn't of the _type Borrower at t/db_dependent/Koha/News.t
line 68.

Test plan:
 prove t/db_dependent/Koha/News.t
must return green, and changes must be consistent

Signed-off-by: David Nind 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27714] Koha::NewsItem->author explodes if the author has been removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27714

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27661] Clarify error for message broker

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion
 CC||m.de.r...@rijksmuseum.nl

--- Comment #13 from Marcel de Rooy  ---
We are advertizing here that we support SQL polling and Rabbit MQ.
Is that really the way we want to go? Support both ways for any new case where
we would like to use RabbitMQ?
The SQL polling has been added to the initial use of RabbitMQ as a fallback and
probably for building some confidence.

Since I doubt that we will be supporting both ways, I would propose rewording.
Any thoughts?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27727] New: Add patron error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27727

Bug ID: 27727
   Summary: Add patron error
 Change sponsored?: ---
   Product: Koha
   Version: 20.11
  Hardware: PC
OS: Linux
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: bugs.koha-community.org
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: nandan.si...@chitkara.edu.in
QA Contact: testo...@bugs.koha-community.org

Created attachment 117018
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117018=edit
Error display in add new petron

Recently i have upgrade koha in new verion 20.11, I am getting error while add
new petron. Errror log is 


[Fri Feb 19 12:01:58.280111 2021] [cgi:error] [pid 442415] [client
x.x.x.x:42556] AH01215: [Fri Feb 19 12:01:58 2021] memberentry.pl:
DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha_library`.`borrowers`, CONSTRAINT `borrowers_ibfk_1`
FOREIGN KEY (`categorycode`) REFERENCES `categories` (`categorycode`)) [for
Statement "INSERT INTO `borrowers` ( `B_address`, `B_address2`, `B_city`,
`B_country`, `B_email`, `B_phone`, `B_state`, `B_streetnumber`, `B_zipcode`,
`address`, `address2`, `altcontactaddress1`, `altcontactaddress2`,
`altcontactaddress3`, `altcontactcountry`, `altcontactfirstname`,
`altcontactphone`, `altcontactstate`, `altcontactsurname`, `altcontactzipcode`,
`autorenew_checkouts`, `borrowernotes`, `borrowernumber`, `branchcode`,
`cardnumber`, `categorycode`, `city`, `contactnote`, `country`, `date_renewed`,
`dateenrolled`, `dateexpiry`, `dateofbirth`, `debarred`, `email`, `emailpro`,
`fax`, `firstname`, `initials`, `lastseen`, `mobile`, `opacnote`, `othernames`,
`password`, `phone`, `phonepro`, `privacy`, `sex`, `sort1`, `sort2`, `state`,
`streetnumber`, `surname`, `title`, `updated_on`, `userid`, `zipcode`) VALUES (
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?,
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?,
?, ?, current_timestamp, ?, ? )" with ParamValues: 0="", 1="", 2="", 3="",
4="", 5="", 6="", 7="", 8="", 9="", 10="", 11="", 12="", 13="", 14="", 15="",
16="", 17="", 18="", 19="", 20="1", 21="", 22=undef, 23="CL", 24="test00011",
25='S', 26="", 27="", 28="", 29=undef, 30='2021-02-19',
31='2029-05-19T00:00:00', 32='2003-02-19', 33=undef, 34="", 35="", 36="",
37="Test", 38="", 39=undef, 40="", 41="", 42="",
43='$2a$08$.VjCLVGfHyzq9lSqRFnwTOaq.OC4ArlxkAiDIgwdpkk9FQU.8QY.y', 44="",
45="", 46=1, 47="M", 48="", 49="", 50="", 51="", 52="test001", 53="Mr",
54="test0001", 55=""] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.:
/usr/share/koha/intranet/cgi-bin/members/memberentry.pl, referer:
http://10.0.1.1/cgi-bin/koha/members/memberentry.pl?op=add=S
[Fri Feb 19 12:01:58.281846 2021] [cgi:error] [pid 442415] [client
x.x.x.x:42556] AH01215: [Fri Feb 19 12:01:58 2021] memberentry.pl:
DBIx::Class::Storage::DBI::_dbh_execute(): Cannot add or update a child row: a
foreign key constraint fails (`koha_library`.`borrowers`, CONSTRAINT
`borrowers_ibfk_1` FOREIGN KEY (`categorycode`) REFERENCES `categories`
(`categorycode`)) at /usr/share/koha/lib/Koha/Object.pm line 169:
/usr/share/koha/intranet/cgi-bin/members/memberentry.pl, referer:
http://10.0.1.1/cgi-bin/koha/members/memberentry.pl?op=add=S

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] Upload status: Failed - (UPLERR_CANNOT_WRITE) undefined

[Sivasamy K]

Sir,

I received the above error (Upload status: Failed - (UPLERR_CANNOT_WRITE)
undefined) while uploading mrc file at Tools
 › Stage MARC
records for import in Koha 20.05.

Thanks

Dr. K.Sivasamy
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27726] New: OPACProblemReports cuts off message text

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726

Bug ID: 27726
   Summary: OPACProblemReports cuts off message text
 Change sponsored?: ---
   Product: Koha
   Version: 20.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: hannah...@northwestu.edu
QA Contact: testo...@bugs.koha-community.org

OPACProblemReport text is truncated to 255 characters, in both database and
email. I tested and confirmed that the patron-facing form does not limit the
amount of text entered, at least not before more than 500 characters. The form
should either limit characters and warn patrons of the character limit, or the
database field should be expanded to allow more data storage.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27610] Accessibility: OPAC - on each page is Logo but should be page description/title

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610

--- Comment #5 from wainuiwitikap...@catalyst.net.nz ---
Created attachment 117017
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117017=edit
Bug 27610: Changed pages of OPAC to have a 

Changed each of the pages in the OPAC to have one  tag showing that
describes the page, rather than the  describing the logo.

The hierarchy of heading tags may be broken in many pages, but this will be
dealt with in a follow up patch or bug.

To test:
1) Go to the OPAC
2) Apply patch
3) Go to each of the pages and check that they have an obvious and
descriptive heading
4) Ensure that the heading in the page is 

Sponsored by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

--- Comment #28 from Aleisha Amohia  ---
Created attachment 117016
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117016=edit
Bug 24194: (follow-up) Renaming syspref to ReserveExpiration

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27721] Circulation Workflow (Statuses)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27721

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27408] Update intranet-tmpl/prog/en/modules/members/mancredit.tt for ACC2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #11 from David Nind  ---
Testing notes:
- For step 2 of the test plan, input type="text" should be input type="number",
the same as bug 27410

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27408] Update intranet-tmpl/prog/en/modules/members/mancredit.tt for ACC2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408

David Nind  changed:

   What|Removed |Added

 Attachment #115550|0   |1
is obsolete||

--- Comment #10 from David Nind  ---
Created attachment 117015
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117015=edit
Bug 27408: (follow-up) Updates to accommodate currency entry

This patch makes two modifications in order to allow the entry of
currency strings (e.g. 1.25).
- Inputmode changed to "decimal"
- Regex pattern changed to "^\d+(\.\d{2})?$" as found in
  admin/debit_types.tt

To test, apply the patch and test entry of various strings in the manual
credit "amount" field. Confirm that the field only accepts digits or
digits followed by a decimal and two digits.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27408] Update intranet-tmpl/prog/en/modules/members/mancredit.tt for ACC2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408

David Nind  changed:

   What|Removed |Added

 Attachment #115549|0   |1
is obsolete||

--- Comment #9 from David Nind  ---
Created attachment 117014
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117014=edit
Bug 27408: Update intranet-tmpl/prog/en/modules/members/mancredit.tt for ACC2

Test Plan:

1. Open intranet-tmpl/prog/en/modules/members/mancredit.tt
2. Search for instances of 'input type="text"
3. If none are found then patch was successful

Signed-off-by: Owen Leonard 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27408] Update intranet-tmpl/prog/en/modules/members/mancredit.tt for ACC2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27410] Update intranet-tmpl/prog/en/modules/members/maninvoice.tt to reflect ACC2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410

David Nind  changed:

   What|Removed |Added

 Attachment #115553|0   |1
is obsolete||

--- Comment #8 from David Nind  ---
Created attachment 117013
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117013=edit
Bug 27410: (follow-up) Updates to accommodate currency entry

This patch makes two modifications in order to allow the entry of
currency strings (e.g. 1.25).

 - Inputmode changed to "decimal"
 - Regex pattern changed to "^\d+(\.\d{2})?$" as found in
   admin/debit_types.tt

To test, apply the patch and test entry of various strings in the manual
invoice "amount" field. Confirm that the field only accepts digits or
digits followed by a decimal and two digits.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27410] Update intranet-tmpl/prog/en/modules/members/maninvoice.tt to reflect ACC2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410

David Nind  changed:

   What|Removed |Added

 Attachment #115551|0   |1
is obsolete||

--- Comment #7 from David Nind  ---
Created attachment 117012
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117012=edit
Bug 27410: Update intranet-tmpl/prog/en/modules/members/maninvoice.tt to
reflect ACC2

Test Plan:
1. Open intranet-tmpl/prog/en/modules/members/maninvoice.tt
2. Search for instances of 'input type="number"'
3. If none are found then patch was successful

Signed-off-by: Owen Leonard 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27410] Update intranet-tmpl/prog/en/modules/members/maninvoice.tt to reflect ACC2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24624] Phase out jquery.cookie.js: Receipt summary

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24624

--- Comment #2 from Owen Leonard  ---
Created attachment 117011
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117011=edit
Bug 24624: Remove unused jquery.cookie.js plugin

This patch removes inclusion of the jquery.cookie.js plugin from the
"Receive orders" page in Acquisitions. It is unused.

To test apply the patch and follow the process for receiving an order in
Acquisitions:

- Acquisitions -> Vendor -> Receive shipments -> Receive a new shipment
- The table of pending orders should display correctly, and there should
  be no JavaScript errors in the browser console.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24624] Phase out jquery.cookie.js: Receipt summary

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24624

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24387] Rename News tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387

Margaret Hade  changed:

   What|Removed |Added

 CC||margaret@bywatersolutions.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24624] Phase out jquery.cookie.js: Receipt summary

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24624

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #1 from Owen Leonard  ---
Although the plugin is included in the template (acquit/parcel.tt) it isn't
used.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27661] Clarify error for message broker

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661

Owen Leonard  changed:

   What|Removed |Added

 Attachment #117006|0   |1
is obsolete||

--- Comment #12 from Owen Leonard  ---
Created attachment 117010
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117010=edit
Bug 27661: (QA follow-up) Use bootstrap classes

This patch removes the local status_* css rules in favour of using the
bg-* rules that are shipped with the bootstrap version we are using and
then updates the relevant lines in the template to use those classes.

We also update the default table styling which adds background color to
the odd table rows so that our local classes take precidence.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27725] Use JavaScript to set history state during patron search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27725

--- Comment #1 from Owen Leonard  ---
Created attachment 117009
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117009=edit
Bug 27725: Use JavaScript to set history state during patron search

This patch modifies the patron search page so that clicks on the "Browse
by last name" letters add an entry to the browser history, allowing the
user to click back and forth from results while preserving their search.

To test, apply the patch and go to Patrons in the staff interface.

- Click one of the "Browse by last name" letters.
- The table of search results should load the correct data.
- In the browser's location bar you should see a query string added to
  the URL, e.g. /cgi-bin/koha/members/members-home.pl?firstletter=Q
- Click another letter.
- Click the back button. You should be returned to the search results
  for your first letter choice.
- Clicking the forward button should work correctly as well.
- Other patron searches (header search, sidebar search) should continue
  to work as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27725] Use JavaScript to set history state during patron search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27725

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27593] Inconsistent return status on club holds routes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27593

David Nind  changed:

   What|Removed |Added

 Attachment #116217|0   |1
is obsolete||

--- Comment #4 from David Nind  ---
Created attachment 117008
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117008=edit
Bug 27593: Consistent behavior for club holds route

This patch:
- Fixes a malformed response when biblio_id is invalid
- Fixes the return status (400 => 404) when biblio_id is invalid
- Adapts the error strings to be consistent with the Cities.pm file

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/clubs_holds.t
=> FAIL: Tests fail
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27593] Inconsistent return status on club holds routes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27593

David Nind  changed:

   What|Removed |Added

 Attachment #116216|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 117007
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117007=edit
Bug 27593: Regression tests

This patch introduces tests for the behaviour change (400 => 404) and
also adds tests for untested (error) behaviours. Notably, the 'Biblio
not found' problematic return value couldn't be triggered, because the
OpenAPI plugin returns a 500 because the response was malformed
(expected { error => 'message' } and it was returning a string).

For the above reason, running the regression tests will show a 500...
instead of the expected 400.

I covered the rest of the codepaths that trigger errors to have full
coverage.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/clubs_holds.t
=> FAIL: Tests fail loudly

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27593] Inconsistent return status on club holds routes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27593

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27661] Clarify error for message broker

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661

--- Comment #11 from Martin Renvoize  ---
https://getbootstrap.com/docs/3.4/css/#helper-classes-backgrounds for reference
of the bootstrap classes I'm talking about

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27661] Clarify error for message broker

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661

Martin Renvoize  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

--- Comment #10 from Martin Renvoize  ---
Setting back to signed off to attract a second QA run here.. I think the final
followup gives us a much cleaner approach to the styling which will allow for
more global use of the bootstrap bg-* options for tables.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27661] Clarify error for message broker

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661

--- Comment #9 from Martin Renvoize  ---
Created attachment 117006
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117006=edit
Bug 27661: (QA follow-up) Use bootstrap classes

This patch removes the local status_* css rules in favour of using the
bg-* rules that are shipped with the bootstrap version we are using and
then updates the relevant lines in the template to use those classes.

We also update the default table styling which adds background color to
the odd table rows so that our local classes take precidence.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26181] Holds placed via the REST API should not be forced by default even if AllowHoldPolicyOverride is enabled

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26181

David Nind  changed:

   What|Removed |Added

  Text to go in the||This patch disables
  release notes||AllowHoldPolicyOverride by
   ||default in the /holds REST
   ||API. It also adds tests for
   ||this behaviour, and adds a
   ||header that can be used to
   ||request the override
   ||explicitly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690

Joonas Kylmälä  changed:

   What|Removed |Added

  Text to go in the||- Proper warning messages
  release notes||are added in staff
   ||interface when trying to
   ||initiate transfer to an
   ||attached hold.
   ||
   ||- Checking
   ||out someone else's hold
   ||that is in transit is
   ||prevented

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18146] C4::Circulation CanBookBeRenewed lacks full test coverage

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18146

David Nind  changed:

   What|Removed |Added

  Text to go in the||This enhancement improves
  release notes||the test coverage for
   ||OverduesBlockRenewing and
   ||removes some of the warning
   ||messages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27714] Koha::NewsItem->author explodes if the author has been removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27714

David Nind  changed:

   What|Removed |Added

 Attachment #116932|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 117005
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117005=edit
Bug 27714: Prevent Koha::NewsItem->author to explode

If the author of a news has been removed, Koha::NewsItem->author must
not explode

DBIC result _type  isn't of the _type Borrower at t/db_dependent/Koha/News.t
line 68.

Test plan:
 prove t/db_dependent/Koha/News.t
must return green, and changes must be consistent

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27714] Koha::NewsItem->author explodes if the author has been removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27714

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27606] Breadcrumbs on parcel.pl should include a link to the vendor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27606

Lucas Gass  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to stable|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27613] Pipe separated online resource links are hard to customize

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613

--- Comment #5 from Lucas Gass  ---
Cait,

1. This patch does change both the OPAC detail and the OPAC results page. 

2. I think we can still easily, even more easily, remove links with jQuery. In
your example I would use this:

$('a[href="http://www.loc.gov/catdir/toc/cam041/2003273871.html;]
').parent().hide(); // This works for hiding it on both the results and
detials.


3. I think to semantically describe the online_resource section as a list of
links is good.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690

--- Comment #13 from Joonas Kylmälä  ---
The patch series is now ready for Sign-off. The actual bug reported here is
fixed in the patch "Bug 25690: SIP2: Don't allow checking out attached hold
that is being transferred" but the series cleans up also a lot of the
duplicated logic and in addition fixes the same issue as here reported for SIP
in staff interface for Transfer and In processing states – now the librarian
gets a pop-up saying the items is in transit or in processing when before it
didn't, thus preventing accidental checkouts also there. Please see the commit
messages and test plans for more info.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27725] New: Use JavaScript to set history state during patron search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27725

Bug ID: 27725
   Summary: Use JavaScript to set history state during patron
search
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

The patron search page can be annoying because it never remembers where you
left off. If I click a letter to browse by last name, follow a link, and then
back up, the page doesn't remember that I was in the middle of a search.

There are a lot of aspects which can be improved, but I have a patch which will
address the specific case of the first letter search ("Browse by last name").

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690

--- Comment #12 from Joonas Kylmälä  ---
Created attachment 117004
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117004=edit
Bug 25690: Add SIP2 tests for checking out with holds

This should cover whether checking out is allowed for all different
hold states:

Attached:
 - Waiting
 - In processing
 - Transfer

Unattached:
 - Reserved

To test:
 1) prove t/db_dependent/SIP/Transaction.t => passes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690

--- Comment #11 from Joonas Kylmälä  ---
Created attachment 117003
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117003=edit
Bug 25690: Make CanBookBeIssued return In Processing state as needing
confirmation

This prevents checking out to a patron an item with hold to someone
else in the In Processing state via staff interface.

Also the checkout error message via SIP is now a more clearer one: "Item is
on hold for another patron." Before it was "Item cannot be issued:
$confirmation".

Also the branch transfer and batch checkout pages are adapted to this new
confirmation message as well.

To test:
 1) Create bib level hold to an item for patron A
 2) Check-in that item via SIP2, now the hold state should be "In processing"
 3) Apply patch
 4) Try to checkout the item to patron B via staff interface and
notice we get now confirmation prompt do we really want to do it
because it is in processing.

 In order to not have to setup SIP2 server, alternatively steps 1) and
 2) can be done so that you check-in the item in staff interface and
 make it Waiting, and then with SQL change it to "In processing":

 UPDATE reserves SET found = "P" WHERE reserve_id = XXX;
 UPDATE reserves SET waitingdate = NULL WHERE reserve_id = XX
 UPDATE reserves SET expirationdate = NULL WHERE reserve_id = XXX;

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690

--- Comment #10 from Joonas Kylmälä  ---
Created attachment 117002
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117002=edit
Bug 25690: Remove duplicated logic in SIP2 checkouts

Because AllowItemsOnHoldCheckoutSIP only affects the checkoutability
of non-attached, i.e. RESERVED holds in SIP2 we can therefore use the
common code from CanBookBeIssued and ignore only the RESERVED confirmation
message case in SIP2 checkout code.

This slightly changes the checkout error message given for "In
processing" holds that someone other than the holdee tries to
checkout. Otherwise there is no logic changes. The message that this
changes is "Item is on hold for another patron." vs. now "Item cannot
be issued: $confirmation". It is easier to create follow-up patch to
properly add INPROCESSING confirmation to CanBookBeIssued and then
show correct message based on the CanBookBeIssued return value.

To test:
 1) Apply all patches from bug 25690 to get latest Transaction.t version
 2) prove t/db_dependent/SIP/Transaction.t => passes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690

--- Comment #9 from Joonas Kylmälä  ---
Created attachment 117001
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117001=edit
Bug 25690: SIP2: Don't allow checking out attached hold that is being
transferred

Items that are attached to a hold and being transferred (found = T) is
final decision and you cannot checkout those to other patrons.

To test (if you have applied all patches from bug 25690):
 1) prove t/db_dependent/SIP/Transaction.t => passes

To test (if you don't have all patches):
 1) Create hold and set pickup library to something else where the
item is at
 2) Return the item and it should confirm the hold and start transfer
 3) Apply this patch
 4) Try to checkout this item now to some other patron via SIP2 and
notice it doesn't allow it
 5) Revert this patch
 6) Notice you can now checkout somebody else's hold that is being transferred!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690

Joonas Kylmälä  changed:

   What|Removed |Added

 Attachment #116948|0   |1
is obsolete||
 Attachment #116949|0   |1
is obsolete||
 Attachment #116950|0   |1
is obsolete||
 Attachment #116951|0   |1
is obsolete||

--- Comment #8 from Joonas Kylmälä  ---
Created attachment 117000
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117000=edit
Bug 25690: Remove double usage of 'Reserved' return value

The patch "Bug 19116: Hold not set to waiting after transfer" added a
new meaning to 'Reserved' return value of C4::Reserves::CheckReserves
function. Let's remove double usage and have separate Transferred
return value so we can differentiate between attached and non-attached
holds. This will come useful in future refactorings.

This patch does no changes to the logic except in the
/cgi-bin/koha/circ/branchtransfers.pl and circulation.pl we now give
similarly to waiting state notice about hold being transferred.

To test:
   1) Apply this patch
   2) Create a new item level hold so that pickup library is different
   than where the item is currently. Then return the item so that hold
   is being attached and transferred.
   3) Go to branchtransfers.pl and try to create a new transfer: it
   should prompt you with message "Item is attached to a hold and
   being transferred for XXX" and provide you with option to cancel
   the hold or to ignore the transfer.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27661] Clarify error for message broker

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661

--- Comment #8 from Martin Renvoize  ---
Hmm, I find the stark red as a background a bit challenging to read.. that's
probably why I went for Tomato..  Must admit, I find the inconsistency in the
about page upsets my OCD.. some status's are on their own line, others are
inline.. some have background colors applied to a span, whilst others still
have the whole row highlighted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27661] Clarify error for message broker

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661

--- Comment #7 from Martin Renvoize  ---
(In reply to Jonathan Druart from comment #5)
> +.status_fatal {
> +background-color: #FF6347 !important;
> 
> Why tomato? :)
> 
> We already have 
> .error {
> color: #CC;
> }

Fair point, I had forgotten we had 'error' already.. kinda annoying this table
has it's own classing in the first place to be honest.

Would you prefer a css change to fix the color to match our .error class.. or
wider template followup to convert to using the existing classes..

I'm thinking the latter.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27717] Date of birth fails to display for babies under 1 year

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27717

Martin Renvoize  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #4 from Martin Renvoize  ---
OK, That was rather unexpected!.. Thanks for testing Owen, new patch attached.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27717] Date of birth fails to display for babies under 1 year

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27717

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #116936|0   |1
is obsolete||

--- Comment #3 from Martin Renvoize  ---
Created attachment 116999
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116999=edit
Bug 27717: Display date of birth even if the patron is under 1

This patch moves the 'age' condition to below the date of birth display,
allowing the date to display for babies.

Test plan
1/ Add a user with a date of birth within the last year
2/ Check that the date of birth appears on the patron details page
(under contact details) with the patch applied.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27289] Template tweaks for point of sale page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289

--- Comment #17 from Martin Renvoize  ---
(In reply to Andrew Fuerste-Henry from comment #16)
> Doesn't apply cleanly to 20.05. Please rebase so I can push bug 27290

Hmm, Not sure it's required to go back that far?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569

--- Comment #55 from Martin Renvoize  ---
Thanks for clarifying.. couldn't see the wood for the trees..

Followups pushed to branch to deal with both issues :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569

--- Comment #54 from Jonathan Druart  
---
(In reply to Martin Renvoize from comment #53)
> (In reply to Jonathan Druart from comment #46)

> > 7. There are some indentation inconsistencies in circ/transferstosend.tt
> 
> Not sure I'm seeing the same thing you are.. need a bit of clarification

 69 
 70 [% END %]
 71 [% END %]
 72 
 73 
 74 [% END %]
 75 [% END %]
 76 
 77 [% ELSE %]
 78 No transfers to send
 79 [% END %]


> > 8. (not blocker) transferCollection.tt
> > +[%- SWITCH message.type -%]
> > +[%- CASE 'failure' %]
> > ...
> > +[%- CASE 'enqueu' -%]
> > 
> > The usual pattern is
> > push @message, 
> > {
> >   type => 'error', # or message
> >   code => 'enqueu(ed?)',
> >   %more_variables 
> > }
> 
> Struggling to find an example.. happy to change but struggling to understand
> the minute

% git grep 'push @messages'
will return a lot of examples :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27048] Add timestamps to verbose output of rebuild_zebra.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27048

--- Comment #7 from Martin Renvoize  ---
(In reply to David Cook from comment #3)
> Comment on attachment 113780 [details] [review]
> Bug 27048: Add basic timekeeping to rebuild_zebra
> 
> Review of attachment 113780 [details] [review]:
> -
> 
> ::: misc/migration_tools/rebuild_zebra.pl
> @@ +848,5 @@
> > +my $now_pretty = POSIX::strftime("%H:%M:%S",localtime($now));
> > +my $elapsed_pretty = $d ? "[$d:$h:$m:$s]" : $h ? "[$h:$m:$s]" : $m ? 
> > "[$m:$s]" : "[$s]";
> > +
> > +return "$now_pretty $elapsed_pretty";
> > +}
> 
> Why not just use DateTime->now()->strftime("%H:%M:%S")?

No major reason for using POSIX.. mostly I was avoiding more DateTime use.. but
as it's a single call it's not terrible so can be swapped if needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569

--- Comment #53 from Martin Renvoize  ---
(In reply to Jonathan Druart from comment #46)
> 5. in circ/transferstosend.pl
> +show_date=> output_pref(   
> 
> +{ dt => dt_from_string, dateformat => 'iso', dateonly => 1 }
> +)
> 
> I'd pass {today => dt_from_string}, it should be enough.

Done in followup on branch

> 6. in circ/transferstosend.tt
> [% FOREACH branchesloo IN branchesloop %]   
>
> should be
> [% FOREACH library IN libraries %]

Done in followup on branch

> 7. There are some indentation inconsistencies in circ/transferstosend.tt

Not sure I'm seeing the same thing you are.. need a bit of clarification

> 8. (not blocker) transferCollection.tt
> +[%- SWITCH message.type -%]
> +[%- CASE 'failure' %]
> ...
> +[%- CASE 'enqueu' -%]
> 
> The usual pattern is
> push @message, 
> {
>   type => 'error', # or message
>   code => 'enqueu(ed?)',
>   %more_variables 
> }

Struggling to find an example.. happy to change but struggling to understand
the minute

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23215] Remove PayPal logic from Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215

--- Comment #7 from Jonathan Druart  
---
Can we have a patch please?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22824] Replace YAML::Syck with YAML::XS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #47 from Jonathan Druart  
---
Switching back to NSO hoping to get other feedbacks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27398] Serials: Values in subscription length pull down are not translatable when defining numbering patterns

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27398

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 CC||and...@bywatersolutions.com
 Version(s)|21.05.00,20.11.03   |21.05.00,20.11.03,20.05.09
released in||

--- Comment #11 from Andrew Fuerste-Henry  ---
Pushed to 20.05.x for 20.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27724] Use lenient also in Elasticsearch authorities search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724

Fridolin Somers  changed:

   What|Removed |Added

 Attachment #116991|0   |1
is obsolete||

--- Comment #3 from Fridolin Somers  ---
Created attachment 116997
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116997=edit
Bug 27724: Use lenient also in Elasticsearch authorities search

In Elasticsearch, query for biblios uses lenient=true.
This is also needed for authorities search.
In case a search field is defined as type numeric.

Test plan :
1) Use Elasticsearch searchengine
2) Define a search field 'local-number' as type 'Number'
3) Be sure to us 'local-number' in autorities mapping
4) Rebuild autorities
5) Performe a search for autorities with 'Search entire record' and
   'contains' with term '123'
=> Without patch you get error :
[query_shard_exception] Can only use prefix queries on keyword and text fields
- not on [local-number] which is of type [integer]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27724] Use lenient also in Elasticsearch authorities search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724

--- Comment #2 from Fridolin Somers  ---
Created attachment 116996
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116996=edit
Bug 27724: Add unit test

Run t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27724] Use lenient also in Elasticsearch authorities search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724

--- Comment #1 from Fridolin Somers  ---
Created attachment 116991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116991=edit
Bug 27724: Use lenient also in Elasticsearch authorities search

In Elasticsearch, query for biblios uses lenient=true.
This is also needed for authorities search.
In case a search field is defined as type numeric.

Test plan :
1) Use Elasticsearch searchengine
2) Define a search field 'local-number' as type 'Number'
3) Be sure to us 'local-number' in autorities mapping
4) Rebuild autorities
5) Performe a search for autorities with 'Search entire record' and
   'contains' with term '123'
=> Without patch you get error :
[query_shard_exception] Can only use prefix queries on keyword and text fields
- not on [local-number] which is of type [integer]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27724] Use lenient also in Elasticsearch authorities search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724

Fridolin Somers  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27676] finesMode=off not correctly handled

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27676

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|21.05.00,20.11.03   |21.05.00,20.11.03,20.05.09
released in||

--- Comment #7 from Andrew Fuerste-Henry  ---
Pushed to 20.05.x for 20.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27676] finesMode=off not correctly handled

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27676

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #6 from Andrew Fuerste-Henry  ---
Correcting a typo in the test plan (charge behavior was backwards between 5 and
7):
Test plan:
0. Don't apply the patch
1. reset_all
=> finesMode eq 'off' in DB
2. Set the pref's value to production
3. Switch it back to 'off'
4. Value is '' in DB
5. Check an item in that should generate overdue charges
=> Charges are generated
6. Apply the patch
7. Check an item in that should generate overdue charges
=> Charges are not generated

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27724] Use lenient also in Elasticsearch authorities search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724

Fridolin Somers  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co
   |ity.org |m
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27724] New: Use lenient also in Elasticsearch authorities search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724

Bug ID: 27724
   Summary: Use lenient also in Elasticsearch authorities search
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolin.som...@biblibre.com

In Elasticsearch, query for biblios uses lenient=true.
This is also needed for authorities search.
In case a search field is defined as type interger.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27410] Update intranet-tmpl/prog/en/modules/members/maninvoice.tt to reflect ACC2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410

Owen Leonard  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27408] Update intranet-tmpl/prog/en/modules/members/mancredit.tt for ACC2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408

Owen Leonard  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27410] Update intranet-tmpl/prog/en/modules/members/maninvoice.tt to reflect ACC2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410

Owen Leonard  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27408] Update intranet-tmpl/prog/en/modules/members/mancredit.tt for ACC2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408

Owen Leonard  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673

--- Comment #28 from Joonas Kylmälä  ---
(In reply to Mason James from comment #27)
> Created attachment 116990 [details] [review]
> Bug 27673: remove libyaml-syck-perl, and lower libyaml-libyaml-perl to 0.41
> (for u16)
> 
> 1/ apply patch
> 2/ build koha package
> 3/ confirm that libyaml-libyaml-perl package is installed, and
> libyaml-syck-perl is not

I think libyaml-syck-perl cannot be removed because bug 22824 is not pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #27 from Owen Leonard  ---
I was looking at this and getting ready to submit a follow-up with some
additional corrections (Holds history page, the holds tab on the checkout page,
etc) but I find that it feels really convoluted to work with a system
preference which is "negative." DisableReserveExpiration equals 1 to turn
something off rather than turn something on.

I know this has been through a lot of revisions already but can it be switched
to be "ReserveExpiration" and have it be enabled by default?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673

Mason James  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673

Mason James  changed:

   What|Removed |Added

 Status|Pushed to master|ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673

--- Comment #27 from Mason James  ---
Created attachment 116990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116990=edit
Bug 27673: remove libyaml-syck-perl, and lower libyaml-libyaml-perl to 0.41
(for u16)

1/ apply patch
2/ build koha package
3/ confirm that libyaml-libyaml-perl package is installed, and
libyaml-syck-perl is not

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27422] HTML5Media is http by default but Youtube is https only

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27422

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Version(s)|21.05.00,20.11.03   |21.05.00,20.11.03,20.05.09
released in||
 Status|Pushed to stable|Pushed to oldstable
 CC||and...@bywatersolutions.com

--- Comment #8 from Andrew Fuerste-Henry  ---
Pushed to 20.05.x for 20.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27582] Breadcrumb incorrect for POS: Library details page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27582

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #6 from Andrew Fuerste-Henry  ---
Not backported for 20.05, please ask if needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27606] Breadcrumbs on parcel.pl should include a link to the vendor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27606

--- Comment #7 from Andrew Fuerste-Henry  ---
Not backporting to 20.05, but please ask if needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26943] Show not for loan descriptions in cataloging search (addbooks.pl)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|21.05.00,20.11.03   |21.05.00,20.11.03,20.05.09
released in||

--- Comment #13 from Andrew Fuerste-Henry  ---
Pushed to 20.05.x for 20.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12260] Printing a page from bootstrap shows unnecessary links

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12260

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #11 from Andrew Fuerste-Henry  ---
Not backporting for 20.05, but please ask if needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27454] Additional patron attributes change sequence on every reload of edit page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27454

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com
 Status|Pushed to stable|Pushed to oldstable
 Version(s)|21.05.00,20.11.03   |21.05.00,20.11.03,20.05.09
released in||

--- Comment #12 from Andrew Fuerste-Henry  ---
Pushed to 20.05.x for 20.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27608] Correct 'accepted by' inconsistency in suggestion.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27608

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Version(s)|21.05.00,20.11.03   |21.05.00,20.11.03,20.05.09
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #12 from Andrew Fuerste-Henry  ---
Pushed to 20.05.x for 20.05.09. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 27510] Download the report in HTML format

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Owen Leonard  changed:

   What|Removed |Added

 Attachment #116968|0   |1
is obsolete||

--- Comment #126 from Owen Leonard  ---
Created attachment 116989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116989=edit
Bug 14242: (follow-up) Format copyright date before plugged into form

This patch formats the copyright date so that only the year shows before
plugging the formatted version into the form.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18912] Show more item information when using itemBarcodeFallbackSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18912

Owen Leonard  changed:

   What|Removed |Added

 Attachment #116930|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 116987
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116987=edit
Bug 18912: Display more info when using itemBarcodeFallbackSearch

Using itemBarcodeFallbackSearch entering a barcode on checkout will do a
keyword
search and provide you with a list of items matching the search term for
checkout.
This allows checking out items, where there is no barcode in the item (you
still need
a dummy barcode in Koha).

At the moment the table of items to choose from will only chow the title and
the dummy barcode.

In order to make it more useful and easier to identify the correct item,
we should show more information here:

- callnumber (952$o)
- serial enumeration (952$h)
- copy number (952$t)
- inventory number (952$i)

(description copier from comment 0)

Test plan:
- Turn on itemBarcodeFallbackSearch
(If you have ES you need bug 27597)
- Check an item out using "street" or a search that will return several
items
- Note that you have now more info about the items

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18912] Show more item information when using itemBarcodeFallbackSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18912

--- Comment #3 from Owen Leonard  ---
Created attachment 116988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116988=edit
Bug 18912: (follow-up) Add even more information

This follow-up proposes that we add even more information (collection
code, item type) and puts the new information in to table columns.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18912] Show more item information when using itemBarcodeFallbackSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18912

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26937] Add an optional delay to the CheckPrevCheckout system preference

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937

--- Comment #9 from Katrin Fischer  ---
I think as this is about the general behaviour, not an on/off switch starting
on a global level would be perfectly fine. It would be possible to extend this
to granular if there is a need later without having to disrupt any existing
workflows.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/