[Koha-bugs] [Bug 9717] Local use recorded for holds/transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9717 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #19 from David Cook --- I just bumped into this for the first time, and I really didn't expect this bug to be such a saga... After reviewing the code in C4/Circulation.pm, the patch could theoretically be small, but it looks like no one can agree on what should or should not constitute a local use. But the thing is... if it's not recorded as "localuse", it's actually going to be recorded as a "return" anyway, so perhaps it's a much of a muchness. If people do care enough, I suppose we could have a multiple value system preference like RecordLocalUseExceptions which defines a list of situations where "return" is logged instead of "localuse". For example, you might want to record "return" instead of "localuse" if it's "OnHold" or "HasTransfer" (although this could be split into several different ones... since you can have outbound and inbound tranfers). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on checkout based on syspref values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley changed: What|Removed |Added Status|Failed QA |ASSIGNED Assignee|hayleypel...@ownmail.net|alexbuck...@catalyst.net.nz --- Comment #34 from Alex Buckley --- I'm going to attempt to revive this patchset so setting this to 'Assigned' and setting myself as assignee. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31217] Fix Coce JavaScript to hide single-pixel cover images in the OPAC lightbox gallery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217 --- Comment #14 from Alex Buckley --- (In reply to Katrin Fischer from comment #13) > Tested in Firefox in a private window to make sure the cache was not to > blame. Also restarted all the things. Hey Katrin, Thank you for trying to test this! I wonder if you try testing with Google Chrome in an incognito window (as David did in comment #4) do you see the cover image on the OPAC detail page? Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24035] When recording local use, there is no alert for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24035 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30958] OPAC Overdrive search result page broken for translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30958 --- Comment #12 from Alex Buckley --- (In reply to Victor Grousset/tuxayo from comment #11) > Sure, will try in the next days :) Thanks very much Victor :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21173] Add Hours as an age unit to auto item modifications by age for the items.damaged_on, items.itemlost_on and items.withdrawn_on age fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Alex Buckley changed: What|Removed |Added Summary|Run auto item modifications |Add Hours as an age unit to |by age every hour and set |auto item modifications by |the item age unit to hours |age for the ||items.damaged_on, ||items.itemlost_on and ||items.withdrawn_on age ||fields Change sponsored?|--- |Sponsored Version(s)||If you create rules in the released in||'Automatic item ||modification by age' tool ||on the age field(s) ||'items.damaged_on, ||items.itemlost_on, or ||items.withdrawn_on' you can ||now define an age unit of ||'Hours', not just 'Days'. || ||This means you can now ||automatically modify items ||based on the number of ||hours since they were ||marked damaged, lost, or ||withdrawn. || ||You will need ||to ask your system ||administrator to configure ||the ||automatic_item_modification ||_by_age.pl cronjob to run ||more than once a day if you ||create rules with the age ||unit of 'Hours'. Status|ASSIGNED|Needs Signoff --- Comment #22 from Alex Buckley --- Hi all, In the interests of upstreaming I have re-written this patchset. This patchset now adds the ability to set a unit of 'Hours' for automatic item modification by age rules on the three existing item datetime columns: items.damaged_on, items.itemlost_on, items.withdrawn_on. This is instead of trying to change existing items date columns to the datetime datatype, or adding new datetime columns. I think adding a new column such as 'created_on' with an automatic timestamp (as Katrin noted in comment #15), could be added in a follow-up bug report, and it's best to get a smaller part of this functionality upstreamed initially. Ready for testing again! Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21173] Run auto item modifications by age every hour and set the item age unit to hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #21 from Alex Buckley --- Created attachment 138872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138872=edit Bug 21173: Unit tests Test plan: 1. sudo koha-shell kohadev 2. prove t/db_dependent/Items/AutomaticItemModificationByAge.t Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21173] Run auto item modifications by age every hour and set the item age unit to hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #20 from Alex Buckley --- Created attachment 138871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138871=edit Bug 21173: Add Hours as an age unit to auto item modifications by age items.damaged_on, items.itemlost_on, and items.withdrawn_on are datetime fields, so it could be useful to configure rules based on the number of hours since these values. All other fields in the automatic item modifications by age tool will use the days unit. Test plan: 1. Go to Tools->Automatic item modifications by age 2. Create a new rule 3. Apply patches and restart services 4. Confirm the rule you created has an 'Age unit' displayed of 'Days' 5. Edit the existing rule. Notice if your 'Age field' is not set to items.damaged_on, items.itemlost_on or items.withdrawn_on then the 'Age unit' dropdown is disabled 6. Confirm if you try to save a rule with age unit = 'Hours' and a field other than items.damaged_on, items.itemlost_on, or items.withdrawn_on then the 'List of rules' table shows that rule with the unit of 'Days' 7. Click 'Add rule'. Observe the 'Age unit' dropdown is initially disabled and set to 'Days' until you change the 'Age field' dropdown to items.damaged_on, items.itemlost_on, or items.withdrawn_on 8. Save the rule: Age: 1 Age unit: Hours Age field: items.itemlost_on Conditions: items.barcode = TEST Substitutions: items.barcode = TEST1 9. Find an item. Set it's barcode to TEST. In the database change it's items.itemlost_on to more than 1 hour ago 10. Restart services 11. Run the automatic_item_modification_by_age.pl script: sudo koha-shell kohadev ./misc/cronjobs/automatic_item_modification_by_age.pl -c 12. Confirm the item's barcode has changed to TEST1 Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21173] Run auto item modifications by age every hour and set the item age unit to hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #19 from Alex Buckley --- Created attachment 138870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138870=edit Bug 21173: Template and JavaScript changes Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21173] Run auto item modifications by age every hour and set the item age unit to hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Alex Buckley changed: What|Removed |Added Attachment #79914|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21173] Run auto item modifications by age every hour and set the item age unit to hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Alex Buckley changed: What|Removed |Added Attachment #78917|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #66 from Victor Grousset/tuxayo --- tested: - order: field "d - Date acquired" (dateaccessioned) - receive shipment: shipmentdate field - receive order: datereceived field - finish receiving: Shipment date and Billing date - Budgets administration > edit budget > start and end dates - patron categories: Enrollment period - batch check out due date - circulation: overdues: from and to dates - holds to pull: start and end dates - renew: Renewal due date - issue found, with the patches, I don't get the "Item renewed" message box. It doesn't renew, I just get back to the same page. Without inputting a date, it works. logs: Invalid date passed to AddRenewal. at /kohadevbox/koha/circ/renew.pl line 101. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 Tomás Cohen Arazi changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #455 from David Cook --- Another thing I haven't checked here is how it works with hold limits... that's a bit of a rabbithole as well... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31303] Fatal error when viewing OPAC user account with waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31303 David Cook changed: What|Removed |Added Blocks|15516 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 [Bug 15516] Allow to place a hold on first available item from a group of titles -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook changed: What|Removed |Added Depends on|31303 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31303 [Bug 31303] Fatal error when viewing OPAC user account with waiting holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #454 from David Cook --- Created attachment 138869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138869=edit Bug 15516: [QA followup] Only show hold groups for multi hold in staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #453 from David Cook --- I fixed the item-specific holds on the staff interface, but I'm Failing QA again, as I've discovered that the checkboxes are irrelevant when placing a staff interface multi-hold: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=29biblionumber=114biblionumber=134multi_hold=1=51 The biblionumbers are in hidden inputs, which get sent no matter what. (The OPAC is fine though.) -- Aleisha: Happy for you to squash my QA followup patches into your patches as well going forward to make it easier to maintain the patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #452 from David Cook --- Created attachment 138868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138868=edit Bug 15516: [QA followup] Fix item-specific holds in staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31303] Fatal error when viewing OPAC user account with waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31303 --- Comment #12 from David Cook --- (In reply to Tomás Cohen Arazi from comment #10) > Thanks for taking care, David. I think my follow-up highlights what we > should be doing in the codebase, in general. Ah yes. Makes sense to me! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30332] Outbound SRU does not work via https
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30332 --- Comment #18 from David Cook --- Are folk happy to close this one now? See https://wiki.koha-community.org/wiki/System_requirements_and_recommendations#Zebra -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30332] Outbound SRU does not work via https
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30332 --- Comment #17 from David Cook --- (In reply to Florian Saling from comment #16) > The upgrade to Debian 11 from Debian 9 solved our problems with SRU services > requiring HTTPS. Debian 9 had libyaz5 5.27.1 installed and Debian 11 shipped > with 5.30.3. So I think it is safe to assume that the YAZ library was the > culprit! Good to know! I'll make a note on https://wiki.koha-community.org/wiki/System_requirements_and_recommendations -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31259] Downloading patron card PDF hangs the server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31259 David Cook changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30958] OPAC Overdrive search result page broken for translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30958 --- Comment #11 from Victor Grousset/tuxayo --- Sure, will try in the next days :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28634] ILL partner request notices are attached to the request creator rather than the partner recipient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28634 Katrin Fischer changed: What|Removed |Added Attachment #122468|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 138867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138867=edit Bug 28634: Fix notice borrowernumber This commit fixes the bug described in this bug. - When a partner is selected, pass their borrowernumber rather than email to the receiving script - Iterate all selected partners, send a notice to each, using the recipient's borrowernumber in the notice, the recipient's email is derived from their patron object TEST PLAN: 1. DO NOT apply the patch. 2. Follow the following setup: *** Setup start *** - Create a report using the following SQL in order to verify that notices are being generated: SELECT borrowernumber, subject, content, message_transport_type, to_address, from_address FROM message_queue WHERE letter_code LIKE 'ILL%' ORDER BY message_id DESC - Create two "partners". These are patrons that belong to a patron category that has a code that matches the value in your koha-conf.xml (default is ILLLIBS). Patrons in this category must have a primary email defined. Patrons defined in this way are offered as request partners within the ILL interface. - Go to "Koha administration", search for "ILLModule" syspref, ensure it is set to "Enable" - Go to "Koha administration", search for "IllLog" syspref, ensure it is set to "Log" BRANCH CONFIG - Go to "Koha administration" > "Libraries" - Choose a library and "Edit" it - Ensure the "Email" field for the library is populated SENDING REQUEST TO PARTNERS - Go to the "Manage ILL request" screen for a request, create a request if one does not exist - Choose "Place request with partners" - Select both partners that were defined earlier, then click "Send email" - Run the report created earlier => TEST: Observe that a notice was created and the borrowernumber is that of the request creator, not the recipient *** Setup end *** 3. Apply the patch a. Go to the "Manage ILL request" screen for a request, create a request if one does not exist b. Choose "Place request with partners" c. Select both partners that were defined earlier, then click "Send email" d. Run the report created earlier => TEST: Observe that once notice per partner is created, the borrowernumber column for each notice contains the borrower number of the recipient, not the request creator Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28634] ILL partner request notices are attached to the request creator rather than the partner recipient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28634 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30200] Add customizable tabs to interlibrary loan requests list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Katrin Fischer changed: What|Removed |Added Version|unspecified |master --- Comment #13 from Katrin Fischer --- Love this - an easy way to organize custom status and all. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31323] New: Edit item highlighting problem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31323 Bug ID: 31323 Summary: Edit item highlighting problem Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl To reproduce: 1 search the catalog 2 find a record with 1 item 3 click the edit button in the item table (to the right of Spine Label) 4 when I click "save changes" the item is still highlighted yellow It appears like the '.active' class is lingering. I think this might be caused by Bug 27526? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30200] Add customizable tabs to interlibrary loan requests list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 --- Comment #12 from Katrin Fischer --- Created attachment 138866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138866=edit Bug 30200: (follow-up) Update database update and pref description * Rephrases the system preference description a bit * Adds IGNORE to the database statement * Update output message of database statement to include pref name Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30200] Add customizable tabs to interlibrary loan requests list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 --- Comment #11 from Katrin Fischer --- Created attachment 138865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138865=edit Bug 30200: (follow-up) Fix missing TT filters Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30200] Add customizable tabs to interlibrary loan requests list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Katrin Fischer changed: What|Removed |Added Attachment #134467|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 138864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138864=edit Bug 30200: Add a new system preference ILLRequestsTabs Signed-off-by: Magnus Enger Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30200] Add customizable tabs to interlibrary loan requests list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Katrin Fischer changed: What|Removed |Added Attachment #134466|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 138863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138863=edit Bug 30200: Add custom tabs to View ILL requests page Prereqs: 1: Make sure you have enabled an ILL backend and enabled system preferecnce ILLModule. For more information see https://koha-community.org/manual/21.11/en/html/ILL_requests.html To test: 1: Note, the following branchcodes, statuses and backends depend on your test environment and which ILL backend you are using. This example is for Libris backend. Set system preference ILLRequestsTabs: - name: tab1 status: - IN_REM - name: tab2 status: - IN_UTEL - IN_LEV - name: tab3 status: - IN_ANK 2. Add at least 4 ILL requests with the following SQL: INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_REM', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_UTEL', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_LEV', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_ANK', 'Libris'); Note: Change values to whatever your test environment has set up. 3. Go to cgi-bin/koha/ill/ill-requests.pl 4. After the page loads, you should now see 4 different tabs: "All", "tab1", "tab2" and "tab3" 5. Confirm all ILL requests are present under "All" tab 6. Confirm only ILL requests with the statuses you defined in system preference ILLRequestsTabs are under tabs 1, 2 and 3 7. Go to cgi-bin/koha/members/ill-requests.pl?borrowernumber=1 8. Repeat steps 4-6 9. Clear system preference ILLRequestsTabs 10. Observe both ill/ill-requests.pl and members/ill-requests.pl now have only one tab "All" under which correct ILL requests are presented 11. Try some other status values in ILLRequestsTabs and observe expected behavior Signed-off-by: Magnus Enger Works as advertised. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30200] Add customizable tabs to interlibrary loan requests list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Katrin Fischer changed: What|Removed |Added Attachment #138858|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30484] Interlibrary loans should have the ability to send notices based on request supplier updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484 --- Comment #27 from Katrin Fischer --- Created attachment 138862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138862=edit Bug 28909: (QA follow-up) Fix typo 'Kind Regards' Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30484] Interlibrary loans should have the ability to send notices based on request supplier updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484 Katrin Fischer changed: What|Removed |Added Attachment #134628|0 |1 is obsolete|| --- Comment #26 from Katrin Fischer --- Created attachment 138861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138861=edit Bug 30484: Add unit tests Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=28909 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30484] Interlibrary loans should have the ability to send notices based on request supplier updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484 Katrin Fischer changed: What|Removed |Added Attachment #134627|0 |1 is obsolete|| --- Comment #25 from Katrin Fischer --- Created attachment 138860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138860=edit Bug 30484: Implement support for ILL request updates This commit adds support for the concept of ILL request update notices. - Adds a new Koha::Illrequest::SupplierUpdate class that is used to encapsulate an update to a request, this update may come from a supplier via a backend or from core ILL via, perhaps, a user action - Adds a new Koha::Illrequest::SupplierUpdateProcessor base class that can be subclassed in order to create a processor that can be passed an update and act accordingly. - Updates to Illrequest.pm to support the above classes and allow core Koha to offer update processors - A shell script to initiate a periodic process to check for updates meeting given criteria and run the appropriate processors Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=28909 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30484] Interlibrary loans should have the ability to send notices based on request supplier updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484 Katrin Fischer changed: What|Removed |Added Attachment #134626|0 |1 is obsolete|| --- Comment #24 from Katrin Fischer --- Created attachment 138859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138859=edit Bug 30484: Add ILL update notice Adds a new ILL_REQUEST_UPDATE notice which is to be used for the formation of notices informing users of updates to ILL requests. Commit includes database updates and template changes for messaging preferences Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=28909 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30484] Interlibrary loans should have the ability to send notices based on request supplier updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 --- Comment #15 from Katrin Fischer --- Created attachment 138858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138858=edit Bug 30484: Add ILL update notice Adds a new ILL_REQUEST_UPDATE notice which is to be used for the formation of notices informing users of updates to ILL requests. Commit includes database updates and template changes for messaging preferences Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058 --- Comment #11 from Martin Renvoize --- Hmm, well bug 20517 uses the CL field for sorter, which from memory is what sorters here use.. I'd have to look at the docs again to remind myself what AQ is for, but from the code this looks reasonable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30484] Interlibrary loans should have the ability to send notices based on request supplier updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484 --- Comment #23 from Katrin Fischer --- (In reply to Andrew Isherwood from comment #8) > Revised test plan: > > This test plan tests the provided functionality by using a mocked update > supplied by the FreeForm backend. The command line script is run which will > look for requests that match the supplied criteria, obtain a mocked update > from them, and process the update. The processor simply prints the message > supplied in the update to the screen. > > - Ensure you have Interlibrary Loans turned on and have the FreeForm backend > installed. It is important you are using the "bug_30484_mock_request_update" > branch of the FreeForm backend as this enables the backend to provide mock > updates that this functionality uses. > - Ensure that the patron that will be creating the request has the > "Interlibrary loan updated" notice enabled for at least "Email" > - Create a FreeForm ILL request > - On the "Manage ILL request" page for the newly created request, click the > "Confirm request" button, thereby setting the request status to "Requested" > - Run the script, in the "misc" directory, run: > > perl process_ill_updates.pl --statuses REQ --backend FreeForm > > - TEST: You should see the following: > - The message "This is a mock update from the FreeForm backend" > - The following run report: > > Run details: > Request ID: xxx > Processing by: FreeForm > Number of processors run: 1 > Processor details: > Processor name: Print to STDERR > Success messages: PRINTED > Error messages: > > - If the above messages were printed, the test plan can be considered > successful. 1) Typo in updatedatabase: Kind Regards > Kind regards I've added a follow-up patch fixing this globally. 2) +=head3 append_to_note. I see it only appears in Illrequest.pm and has a test, but not sure how it relates to the functionality of this patch set? 3) Worked through the test plan and it works as described. The changes for messaging preferences appear to be complete, but we should start thinking about a way to make the list of message options configurable as not all libraries will offer all notices (totally a separate bug of course). Now we need another QA for the dependent bug 28909 to unlock! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20517] Use the "sort bin" field in SIP2 Checkin Response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20058 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20517 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Katrin Fischer changed: What|Removed |Added Summary|Allow Interlibrary Loans|Allow Interlibrary loans |illview method to use |illview method to use |backend template|backend template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27779] Cashup summary 'refunds' should denote what the refund was actioned against
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #36 from Victor Grousset/tuxayo --- __x() usage looks correct ️ https://metacpan.org/pod/Locale::TextDomain https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395#c131 can't say for the rest of the patch: correct building of the phrase, complete and accurate usage of format_price or escape_str -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31259] Downloading patron card PDF hangs the server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31259 Chris Nighswonger changed: What|Removed |Added Severity|minor |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21092] Bad template in patron card creator can cause server issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21092 Chris Nighswonger changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31259] Downloading patron card PDF hangs the server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31259 Chris Nighswonger changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21092 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21092] Bad template in patron card creator can cause server issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21092 Chris Nighswonger changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31259 --- Comment #10 from Chris Nighswonger --- (In reply to Liz Rea from comment #9) > This may be related to the line wrapping code? i.e. we get into a templated > situation where we get into the while(1) loop and never get out. More > recently lately we've seen the following in our logs when these fail (also > this generates gigs and gigs of logs! It's terrible!) See my comment here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31259#c6 The root problem may be the same. An immediate solution would be to add a conditioned break to the loop that trips when the loop count exceeds the total length of the line being wrapped. That at least should prevent infinite looping. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30484] Interlibrary loans should have the ability to send notices based on request supplier updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484 Katrin Fischer changed: What|Removed |Added Summary|Interlibrary Loans should |Interlibrary loans should |have the ability to send|have the ability to send |notices based on request|notices based on request |supplier updates|supplier updates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Katrin Fischer changed: What|Removed |Added Attachment #124271|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 138857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138857=edit Bug 28909: Fix handling if backend doesn't support If a backend hasn't been updated to support this functionality, we need to handle that gracefully Also, this commit fixes some indentation. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909
Katrin Fischer changed:
What|Removed |Added
Attachment #124174|0 |1
is obsolete||
--- Comment #13 from Katrin Fischer ---
Created attachment 138856
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138856=edit
Bug 28909: Allow illview to use backend template
This commit allows illview to use an intranet template supplied by the backend,
as
per other stages. The template must be named illview.inc
Test plan:
- Apply the patch
- Install FreeForm backend (https://github.com/PTFS-Europe/koha-ill-freeform)
- Create a request
- On the resulting "Manage ILL request" note the display is normal
- Create a new file in the FreeForm backend directory:
/intra-includes/illview.inc
with the following content:
[% BLOCK backend_jsinclude %]
(function() { alert("Working!"); })()
[% END %]
- Restart Plack if enabled
- Reload the page
=> TEST: Observe that the alert specified in the template is displayed
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484 Katrin Fischer changed: What|Removed |Added Version|unspecified |master QA Contact||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31217] Fix Coce JavaScript to hide single-pixel cover images in the OPAC lightbox gallery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217 --- Comment #13 from Katrin Fischer --- Tested in Firefox in a private window to make sure the cache was not to blame. Also restarted all the things. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31217] Fix Coce JavaScript to hide single-pixel cover images in the OPAC lightbox gallery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217 --- Comment #12 from Katrin Fischer --- I believe that this should work, but I have trouble testing. I can see the cover in the OPAC result list, but the detail pages all remain empty, with and without the patch :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10086] No way to go back to the basket on uncertain prices page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10086 --- Comment #14 from Katrin Fischer --- Created attachment 138855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138855=edit Bug 10086: (QA follow-up) Fix TT filters Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10086] No way to go back to the basket on uncertain prices page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10086 Katrin Fischer changed: What|Removed |Added Attachment #137737|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 138854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138854=edit Bug 10086: Link to go to basket from uncertain prices page This patch moves the Edit button into an Edit column, styled with bootstrap button and font awesome icon, and adds a link on the basket name to go to the basket. To test: 1) Add an item with uncertain prices to a basket 2) Go to the vendor of the basket 3) Click Uncertain prices on the left 4) Notice 'edit' button does not look like a button, and basket name is not a link 5) Apply patch and refresh page 6) Basket name is now a link. Click to confirm it takes you to the right page 7) Edit button is now in edit column. Confirm it works as expected 8) Confirm you cannot sort on Edit column and the button does not wrap on a narrower browser 9) Check that the correct information is displayed for the order column (title, author, publisher code, publication year, copyright date, isbn) Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10086] No way to go back to the basket on uncertain prices page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10086 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10086] No way to go back to the basket on uncertain prices page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10086 Katrin Fischer changed: What|Removed |Added QA Contact||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30543] Decouple DumpSearchQueryTemplate from other template dump preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30543 Katrin Fischer changed: What|Removed |Added Attachment #138485|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 138853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138853=edit Bug 30543: Decouple DumpSearchQueryTemplate from other tempalte dump preferences To test: 1 - Enable DumpSearchQueryTemplate 2 - Confirm you can find the search query in the HTML as a comment 3 - Enable other template dump preference 4 - Confirm they work as before 5 - Confirm new description of preference makes sense Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30543] Decouple DumpSearchQueryTemplate from other template dump preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30543 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28269] Order search should be possible with ISSN too
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Katrin Fischer changed: What|Removed |Added Keywords||release-notes-needed --- Comment #21 from Katrin Fischer --- Nice enhancement :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28269] Order search should be possible with ISSN too
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 --- Comment #20 from Katrin Fischer --- Created attachment 138852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138852=edit Bug 28269: (QA follow-up) Fix typo in test description Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28269] Order search should be possible with ISSN too
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Katrin Fischer changed: What|Removed |Added Attachment #138186|0 |1 is obsolete|| --- Comment #19 from Katrin Fischer --- Created attachment 138851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138851=edit Bug 28269: Add tests for Acquisitions Orders search by ISSN also with SearchWithISSNVariations on and off Signed-off-by: KIT Library Germany Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28269] Order search should be possible with ISSN too
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Katrin Fischer changed: What|Removed |Added Attachment #138185|0 |1 is obsolete|| --- Comment #18 from Katrin Fischer --- Created attachment 138850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138850=edit Bug 28269: Add feature to search Acquisitions Orders by ISSN - add search form field for ISSN number - add search logic including ISSN variations search if SearchWithISSNVariations preference is set Signed-off-by: KIT Library Germany Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28269] Order search should be possible with ISSN too
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21092] Bad template in patron card creator can cause server issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21092 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #9 from Liz Rea --- This may be related to the line wrapping code? i.e. we get into a templated situation where we get into the while(1) loop and never get out. More recently lately we've seen the following in our logs when these fail (also this generates gigs and gigs of logs! It's terrible!) [2022/08/08 11:28:39] [WARN] Use of uninitialized value $1 in quotemeta at /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 269. [2022/08/08 11:28:39] [WARN] Use of uninitialized value $1 in quotemeta at /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 269. [2022/08/08 11:28:39] [WARN] Use of uninitialized value $1 in concatenation (.) or string at /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 267. [2022/08/08 11:28:39] [WARN] Use of uninitialized value $1 in concatenation (.) or string at /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 267. Hope this helps some, Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27779] Cashup summary 'refunds' should denote what the refund was actioned against
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779
Tomás Cohen Arazi changed:
What|Removed |Added
Keywords||additional_work_needed
--- Comment #35 from Tomás Cohen Arazi ---
Hi, please review my follow-up patch and sign it if correct. The way the phrase
was built is incorrect IMO, but I didn't find precedent uses of __x() in the
codebase.
Also, and important too:
t/db_dependent/Koha/Cash/Register/Cashups.t ..
# Failed test 'Returns only CASHUP actions'
# at t/db_dependent/Koha/Cash/Register/Cashups.t line 66.
# got: '5'
# expected: '1'
# Looks like you failed 1 test of 3.
t/db_dependent/Koha/Cash/Register/Cashups.t .. 1/1
# Failed test 'search'
# at t/db_dependent/Koha/Cash/Register/Cashups.t line 74.
# Looks like you failed 1 test of 1.
t/db_dependent/Koha/Cash/Register/Cashups.t .. Dubious, test returned 1 (wstat
256, 0x100)
Failed 1/1 subtests
t/db_dependent/Koha/Cash/Register/Cashup.t ... 1/3
# Failed test 'payout_grouped arrayref is correct'
# at t/db_dependent/Koha/Cash/Register/Cashup.t line 226.
# Structures begin differing at:
# $got->[0]{related_debit} = HASH(0x55c08306c098)
# $expected->[0]{related_debit} = Does not exist
# Failed test 'payout_grouped arrayref is correct'
# at t/db_dependent/Koha/Cash/Register/Cashup.t line 346.
# Structures begin differing at:
# $got->[0]{credit_type}{description} = 'Refund'
# $expected->[0]{credit_type}{description} = 'A refund applied to a
patrons fine'
# Looks like you failed 2 tests of 29.
t/db_dependent/Koha/Cash/Register/Cashup.t ... 3/3
# Failed test 'summary'
# at t/db_dependent/Koha/Cash/Register/Cashup.t line 350.
# Looks like you failed 1 test of 3.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371 Tomás Cohen Arazi changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31104] Pagination generates HTTP "Link:" header which is over 8192 bytes apache's limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31104 Tomás Cohen Arazi changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #13 from Tomás Cohen Arazi --- Tests reverted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30756] Get skip block out of Koha_Authority.t and add TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 Tomás Cohen Arazi changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30992] Hard to translate single word strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992 Tomás Cohen Arazi changed: What|Removed |Added Keywords|additional_work_needed | CC||tomasco...@gmail.com --- Comment #20 from Tomás Cohen Arazi --- Follow-up pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27779] Cashup summary 'refunds' should denote what the refund was actioned against
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 --- Comment #34 from Tomás Cohen Arazi --- Created attachment 138849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138849=edit Bug 27779: (QA follow-up) Better translatability Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31313] Remove GetItemsInfo from opac-detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 --- Comment #4 from Owen Leonard --- Created attachment 138848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138848=edit Bug 31313: Fix availability - OPAC opac-detail Has to move some code to a method Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31313] Remove GetItemsInfo from opac-detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 Owen Leonard changed: What|Removed |Added Attachment #138821|0 |1 is obsolete|| Attachment #138822|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 138847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138847=edit Bug 31313: Remove GetItemsInfo from opac-detail Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered. Here we are going to deal with opac-detail Test plan: List items on the modified view and confirm that all the info is displayed correctly Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31313] Remove GetItemsInfo from opac-detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31312] Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31312 --- Comment #3 from Owen Leonard --- > Test plan: > I am not sure, what do we want to test here? Items' info indexed > correctly? The process completes correctly and the results appear to be up to date. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31312] Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31312 Owen Leonard changed: What|Removed |Added Attachment #138820|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 138846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138846=edit Bug 31312: Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl Hum... Item2Marc ok here? Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search. Here we are going to deal with misc/migration_tools/rebuild_zebra.pl Test plan: I am not sure, what do we want to test here? Items' info indexed correctly? Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31312] Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31312 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31322] Searching not working on the receive orders page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31322 --- Comment #1 from Katrin Fischer --- Hi Holly, the receive page now uses an API based search. Can you test if you can see the libraries list in administration on these installations? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31311] Remove GetItemsInfo from labels/label-item-search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31311 Owen Leonard changed: What|Removed |Added Attachment #138819|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 138845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138845=edit Bug 31311: Remove GetItemsInfo labels/label-item-search It was commented anyway Hey, nothing to do here! Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31311] Remove GetItemsInfo from labels/label-item-search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31311 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20416] Remove hide_marc and advancedMARCeditor system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20416 --- Comment #5 from Katrin Fischer --- (In reply to Caroline Cyr La Rose from comment #3) > Re: hide_marc > > It doesn't do what the syspref description says it does. > > What it says: Show/Don't show MARC tag numbers, subfield codes and > indicators in MARC views. > > - MARC tag numbers > - MARC subfield codes (these appear in staff only) > - Indicators > > What it does: Show/Don't show MARC tag numbers and indicators in MARC views. > > - MARC tag numbers > - Indicators > > **Subfield codes still show in the MARC view in the staff interface. I believe this could be a 'recent' bug and instead of changing the pref we might want to check into making it work like described. > Re: advancedMARCeditor > > The name of this one is misleading, in my opinion. To me, the 'advanced MARC > editor' is the advanced editor that is available when > EnableAdvancedCatalogingEditor is enabled. This system preference removes > the field/subfield names in the *basic* MARC editor. > > I don't really have an opinion as to whether they should be removed or not. > All my clients have them both enabled, and most hide the MARC view in the > OPAC, as it is not very useful to the average patron. But the names and > descriptions should definitely be updated to reflect the actual behaviour. The problem here was that advancedMARCeditor existed before the new advanced MARC editor... but I'd be all +1 for renaming it :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20416] Remove hide_marc and advancedMARCeditor system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20416 --- Comment #4 from Caroline Cyr La Rose --- Also, I think hide_marc used to be used to show/don't show the tag numbers in the basic editor (https://koha-community.org/manual/21.05/en/html/catalogingpreferences.html#hide-marc) but it doesn't do that anymore. It really only affects the MARC view. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20416] Remove hide_marc and advancedMARCeditor system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20416 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #3 from Caroline Cyr La Rose --- Re: hide_marc It doesn't do what the syspref description says it does. What it says: Show/Don't show MARC tag numbers, subfield codes and indicators in MARC views. - MARC tag numbers - MARC subfield codes (these appear in staff only) - Indicators What it does: Show/Don't show MARC tag numbers and indicators in MARC views. - MARC tag numbers - Indicators **Subfield codes still show in the MARC view in the staff interface. Re: advancedMARCeditor The name of this one is misleading, in my opinion. To me, the 'advanced MARC editor' is the advanced editor that is available when EnableAdvancedCatalogingEditor is enabled. This system preference removes the field/subfield names in the *basic* MARC editor. I don't really have an opinion as to whether they should be removed or not. All my clients have them both enabled, and most hide the MARC view in the OPAC, as it is not very useful to the average patron. But the names and descriptions should definitely be updated to reflect the actual behaviour. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30332] Outbound SRU does not work via https
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30332 Florian Saling changed: What|Removed |Added CC||flor...@torchwood4.de --- Comment #16 from Florian Saling --- (In reply to David Cook from comment #15) > (In reply to Thomas Klausner from comment #14) > > OK, I found something in the YAZ changelog that might be relevant: > > > > https://software.indexdata.com/yaz/doc/NEWS > > > > > --- 5.30.3 2020/06/10 > > > > > > Require getaddrinfo which has been available since 2003. > > > > > > Provide server host for SSL by using gnutls_server_name_set(3). > > > Thx to Guillaume Jactat. > > > > So I'll try to get the sysadmin to update to a more recent libyaz5, and also > > get them to provide us with a more recent debian (11, stable; instead of 10, > > oldstable). > > > > If it's OK for you, I'll keep this ticket open until I have confirmed that a > > libyaz5 update is the way to go! > > > > Greetings, > > domm > > Yeah that sounds reasonable to me. Plus, older versions of Debian are still > listed as recommended for Koha on > https://wiki.koha-community.org/wiki/System_requirements_and_recommendations > so it would be good to determine that the YAZ library is the culprit here so > we could note it down. The upgrade to Debian 11 from Debian 9 solved our problems with SRU services requiring HTTPS. Debian 9 had libyaz5 5.27.1 installed and Debian 11 shipped with 5.30.3. So I think it is safe to assume that the YAZ library was the culprit! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30213] Hide Delete (aka Priority) column when user only has place_hold permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30213] Hide Delete (aka Priority) column when user only has place_hold permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27779] Cashup summary 'refunds' should denote what the refund was actioned against
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 --- Comment #33 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27779] Cashup summary 'refunds' should denote what the refund was actioned against
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28787] Send a notice with the TOTP token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #79 from Tomás Cohen Arazi --- Hey, can you please check this: Error while executing command: unexpected alert open: Dismissed user prompt dialog: Cannot send the notice, you don't have an email address defined. at /usr/share/perl5/Selenium/Remote/Driver.pm line 411. at /usr/share/perl5/Selenium/Remote/Driver.pm line 356. # Looks like your test exited with 255 just after 3. /kohadevbox/koha/t/db_dependent/selenium/authentication_2fa.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 2/4 subtests Just in case, I'm running on: $ ktd --selenium --es7 up -d -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9596] Allow longoverdue.pl to be configured by library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9596 Todd Goatley changed: What|Removed |Added CC||tgoat...@gmail.com --- Comment #3 from Todd Goatley --- It would be great if this is added to circ & fine. Consortium's with a number of defined items could set this up per library making life easier on the individual libraries. This would be fantastic for stand alone libraries as well. Please, please, please someone take this on! :~D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31310] Remove GetItemsInfo from catalogue/imageviewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31310 Owen Leonard changed: What|Removed |Added Attachment #138818|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 138844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138844=edit Bug 31310: Remove GetItemsInfo from catalogue/imageviewer Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered. Here we are going to deal with catalogue/imageviewer Test plan: List items on the modified view and confirm that all the info is displayed correctly Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31310] Remove GetItemsInfo from catalogue/imageviewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31310 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31309] Remove GetItemsInfo from basket/sendbasket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31309 Owen Leonard changed: What|Removed |Added Attachment #138817|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 138843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138843=edit Bug 31309: Remove GetItemsInfo from basket/sendbasket Why are we display with $raw? Why are we display the location code instead of the AV's lib? Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered. Here we are going to deal with basket/sendbasket Test plan: List items on the modified view and confirm that all the info is displayed correctly Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
