[Koha-bugs] [Bug 27880] Store each database migrations state in database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27880 --- Comment #38 from David Cook --- I wonder sometimes how many people use the Debian packages versus other installation methods... The Debian packages automatically run the database upgrade so the upgrade check at startup time should always be false in a test/prod setting. For developers, expecting them to manually run "koha-upgrade-schema" seems fair to me. So I imagine we're considering people who do source/tarball installs, or git/dev installs? In theory, when they're doing installs/upgrades, they're using "make", so maybe we should add a database upgrade step there OR just add a warning that they should manually run it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27880] Store each database migrations state in database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27880 --- Comment #37 from David Cook --- (In reply to Julian Maurice from comment #36) > (In reply to David Cook from comment #35) > > If we move it to the start of the application, I think we'd have to process > > upgrades automatically behind the scenes and not via the UI. > > It's an interesting option. But maybe Koha should warn before making changes > to the database schema. Or administrators should be able to disable this > feature if they want greater control. > Another option is to simply refuse to start and tell the administrator it > should run updatedatabase.pl > Another one is to start a minimal app that includes only the web installer > (but that would probably require another restart after the web installer is > done). I suppose another option would be to do the install/upgrade check at startup time and set a variable in a global/singleton like Koha::Installer, which would be checked by each worker... If "need_upgrade" is set, then they repeat the check, because only 1 worker will likely complete the install/upgrade process, and the other workers would be working with stale data... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33932] Why multiple statuses on item record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33932 --- Comment #12 from David Cook --- (In reply to Katrin Fischer from comment #11) > If we had only one status field, we'd have to prioritize the different > status as only one would apply. So it can be either lost, or withdrawn, or > not for loan, or damaged... only one thing applies at a time, leading to > less exact reporting. I was thinking the same thing. While there might be more convenience, there'd be less granularity. > But maybe I misunderstood and you only meant one calculated status or a > display status and the other fields remain as they are? Not sure which "you" you mean here hehe. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33938] Installer wants to upgrade even when the DB is up-to-date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33938 --- Comment #7 from David Cook --- (In reply to Marcel de Rooy from comment #5) > If I hit this URL, I need to login first with the admin user to discover > that the version is the same. We could do better than that? That's a good point too. Near the top of install.pl, we could do an upgrade check (I'd suggest the one from bug 34088) and if an upgrade isn't required, redirect to mainpage.pl. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33938] Installer wants to upgrade even when the DB is up-to-date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33938 --- Comment #6 from David Cook --- (In reply to Jonathan Druart from comment #4) > Are you suggesting to make the comparison in the pl then pass a variable > 'needs_upgrade' if dbversion != kohaversion? Well, there is already an "upgrading" variable which seems to be set without checking that upgrading is necessary. I think that we should fix it there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34257] New: Library limitations for item types not respected when batch modding items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34257 Bug ID: 34257 Summary: Library limitations for item types not respected when batch modding items Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com To recreate: 1. Go to Item types administration. 2. Set some items types to be limited to a branch you are not logged in as. 3. Find some items from the branch you are logged in at and go to Batch item modification. 4. Add the barcodes and attempt to edit the item type to the one you limited in step 2. 5. You can change these item types to ones that your branch should not be able to. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32801] /checkouts?checked_in=1 errors when itemnumber is null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32801 Katrin Fischer changed: What|Removed |Added Attachment #153107|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 153340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153340=edit Bug 32801: Prevent 500 on /checkouts If checked_in flag is passed we return the "old checkouts". But if the item has been deleted we explode with "message":"Expected integer - got null.","path":"\/0\/item_id" The specs should reflect that an item can have been deleted. Test plan: Hit the endpoint and confirm the above. Can be done easily using curl: curl -u koha:koha --request GET 'http://localhost:8081/api/v1/checkouts?patron_id=5_in=1' --header "Content-Type: application/json" | jq Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32801] /checkouts?checked_in=1 errors when itemnumber is null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32801 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34256] New: Patron search: search for borrowernumber starts with fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34256 Bug ID: 34256 Summary: Patron search: search for borrowernumber starts with fails Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com The sample data has patrons with borrowernumbers 51 and 19. Neither is found when you select borrowernumber and starts with in the search filters. I am sure this was a regression on one point, because I have used this feature before. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31147] Recalls due date to the minute rather than 23:59
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31147 Katrin Fischer changed: What|Removed |Added Attachment #153283|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 153339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153339=edit Bug 31147: Recalls should not adjust due time for related checkouts The current recalls behaviour adjusts the due date of the most appropriate checkout based on the 'recall due date interval' circulation rule. It also adjusts the due time, which is buggy behaviour. The due date should be adjusted based on the circulation rule, but the due time should remain the same. To test: 1. Enable the UseRecalls system preference and configure recalls-related circulation and fines rules 2. Check out Item A to Patron A 3. Log into the database and check the due date for that checked out item, e.g. SELECT date_due FROM issues WHERE itemnumber = ; --> It should be -MM-DD 23:59:00 4. Log into the OPAC as Patron B and place a recall on Item A. This will force a change to the recall's due date. Check the due date in the database SELECT date_due FROM issues WHERE itemnumber = ; --> It should be today + the number of days in your recall due date interval circulation rule, at the exact time you placed the recall. This is buggy behaviour. 5. Apply the patch and restart services 6. Check in Item A, do NOT fulfill the recall 7. Cancel the recall 8. Check out Item A to Patron A 9. Log into the database and check the due date for that checked out item, e.g. SELECT date_due FROM issues WHERE itemnumber = ; --> It should be -MM-DD 23:59:00 10. Log into the OPAC as Patron B and place a recall on Item A. This will force a change to the recall's due date. Check the due date in the database SELECT date_due FROM issues WHERE itemnumber = ; --> It should be today + the number of days in your recall due date interval circulation rule, with time of 23:59:00. 11. Check in Item A, do NOT fulfill the recall 12. Cancel the recall 13. Check out Item A to Patron A. Specify a due date and change the due time so it isn't 23:59. 14. Log into the OPAC as Patron B and place a recall on Item A. This will force a change to the recall's due date. Check the due date in the database SELECT date_due FROM issues WHERE itemnumber = ; --> It should be today + the number of days in your recall due date interval circulation rule, with time you set in Step 13. 15. Confirm tests pass t/db_dependent/Koha/Recalls.t Sponsored-by: Catalyst IT Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31147] Recalls due date to the minute rather than 23:59
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31147 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31147] Recalls due date to the minute rather than 23:59
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31147 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14322] Can't link to an item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14322 he...@bywatersolutions.com changed: What|Removed |Added CC||he...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14322] Can't link to an item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14322 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34188] Require Library Branch Selection when Logging in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34188 Sam Lau changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34188] Require Library Branch Selection when Logging in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34188 Sam Lau changed: What|Removed |Added Attachment #153337|0 |1 is obsolete|| --- Comment #2 from Sam Lau --- Created attachment 153338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153338=edit Bug 34188: Require Library Branch Selection when Logging in This patch adds the ability to force staff to select a library when logging into the staff interface. This is done via a new system preference: 'ForcedLibrarySelection' To test: 1) Apply patch, restart_all, and updatedatabase 2) Log out of the staff interface. Notice the login form looks the same and the "Library:" dropdown has 'My Library" selected as default. Log back into the staff interface. 3) In Administration, search for the system preference "ForcedLibrarySelection". Set it to 'Force' and press save. 4) Log out of the staff interface. Notice that this time, the "Library:" dropdown is required and has a blank selection as the default. 5) Fill in the username and password but do not select a library. Click 'Log in' 6) Notice you cannot log in and are asked to 'Please select an item in the list' 7) Select a library from the drop down and click 'Log in' 8) Notice the login was successful and you were logged in to the library you selected.9) Try loggin in with some other libraries to verify it works as expected 10) Sign-off :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34188] Require Library Branch Selection when Logging in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34188 --- Comment #1 from Sam Lau --- Created attachment 153337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153337=edit Bug 34188: Require Library Branch Selection when Logging in This patch adds the ability to force staff to select a library when logging into the staff interface. This is done via a new system preference: 'ForcedLibrarySelection' To test: 1) Apply patch, restart_all, and updatedatabase 2) Log out of the staff interface. Notice the login form looks the same and the "Library:" dropdown has 'My Library" selected as default. Log back into the staff interface. 3) In Administration, search for the system preference "ForcedLibrarySelection". Set it to 'Force' and press save. 4) Log out of the staff interface. Notice that this time, the "Library:" dropdown is required and has a blank selection as the default. 5) Fill in the username and password but do not select a library. Click 'Log in' 6) Notice you cannot log in and are asked to 'Please select an item in the list' 7) Select a library from the drop down and click 'Log in' 8) Notice the login was successful and you were logged in to the library you selected.9) Try loggin in with some other libraries to verify it works as expected 10) Sign-off :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34251] Marc editor with JS error when using fast add framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34251 Jan Kissig changed: What|Removed |Added Summary|Marc editor throws error|Marc editor with JS error |when using fast add |when using fast add |framework |framework -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34188] Require Library Branch Selection when Logging in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34188 Sam Lau changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |sama...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8676] Show vendor name in source of acquisition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8676 Laura Escamilla changed: What|Removed |Added CC||Laura.escamilla@bywatersolu ||tions.com --- Comment #16 from Laura Escamilla --- +1 this is still relevant -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25159] Action logs should be stored in JSON ( and as a diff of the change )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #7 from Andrew Fuerste-Henry --- (In reply to Kyle M Hall from comment #6) > I'm going to propose we begin by adding a new column named "diff" to the > action_logs table to store this json formatted diff. Once that's in we can > work on the viewer as a followup. That seems like a good low-bar option to get this moving. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34156] C4::Acquisition::FillWithDefaultValues handles leader incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34156 --- Comment #2 from Nick Clemens --- I think we just need to catch field 000 and use the leader subroutine for setting it, need a conditional to catch the case -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378
--- Comment #157 from Matt Blenkinsop ---
(In reply to Katrin Fischer from comment #143)
> Overall this is mostly small stuff, apart from 9) maybe!
>
> We'll also need some good documetnation, but the test plan in comment 121 is
> a good start.
>
> 1) Perltidy
>
> Should we perltidy the new files at least?
I've run perltidy for JSConsents.pm.
>
> 2) System preferences - sysprefs.sql
>
> sysprefs.sql is supposed to be alphabetic (being a librarian, this is not
> acceptable! ;) )
Fixed :)
>
> ('ConfirmFutureHolds','0',...
> +('CookieConsentedJS', '', NULL, 'Add ...
> ('ConsiderOnSiteCheckoutsAsNormalCheckouts',...
> ('ContentWarningField', '',...
> +('CookieConsent', '0', NULL...
>
> 3) System preferences - YAML
>
> a)
> + - pref: CookieConsent
> + choices:
> + yes: Require
> + no: "Don't require"
> + - cookie consent to be displayed
>
> Should be 1 and 0. (blocker)
Fixed
> Should we rephrase a bit?
Re-written as per below
> ... cookie consent to be displayed in the OPAC and staff interface.
>
> Question: Could it be interesting to make this OPAC only in the future?
>
> b) Add Javascript code that will run if cookie consent is provided (e.g.
> tracking code).
>
> Should we rephrase this a little?
Re-phrased as per below
> Run the following JavaScript if cookie consent was provided (e.g. tracking
> code):
>
>
> 3) Add to cookie documentation please
>
> https://wiki.koha-community.org/wiki/Use_of_Cookies
>
> For OPAC and staff interface.
Done
>
> 4) Translatability (blocker)
>
> ' href="#">Delete' +
Fixed
>
> 5) Test plan and comments
>
> Giving that this is an old development there are quite some inconsistencies
> in what is the final product and what is mentioned in the commit messages.
> Like we started out with 4 prefs and now 2 are HTML customizations. Some
> squashing and clean-up could be really helpful I think.
>
> But: great updated test plan in comment 121 !
I've squashed the original commits into one to remove the confusing messages.
I've also consolidated the accessibility fixes into one commit and combined a
couple of other similar commits to try and prevent duplication
>
> 6) Display issues
>
> a) In the OPAC, the cookie banner overlaps and blocks access to the language
> selection at the bottom. If you have them at the top too, that's ok, but
> some libraries prefer one over the other ( OpacLangSelectorMode = only
> footer ).
Fixed - it will now sit above the language selection when visible
>
> b) In the staff interface we have the language chooser in front, cutting off
> a bit of the "Accept all cookies" button.
Fixed as per above solution
>
> c) In the OPAC readability (font color and size) is good, but in the staff
> interface it's much less readable.
It currently just uses the default bootstrap class as in the rest of Koha,
could this be a problem elsewhere?
>
>
> 7) Patron account
>
> a) It doesn't appear to be possible to revoke the general cookie consent?
Do you mean consent to all cookies including for example the session id? Giving
this option could lead to issues with using Koha, we would probably need to be
specific about which cookies this would delete
>
> b) The contrast on the yellow "Accept selected non-essential" cookies seems
> bad (greyish font color on yellow background)
It currently just uses the default bootstrap class as in the rest of Koha,
could this be a problem elsewhere?
>
> c) Should the button read "View and update..."?
>
> d) I cannot close/cancel the modal without making a change. Clicking
> outside, pressing ESC, nothing works. We shoudl have a "Cancel" link. This
> is also true when using the "your cookies" link for a non-authenticated user.
I've added a cancel button that now closes the modal
>
>
> 8) Visibility OPAC/staff
>
> a) I checked one of the cookies for only OPAC and one only for staff
> interface. I still see all 3 cookies in the pop-up in both OPAC and staff
> after clearing local storage.
>
> b) This might be related: test2 is my "staff only" cookie. It's unchecked in
> the view, but it still gets added every time I refresh any OPAC page.
> Same for my "opac only" cookie: it's always added in staff interface on page
> reload.
For points A and B I've added some filtering into the call for the cookies
code. This was missing previously so all cookies were being provided to both
the OPAC and the staff client. This should now be fixed
>
> c) Where can staff view and alter their cookie consents?
I've added a "My Consents" option under the user menu dropdown in the top right
hand corner. This opens the modal and allows staff to review their consents
Hopefully I've addressed everything, let me know if there are any further
comments!
--
You are receiving this mail because:
You are watching all bug changes.
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151842|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151839|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151838|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151837|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151836|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151834|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151833|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151832|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151831|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151830|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151829|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151828|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151827|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151826|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151843|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #156 from Matt Blenkinsop --- Created attachment 153336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153336=edit Bug 27378: (QA follow-up) Add filtering for OPAC only and staff only cookies This patch fixes an issue where cookies selected as OPAC only would still show in the staff client and vise versa. The cookies are now filtered and only the correct cookies will be used in the OPAC and staff client -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #155 from Matt Blenkinsop --- Created attachment 153335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153335=edit Bug 27378: (QA follow-up) Add cancel button to cookie modal This patch adds a cancel button to the modal for reviewing cookie consents. Previously there was no way to exit without selecting one of the cookie options -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #154 from Matt Blenkinsop --- Created attachment 153334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153334=edit Bug 27378: (QA follow-up) Allow staff to view their cookie consents This patch allows staff to view their cookie consents through a link in the dropdown menu in the navbar. Previously staff had no way of accessing their cookie consents -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #153 from Matt Blenkinsop --- Created attachment 15 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15=edit Bug 27378: (QA follow-up) Small fixes and tidy-ups This patch does the following: - Realphabetizes the lines in sysprefs.sql - Fixes a formatting error in patrons.pref - Adjusts the position of the cookie consent bar if the language selector is visible - Fixes translatability on the syspref modal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151844|0 |1 is obsolete|| --- Comment #152 from Matt Blenkinsop --- Created attachment 153332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153332=edit Bug 27378: Remove two sysprefs and replace with html customisations Currently there are two sysprefs - CookieConsentBar and CookieConsentPopup. These allow the user to select what text they would like to see in the consent bar and modal. These have been removed and replaced with HTML customisations to allow more flexible customisations and different languages. Sponsored by: PTFS-Europe -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #151 from Matt Blenkinsop --- Created attachment 153331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153331=edit Bug 27378: Stop the codemirror editor and delete confirmation from duplicating Previously, if the "Add new code button" was clicked in the CookieConsentedJS editor, the original entry would have duplicated CodeMirror editors. This was exponential, i.e adding two new lines would result in three codemirror editors appearing on the first entry, two on the second and so on. The click event was not being applied properly and was being applied to every element with the .expand-textarea class, rather than specifically the new elements being created. The addExpandHandler function now loops through each element individually and decides whether to apply the click event handler. Similarly, the delete confirmation was dupliacting for the same reason. This has also been resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151841|0 |1 is obsolete|| --- Comment #150 from Matt Blenkinsop --- Created attachment 153330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153330=edit Bug 27378: Change ConsentJS to CookieConsentedJS This patch updates the name of the ConsentJS syspref to CookieConsentedJS and amends the description to be more clear what the syspref is for -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151840|0 |1 is obsolete|| --- Comment #149 from Matt Blenkinsop --- Created attachment 153329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153329=edit Bug 27378: Update to new atomicupdate structure This patch consolidates the previous 4 database update files into one atomicupdate file in line with the new structure -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #148 from Matt Blenkinsop --- Created attachment 153328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153328=edit Bug 27378: Fix accessibility issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151835|0 |1 is obsolete|| --- Comment #147 from Matt Blenkinsop --- Created attachment 153327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153327=edit Bug 27378: (follow-up) Add missing filters (cherry picked from commit 6b8565b949b62269f6d850e6d412458d0dbcfb37) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #146 from Matt Blenkinsop --- Created attachment 153326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153326=edit Bug 27378: Introduce cookie consent to OPAC and staff client To avoid confusion around commit messages and the content of this enhancement, this first commit is a squashed commit of all the original code submited to this bug. Following a few years of inactivity, it has been rebased and re-submitted with some fixes and concept changes contained in the more recent commits. Signed-ff-by: Barry Cannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What|Removed |Added Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #96 from Pedro Amorim --- Katrin, thank you for your amazing QA. I have 18 patches that address your observations here: https://github.com/PTFS-Europe/koha/commits/new_30719 Please have another look and then let me know how to proceed, if there's more fixing required, should I submit all these patches here or provide a squashed version? I did not address 11) directly because I'm not sure where exactly to apply it. Thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13093] Allow/Don't allow holds on items with set statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13093 --- Comment #4 from Christopher Brannon --- (In reply to Katrin Fischer from comment #3) > I think settings would work, yes. Also this would allow for migrations > without changing behaviour. :) I finally have an idea you like! :) Just kidding. I know you are trying to keep us in line with what everyone else is doing. Thanks for helping us with the perspectives. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What|Removed |Added Blocks||34255 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34255 [Bug 34255] Add an enquiry/request/workflow management module -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33105] Add vendor issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 Martin Renvoize changed: What|Removed |Added Blocks||34255 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34255 [Bug 34255] Add an enquiry/request/workflow management module -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34255] New: Add an enquiry/request/workflow management module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34255 Bug ID: 34255 Summary: Add an enquiry/request/workflow management module Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Depends on: 33105, 31028 We have a number of different ways to create what boils down to a simple enquiry in Koha.. OPAC Problem reports, Catalogue concerns, Purchase suggestions and the upcoming Vendor issues. It would be great to have a central module for managing all these different enquiry/ticket types, with jump out points to the various different workflows for working those enquiries through to a resolution. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 [Bug 33105] Add vendor issues -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25159] Action logs should be stored in JSON ( and as a diff of the change )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #6 from Kyle M Hall --- I'm going to propose we begin by adding a new column named "diff" to the action_logs table to store this json formatted diff. Once that's in we can work on the viewer as a followup. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33105] Add vendor issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #64 from Martin Renvoize --- I think I left follow-up bugs to generalise that.. I was heading towards a more generalised enquiry management flow but I had to also keep the sponsor happy.. hense the API design trying hard to generalise and then my aim was to migrate to vue and a new 'enquiries' module once some of the vue stuff had settled (at the time I coded catalogue concerns, we'd not made anywhere near the progress in vue). I'd love to see a much more generalise enquiries/workflows entity and am happy to contribute in that space.. we're currently working on sponsorship for it here at ptfs-e. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25159] Action logs should be stored in JSON ( and as a diff of the change )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Barbara Johnson changed: What|Removed |Added CC||barbara.johnson@bedfordtx.g ||ov --- Comment #5 from Barbara Johnson --- This would be so great. I often have a hard time interpreting the action logs - easily seeing the before and after values would be really helpful. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33105] Add vendor issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 --- Comment #63 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #62) > (In reply to Tomás Cohen Arazi from comment #61) > > (In reply to Jonathan Druart from comment #60) > > > (In reply to Tomás Cohen Arazi from comment #59) > > > > Not going to block this, but we added the 'OPAC concerns' and now the > > > > 'vendor issues'. Should we think of a more generic approach? > > > > > > Hum I don't think so, they are two completely different things. One is > > > linked with the acquisition module for external entities, OPAC concerns is > > > for OPAC users. I don't see how we could merge them. > > > > Besides the UI differences, I see 'ticket type X' and 'ticket type Y'. I had > > the same concerns about the 'OPAC record concerns ' feature as being too > > specific by design. > > The table name was not specific: "tickets" :D The table name got the right name, that's true. But we have concerns.pl concerns.tt and all the tools are named 'catalog_concern.*'. Including the admin pages. Not complaining, just saying that we might need to think of a more general approach at some point. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34254] New: Reopening a basket to edit an order item will remove it from the invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34254 Bug ID: 34254 Summary: Reopening a basket to edit an order item will remove it from the invoice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: laura.escami...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Steps to recreate: 1. Create basket and add items 2. Receive shipment 3. Confirm that all items in shipment are showing up on the invoice created 4. Reopen the basket and modify one of the items 5. Re-close basket and confirm that all items in the basket are still showing up as received 6. Check the invoice, the item that was modified is no longer showing up in the invoice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34252] Ability to link to ILL request in external ILL system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34252 --- Comment #3 from Pedro Amorim --- (In reply to Katrin Fischer from comment #2) > Hm, I am not sure. We don't use that yet and I thought it was supposed to be > the URL to the document, like a delivery URL. What about orderid? We use that to store the ID of the order placed in the supplier in some of our backends. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34181] Batch Patron Modification Tool missing checkboxes to clear field values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33872] Duplicated patron's registration date is set to expiration date of template patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33872 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34252] Ability to link to ILL request in external ILL system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34252 --- Comment #2 from Katrin Fischer --- Hm, I am not sure. We don't use that yet and I thought it was supposed to be the URL to the document, like a delivery URL. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34249] New privacy option for lists: staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34249 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33270] OAI-PMH should not die on record errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33270 --- Comment #14 from Nick Clemens --- Created attachment 153325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153325=edit Bug 33270: (follow-up) Handle records that fail attempt to ignore bad characters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34252] Ability to link to ILL request in external ILL system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34252 --- Comment #1 from Pedro Amorim --- Does the existent accessurl column in illrequests satisfy this requirement? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 --- Comment #92 from Katrin Fischer --- (In reply to Nick Clemens from comment #91) > (In reply to Katrin Fischer from comment #79) > > Testing here again... back and forth we go! > > Heh, tested as well, Katrin beat me by about 5 minutes, but adding my > support too :-) I think another set of eyes definitely won't hurt for sure! I'd love to see a fix for bug 32271 as next step, so we hopefully get in a state again where editing rules doesn't create unwanted side effects. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34094] Apply DefaultPatronSearchMethod to all patron search forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34094 Martin Renvoize changed: What|Removed |Added Blocks||34253 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34253 [Bug 34253] DefaultPatronSearchMethod should be more thoroughly unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34253] DefaultPatronSearchMethod should be more thoroughly unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34253 Martin Renvoize changed: What|Removed |Added Depends on||34094 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34094 [Bug 34094] Apply DefaultPatronSearchMethod to all patron search forms -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34253] New: DefaultPatronSearchMethod should be more thoroughly unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34253 Bug ID: 34253 Summary: DefaultPatronSearchMethod should be more thoroughly unit tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org It became apparent to me that I didn't add enough tests for the introduction of DefaultPatronSearchMethod at the time.. we should add more tests for the two options it allows. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34173] Imported items do not require home/holding branches, causing uneditable item records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34173 Enica Davis changed: What|Removed |Added CC||en...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34252] New: Ability to link to ILL request in external ILL system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34252 Bug ID: 34252 Summary: Ability to link to ILL request in external ILL system Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de CC: pedro.amo...@ptfs-europe.com When implementing backends for ILL it would sometimes be helfpul if we could link to the request in the external system or portal. The backends could create/fill this link. If set, it should display in the request detail page in the ILL module. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 --- Comment #91 from Nick Clemens --- (In reply to Katrin Fischer from comment #79) > Testing here again... back and forth we go! Heh, tested as well, Katrin beat me by about 5 minutes, but adding my support too :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13125] Total holds does not tally holds / items.reserves is not populated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13125 Axelle Aix-Marseille Université changed: What|Removed |Added CC|axelle.clari...@univ-amu.fr | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32271] Overdue fines cap (amount) set to 0.00 when editing rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32271 --- Comment #15 from Katrin Fischer --- It would be great to get more eyes on this one. We are now nearly there with bug 33028 and I think this is the missing piece to get us back on track again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34094] Apply DefaultPatronSearchMethod to all patron search forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34094 --- Comment #16 from Martin Renvoize --- Created attachment 153324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153324=edit Bug 34094: (follow-up) Fix failing unit test The unit tests were written to assume we always do a 'contains' search, but the new system preference allows for 'starts_with' or 'contains'. As such, for the tests to pass, we need to explicitly mock the preference to 'contains' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 --- Comment #90 from Katrin Fischer --- Created attachment 153323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153323=edit Bug 33028: Perltidy database update script Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 Katrin Fischer changed: What|Removed |Added Attachment #152936|0 |1 is obsolete|| --- Comment #89 from Katrin Fischer --- Created attachment 153322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153322=edit Bug 33028: Throw exception if not passed a decimal number Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 Katrin Fischer changed: What|Removed |Added Attachment #152935|0 |1 is obsolete|| --- Comment #88 from Katrin Fischer --- Created attachment 153321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153321=edit Bug 33028: (follow-up) Apply unformat_price to decimal fields Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 Katrin Fischer changed: What|Removed |Added Attachment #152934|0 |1 is obsolete|| --- Comment #87 from Katrin Fischer --- Created attachment 153320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153320=edit Bug 33028: (follow-up) Add unformat_price js function Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 Katrin Fischer changed: What|Removed |Added Attachment #152933|0 |1 is obsolete|| --- Comment #86 from Katrin Fischer --- Created attachment 153319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153319=edit Bug 33028: (follow-up) Rewrite database update This rewrite the database update with some things in mind: * We now use a positive value list of allowed characters to check This makes sure that all of those are recognized: 1,00 1.00€ abc * Instead of dying after finding one wrong value, we loop through all values first, building up an error string * When we have errors... we die and print the full list of things that need fixing. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 Katrin Fischer changed: What|Removed |Added Attachment #152932|0 |1 is obsolete|| --- Comment #85 from Katrin Fischer --- Created attachment 153318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153318=edit Bug 33028: Add TT filters for Price and pattern checks to input fields With this patch, all monetary values in the table will be displayed formatted. Also, the input will be checked against our agreed pattern to make sure no false values can be entered. Missing: When editing a rule, we need to unformat the value, so that instead of the display format we have the input format available for editing. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 Katrin Fischer changed: What|Removed |Added Attachment #152931|0 |1 is obsolete|| --- Comment #84 from Katrin Fischer --- Created attachment 153317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153317=edit Bug 33028: Add is_monetary to recall_overdue_fine and article_request_fee This patch marks the 2 missing monetary values for recal over due fines and article request fees as monetary. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 Katrin Fischer changed: What|Removed |Added Attachment #152930|0 |1 is obsolete|| --- Comment #83 from Katrin Fischer --- Created attachment 153316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153316=edit Bug 33028: (follow-up) Fix trailing 0 decimals We want to recognise the truthyness of a number vs string so we drop trailing decimals if they're just 0. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 Katrin Fischer changed: What|Removed |Added Attachment #152929|0 |1 is obsolete|| --- Comment #82 from Katrin Fischer --- Created attachment 153315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153315=edit Bug 33028: (follow-up) Move monetary definition into hash This patch moves the defintion of monetary rule type into the rule kinds hash. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 Katrin Fischer changed: What|Removed |Added Attachment #153313|0 |1 is obsolete|| --- Comment #81 from Katrin Fischer --- Created attachment 153314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153314=edit Bug 33028: Fix calculations around cronjob fines.pl When currency format is set on FR commas are decimals separators but when cron like fines.pl try to calculate fines it's fails due to this format. I changed this behavior by targetted 'fine' and 'overduefinescap' in circulation_rules.rule_name to unformat them when we save them. This also fix the display in smart_rules table (before with commas price was not good displayed - without decimals) Test Plan : 1) Set your currency format on 'FR' and 'fine' OR/AND 'overduefinescap' with commas 2) Be sure to have some patron overdues 3) Run ~/misc/cronjobs/fines.pl with args to find overdues 4) See an error like 'isn't numeric in substraction[..] or gt > [...]' 5) Run updatedatabase script (it will replace commas in your rules changed in step 1) ) 6) Repeat step 3 and see that everything was going "fine" (:tada:) Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 Katrin Fischer changed: What|Removed |Added Attachment #152928|0 |1 is obsolete|| --- Comment #80 from Katrin Fischer --- Created attachment 153313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153313=edit Bug 33028: Fix calculations around cronjob fines.pl When currency format is set on FR commas are decimals separators but when cron like fines.pl try to calculate fines it's fails due to this format. I changed this behavior by targetted 'fine' and 'overduefinescap' in circulation_rules.rule_name to unformat them when we save them. This also fix the display in smart_rules table (before with commas price was not good displayed - without decimals) Test Plan : 1) Set your currency format on 'FR' and 'fine' OR/AND 'overduefinescap' with commas 2) Be sure to have some patron overdues 3) Run ~/misc/cronjobs/fines.pl with args to find overdues 4) See an error like 'isn't numeric in substraction[..] or gt > [...]' 5) Run updatedatabase script (it will replace commas in your rules changed in step 1) ) 6) Repeat step 3 and see that everything was going "fine" (:tada:) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33105] Add vendor issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 --- Comment #62 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #61) > (In reply to Jonathan Druart from comment #60) > > (In reply to Tomás Cohen Arazi from comment #59) > > > Not going to block this, but we added the 'OPAC concerns' and now the > > > 'vendor issues'. Should we think of a more generic approach? > > > > Hum I don't think so, they are two completely different things. One is > > linked with the acquisition module for external entities, OPAC concerns is > > for OPAC users. I don't see how we could merge them. > > Besides the UI differences, I see 'ticket type X' and 'ticket type Y'. I had > the same concerns about the 'OPAC record concerns ' feature as being too > specific by design. The table name was not specific: "tickets" :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16436] Allow action logs to be logged to the koha log file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16436 Kyle M Hall changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20956 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20956] BorrowersLog is not logging permission changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956 Kyle M Hall changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16436 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 --- Comment #79 from Katrin Fischer --- Testing here again... back and forth we go! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33105] Add vendor issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 --- Comment #61 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #60) > (In reply to Tomás Cohen Arazi from comment #59) > > Not going to block this, but we added the 'OPAC concerns' and now the > > 'vendor issues'. Should we think of a more generic approach? > > Hum I don't think so, they are two completely different things. One is > linked with the acquisition module for external entities, OPAC concerns is > for OPAC users. I don't see how we could merge them. Besides the UI differences, I see 'ticket type X' and 'ticket type Y'. I had the same concerns about the 'OPAC record concerns ' feature as being too specific by design. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33105] Add vendor issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 --- Comment #60 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #59) > Not going to block this, but we added the 'OPAC concerns' and now the > 'vendor issues'. Should we think of a more generic approach? Hum I don't think so, they are two completely different things. One is linked with the acquisition module for external entities, OPAC concerns is for OPAC users. I don't see how we could merge them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34251] New: Marc editor throws error when using fast add framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34251 Bug ID: 34251 Summary: Marc editor throws error when using fast add framework Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: bibliot...@th-wildau.de QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl When using the fast add framework in addbiblio.pl there is thrown a JS error in selectTab( "#tab0XX_panel" ); This is because no nav tabs are build in addbiblio.tt as BIG_LOOP has a length(size) of 1 To test: 1) go to More>Cataloging 2) click +New record 3) Click Settings> Fast add framework 4) take a look on console 5) try selecting a different framework now, -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34169] Add pattern check for monetary fields to acquisition module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169
--- Comment #2 from Katrin Fischer ---
I tried to write a POC using jQuery starting with the normal acq order form:
$("#acq_neworderempty #unitprice").attr({inputmode: "decimal", pattern:
"^\d+(\.\d{2})?$" });
It didn't work there, because we use the validate JS plugin.
But we could maybe use that to our advantage. With Joubu's help:
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
index 42f537a5924..7f0be4c0af2 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
@@ -669,7 +669,7 @@
Actual cost:
-
+
[% IF (invoiceincgst == 1) %](tax inc.)[% ELSE %](tax exc.)[%
END %]
diff --git a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js
b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js
index 74af1ad89ae..aeab2be8667 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js
+++ b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js
@@ -110,6 +110,9 @@ $(document).ready(function() {
$(".validated").each(function() {
$(this).validate();
});
+jQuery.validator.addClassRules("price", {
+number: true
+});
$("#logout").on("click",function(){
logOut();
* It allows to add negative and positive amounts with decimal dot. This is OK
as we do need the ability to add negatives in acquisitions.
* It does allow entering thousand separators with a ., but Koha hates it and
won't save the value:
check_budget_total.pl:
XML Parsing Error: syntax error
Location:
http://localhost:8081/cgi-bin/koha/acqui/check_budget_total.pl?budget_id=2=21.60
Line Number 1, Column 1:
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33105] Add vendor issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 --- Comment #59 from Tomás Cohen Arazi --- Not going to block this, but we added the 'OPAC concerns' and now the 'vendor issues'. Should we think of a more generic approach? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
