[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 --- Comment #15 from Emmi Takkinen --- (In reply to Katrin Fischer from comment #14) > (In reply to Emmi Takkinen from comment #13) > > We don't probably have to do anything to past dates, since they aren't > > displayed at all. If I set reserves.expirationdate in past (or current date) > > through database, expiration date field is blank. Is this intentional? > > Hm, I have been wondering what we show in the GUI but didn't check. > > It might all be a bit 'history' there. In the past there was only one field > in the database used for both the "don't need after x" and "pick-up before". > That lead to a couple of issues. > > Later we divided the fields in the database (yay!), but maybe we don't show > both in the GUI? Technically we don't show them both, we show value in reserves.expirationdate. But if reserves.patron_expiration_date is filled, it is copied to reserves.expirationdate (not only with these patches but by default). But this doesn't seem to be the problem here. In GUI it seems that expiration field doesn't display date in past, including if value is current date. They are in database however. There's probably some sort of jQuery (flatpicker maybe) affecting this. I was wondering should we should also show dates in past and display them with visual hind or does the field behave this way on purpose? I was also wondering if we "fix" this, should it be done in another bug? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35211] Make it possible to add new tab to record’s detail page catalogue/detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 --- Comment #1 from Kati Sillgren --- Tab is shown automatically according to the library where Koha-user is logged in, and library is included to the library group (search group). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32256] Self checkout batch mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256 --- Comment #13 from Aleisha Amohia --- (In reply to David Nind from comment #9) > (In reply to Aleisha Amohia from comment #7) > > (In reply to David Nind from comment #6) > ... > > > > You're completely right, and actually that's what we wrote in the patch so > > maybe the test plan is misleading... > > > > "The items in the batch will still be handled one-by-one, so if any item in > > the batch requires confirmation (i.e. to be renewed or returned) or is > > impossible to check out, the process will stop at that item. Any items > > earlier in the list will be processed, but any items coming after in the > > list will be ignored." > > > > Do we think this is acceptable? > > Thanks Aleisha - I didn't properly read the description in the test plan! > > I guess the main thing is knowing that this will happen. Having more > advanced error messaging could be handled in a separate bug, if required. > > Adding this as a note in the documentation will help as well. > > The patch still applies, so I will sign off as it currently is, as it is > working as planned. > > David Thanks David. I added the follow-up you suggested to say it only works for multiple checkouts, and agree with your other comments. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32256] Self checkout batch mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256 --- Comment #12 from Aleisha Amohia --- Created attachment 158586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158586=edit Bug 32256: Add message to SCO that batch checkouts works for checkouts only Not yet handling renewals, returns, or items that are impossible to check out. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32256] Self checkout batch mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256 David Nind changed: What|Removed |Added Text to go in the||This new feature allows release notes||more than one item to be ||scanned and processed at ||once in Koha's ||self-checkout module. This ||feature uses the existing ||BatchCheckouts and ||BatchCheckoutsValidCategori ||es system preferences to ||determine if batch ||checkouts should be ||allowed. || ||NOTE: The items ||in the batch are handled ||one-by-one, so if any item ||in the batch requires ||confirmation (for example, ||to be renewed or returned) ||or is impossible to check ||out, the process will stop ||at that item. Any items ||earlier in the list will be ||processed, but any items ||coming after in the list ||will be ignored. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32256] Self checkout batch mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256 David Nind changed: What|Removed |Added Attachment #154893|0 |1 is obsolete|| --- Comment #11 from David Nind --- Created attachment 158585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158585=edit Bug 32256: Enable batch checkout using self-checkout This patch allows more than one item to be scanned and processed at once in Koha's self-checkout module. The items in the batch will still be handled one-by-one, so if any item in the batch requires confirmation (i.e. to be renewed or returned) or is impossible to check out, the process will stop at that item. Any items earlier in the list will be processed, but any items coming after in the list will be ignored. This feature uses the existing BatchCheckouts and BatchCheckoutsValidCategories system preferences to determine if batch checkouts should be allowed. To test: 1) Open the staff interface. Go to Koha Administration -> Global system preferences. Search for "BatchCheckouts". Confirm BatchCheckouts syspref is disabled, and no categories are selected for the BatchCheckoutsValidCategories syspref. 2) In another tab, open the OPAC self checkout (found out OPACBaseURL/cgi-bin/koha/sco/sco-main.pl) and log in 3) Confirm the self-checkout works as normal for checking out, returning or renewing one item at a time 4) Go back to the staff interface tab (you may need to log back in). Enable the BatchCheckouts syspref but leave the BatchCheckoutsValidCategories syspref empty. 5) Refresh the OPAC self checkout tab. The barcode input field will now be bigger to support a list of barcodes. Enter a list of barcodes separated by newlines and Submit. 6) Only the first barcode should be processed. This is because no categories are valid for BatchCheckouts. 7) Go back to the staff interface tab (you may need to log back in). Select at least your patron category for the BatchCheckoutsValidCategories syspref and Save. 8) Refresh the OPAC self checkout tab. Enter a list of barcodes separated by newlines and Submit. Confirm all valid items are checked out as expected. 9) Test with a few items that are notforloan or would not be valid checkouts. Confirm they are not checked out, but other valid items in the batch are checked out successfully. 10) Test with a batch where one of the items is already checked out to the patron. The batch should get blocked at this item as the self-checkout asks for confirmation. 11) Test with both renewing and returning of items that are already checked out to the patron. This will only work with one item at a time and later items in the list will be ignored. Sponsored-by: Koha-US Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32256] Self checkout batch mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256 David Nind changed: What|Removed |Added Status|ASSIGNED|Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 --- Comment #53 from David Cook --- Despite my efforts to save these patches just now... it's probably best to mark this as RESOLVED WISHLIST. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26791] Build Mojolicious controller replacement for export.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 David Cook changed: What|Removed |Added Resolution|--- |WISHLIST Status|NEW |RESOLVED --- Comment #26 from David Cook --- The patches are outdated and realistically we're not moving in this direction anyway. It's probably more realistic to handle this as a background task. It would allow the web app to be more available. The only downside is that it will take up disk space. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28325] Build Mojolicious controller replacement for tools-home.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28325 David Cook changed: What|Removed |Added Resolution|--- |WISHLIST Status|NEW |RESOLVED --- Comment #7 from David Cook --- The patch is outdated and realistically we're not moving in this direction anyway -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32256] Self checkout batch mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256 --- Comment #10 from David Nind --- (In reply to Dave from comment #8) > I have not tested as I'm having an issue with adding the bug patch to my > test server at the moment (I'm a rookie still LOL.) One way to test is to use the sandboxes (this bug can be tested in the sandboxes) - basically a fresh Koha environment that you can apply the bug with in your browser: https://wiki.koha-community.org/wiki/Sandboxes A more advanced way is to set up the testing environment on your desktop (which is what I normally use) https://gitlab.com/koha-community/koha-testing-docker (feel free to ask on IRC or the development list if you want to use it, but have issues setting it up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 --- Comment #52 from David Cook --- Since writing this plugin, I've done more work on plugins, and maybe it's not a good idea. I mean the framework for using Mojolicious is still good but maybe not the stuff for plugins... For instance, opac/opac-account-pay-return.pl calls the "opac_online_payment_end" and passes a CGI object as the controller. There's no way of really making that a Mojolicious controller. So this would really only work for "report" and "tool" plugins. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 David Cook changed: What|Removed |Added Text to go in the|This change allows Koha |This change allows Koha release notes|plugins that return a true |plugins that return a true |value from the |value from the |"use_mojolicious" method to |"use_mojolicious" method to |be run as Mojolicious |be run as Mojolicious |controllers rather than CGI |controllers rather than CGI |script controllers. |script controllers. | | |This|This |change also sets up a |change also sets up a |framework for using writing |framework for writing new |new Koha functionality |Koha functionality using |using Mojolicious |Mojolicious controllers. |controllers.| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32256] Self checkout batch mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256 --- Comment #9 from David Nind --- (In reply to Aleisha Amohia from comment #7) > (In reply to David Nind from comment #6) ... > > You're completely right, and actually that's what we wrote in the patch so > maybe the test plan is misleading... > > "The items in the batch will still be handled one-by-one, so if any item in > the batch requires confirmation (i.e. to be renewed or returned) or is > impossible to check out, the process will stop at that item. Any items > earlier in the list will be processed, but any items coming after in the > list will be ignored." > > Do we think this is acceptable? Thanks Aleisha - I didn't properly read the description in the test plan! I guess the main thing is knowing that this will happen. Having more advanced error messaging could be handled in a separate bug, if required. Adding this as a note in the documentation will help as well. The patch still applies, so I will sign off as it currently is, as it is working as planned. David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 David Cook changed: What|Removed |Added Text to go in the||This change allows Koha release notes||plugins that return a true ||value from the ||"use_mojolicious" method to ||be run as Mojolicious ||controllers rather than CGI ||script controllers. || ||This ||change also sets up a ||framework for using writing ||new Koha functionality ||using Mojolicious ||controllers. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 David Cook changed: What|Removed |Added Attachment #144970|0 |1 is obsolete|| --- Comment #51 from David Cook --- Created attachment 158584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158584=edit Bug 31380: Add plugin hook for choosing Mojolicious or CGI script controller This change checks for a "use_mojolicious" method in the plugin in order to determine whether it should use a Mojolicious controller or a CGI script controller. Note that the check is for the existence of the method, so it is backwards compatible with all existing Koha Plugins. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 David Cook changed: What|Removed |Added Attachment #144969|0 |1 is obsolete|| --- Comment #50 from David Cook --- Created attachment 158583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158583=edit Bug 31380: Allow Koha Plugins to run using Mojolicious controllers This patch adds a new mount point in plack.psgi, which makes Koha able to run Mojolicious controllers. For example: http://localhost:8081/cgi-bin/koha/staff/plugins/run 0a) Apply patch 0b) cp debian/templates/plack.psgi /etc/koha/sites/kohadev/plack.psgi 0c) koha-plack --restart kohadev 1) Upload Koha Plugin koha-plugin-mojolicious.kpz 2) koha-plack --restart kohadev 3) Go to http://localhost:8081/cgi-bin/koha/plugins/plugins-home.pl 4) Next to "Mojolicious Test", click "Actions", then click "Run tool" 5) Note that the web page looks perfect 6) Note that the URL is a bit different to normal: http://localhost:8081/cgi-bin/koha/staff/plugins/run?class=Koha%3A%3APlugin%3A%3AProsentient%3A%3AMojolicious=tool instead of: http://localhost:8081/cgi-bin/koha/plugins/run.pl?class=Koha%3A%3APlugin%3A%3AProsentient%3A%3AMojolicious=tool Note: The test Koha plugin will only work with a Mojolicious controller, but it could be easily made to work with both 7) Run the above test using an unauthenticated user, use a staff user without plugin permissions, try with a staff user with plugin permissions, and try with a superlibrarian 8) Run tests prove t/db_dependent/Koha/Auth.t prove t/db_dependent/Koha/Mojo/Plugins/Core.t prove t/db_dependent/Koha/Template.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 David Cook changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 --- Comment #49 from David Cook --- (In reply to David Cook from comment #48) > Something very weird is going on with the QA tools... > > I'll pull down everything again and retry koha-testing-docker but bizarre... Switching back to "master" from "master-jammy" and doing a full "docker-compose pull" seems to have fixed the problem. Hurray! Now for me to fix all the things... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32256] Self checkout batch mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256 --- Comment #8 from Dave --- I have not tested as I'm having an issue with adding the bug patch to my test server at the moment (I'm a rookie still LOL.) I think the patch is acceptable from previous comments, the workflow is as described. It will work for our needs; we do have alerts to let patrons know if a book causes an issue, so this helps with reducing unchecked items from walking out overall as well. This currently would be the best option to provide multiple item checkouts at once inside koha self-checkout natively. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 --- Comment #48 from David Cook --- Something very weird is going on with the QA tools... I'll pull down everything again and retry koha-testing-docker but bizarre... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380
--- Comment #47 from David Cook ---
Oddly without any changes I'm getting the following:
testing 2 commit(s) (applied to 00fb85d 'fc Bug 34275: Add toggle switch for
b')
Processing files before patches
|>| 10 / 10 (100.00%)
Processing files after patches
|>| 10 / 10 (100.00%)
OK Koha/Auth.pm
OK Koha/Mojo/Plugins/Core.pm
OK Koha/Mojo/Staff.pm
OK Koha/Mojo/Staff/Controller/Plugins.pm
OK Koha/Template.pm
OK koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt
OK koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
OK t/db_dependent/Koha/Auth.t
FAIL t/db_dependent/Koha/Mojo/Plugins/Core.t
FAIL file permissions
File must have the exec flag
OK t/db_dependent/Koha/Template.t
Processing additional checks OK!
Running tests (3)
* Proving /kohadevbox/koha/t/db_dependent/Koha/Template.t KO!
Cannot detect source of '/kohadevbox/koha/t/db_dependent/Koha/Template.t'! at
/usr/share/perl/5.34/TAP/Parser/IteratorFactory.pm line 256.
TAP::Parser::IteratorFactory::detect_source(TAP::Parser::IteratorFactory=HASH(0x5578694732d0),
TAP::Parser::Source=HASH(0x55786933c148)) called at
/usr/share/perl/5.34/TAP/Parser/IteratorFactory.pm line 211
TAP::Parser::IteratorFactory::make_iterator(TAP::Parser::IteratorFactory=HASH(0x5578694732d0),
TAP::Parser::Source=HASH(0x55786933c148)) called at
/usr/share/perl/5.34/TAP/Parser.pm line 472
TAP::Parser::_initialize(TAP::Parser=HASH(0x55786930d9c0),
HASH(0x5578691627f0)) called at /usr/share/perl/5.34/TAP/Object.pm line 55
TAP::Object::new("TAP::Parser", HASH(0x5578691627f0)) called at
/usr/share/perl/5.34/TAP/Object.pm line 130
TAP::Object::_construct(TAP::Harness=HASH(0x557868bfdc48),
"TAP::Parser", HASH(0x5578691627f0)) called at
/usr/share/perl/5.34/TAP/Harness.pm line 856
TAP::Harness::make_parser(TAP::Harness=HASH(0x557868bfdc48),
TAP::Parser::Scheduler::Job=HASH(0x55786930d738)) called at
/usr/share/perl/5.34/TAP/Harness.pm line 655
TAP::Harness::_aggregate_single(TAP::Harness=HASH(0x557868bfdc48),
TAP::Parser::Aggregator=HASH(0x557868bfd858),
TAP::Parser::Scheduler=HASH(0x55786930d708)) called at
/usr/share/perl/5.34/TAP/Harness.pm line 747
TAP::Harness::aggregate_tests(TAP::Harness=HASH(0x557868bfdc48),
TAP::Parser::Aggregator=HASH(0x557868bfd858),
"/kohadevbox/koha/t/db_dependent/Koha/Template.t") called at
/usr/share/perl/5.34/TAP/Harness.pm line 558
TAP::Harness::__ANON__() called at /usr/share/perl/5.34/TAP/Harness.pm
line 571
TAP::Harness::runtests(TAP::Harness=HASH(0x557868bfdc48),
"/kohadevbox/koha/t/db_dependent/Koha/Template.t") called at
/usr/share/perl/5.34/App/Prove.pm line 548
App::Prove::_runtests(App::Prove=HASH(0x557868bca518),
HASH(0x55786903ce78), "/kohadevbox/koha/t/db_dependent/Koha/Template.t") called
at /usr/share/perl/5.34/App/Prove.pm line 506
App::Prove::run(App::Prove=HASH(0x557868bca518)) called at
/usr/bin/prove line 13
* Proving /kohadevbox/koha/t/db_dependent/Koha/Mojo/Plugins/Core.t KO!
Can't locate Koha/Auth.pm in @INC (you may need to install the Koha::Auth
module) (@INC contains: /kohadevbox/koha /kohadevbox/koha/lib
/kohadevbox/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.34.0
/usr/local/share/perl
/5.34.0 /usr/lib/x86_64-linux-gnu/perl5/5.34 /usr/share/perl5
/usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.34
/usr/share/perl/5.34 /usr/local/lib/site_perl /var/lib/koha/kohadev/plugins) at
/kohadevbox/koha/Koha/M
ojo/Plugins/Core.pm line 22.
BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Mojo/Plugins/Core.pm
line 22.
Compilation failed in require at (eval 1958) line 1.
# Looks like your test exited with 255 before it could output anything.
/kohadevbox/koha/t/db_dependent/Koha/Mojo/Plugins/Core.t ..
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 2/2 subtests
Test Summary Report
---
/kohadevbox/koha/t/db_dependent/Koha/Mojo/Plugins/Core.t (Wstat: 65280 Tests: 0
Failed: 0)
Non-zero exit status: 255
Parse errors: Bad plan. You planned 2 tests but ran 0.
Files=1, Tests=0, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.45 cusr 0.09
csys = 1.56 CPU)
Result: FAIL
* Proving /kohadevbox/koha/t/db_dependent/Koha/Auth.t KO!
Cannot detect source of '/kohadevbox/koha/t/db_dependent/Koha/Auth.t'! at
/usr/share/perl/5.34/TAP/Parser/IteratorFactory.pm line 256.
TAP::Parser::IteratorFactory::detect_source(TAP::Parser::IteratorFactory=HASH(0x55631048f6e0),
TAP::Parser::Source=HASH(0x5563103585e8)) called at
/usr/share/perl/5.34/TAP/Parser/IteratorFactory.pm line 211
TAP::Parser::IteratorFactory::make_iterator(TAP::Parser::IteratorFactory=HASH(0x55631048f6e0),
TAP::Parser::Source=HASH(0x5563103585e8)) called at
[Koha-bugs] [Bug 35265] Remove drag and drop in Elasticsearch mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 David Nind changed: What|Removed |Added CC||da...@davidnind.com Text to go in the||This removes the ability to release notes||drag and drop the order of ||the bibliographic and ||authorities search fields ||(Administration > Catalog > ||Search engine configuration ||(Elasticsearch)). This was ||removed as it feature has ||no effect on the search ||results when using ||Elasticsearch or OpenSearch ||as the search engine. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31199] selenium/patrons_search.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31199 --- Comment #14 from David Cook --- I've started tracking the loop iterations inside "wait_for_ajax" and sometimes it will finish within a few seconds and sometimes it takes longer with 10 re-attempts or 10 seconds being where it times out and fails. 5 seconds seems to be fairly common on my machine. I've cranked the max retries up to 20 from 10 and now I'm not getting failures when a search takes 12 seconds instead of 5 seconds. Of course, it's not clear why sometimes it takes 12 seconds instead of 5 seconds. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18827] Elasticsearch mappings - not displayed or retrieved in saved order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18827 David Nind changed: What|Removed |Added CC||da...@davidnind.com Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #8 from David Nind --- I think so, from reading the comments. Ability to drag and drop being removed in bug 35265. Feel to change status if you disagree! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35265] Remove drag and drop in Elasticsearch mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 David Nind changed: What|Removed |Added Attachment #158493|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 158582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158582=edit Bug 35265: Remove drag and drop in Elasticsearch mappings Bug 18827 says ordering search fields in Elasticsearch mappings is useless. This patch removes it. Test plan : 1) Enable Elasticsearch 2) Go to Administration > Search engine configuration (Elasticsearch) 3) Go to tab 'Bibliographic records' 4) Check there is no Javscript error 5) Check you can't drag and drop lines anymore Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35265] Remove drag and drop in Elasticsearch mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28639] Embed see-from headings (from authorities) into bibliographic records at OAI repository level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||lu...@bywatersolutions.com --- Comment #14 from Lucas Gass --- This no longer applies cleanly to current master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34021] Add option to search within results in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 Lucas Gass changed: What|Removed |Added Attachment #158166|0 |1 is obsolete|| --- Comment #13 from Lucas Gass --- Created attachment 158581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158581=edit Bug 34021: Make search within OPAC consistent with staff interface Test plan: 0. Apply the patch 1. Go to http://localhost:8080/cgi-bin/koha/opac-main.pl 2. Type "an:104" in the search box and click the search button 3. Type "Alcestis" into the "Search within results" box and click the Search button next to the box 4. Note that now there are only 2 results 5. Type "Dale" into the "Search within results" box and click the Search button next to the box 6. Note that you're taken directly to the last result Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34021] Add option to search within results in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 Lucas Gass changed: What|Removed |Added Attachment #158138|0 |1 is obsolete|| --- Comment #12 from Lucas Gass --- Created attachment 158580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158580=edit Bug 34021: wrap search within using block with an ID for styling Signed-off-by: Katrin Fischer Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34021] Add option to search within results in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 Lucas Gass changed: What|Removed |Added Attachment #158137|0 |1 is obsolete|| --- Comment #11 from Lucas Gass --- Created attachment 158579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158579=edit Bug 34021: Add 'search within' to OPAC This change adds a "Search within results" box to the OPAC, which complements the feature already in the staff interface. Test plan: 0. Apply the patch 1. Go to http://localhost:8080/cgi-bin/koha/opac-main.pl 2. Type "e" in the search box and click the search button 3. Click the "Books" value for the "Item types" facet, and note there are fewer search results 4. Type "test" into the "Search within results" box and click the Search button next to the box 5. Note that now there are only 2 results. 6. Also note that the "Books" facet is still selected Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34021] Add option to search within results in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35197] Expose additional fields through REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35197 Lucas Gass changed: What|Removed |Added Attachment #158515|0 |1 is obsolete|| --- Comment #8 from Lucas Gass --- Created attachment 158578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158578=edit Bug 35197: Add tests prove t/db_dependent/api/v1/additional_fields.t Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35197] Expose additional fields through REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35197 Lucas Gass changed: What|Removed |Added Attachment #158514|0 |1 is obsolete|| --- Comment #7 from Lucas Gass --- Created attachment 158577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158577=edit Bug 35197: Add additional_fields REST API endpoint Test plan: 1) Apply patch, restart plack 'koha-plack --restart kohadev' 2) Visit /api/v1/additional_fields?tablename=aqinvoices - Notice its empty 3) Visit /cgi-bin/koha/admin/additional-fields.pl?tablename=aqbasket and add a new additional field 4) Do step 2) again - Notice the newly created additional field is there 5) Visit /cgi-bin/koha/admin/additional-fields.pl?tablename=aqinvoices and add a new additional field for invoices 6) Do step 2) again - Notice both additional fields are there 7) Visit /api/v1/additional_fields?tablename=aqinvoices - Notice only the additional field for aqinvoices is listed Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35197] Expose additional fields through REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35197 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML renders differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 --- Comment #8 from Lucas Gass --- This looks good and I am tempted to sign-off but the dependency is currently 'Failed QA'. Maybe we should sort that one out and then get this one done on top of Bug 34704? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31199] selenium/patrons_search.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31199 --- Comment #13 from David Cook --- Another "reset_all" and successful once. Tried again and failed again at another different spot: ok 23 - Refining with DataTables search works to further filter the original query # Looks like you planned 26 tests but ran 23. not ok 1 - Search patrons # Failed test 'Search patrons' # at ./t/db_dependent/selenium/patrons_search.t line 401. Cannot wait more for jQuery to be active (wait_for_ajax) at /kohadevbox/koha/t/lib/Selenium.pm line 206. # Looks like your test exited with 255 just after 1. WARNING: Cleanup failed! Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/1 subtests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31199] selenium/patrons_search.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31199 --- Comment #12 from David Cook --- I ran a "reset_all" and now "prove -v ./t/db_dependent/selenium/patrons_search.t" returns "All tests successful" twice. On the third try it failed again although slightly later this time: ok 25 - remember_search # Subtest: filter by date of birth 1..7 ok 1 - search by correct year shows the patron ok 2 - search by incorrect year does not show the patron ok 3 - search by correct year-month shows the patron ok 4 - search by correct full iso date shows the patron ok 5 - search by incorrect full iso date does not show the patron # Looks like you planned 7 tests but ran 5. not ok 26 - filter by date of birth # Failed test 'filter by date of birth' # at ./t/db_dependent/selenium/patrons_search.t line 392. # Looks like you failed 1 test of 26. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 --- Comment #9 from David Cook --- (In reply to Lucas Gass from comment #7) > I have a few follow-up questions: > > 1. Should a default value of noindex, nofollow be used here? > > 2. Is freetext the right thing to use here? Using conflicting or > inconsistent values can confuse search engine crawlers and cause them to > make incorrect assumptions about how to treat your pages in their index. Good questions... With Google is looks like there are quite a few valid rules: https://developers.google.com/search/docs/crawling-indexing/robots-meta-tag#directives But then free-text is error prone as Lucas says... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34149] Syndetics cover images don't load in staff interface detail page if other images services are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34149 Lucas Gass changed: What|Removed |Added CC||p...@interleaf.ie --- Comment #16 from Lucas Gass --- *** Bug 33959 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33959] Problem displaying Syndetics cover images in staff searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33959 Lucas Gass changed: What|Removed |Added Status|NEW |RESOLVED CC||lu...@bywatersolutions.com Resolution|--- |DUPLICATE --- Comment #1 from Lucas Gass --- *** This bug has been marked as a duplicate of bug 34149 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27309] Add plugin hooks for capturing raw passwords (NNPDB)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27309 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #6 from Lucas Gass --- Do we need unit tests for this change? Also, the commit title needs amended: Processing additional checks * Commit title does not start with 'Bug X: ' - 82ca5ad8aef -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #8 from Lucas Gass --- Failing QA here until my questions are addressed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31199] selenium/patrons_search.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31199 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #11 from David Cook --- I'm just looking at t/lib/Selenium.pm and it looks like the message in "wait_for_ajax" is a bit misleading. The "die" message should probably say something more like "Cannot wait more for jQuery to be ready - jQuery still has active AJAX requests (wait_for_ajax)" -- Well the sort of good news is that I've run "prove -v ./t/db_dependent/selenium/patrons_search.t" again and it failed for me this time. It didn't fail yesterday. ok 24 - Refining with header filters works to further filter the original query # Subtest: remember_search 1..7 ok 1 - Patrons selected is not displayed ok 2 - One patron selected ok 3 - Two patrons are selected ok 4 - Three patrons are selected ok 5 - Three patrons still selected ok 6 ok 7 ok 25 - remember_search # Subtest: filter by date of birth 1..7 ok 1 - search by correct year shows the patron # Looks like you planned 7 tests but ran 1. not ok 26 - filter by date of birth # Failed test 'filter by date of birth' # at ./t/db_dependent/selenium/patrons_search.t line 392. # Looks like you failed 1 test of 26. not ok 1 - Search patrons # Failed test 'Search patrons' # at ./t/db_dependent/selenium/patrons_search.t line 401. Cannot wait more for jQuery to be active (wait_for_ajax) at /kohadevbox/koha/t/lib/Selenium.pm line 206. # Looks like your test exited with 255 just after 1. WARNING: Cleanup failed! Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/1 subtests Test Summary Report --- ./t/db_dependent/selenium/patrons_search.t (Wstat: 65280 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 255 Files=1, Tests=1, 50 wallclock secs ( 0.02 usr 0.02 sys + 4.80 cusr 1.20 csys = 6.04 CPU) Result: FAIL Yikes when it fails you have to do a "reset_all" it seems... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35273] When editing items on receive, aqorders_items is not updated correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 Katrin Fischer changed: What|Removed |Added CC||n...@bywatersolutions.com, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35273] When editing items on receive, aqorders_items is not updated correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 --- Comment #1 from Katrin Fischer --- Note: ordernumber in aqorders.items was not updated correctly to the new ordernumber. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Katrin Fischer changed: What|Removed |Added Blocks||35273 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 [Bug 35273] When editing items on receive, aqorders_items is not updated correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21173] Add hours as age unit to auto item modifications by age for damaged_on, itemlost_on and withdrawn_on fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #36 from Alex Buckley --- Thanks Katrin and Owen! Great suggestions, I am just trying them out in those follow-ups. This isn't ready to testing yet, I'll change the status when it is :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35273] New: When editing items on receive, aqorders_items is not updated correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 Bug ID: 35273 Summary: When editing items on receive, aqorders_items is not updated correctly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Depends on: 8179 I see something strange there: * Create a basket with creating items on order * Create an order line with 3 items * Close basked * Receive shipment * Edit first item displayed, add barcode * Check checkbox and receive * Verify the order line has been split 2:1 * Receive again - notice all 3 items are showing. It should only be the remaining 2. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 [Bug 8179] Receiving multiple order lines at once -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35266] opac-MARCdetail: Can't call method "metadata" on an undefined value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35266 David Nind changed: What|Removed |Added Text to go in the||This fixes the display of release notes||the MARC view page when a ||record does not exist - it ||now redirects to the 404 ||(page not found) page. ||Previously, it generated an ||error trace, where the ||normal and ISBD view pages ||redirected to the 404 (page ||not found) page. CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35266] opac-MARCdetail: Can't call method "metadata" on an undefined value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35266 David Nind changed: What|Removed |Added Attachment #158518|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 158576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158576=edit Bug 35266: Fix biblio check in opac-MARCdetail We should check before retrieving metadata. Test plan; Try /cgi-bin/koha/opac-MARCdetail?biblionumber=X Replace X by a not-existing biblionumber. Verify that you get a 404 error page. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35266] opac-MARCdetail: Can't call method "metadata" on an undefined value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35266 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35244] AcqItemSetSubfieldsWhenReceived not working after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35244 --- Comment #1 from Katrin Fischer --- I could not test in 23.05 yet, but on the current development version this appears to work ok: * AcqItemSetSubfieldsWhenReceiptIsCancelled: 7=-1 * AcqItemSetSubfieldsWhenReceived: 7=1 When received NFL switched to 1 = Not for loan. When receive was undone, NFL switched to -1 = 0n Order. So this appeared to work right. Can you share your mappings maybe? A step by step? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21173] Add hours as age unit to auto item modifications by age for damaged_on, itemlost_on and withdrawn_on fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #35 from Alex Buckley --- Created attachment 158575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158575=edit Bug 21173: (follow-up) Re-ordering input fields in item modification by age form Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21173] Add hours as age unit to auto item modifications by age for damaged_on, itemlost_on and withdrawn_on fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 --- Comment #34 from Alex Buckley --- Created attachment 158574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158574=edit Bug 21173: (follow-up) Perltidy Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29074] DefaultHoldExpirationdatePeriod blank value interpreted as zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29074 Katrin Fischer changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com --- Comment #15 from Katrin Fischer --- Calling for reinforcements to hopefully get another review/opinion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32508] Translation gives incorrect menu text in system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32508 Katrin Fischer changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- (In reply to Elaine Bradtke from comment #2) > It was nearly a year ago and we try to keep up with the latest updates, so I > can't give more specific version info. After reporting the problem, I > switched us to the default version of English because it was such a mess. > Now, on 23.05.04 British English seems to be working just fine. Thanks for the feedback! It looks like this was fixed and might have been a problem in a specific version only. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35260] Review batch checkout page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35260 Katrin Fischer changed: What|Removed |Added Attachment #158539|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 158573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158573=edit Bug 35260: Revise structure of the batch checkout page This patch makes some changes to the style and structure of the batch checkout page in order to make it more usable. To test, apply the patch and rebuild the staff interface CSS. Clear your browser cache if necessary. - Make sure the BatchCheckouts preference is enabled and that the BatchCheckoutsValidCategories has some categories selected. - Locate a patron and open the batch checkout page. - Test the process of checking out to the patron both by entering barcodes into the textarea and by uploading a file. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35260] Review batch checkout page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35260 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35260] Review batch checkout page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35260 --- Comment #2 from Katrin Fischer --- This is much nicer, thanks Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34784] Add ability to populate empty item call numbers for a record based on the itemcallnumber system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784 Katrin Fischer changed: What|Removed |Added Summary|Add ability to populate |Add ability to populate |empty item callnumbers for |empty item call numbers for |a record based on the |a record based on the |itemcallnumber system |itemcallnumber system |preferences |preference |sss | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber system preferencessssssssssssssssssssssssssssssssssssssssssss
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784 Katrin Fischer changed: What|Removed |Added Summary|Add ability to populate |Add ability to populate |empty item callnumbers for |empty item callnumbers for |a record based on the |a record based on the |itemcallnumber syspref |itemcallnumber system ||preferences ||sss -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784
--- Comment #16 from Katrin Fischer ---
(In reply to Kyle M Hall from comment #11)
> > Most of these are cosmetic and should be quick to follow-up:
> >
> > 1) Needs a follow-up to fix documentation.
> >
> > +=head3 populate_empty_callnumbers
> > +
> > +Controller function that handles deleting a biblio object
>
> Fixed!
Yes, but introducing more wrong terminology (see 2).
> > 2) Spelling
> >
> > In the item form and the holding table we are using 'call number', but the
> > patch uses 'callnumber'. I believe we should follow the GUI.
> >
> > See also: https://wiki.koha-community.org/wiki/Terminology
>
> Fixed!
Not quite, see my follow-up.
> > 3) I feel we should include the call number that would be used in the
> > confirmation question.
> >
> > if ( confirm(__('Are you sure you want to populate callnumbers for all items
> > without a callnumber on this record?')) )
>
> Wow, that was more work than I expected but I was able to make that happen!
Sorry, but I believe it's worth it! And it works nicely too.
> > 4) Please no line breaks in translatable strings!
> >
> > This is a known issue with Pootle, not sure about Weblate, but translators
> > often might not know what it is and accidentally remove it.
> >
> > msg += __('\nReload the page?');
> > let msg = __('Item populated with the callnumber "%s"\nReload the
> > page?').format(callnumber);
You did:
+msg += " " + __('Reload the page?');
You could just have done this to keep your line break:
+msg += "\n" + __('Reload the page?');
We can do line breaks, they just should not be with the translated string :)
> I think I've fixed this based on your description. We should add a coding
> guideline for this.
I thought we had one, but it might be lost in time. I fixed a ton of those
strings back in the day. This one goes in the right direction, even if it uses
HTML formatting: JS3: Avoid strings which mix text and markup
> > 4) Button in the holdings table
> >
> > The button for every single item in the holdings table takes up quite a bit
> > of space. I wonder if we could find a way to make this work a little better.
> > Maybe a split button with Edit as the main action?
> Done!
Yes, but it no longer works :(
POST
http://localhost:8081/api/v1/biblios/undefined/items/undefined/populate_empty_callnumbers
The undefined don't look good.
> >
> > 5) Button in the detail page's toolbar (not blocker)
> >
> > Why not move this into the edit menu?
>
> Done!
Yes, but it no longer works :(
POST
http://localhost:8081/api/v1/biblios/undefined/items/populate_empty_callnumbers
> >
> > 4) Maintenance script? (not blocker)
> >
> > I wonder about the use case to require such a one by one change. If you have
> > itemcallnumber set, this would only apply to items that have been created
> > before, that have been imported or otherwise added from outside of Koha.
> >
> > Are there plans for a maintenance script to do this in batch?
>
> There are no plans for a maintenance script but I'd be happy to make one on
> a followup bug report if you can provide the parameters you'd like to see!
I don't need one, I was just wondering if there was more planned around this.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784 --- Comment #15 from Katrin Fischer --- Created attachment 158572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158572=edit Bug 34784: (QA follow-up) Terminology: callnumber, biblio, syspref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784 Katrin Fischer changed: What|Removed |Added Attachment #158556|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 158571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158571=edit Bug 34784: (QA follow-up) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784 Katrin Fischer changed: What|Removed |Added Attachment #158555|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 158570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158570=edit Bug 34784: Implement feature in staff interface Some libraries would like to auto-populate item callnumbers for items on a record based on the system preference "itemcallnumber". Only items with empty callnumbers would affected. This would add a button "Populate empty item callnumbers" on catalogue/detail.pl, as well as a "Populate callnumber" button for each line in the holdings table to set the callnumber for that specific item. Test Plan: 1) Set the systempreference to something ( "245a" will make the callnumber the record title for testing purposes ) 2) Apply this patch set 3) Restart all the things! 4) Browse to a record details page, note no new buttons 5) Enable the new syspref EnablePopulateCallnumbers 5) Reload the record details, note the new "Populate callnumbers" button in the cataloging toolbar 7) Add one or more items with no callnumber to the record 8) Test the "Populate callnumbers" button 9) Add another item with no callnumber to the record 10) Test the "Populate callnumber" button for that single item Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784 Katrin Fischer changed: What|Removed |Added Attachment #158554|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 158569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158569=edit Bug 34784: Add REST API endpoints for updating single item or all applicable items on a bib Test Plan: 1) Apply this patch 2) prove t/db_dependent/api/v1/biblios.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35261] Update links for self registration avoiding "here"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35261 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #5 from Katrin Fischer --- Thank you David! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35261] Update links for self registration avoiding "here"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35261 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #4 from David Nind --- Have added my sign-off, so that Katrin can QA. The only thing I noticed is that the breadcrumb and page title are "Register a new account", and the updated text for the link is "Create an account". Not a showstopper for me though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35261] Update links for self registration avoiding "here"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35261 David Nind changed: What|Removed |Added Attachment #158550|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 158568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158568=edit Bug 35261: Update links for self registration avoiding "here" This patch updates several OPAC templates to change the wording of the self registration link to "Create an account." Minor adjustments to CSS have been made to make whitespace around the links more comfortable. To test, apply the patch and rebuild the OPAC CSS. - If necessary enable the PatronSelfRegistration system preference is enabled. - Go to the OPAC and check the login form in the right-hand sidebar. - Click the "Log in to your account" link in the header and check the form displayed in the modal window. - Navigate directly to /cgi-bin/koha/opac-user.pl and check the link on the login page. - Complete the self-registration process and check the link in the right-hand sidebar menu on the "Registration complete" page. Signed-off-by: Katrin Fischer Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35259] Highlight staff user's home library in library selection on login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35259 Katrin Fischer changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- (In reply to Lucas Gass from comment #1) > Maybe I misunderstand this but I don't know how we'd know which branch is a > patron's homebrnach prior to them logging in. No, you are completely right - that one is on me :D (just testing you all...) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35263] Cannot update patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35263 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34963] Unable to delete fields in suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34963 --- Comment #5 from Katrin Fischer --- It's all the text fields :( But I haven't been able to get developer's attention on this bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35263] Cannot update patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35263 David Nind changed: What|Removed |Added Attachment #158544|0 |1 is obsolete|| --- Comment #10 from David Nind --- Created attachment 158567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158567=edit Bug 35263: Default 'can_place_ill_in_opac' to 1 If ILLModule sys pref is 'off', this input param is undef. The database does not allow it to be nullable causing an error. Check if its defined (i.e. the option was submitted) and use that, if not default to 1 Test plan, k-t-d: 1) Edit an existing patron category, visit: /cgi-bin/koha/admin/categories.pl?op=add_form=B 2) Click 'Save' at the bottom of the form 3) Notice a yellow box is shown with an error message 4) Apply patch. Repeat steps 1-3. Notice it now updates successfully. Signed-off-by: Katrin Fischer Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35263] Cannot update patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35263 David Nind changed: What|Removed |Added Attachment #158543|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 158566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158566=edit Bug 35263: Add selenium tests Test plan, on k-t-d selenium (ktd --selenium up): 1) Apply just this tests patch 2) Run: prove t/db_dependent/selenium/administration_tasks.t 3) Notice it fails. Apply the other patch. Restart plack 4) Repeat step 2. Notice it passes. Signed-off-by: Katrin Fischer Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35263] Cannot update patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35263 --- Comment #8 from David Nind --- (In reply to David Nind from comment #5) > I was going to add my sign-off, so Katrin's could count as QA. > > However, the tests fail for me after the patch is applied - are there other > system preferences that need enabling/disabling (tested using KTD)?: > I didn't read the test plan properly - needed to start KTD with --selenium (ktd --selenium up). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34963] Unable to delete fields in suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34963 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #4 from Caroline Cyr La Rose --- I just noticed this is also true for the new non-public note... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35263] Cannot update patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35263 --- Comment #7 from Katrin Fischer --- kohadev-koha@kohadevbox:koha(71-35263-update-atron-category)$ prove t/db_dependent/selenium/administration_tasks.t t/db_dependent/selenium/administration_tasks.t .. ok All tests successful. Files=1, Tests=3, 18 wallclock secs ( 0.01 usr 0.01 sys + 1.03 cusr 0.15 csys = 1.20 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35254] Adding files to basket from a staged file uses wrong inputs for order information when not all records are selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35254 Victor Grousset/tuxayo changed: What|Removed |Added Status|Patch doesn't apply |Passed QA --- Comment #7 from Victor Grousset/tuxayo --- Works, makes sense, QA script happy, code looks good, passing QA :) --- (In reply to Katrin Fischer from comment #3) > I really wonder why we didn't stumble on this much sooner? Indeed! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35254] Adding files to basket from a staged file uses wrong inputs for order information when not all records are selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35254 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #158374|0 |1 is obsolete|| --- Comment #6 from Victor Grousset/tuxayo --- Created attachment 158565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158565=edit Bug 35254: Add import_record_id to order inputs This patch follows the logic of bug 32166 and adds specific inputs for each order to avoid any misalignment when some records are not imported To test: 1 - Find a vendor in acquisitions 2 - Create or find an open basket 3 - Add to basket form a new file 4 - Stage file and add to basket 5 - Select the second record in the list 6 - Enter price info 7 - Save (don't forget, you need to set item type in the second tab) 8 - The order has no price info! 9 - Apply patch 10 - Repeat 3-7 above, staging file fresh 11 - Confirm order has correct prices 12 - Test with a file with many records 13 - Confirm any combination of choosing/skipping records works as expected Signed-off-by: Katrin Fischer Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35263] Cannot update patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35263 --- Comment #6 from Katrin Fischer --- Hm, I just double checked, tests are passing nicely on a new database for me: OK admin/categories.pl OK t/db_dependent/selenium/administration_tasks.t Processing additional checks OK! Running tests (1) * Proving /kohadevbox/koha/t/db_dependent/selenium/administration_tasks.t OK! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35259] Highlight staff user's home library in library selection on login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35259 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #1 from Lucas Gass --- Maybe I misunderstand this but I don't know how we'd know which branch is a patron's homebrnach prior to them logging in. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27767] Number of elements in cart is not updated when records are deleted or merged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27767 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #6 from Victor Grousset/tuxayo --- Additional impact of the bug: downloading cart doesn't work (internal server error) Mitigation: Empty cart to get rid of the invalid data. Valid records can be added to a list to easily re-add them after. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17897] Koha::SearchMappingManager - Simplify search mapping modifications
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897 David Nind changed: What|Removed |Added Attachment #158492|0 |1 is obsolete|| --- Comment #33 from David Nind --- Created attachment 158564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158564=edit Bug 17897: Add search_marc_to_field.filter to SearhMappingManager Methods in SearchMappingManager didn't take into account search_marc_to_field.filter indtroduced in bug 27153. To test, prove t/db_dependent/Koha/SearchEngine/ElasticSearch.t Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17897] Koha::SearchMappingManager - Simplify search mapping modifications
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897 David Nind changed: What|Removed |Added Attachment #158491|0 |1 is obsolete|| --- Comment #32 from David Nind --- Created attachment 158563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158563=edit Bug 17897: Fix failing tests and QA issues Tests failed because 1) txn_begin and rollback were used inside of subtests. 2) column search_field.type was filled with unallowed value. This patch also fixes QA issue with test file exec rights and incorrect license statement. To test prove t/db_dependent/Koha/SearchEngine/ElasticSearch.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17897] Koha::SearchMappingManager - Simplify search mapping modifications
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897 David Nind changed: What|Removed |Added Attachment #158490|0 |1 is obsolete|| --- Comment #31 from David Nind --- Created attachment 158562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158562=edit Bug 17897: (follow-up) Cleanup after tests Adds rollback to test data in t/db_dependent/Koha/SearchEngine/ElasticSearch.t To test: 1. prove t/db_dependent/Koha/SearchEngine/ElasticSearch.t Rebased-by: Emmi Takkinen Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17897] Koha::SearchMappingManager - Simplify search mapping modifications
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897 David Nind changed: What|Removed |Added Attachment #158489|0 |1 is obsolete|| --- Comment #30 from David Nind --- Created attachment 158561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158561=edit Bug 17897: Koha::SearchMappingManager - Simplify search mapping modifications Currently there is a lot of DBIC-magic everywhere where search mappings (search_fields, search_marc_to_field, search_marc_map -tables) are CRUD:ed. Encapsulate this hard-to-read DBIC-magic into a Manager class which promotes code-reusability and thus, simpler test case writing. Includes tests for Buug 17885 Rebased-by: Emmi Takkinen Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17897] Koha::SearchMappingManager - Simplify search mapping modifications
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35263] Cannot update patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35263 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #5 from David Nind --- I was going to add my sign-off, so Katrin's could count as QA. However, the tests fail for me after the patch is applied - are there other system preferences that need enabling/disabling (tested using KTD)?: kohadev-koha@kohadevbox:koha(bz35263)$ prove t/db_dependent/selenium/administration_tasks.t t/db_dependent/selenium/administration_tasks.t .. Selenium server did not return proper status at /usr/share/perl5/Selenium/Remote/Driver.pm line 552. # Looks like your test exited with 22 before it could output anything. t/db_dependent/selenium/administration_tasks.t .. Dubious, test returned 22 (wstat 5632, 0x1600) Failed 3/3 subtests Test Summary Report --- t/db_dependent/selenium/administration_tasks.t (Wstat: 5632 Tests: 0 Failed: 0) Non-zero exit status: 22 Parse errors: Bad plan. You planned 3 tests but ran 0. Files=1, Tests=0, 1 wallclock secs ( 0.00 usr 0.01 sys + 0.82 cusr 0.14 csys = 0.97 CPU) Result: FAIL I get the same result whether ILLModule is enabled or not. The patches do fix the error when editing a patron category though... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35262] Improve OPAC self registration confirmation page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35262 Katrin Fischer changed: What|Removed |Added Attachment #158558|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 158560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158560=edit Bug 35262: Improve OPAC self registration confirmation page This patch corrects logic in the OPAC self registration confirmation template so that the right column markup is shown when various combinations of OpacNav, OpacNavBottom, and OpacNavRight are displayed. To test, apply the patch and enable the PatronSelfRegistration system preference, and deactivate the PatronSelfRegistrationVerifyByEmail preference. - Go to the OPAC and start the process of registering online. - Fill in the form and submit it. - On the registration confirmation page, check that the layout looks correct. - Test with the presence of various combinations of OpacNav, OpacNavBottom, and OpacNavRight HTML customizations. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35262] Improve OPAC self registration confirmation page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35262 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35272] New: Add padding above vendor contracts section
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35272 Bug ID: 35272 Summary: Add padding above vendor contracts section Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org This is very minor. I noticed that when a vendor has contracts, the space between the contracts section and the other sections disappeared. Here is what it looked like https://koha-community.org/manual/23.05/en/html/_images/vendorpage.png And this is what I currently have: https://snipboard.io/pTKWIA.jpg Notice how there is no more grey section between the ordering information section and the contracts section. To recreate: 1. If needed, create a vendor 1.1. Go to Acquisitions > New vendor 1.2. Fill out the form, including the contacts section 1.3. Click Save 2. Create a contract 2.1. Click New > Contract 2.2. Fill out the form 2.3. Click Save --> Notice there is no space between ordering information and contracts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34404] Inconsistencies in Budgets and funds page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34404
Katrin Fischer changed:
What|Removed |Added
Attachment #158475|0 |1
is obsolete||
--- Comment #3 from Katrin Fischer ---
Created attachment 158559
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158559=edit
Bug 34404: Fix inconsistencies in Budgets and funds page titles, breadcrumbs,
and headers
This patch fixes some inconsistencies in the budget and fund
administration templates, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.
Other changes: Bootstrap tooltips have been enabled in a few places
where the markup showed intent for the tooltips to be active but where
the JS was not being initiated.
Some translation imrovements have been added where budget planning
strings could be improved with context:
'by months' ->
'[% tp("Budget planning", "by months") | html %]'
To test, apply the patch and go to Administration -> Budgets. Test each
of these cases:
- Budgets list
- New budget
- Edit budget
- Duplicate budget
- Close budget
- Close a budget with and without unreceived orders.
- Delete budget
- Test the delete button on a budget which has funds attached to
confirm that the menu item is disabled and a tooltip shows with an
explanation.
- Delete a budget which has no funds attached.
- Add fund
- Test the add fund button on a budget which is locked. The menu
item should be disabled and it should show a tooltip, "Budget is
locked."
- Test the add fund page for a budget which is not locked.
- Click the name of a budget with funds attached to see the funds view
- In this view, if the budget is locked, the "New" toolbar menu
should have a disabled "New fund" item with a Bootstrap tooltip.
- While viewing the funds on a budget, test the "Planning" button to
confirm that the view of each planning type.
Signed-off-by: David Nind
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34404] Inconsistencies in Budgets and funds page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34404 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35262] Improve OPAC self registration confirmation page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35262 David Nind changed: What|Removed |Added Attachment #158553|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 158558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158558=edit Bug 35262: Improve OPAC self registration confirmation page This patch corrects logic in the OPAC self registration confirmation template so that the right column markup is shown when various combinations of OpacNav, OpacNavBottom, and OpacNavRight are displayed. To test, apply the patch and enable the PatronSelfRegistration system preference, and deactivate the PatronSelfRegistrationVerifyByEmail preference. - Go to the OPAC and start the process of registering online. - Fill in the form and submit it. - On the registration confirmation page, check that the layout looks correct. - Test with the presence of various combinations of OpacNav, OpacNavBottom, and OpacNavRight HTML customizations. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35262] Improve OPAC self registration confirmation page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35262 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34404] Inconsistencies in Budgets and funds page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34404 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34375] Shipping fund in an invoice defaults to the first fund from the list rather than 'no fund' after receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34375 Katrin Fischer changed: What|Removed |Added Summary|Shipping fund in an invoice |Shipping fund in an invoice |defaults to the first fund |defaults to the first fund |from the list rather than |from the list rather than |'no fund' after receiving. |'no fund' after receiving Version|22.11 |master QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34375] Shipping fund in an invoice defaults to the first fund from the list rather than 'no fund' after receiving.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34375 Katrin Fischer changed: What|Removed |Added Attachment #158513|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 158557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158557=edit Bug 34375: Fix the option to provide no fund in budget dropdown Currently it is not possible to use the No fund option as the dropwdown will default to the first budget in the list. This patch re-adds this option so that the defaulting behaviour is fixed Test plan: 1) Go to a vendor record in Acquisitions and then Receive Shipment 2) Enter an invoice number 3) Leave the Shipping cost empty and Shipping Fund as 'No fund' 4) Receive some orders or go straight to Finish receiving 5) Notice the Shipping fund has defaulted to the first fund in the alphabetical list of funds. It is not possible to select 'No fund' and the selected fund is recorded in shipmentcost_budgetid incorrectly. 6) Apply patch 7) Repeat steps 1-5 and this time the No fund option should be used correctly Signed-off-by: Georgia Newman Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
