[Koha-bugs] [Bug 36173] Cancelling order confirmation view does not show basket's info
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36173 David Nind changed: What|Removed |Added Text to go in the||This fixes the breadcrumb release notes||links on the confirmation ||page when cancelling an ||order (from the receiving ||screen). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36173] Cancelling order confirmation view does not show basket's info
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36173 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #4 from David Nind --- Testing notes (using KTD): 1. Breadcrumb links when you cancel an order are corrected with the patch: . Before - no text or link to My Vendor and no link for Basket number: Acquisitions > > Basket () for > Cancel order . After - now correctly has text and link to the vendor and for the Basket: Acquisitions > My Vendor > Basket TEST1 (2) for My Vendor > Cancel order Other notes === Is there another issue here as well, with actually receiving an order? When I go to receive an order (before the patch is applied), I get an error - not sure whether this is something to do with my KTD setup, or something else: 1. Added one item to a basket 2. Closed the basket 4. Went to receive order for an order 5. Update quantity to receive - 1 6. Error in pop up window: "Order 1: An error occurred while saving" 7. Web developer tools error: XHRPOST http://127.0.0.1:8081/cgi-bin/koha/acqui/finishreceive.pl [HTTP/1.1 403 Forbidden 103ms] POST http://127.0.0.1:8081/cgi-bin/koha/acqui/finishreceive.pl Status 403 Forbidden Version HTTP/1.1 Transferred 29.46 kB (29 kB size) Referrer Policy strict-origin-when-cross-origin Request Priority Highest DNS Resolution System Response Headers: Cache-Control no-cache Connection Keep-Alive Content-Length 28999 Content-Script-Type text/javascript Content-Style-Type text/css Content-Type text/html; charset=UTF-8 Date Tue, 12 Mar 2024 04:55:06 GMT Keep-Alive timeout=5, max=100 Pragma no-cache Server Apache/2.4.56 (Debian) Set-Cookie CGISESSID=0edfe61661acb72d2e9f2c872340a966; path=/; HttpOnly; SameSite=Lax Vary User-Agent X-Frame-Options SAMEORIGIN Request Headers: Accept */* Accept-Encoding gzip, deflate, br Accept-Language en-US,en;q=0.5 Connection keep-alive Content-Length 260 Content-Type application/x-www-form-urlencoded; charset=UTF-8 Cookie CGISESSID=0edfe61661acb72d2e9f2c872340a966; searchToOrder=1/1 Host 127.0.0.1:8081 Origin http://127.0.0.1:8081 Referer http://127.0.0.1:8081/cgi-bin/koha/acqui/orderreceive.pl?multiple_orders=1=1 Sec-Fetch-Dest empty Sec-Fetch-Mode cors Sec-Fetch-Site same-origin User-Agent Mozilla/5.0 (X11; Linux x86_64; rv:124.0) Gecko/20100101 Firefox/124.0 X-Requested-With XMLHttpRequest -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36173] Cancelling order confirmation view does not show basket's info
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36173 David Nind changed: What|Removed |Added Attachment #162501|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 163086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163086=edit Bug 36173: Display basket info when cancelling an order The basketno is missing from the 2 links in acqui/parcel.tt Better to retrieve the basketno from the order in the controller. Test plan: Create an order, receive it On the parcel view notice that the "Cancel order" link leads to a confirmation page that does not contain the info of the basket. It's fixed with this patch applied. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36173] Cancelling order confirmation view does not show basket's info
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36173 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook changed: What|Removed |Added Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516
--- Comment #470 from David Cook ---
Comment on attachment 162078
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162078
Bug 15516: Relevant controller changes and tests
Review of attachment 162078:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=15516=162078)
-
::: Koha/Holds.pm
@@ +213,5 @@
> +
> +sub count_holds {
> +my ( $self, $search_params ) = @_;
> +
> +$search_params = {
These $search_params lines redefine the variable instead of updating the
variable. This means that you end up selecting all holds and not just the holds
for particular criteria (like an individual patron).
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #469 from David Cook --- Found a nasty bug in Koha::Holds->count_holds(). I'm going to need to review this code in-depth again... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27753] Automate resolution of return claim when checking in an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #13 from Laura Escamilla --- Created attachment 163085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163085=edit Bug 27753: Adding patch for AutoClaimReturnStatusOnCheckout syspref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27753] Automate resolution of return claim when checking in an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla changed: What|Removed |Added Attachment #163061|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27753] Automate resolution of return claim when checking in an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #12 from Laura Escamilla --- Created attachment 163084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163084=edit Bug 27753: Added new system preferences for automatically resolving claims To test: 1. Configure Claims returned 1. Go to Administration > Authorized Values > LOST 2. Add a new authorized value with value:6 and description:Claims returned 3. Go to Administration > System Preferences 4. Set ClaimReturnedLostValue to 6 and save 2. Check out an item to a patron. 1. Mark the item as claim returned 2. Check the item in. 3. A message stating that the item has been claimed as returned pops up with an option to resolve. 4. Resolve the claim. 3. Check out the item to the patron again. 1. Mark the item as claim returned. 2. Check out the item to a new patron. Select “Yes, check out” 3. Go back to the previous patron. Notice that their claim was not resolved. 4. Apply the patch. 1. Updatedatabase 2. restart_all 3. Go to the system preferences and set the system preference ‘AutoClaimReturnStatusOnCheckin’ to ‘Returned by patron’ 4. Set ‘AutoClaimReturnStatusOnCheckout’ to ‘Found in library’ 5. Redo step 2 1. When checking the claim returned item in you will now see a message that says “The previously claimed returned item has been found, automatically resolving the associated claim.” 2. View the previous patron. Their claim has automatically been resolved with a status of ‘Returned by patron’ 6. Redo step 3 1. Upon checking the item out to another patron you will see a message that says “The previously claimed returned item has been found, automatically resolving the associated claim.” 2. View the previous patron. Their claim has automatically been resolved with a status of ‘Found in library’. 7. Sign off and have a wonderful day! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27753] Automate resolution of return claim when checking in an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36169] Add guarantee to patron categories with type='Staff'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36169 --- Comment #3 from Alex Buckley --- (In reply to Lucas Gass from comment #2) > Alex, I must not understand. What is the use case for STAFF adding a > guarantee? Hi Lucas, thanks for your question. We have a partner library where the librarians each have a Koha account belonging to the patron category 'Library staff' (this category has the type = 'staff' so the accounts cannot be so easily deleted). However, as their librarian have children registered at the library they would like to link their children's accounts to their 'Library staff' accounts. i.e. they do not want to have to manage two patron accounts: a 'Library staff' account and an 'Adult' account in order to add their children as guarantees. Does that help clarify the use case? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34478] Full CSRF protection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 --- Comment #185 from David Cook --- (In reply to David Cook from comment #184) > (In reply to David Cook from comment #183) > > However, I have been thinking a bit about how to provide some protection to > > stable branches. > > I think my abbreviated anti-CSRF plus bug 33259 (when it's ready) would be > an OK compromise for stable branches. Although as I say that I'm finding more changes that need to be backported to really support this... heh... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34478] Full CSRF protection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 --- Comment #184 from David Cook --- (In reply to David Cook from comment #183) > However, I have been thinking a bit about how to provide some protection to > stable branches. I think my abbreviated anti-CSRF plus bug 33259 (when it's ready) would be an OK compromise for stable branches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #57 from David Cook --- I hate to say it now, but I think we should change tack, and just focus on the SameSiteSessionCookie being for the CGISESSID cookie and only for authenticated contexts. (Focusing only on the CGISESSID cookie is mostly just to help in terms of testability, although I think the best practice is to only set Strict for sensitive cookies.) That should provide security for authenticated Koha users while also allowing usability for things like SSO. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #56 from David Cook --- Oh good. Chrome and Firefox appear to work differently. In Chrome, if you login to Keycloak first, and then do that Koha->Keycloak->Koha redirect you're fine. In Firefox, if you login to Keycloak first, and then do that Koha->Keycloak->Koha redirect, you still will get an error. Of course, you should only be clicking "Login with Keycloak" from an anonymous session, which takes me back to that thing about the anonymous session not being Strict even when authenticated cookies are Strict. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #55 from David Cook --- (In reply to David Cook from comment #54) > Interestingly, when Keycloak POSTs a 302 to Koha it doesn't work, but there > is a scenario with Keycloak where a Strict cookie is still sent after a > redirect. > > If I log into Keycloak first, and then I go to Koha and click "Log in with > Keycloak", I'm redirected from Koha to Keycloak and redirected from Keycloak > to Koha. In this situation where it's two GET 302s in a row, the Strict > cookie is still sent, and I'm logged into Koha using Keycloak. I'm not describing this right. With Strict, it's failing because Keycloak is doing a GET to Koha and that's not allowed. With Lax, it's succeeding because it's allowed for Keycloak to do a GET to Koha. And I think in the scenario where it goes Koha -> Keycloak -> Koha will all 302s, I think the browser is considering that to be user-initiated from the Koha side, and that's why it's allowing it to send the cookie. Because we have a POST to Keycloak with the login, that's why it won't let us login with Keycloak when Strict is in use. I think that brings me back to anonymous CGISESSID cookies needing to be Lax, even if an authenticated CGISESSID cookie is Strict. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 David Cook changed: What|Removed |Added Status|In Discussion |Failed QA --- Comment #54 from David Cook --- Going to mark this as Failed QA in any case as it doesn't take into account the CGISESSID cookie created by the OIDC in Koha/REST/V1/OAuth/Client.pm. -- Also, as I feared, with SameSite of "Strict", OIDC SSO is broken. -- Interestingly, when Keycloak POSTs a 302 to Koha it doesn't work, but there is a scenario with Keycloak where a Strict cookie is still sent after a redirect. If I log into Keycloak first, and then I go to Koha and click "Log in with Keycloak", I'm redirected from Koha to Keycloak and redirected from Keycloak to Koha. In this situation where it's two GET 302s in a row, the Strict cookie is still sent, and I'm logged into Koha using Keycloak. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #60 from Lucas Gass --- Rebased for current master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass changed: What|Removed |Added Attachment #162731|0 |1 is obsolete|| --- Comment #59 from Lucas Gass --- Created attachment 163083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163083=edit Bug 33703: Add Maskito to about.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass changed: What|Removed |Added Attachment #162730|0 |1 is obsolete|| --- Comment #58 from Lucas Gass --- Created attachment 163082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163082=edit Bug 33703: Add Maskito support for OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass changed: What|Removed |Added Attachment #162729|0 |1 is obsolete|| --- Comment #57 from Lucas Gass --- Created attachment 163081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163081=edit Bug 33703: Add Maskito to dateaccessioned.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass changed: What|Removed |Added Attachment #162728|0 |1 is obsolete|| --- Comment #56 from Lucas Gass --- Created attachment 163080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163080=edit Bug 33703: Don't use Maskito when picking a range -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass changed: What|Removed |Added Attachment #162727|0 |1 is obsolete|| --- Comment #55 from Lucas Gass --- Created attachment 163079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163079=edit Bug 33703: Add time support -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass changed: What|Removed |Added Attachment #162726|0 |1 is obsolete|| --- Comment #54 from Lucas Gass --- Created attachment 163078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163078=edit Bug 33703: Add Masikto core/kit for date masking To test: 1. Apply patch 2. Restart all, clear browser cache 3. In the staff interface start testing some flatpickr instances with direct inputs. 4. Try entering your dates without delimiters, '/' or '-', or '.'. 5. Make sure the dates are well formed. 6. Test with each of dateformat's Koha supports. ( system preference 'dateformat'). 7. Add/edit an item with the dateaccessioned.pl plugin loaded, making the dates are well formed. 8. Make an item bookable by going to the item tab of a record and setting at least 1 item to "Bookable:". 9. Now "Place booking", which should trigger a modal. 10. In the "Period" date picker, which is a range, the dates should NOT be formatted. 11. Log in to the OPAC and try some date pickers ( self reg/borrower mod/ect ) Some places to test: -Patron record date of birth -Patron record registration date -Patron record expiry date -Checkouts, manually set a due date -Patron category, enrollment period -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep local use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep local use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass changed: What|Removed |Added Attachment #161160|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep local use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass changed: What|Removed |Added Attachment #161159|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep local use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass changed: What|Removed |Added Attachment #161155|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep local use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass changed: What|Removed |Added Attachment #161158|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep local use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122
--- Comment #89 from Lucas Gass ---
Created attachment 163077
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163077=edit
Bug 16122: Add unit test
To test:
1. Apply patch, updatedatabase & schema, restart all Services
2. Go to Administration > Table setting. Find the holdings table ( Catalog >
holdings_table ) and turn the local use column on.
3. Go to an item record and notice the column 'Local uses'
4. Turn the system preference RecordLocalUseOnReturn Off.
5. Check in an item that is not checkout out. No local use should be recorded
for the item.
6. Turn RecordLocalUseOnReturn on and check in an item that is not checked out.
Local use on that item should increment by 1.
7. Create a statistical patron and check an item out to them. Local use should
increment by 1.
8. Go to /api/v1/items?external_id={barcode} and make sure the numbers for
localuse look correct.
To test maintainence script:
1. Without the patch, have RecordLocalUseOnReturn on.
2. Check in some items to record localuse in the stats table. Keep note of
those stats.
3. Apply the patches, updatedatabase.
4. Run the maintenance script, perl update_localuse_from_statistics.pl
5. Now check that items.localuse is congruent with what is in the stats table
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep local use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass changed: What|Removed |Added Attachment #161157|0 |1 is obsolete|| --- Comment #88 from Lucas Gass --- Created attachment 163076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163076=edit Bug 16122: Add maintenance script to update items.localuse from stats Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep local use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass changed: What|Removed |Added Attachment #161156|0 |1 is obsolete|| --- Comment #87 from Lucas Gass --- Created attachment 163075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163075=edit Bug 16122: Add display and Table settings Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep local use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #86 from Lucas Gass --- Created attachment 163074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163074=edit Bug 16122: Increment items.localuse -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep local use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass changed: What|Removed |Added Attachment #161154|0 |1 is obsolete|| --- Comment #85 from Lucas Gass --- Created attachment 163073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163073=edit Bug 16122: API and Schema updates Signed-off-by: Christopher Brannon Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep local use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass changed: What|Removed |Added Attachment #161153|0 |1 is obsolete|| --- Comment #84 from Lucas Gass --- Created attachment 163072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163072=edit Bug 16122: Add localuse column to items and deleteditems Signed-off-by: Christopher Brannon Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34478] Full CSRF protection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 --- Comment #183 from David Cook --- (In reply to Fridolin Somers from comment #182) > Not for backport I bet ? I don't think that it would be possible to backport this one. However, I have been thinking a bit about how to provide some protection to stable branches. Locally, I've applied the following: - Bug 36098 (the Koha::Session patches) - Bug 34755: Backport Koha::Token change from bug 34478 - Bug 34478: Add csrf-token in meta I've created a middleware based off Koha::Middleware::CSRF and then using a mix of ideas from Marcel and myself, I've used Javascript to inject CSRF tokens into forms and Koha API calls. At the moment, I'm testing this on the OPAC, and then I'm going to look at the Staff Interface. I want to do some more thinking about how we can use "Strict" in the SameSite attribute for the CGISESSID cookie to cover off CSRF for GET requests as well. Less of a problem for 34478 because it fixes a lot of stateful GET requests, but for older versions... -- Long story short... it might be worth backporting just "Bug 34478: Add csrf-token in meta" for now. Maybe a new bug report for that? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 David Cook changed: What|Removed |Added Status|Passed QA |In Discussion --- Comment #53 from David Cook --- Actually, I'm momentarily going to move this to "In Discussion". I think using a Strict SameSite attribute would break the SSO implementation especially in terms of CSRF. You'd have an anonymous session, then you redirect to the IdP, and then you're redirected back. Since you're being redirected back via an external site, your browser shouldn't send the Strict CGISESSID cookie, which means your CSRF validation will fail. I'll test that in a minute. We might need to always use a "Lax" SameSite attribute for anonymous sessions. I'll try to think of any other problem scenarios... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 David Cook changed: What|Removed |Added Attachment #162186|0 |1 is obsolete|| --- Comment #52 from David Cook --- Created attachment 163071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163071=edit Bug 33259: (QA follow-up) Default 'Strict' for new installs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 David Cook changed: What|Removed |Added Attachment #162185|0 |1 is obsolete|| --- Comment #51 from David Cook --- Created attachment 163070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163070=edit Bug 33259: (follow-up) perltidy Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 David Cook changed: What|Removed |Added Attachment #162184|0 |1 is obsolete|| --- Comment #50 from David Cook --- Created attachment 163069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163069=edit Bug 33259: (follow-up) Add HTML filters to Cookies.set Test plan: Run QA test tools and confirm the no complaints about filters Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 David Cook changed: What|Removed |Added Attachment #162183|0 |1 is obsolete|| --- Comment #49 from David Cook --- Created attachment 163068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163068=edit Bug 33259: (follow-up) Use different speechmarks to prevent errors To test: Confirm the checkouts table for a patron loads successfully Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 David Cook changed: What|Removed |Added Attachment #162182|0 |1 is obsolete|| --- Comment #48 from David Cook --- Created attachment 163067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163067=edit Bug 33259: Optionally set SameSite attribute of session cookie to Strict Note: The below test plan is assuming you are running the Mozilla Firefox browser. Test plan: 1. Apply patches 2. Upgrade database sudo koha-upgrade-schema 3. Confirm the new system preference 'SameSiteSessionCookie' is 'Lax' 4. Go to a staff client and OPAC page, right click, choose 'Inspect', go to the 'Storage' tab, click on 'Cookies', click on 'CGISESSID' 5. Confirm 'SameSite' = 'Lax' 6. Change the 'SameSiteSessionCookie' to 'Strict' 7. Open a new private browser window. Go to a staff client and OPAC page, right click, choose 'Inspect, go to the 'Storage' tab, click on 'Cookies', click on 'CGISESSID' 8. Repeat step 4 and confirm 'SameSite' = 'Strict' 9. Go to: Cataloguing > New record 10. Right click, click 'Inspect', go to the 'Console' tab, confirm there are no JavaScript errors 11. Change 'SameSiteSessionCookie' to 'None' 12. Open a new private browser window, repeat step 4, and confirm the 'SameSite' = 'None' 13. Go to: Cataloguing > New record 14. Right click, click 'Inspect', go to the 'Console' tab, confirm there are no JavaScript errors. Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: Sally Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 David Cook changed: What|Removed |Added Attachment #162181|0 |1 is obsolete|| --- Comment #47 from David Cook --- Created attachment 163066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163066=edit Bug 33259: Add SameSiteSessionCookie system preference Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: Sally Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #46 from David Cook --- Technically, a lot of this was probably overkill. The key cookie that needed Strict is the CGISESSID cookie, because that's where there's security implications. However, it doesn't hurt doing it like we have here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #45 from David Cook --- Rebasing this one as opac/sco-sco-main.pl wasn't applying anymore. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36292] 'See all charges' hyperlink to view guarantee fees is not linked correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36292 David Nind changed: What|Removed |Added Attachment #163046|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 163065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163065=edit Bug 36292: Fixed 'See all charges' hyperlink for guarantees/guarantor linked charges To test: 1. Add a guarantee / guarantor relationship for two patrons. 2. Add a manual fee to the guarantees' account. 3. Go to the guarantor's account and view the 'Details' tab. Under contact information there should be a Guarantees section. There you will see the charges for your guarantee. Click on ‘See all charges’. The link leads you no where. 4. Apply the patch and restart_all 5. Refresh the guarantor’s page and click on ‘See all charges’ again. This time it will take you down to the ‘Guarantees’ Charges’ panel. 6. Sign off and have a great day! :D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36292] 'See all charges' hyperlink to view guarantee fees is not linked correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36292 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36291] Scrolling glitch on ILL batches table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 David Nind changed: What|Removed |Added CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13706] Deduping authorities script (dedup_authorities.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706 David Nind changed: What|Removed |Added Text to go in the||This new command line release notes||script ||(misc/maintenance/dedup_aut ||horities.pl) is a tool for ||helping to automatically ||remove duplicate authority ||records. || ||Features: ||- ||Choose a method(s) to ||select which authority ||record to keep when ||duplicates are found. ||Methods include: || . date: ||keep the most recent ||authority (based on 005 ||field) || . used: keep the ||most used authority || . ||ppn: PPN (UNIMARC only), ||keep the authority with a ||ppn (when some authorities ||don't have one, based on ||009 field) ||- Use a SQL ||WHERE statement to limit ||the authority records ||checked for deduplication ||- ||Check only specified ||authority types ||- Increase ||the level of detail shown ||using the --verbose option ||- Changes are only made ||when the --confirm option ||is used || ||Examples: ||- ||Methods - for the ||authorities that have a ||PPN, keep the most recent, ||and if two (or more) have ||the same date in 005, keep ||the most used: --method ppn ||--method date --method used || ||- SQL WHERE statement - ||only look at records with ||an auth_id less than 5,000: ||--where="authid < 5000" ||- ||Limit deduplication to ||specific authority types: ||--authtypecode PERSO_NAME || ||See the script help for the ||options available and usage ||examples ||(misc/maintenance/dedup_aut ||horities.pl --help). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27753] Automate resolution of return claim when checking in an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Michelle Spinney changed: What|Removed |Added CC||mspin...@clamsnet.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35955] New CSRF token generated everytime we need one
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35955 --- Comment #13 from David Cook --- (In reply to Fridolin Somers from comment #12) > May we backport this for better performance ? I can't imagine that it would hurt. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35532] Use of calendar for date range in bookings is not clear
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 --- Comment #17 from Katrin Fischer --- (In reply to Fridolin Somers from comment #16) > Depends on Bug 35426 not in 23.11.x Maye worth reconsidering - a lot of us didn't understand this new type of date selector and this improves things quite a bit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36296] There are no items that can be placed on hold.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36296 --- Comment #1 from Nasr --- Created attachment 163064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163064=edit This is how it look like -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36296] New: There are no items that can be placed on hold.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36296 Bug ID: 36296 Summary: There are no items that can be placed on hold. Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nasralyashas...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Hello all, I have this problem when I want to place hold an book is says : There are no items that can be placed on hold. What could be the issue? Any help will be appreciated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23335] "There are no items that can be placed on hold."
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23335 Nasr changed: What|Removed |Added CC||nasralyashas...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36232] Error fixing OAI-PMH:AutoUpdateSetsEmbedItemData syspref name on the DB
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36232
David Nind changed:
What|Removed |Added
Attachment #163062|0 |1
is obsolete||
--- Comment #5 from David Nind ---
Created attachment 163063
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163063=edit
Bug 36232: Fix error in DBRev dealing with OAI-PMH:AutoUpdateSetsEmbedItemData
typo
This patch fixes the case of the wrong syspref variable co-existing with
the good one.
OAI-PMH:AutoUpdateSetsEmbedItemData is the only case, as the rest of the
mispelled ones are just case fixes, which would not trigger the same
situation as the `systempreferences` table collation is
case-insentitive.
To test:
1. Run:
$ ktd --shell
k$ koha-mysql kohadev
> INSERT INTO systempreferences VALUES
('OAI-PMH:AutoUpdateSetEmbedItemData',0,'','','YesNo');
> UPDATE systempreferences SET variable = 'IllCheckAvailability' WHERE
variable = "ILLCheckAvailability";
> INSERT INTO systempreferences VALUES
('IllCheckAvailability',0,'','','YesNo');
=> FAIL: The last command fails because the good and wrong values cannot
coexist
2. Set the version to a prior one:
> UPDATE systempreferences SET value="23.124" WHERE variable like
'version';
3. Run:
k$ updatedatabase
=> FAIL: You get this error:
ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry
'OAI-PMH:AutoUpdateSetsEmbedItemData' for key 'systempreferences.PRIMARY' at
...
4. Apply this patch
5. Repeat 3
=> SUCCESS: It works!
6. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Victor Grousset/tuxayo
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36232] Error fixing OAI-PMH:AutoUpdateSetsEmbedItemData syspref name on the DB
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36232 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Needs Signoff |Signed Off --- Comment #4 from Victor Grousset/tuxayo --- It works :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36232] Error fixing OAI-PMH:AutoUpdateSetsEmbedItemData syspref name on the DB
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36232
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #163027|0 |1
is obsolete||
--- Comment #3 from Victor Grousset/tuxayo ---
Created attachment 163062
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163062=edit
Bug 36232: Fix error in DBRev dealing with OAI-PMH:AutoUpdateSetsEmbedItemData
typo
This patch fixes the case of the wrong syspref variable co-existing with
the good one.
OAI-PMH:AutoUpdateSetsEmbedItemData is the only case, as the rest of the
mispelled ones are just case fixes, which would not trigger the same
situation as the `systempreferences` table collation is
case-insentitive.
To test:
1. Run:
$ ktd --shell
k$ koha-mysql kohadev
> INSERT INTO systempreferences VALUES
('OAI-PMH:AutoUpdateSetEmbedItemData',0,'','','YesNo');
> UPDATE systempreferences SET variable = 'IllCheckAvailability' WHERE
variable = "ILLCheckAvailability";
> INSERT INTO systempreferences VALUES
('IllCheckAvailability',0,'','','YesNo');
=> FAIL: The last command fails because the good and wrong values cannot
coexist
2. Set the version to a prior one:
> UPDATE systempreferences SET value="23.124" WHERE variable like
'version';
3. Run:
k$ updatedatabase
=> FAIL: You get this error:
ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry
'OAI-PMH:AutoUpdateSetsEmbedItemData' for key 'systempreferences.PRIMARY' at
...
4. Apply this patch
5. Repeat 3
=> SUCCESS: It works!
6. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Victor Grousset/tuxayo
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32636] More info with batch patron deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32636 Jack changed: What|Removed |Added CC||jmor...@sbhrs.org --- Comment #1 from Jack --- It would sure be nice to know which patrons were not being deleted from your list. Without knowing, it just creates more work to find out who and why they were not deleted. Just showing who was not deleted would sure be nice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27753] Automate resolution of return claim when checking in an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla changed: What|Removed |Added Attachment #163058|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27753] Automate resolution of return claim when checking in an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla changed: What|Removed |Added Attachment #163060|0 |1 is obsolete|| --- Comment #11 from Laura Escamilla --- Created attachment 163061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163061=edit Bug 27753: Testing - not ready -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27753] Automate resolution of return claim when checking in an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla changed: What|Removed |Added Attachment #163059|0 |1 is obsolete|| --- Comment #10 from Laura Escamilla --- Created attachment 163060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163060=edit Bug 27753: Testing - not ready -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27753] Automate resolution of return claim when checking in an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #9 from Laura Escamilla --- Created attachment 163059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163059=edit Bug 27753: Testing - not ready -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27753] Automate resolution of return claim when checking in an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla changed: What|Removed |Added Attachment #162517|0 |1 is obsolete|| --- Comment #8 from Laura Escamilla --- Created attachment 163058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163058=edit Bug 27753: Added two new system preferences for automatically resolving claims. Bug 27753: Removed syspref code in order to move it over to Circulation.pl Bug: 27753 - Updates to AutoClaimResolutionOnCheckin Bug 27753: Added code for AutoClaimResolutionOnCheckout Bug 27753: Added CLAIM_RESOLUTION alert Bug 27753: Made updates to AutoClaimResolved messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36280] Viewing batch of staged records broken: CSRF token error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36280 --- Comment #3 from Victor Grousset/tuxayo --- issue reported in the pad, section "Testing Reports (36195):" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33510] Add context to "New" as a status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33510 Caroline Cyr La Rose changed: What|Removed |Added CC||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36295] Space out content blocks in Batch record modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36295 Caroline Cyr La Rose changed: What|Removed |Added CC||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36295] Space out content blocks in Batch record modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36295 --- Comment #1 from Caroline Cyr La Rose --- I found this in 23.05. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36295] New: Space out content blocks in Batch record modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36295 Bug ID: 36295 Summary: Space out content blocks in Batch record modification Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org This is very minor, but I figure I'd report it anyway... When using the batch record modification tool, there is no space between the "Record type" content block and the tabbed "Source of records" block. To recreate: 1. Create a MARC modification template 1.1. Go to Cataloging > MARC modification templates > New template 1.2. Give the template a name (for example, "Hide from OPAC") 1.3. Click Submit 1.4. Click New action 1.5. Add a new action (for example, Update existing or add new field(s) 942 n with value 1) 1.6. Click Add action 2. Go to Cataloging > Batch record modification --> Note that there is no space between the white "Record type" block and the block underneath with the tabs for the record source -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36280] Viewing batch of staged records broken: CSRF token error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36280 --- Comment #2 from Victor Grousset/tuxayo --- Thanks, it's a catch all ticket, that's why I didn't find it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35357] Item not removed from holds queue when checked out to a different patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35357 --- Comment #25 from Victor Grousset/tuxayo --- (In reply to Kyle M Hall from comment #22) > Using DBIC to find and delete the lines in the two tables will result in 4 > queries compared to the one query we have now. The manual query should still do in practice two lookups via itemnumber. And then two deletes. But maybe for simple queries the overhead of doing individual queries is larger than the work done by the simple queries themselves. I don't know enough about real world DBMS behavior. --- (In reply to Katrin Fischer from comment #23) > Hi Kyle, can you explain a bit more about those extra queries if you can? > I'd like to understand the issue better and learn. IIUC, we don't have the ORM objects on hand so we have to do a find first. Then do a delete on the object. So 4 queries. (maybe Kyle had something else in mind) --- (In reply to Fridolin Somers from comment #24) > Seeing comments, I wait for backport No worries, you can backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 --- Comment #41 from Katrin Fischer --- (In reply to Hans Pålsson from comment #40) > Dito, upgrade from 23.11.02 fails. I am sorry for that. If you remove the pref from the database and then re-run the script, that should fix things. We are also working on a fix here: bug 36232 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33898] background_jobs_worker.pl may leave defunct children processes for extended periods of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898 --- Comment #28 from Victor Grousset/tuxayo --- (In reply to Marcel de Rooy from comment #20) > The alternative patch addresses the issues raised earlier on the use of > signals and follows the suggestions of David. Thanks :) > Kyle, Victor and Asymar: Would this work for you? It works, so signing off. As for the signal vs no signals I don't know the good practices to QA this. Same for how this plays with when using database polling or the message queue. (I would have missed that the 1st alternate patch missed this) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33898] background_jobs_worker.pl may leave defunct children processes for extended periods of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #162954|0 |1 is obsolete|| --- Comment #27 from Victor Grousset/tuxayo --- Created attachment 163057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163057=edit Bug 33898: Implement reaping for database polling Signed-off-by: Kyle M Hall Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33898] background_jobs_worker.pl may leave defunct children processes for extended periods of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #162953|0 |1 is obsolete|| --- Comment #26 from Victor Grousset/tuxayo --- Created attachment 163056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163056=edit Bug 33898: Alternative approach with receive frame timeout See bug 33898 comment6. Test plan: Based on comment12: Stage MARC import and manage. Look at the same time to the results of ps aux|grep Z. Verify that the lines with [background_jobs] disappear within 10 seconds. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #293 from Nick Clemens --- Created attachment 163055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163055=edit Bug 15565: Add 'DisplayMultiItemHolds' system preference to toggle display of multi item holds These patches allow the display of checkboxes instead of radio buttons for placing specific item holds in the OPAC and staff interface. This display is controlled by the system preference 'DisplayMultiItemHolds'. When disabled, the hold display is the same as in the past. When enabled, the user can select multiple items to place holds on at the same time. If there is an error placing one or more holds, an error will display on the following screen. Test plan: 0. Apply the patches and koha-plack --reload kohadev 1. Enable 'DisplayMultiItemHolds' syspref 2. In staff interface, go to a record with multiple holdable items 3. Check the boxes next to 2+ items and click the button to place the holds 4. Note that the holds are all placed (unless there is a failure) 5. Cancel the holds, and try again (but this time make Holds per record (count) only 1 in the circ rules) 6. Note that one of the holds is placed, but the others are not and an error message is displayed saying that one or more holds could not be placed because the holds per record was exceeded 7. Perform the same above procedure on the OPAC 8. If DisplayMultiPlaceHold is enabled, you can test placing multiple specific item holds across multiple bibs in the OPAC via the search results 9. If EnableItemGroups and EnableItemGroupHolds is enabled, you can test that you can either place item group holds or specific item holds. Toggling the checkboxes in the staff interface will uncheck the item group hold radio button. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #292 from Nick Clemens --- Created attachment 163054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163054=edit Bug 15565: Place multiple holds on one or more records in OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #291 from Nick Clemens --- Created attachment 163053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163053=edit Bug 15565: Tidy reserve/placerequest.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Nick Clemens changed: What|Removed |Added Attachment #162071|0 |1 is obsolete|| Attachment #162072|0 |1 is obsolete|| Attachment #162073|0 |1 is obsolete|| Attachment #162074|0 |1 is obsolete|| --- Comment #290 from Nick Clemens --- Created attachment 163052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163052=edit Bug 15565: Place multiple holds on one record on staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35959] Inconsistent hierarchy during C3 merge of class 'Koha::AuthorisedValue' (and a few other modules)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35959 --- Comment #26 from Tomás Cohen Arazi --- I mean... This is clearly a Perl bug :-P It is a bad sign that it hasn't been reported+solved already upstream. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36294] New: Replace inaccurate use of "book" in system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36294 Bug ID: 36294 Summary: Replace inaccurate use of "book" in system preferences Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: andre...@dubcolib.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Several system preferences refer to "books" in their text but are referring to either a biblio or an item, not something that is necessarily a book. Should refer to titles: virtualshelves: "Allow staff and patrons to create and view saved lists of books" SyndeticsSeries: "(Do/Don't show) information on other books in a title's series from Syndetics on item detail pages on the OPAC." Should refer to items: AutoSwitchPatron: "(dis/enable) the automatic redirection to another patron when a patron barcode is scanned instead of a book. This should not be enabled if you have overlapping patron and book barcodes." OPACFineNoRenewals: "Only allow patrons to renew their own books on the OPAC if they have less than [] USD in charges (leave blank to disable)." OpacRenewalAllowed: "(do/don't allow) patrons to renew their own books on the OPAC." opacreadinghistory: "patrons to see what books they have checked out in the past." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36195] CSRF - testing reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36195 Dave changed: What|Removed |Added CC||ddagh...@mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28981] Add a syspref for marking items as unavailable in Z3950Responder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28981 Noémie Labine changed: What|Removed |Added CC||noemie.lab...@collecto.ca --- Comment #1 from Noémie Labine --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36215] Bookings calendar only shows bookings within RESTdefaultPageSize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36215 Tomás Cohen Arazi changed: What|Removed |Added Attachment #162846|0 |1 is obsolete|| --- Comment #4 from Tomás Cohen Arazi --- Created attachment 163051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163051=edit Bug 36215: Remove limit on fetching bookings This removes the paging from the bookings request so we take into account all bookings. We may want to replace this with date bounded paging in the future, but lets not try to optimise until we need to. To test: 1 - Find a record detail page in Koha staff interface 2 - Click on a barcode to go to items tab 3 - Edit 'bookable' to 'yes' 4 - Return to details page 5 - Place 5 bookings on a record 6 - Set system preference RESTDefaultPageSize 2 7 - Click the 'Bookings' tab on the record details 8 - Confirm onyl 2 bookings shown in calendar view 9 - Apply patch, reload 10 - All bookings now show in calendar Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36215] Bookings calendar only shows bookings within RESTdefaultPageSize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36215 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36195] CSRF - testing reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36195 Brendan Lawlor changed: What|Removed |Added CC||blaw...@clamsnet.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Tomás Cohen Arazi changed: What|Removed |Added Status|In Discussion |Signed Off --- Comment #23 from Tomás Cohen Arazi --- Martin, can you please check if my follow-up is what you were envisioning? Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36195] CSRF - testing reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36195 Brendan Lawlor changed: What|Removed |Added Attachment #163049|0 |1 is obsolete|| --- Comment #7 from Brendan Lawlor --- Created attachment 163050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163050=edit Bug 36195: Replace POST in itemsearch.tt with GET We retrieve a list of records for DT, it does not need to be a POST request. Test plan: 1. Try an item search 2. The page loads but pops an alert that says "403: Forbidden" and table stays empty 3. Apply patch 4. Try an item search again and the table loads results -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36195] CSRF - testing reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36195 --- Comment #6 from Brendan Lawlor --- Created attachment 163049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163049=edit Bug 36195: Replace POST in itemsearch.tt with GET -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 163048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163048=edit Bug 34943: (QA follow-up) Use `before_biblio_action` and an `action` param This patch harmonizes the hook name and parameters with the rest of the codebase. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ qa => SUCCESS: All looks green, and tests still pass (i.e. they were correctly adjusted to the new schema). 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 David Gustafsson changed: What|Removed |Added Text to go in the|This enhancement changes|This enhancement changes release notes|how marc overlay rules are |how marc overlay rules are |evaluated. Before the |evaluated. Before the |change rules with filter|change rules with filter |set to '*' (wildcard) where |set to '*' (wildcard) where |only applied when no other |only applied when no other |rules had been defined for |rules had been defined for |a specific filter value,|a specific filter value, |regardless of if any of the |regardless of if any of the |rules with that filter |rules with that filter |value matched or not. |value matched or not. | | |With|With |this change we fallback to |this change we fallback to |the wildcard filter rules |the wildcard filter rules |even though rules with a|even though rules with a |matching filter value do|matching filter value do |exists, if no rule for that |exists, if no rule for that |filter value matches. This |filter value matches. This |resolves the issue of |resolves the issue of |having to repeat the same |having to repeat the same |default rules for each |default rules for each |filter value rule set. If |filter value rule set. If |for some filter value the |for some filter value the |wildcard filter rules |wildcard filter rules |should be overridden, a |should be overridden, a |wildcard tag rule for that |wildcard tag rule for that |filter value can be defined |filter value can be defined |which will have higher |which will have higher |precedence and override all |precedence and override all |the filter wildcard rules. |the filter wildcard rules. || |In summary, the rules will |In summary, the rules will |applied as follows: |applied as follows: | | |- A |- A |matching rule is looked for |matching rule is looked for |based on context (module|based on context (module |and filter value), if |and filter value), if |multiple contexts matches |multiple contexts matches |rules for the module with |rules for the module with |highest priority are used. |highest priority are used. |The module priority is |The module priority is |(from highest to lowest)|(from highest to lowest) |"User name", "Patron|"User name", "Patron |category" and "Source" |category" and "Source". | | |- |- |If no matching rule is |If no matching rule is |found, we fallback to the |found, we fallback to the |wildcard filter rules of|wildcard filter rules of |the current context. |the current context module. | | |For |For Koha installations |Koha installations where|where marc overlay rules is |marc overlay rules is in|in use a database migration |use a database migration|will run that creates new |will run that creates new |rules if necessary to |rules if necessary to |preserve the current |preserve the current|behavior, so no user action |behavior, so no user action |needs to be taken in order |needs to be taken in order |to correct for this change. |to correct for this change. | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git :
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 David Gustafsson changed: What|Removed |Added Text to go in the|This enhancement changes|This enhancement changes release notes|how marc overlay rules are |how marc overlay rules are |evaluated. Before the |evaluated. Before the |change rules with filter|change rules with filter |set to '*' (wildcard) where |set to '*' (wildcard) where |only applied when no other |only applied when no other |rules had been defined for |rules had been defined for |a specific filter value,|a specific filter value, |regardless of if any of the |regardless of if any of the |rules with that filter |rules with that filter |value matched or not. |value matched or not. | | |With|With |this change we fallback to |this change we fallback to |the wildcard filter rules |the wildcard filter rules |even though rules with a|even though rules with a |matching filter value do|matching filter value do |exists, if no rule for that |exists, if no rule for that |filter value matches. This |filter value matches. This |resolves the issue of |resolves the issue of |having to repeat the same |having to repeat the same |default rules for each |default rules for each |filter value rule set. If |filter value rule set. If |for some filter value the |for some filter value the |wildcard filter rules |wildcard filter rules |should be overridden, a |should be overridden, a |wildcard tag rule for that |wildcard tag rule for that |filter value can be defined |filter value can be defined |which will have higher |which will have higher |precedence and override all |precedence and override all |the filter wildcard rules. |the filter wildcard rules. || |In summary, the rules will |In summary, the rules will |applied as follows: |applied as follows: | | |- A |- A |matching rule is looked for |matching rule is looked for |based on context (module|based on context (module |and filter value), if |and filter value), if |multiple contexts matches |multiple contexts matches |rules for the module with |rules for the module with |highest priority are used. |highest priority are used. |The module priority is |The module priority is |(from highest to lowest)|(from highest to lowest) |"User name", "Patron|"User name", "Patron |category" and "Source" |category" and "Source" | | |- |- |If no matching rule is |If no matching rule is |found, we fallback to the |found, we fallback to the |wildcard filter rules of|wildcard filter rules of |the current context.|the current context. || ||For ||Koha installations where ||marc overlay rules is in ||use a database migration ||will run that creates new ||rules if necessary to ||preserve the current ||behavior, so no user action ||needs to be taken in order ||to correct for this change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git :
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #63 from David Gustafsson --- @Victor Grousset/tuxayo Ok, thanks for the feedback and test plan. I now submitted a release note. It's not that easy to explain the change in clear terms, so suggestions are welcome if there is room for improvements. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 David Gustafsson changed: What|Removed |Added Patch complexity|--- |Medium patch Change sponsored?|--- |Sponsored Text to go in the||This enhancement changes release notes||how marc overlay rules are ||evaluated. Before the ||change rules with filter ||set to '*' (wildcard) where ||only applied when no other ||rules had been defined for ||a specific filter value, ||regardless of if any of the ||rules with that filter ||value matched or not. || ||With ||this change we fallback to ||the wildcard filter rules ||even though rules with a ||matching filter value do ||exists, if no rule for that ||filter value matches. This ||resolves the issue of ||having to repeat the same ||default rules for each ||filter value rule set. If ||for some filter value the ||wildcard filter rules ||should be overridden, a ||wildcard tag rule for that ||filter value can be defined ||which will have higher ||precedence and override all ||the filter wildcard rules. || ||In summary, the rules will ||applied as follows: || ||- A ||matching rule is looked for ||based on context (module ||and filter value), if ||multiple contexts matches ||rules for the module with ||highest priority are used. ||The module priority is ||(from highest to lowest) ||"User name", "Patron ||category" and "Source" || ||- ||If no matching rule is ||found, we fallback to the ||wildcard filter rules of ||the current context. Severity|major |enhancement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36226] Large patron databases create difficult patron auto-complete searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36226 --- Comment #2 from Kyle M Hall --- Also https://www.perl.com/pub/2003/09/25/searching.html/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep local use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #83 from Lucas Gass --- Needs rebased/refactored on top of Bug 35950. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 Lucas Gass changed: What|Removed |Added Blocks||16122 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 [Bug 16122] Item record needs to keep local use count -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep local use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass changed: What|Removed |Added Depends on||35950 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
