[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #70 from Katrin Fischer  ---
I think the overpaying note might not be valid, but the other remarks (input,
db update) are, can you please check?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #69 from Josef Moravec  ---
To add more: you missed the database part of adding a system preference, see
https://wiki.koha-community.org/wiki/System_Preferences#Adding_a_new_system_preference

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #68 from Katrin Fischer  ---
Hi Martin, I just tested: Overpaying and creating a credit by it is not
possible right now. I think it was intentionally changed as the credits caused
a bit of trouble and should be added intentionally.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #67 from Katrin Fischer  ---
(In reply to Martin Renvoize from comment #50)
> The bug description is really misleading.. this doesn't add a cash
> register/till at all, rather it's just a method of displaying change to give.

Hi Martin, do you have a good idea for a new bug title? I agree it might be a
little misleading the way it is.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #66 from Martin Renvoize  ---
Comment on attachment 79951
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79951
Bug 11373: Show the difference between the amount collected and the amount paid
of a fine payment.

Review of attachment 79951:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=11373=79951)
-

Can one still overpay when using this system?

What if the librarian finds they don't have the appropriate change in the
drawer, can they continue with the transaction inputting the full amount and as
such creating a credit?

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
@@ +108,5 @@
> +
> +
> +
> +Change to give: 
> +

This shouldn't be an 'input' in my opinion, rather it should be more clearly
distinguished as information.. perhaps a span with a class highlighting in
'red' if the patron is owed change?

@@ +220,5 @@
> +
> +
> +
> +Change to give: 
> +

As above

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Michal Denar  changed:

   What|Removed |Added

  Attachment #79944|0   |1
is obsolete||

--- Comment #65 from Michal Denar  ---
Created attachment 79951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79951=edit
Bug 11373: Show the difference between the amount collected and the amount paid
of a fine payment.

This patch adds a feature in the fine payment section. It allows to see the
change due to patrons when the amount collected is higher than the amount paid.
This includes also a new system preference called FineChange which enables or
disables the feature.

Test plan :
- Apply patch.
- Make sure FineChange is at ENABLE in System preferences > Patrons.
- Select a patron with a fine.
- Go to Fines > Pay fines.
- Click the button pay.
- Choose the amount paid equal to the outstanding amount (exemple : 3$).
- Choose the amount collected to be more than the outstanding amount (exemple :
5$).
- Confirm that the change is correct (example : 5$ - 3$ = 2$).
- Click the button confirm.
- Click on Yes in the dialog box.
- Confirm that the payment has been made (example : last amount = 3$).
- Make sure FineChange is at DISABLE in System preferences > Patrons.
- Select a patron with a fine and go to Fines > Pay fines.
- Confirm that the inputs paid and change are gone.
- Choose an amount collected (exemple : 3$).
- Click the button confirm.
- Confirm that the payment has been made.

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Michal Denar  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Pierre-Marc Thibault  changed:

   What|Removed |Added

  Attachment #79759|0   |1
is obsolete||

--- Comment #64 from Pierre-Marc Thibault  ---
Created attachment 79944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79944=edit
Bug 11373: Show the difference between the amount collected and the amount paid
of a fine payment.

This patch adds a feature in the fine payment section. It allows to see the
change due to patrons when the amount collected is higher than the amount paid.
This includes also a new system preference called FineChange which enables or
disables the feature.

Test plan :
- Apply patch.
- Make sure FineChange is at ENABLE in System preferences > Patrons.
- Select a patron with a fine.
- Go to Fines > Pay fines.
- Click the button pay.
- Choose the amount paid equal to the outstanding amount (exemple : 3$).
- Choose the amount collected to be more than the outstanding amount (exemple :
5$).
- Confirm that the change is correct (example : 5$ - 3$ = 2$).
- Click the button confirm.
- Click on Yes in the dialog box.
- Confirm that the payment has been made (example : last amount = 3$).
- Make sure FineChange is at DISABLE in System preferences > Patrons.
- Select a patron with a fine and go to Fines > Pay fines.
- Confirm that the inputs paid and change are gone.
- Choose an amount collected (exemple : 3$).
- Click the button confirm.
- Confirm that the payment has been made.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #63 from Josef Moravec  ---
Comment on attachment 79759
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79759
Bug 11373: Show the difference between the amount collected and the amount paid
of a fine payment.

Review of attachment 79759:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=11373=79759)
-

Great job, just one little thing, reading the code only:

::: members/paycollect.pl
@@ +194,4 @@
>  patron=> $patron,
>  total => $total_due,
>  ExtendedPatronAttributes => 
> C4::Context->preference('ExtendedPatronAttributes'),
> +FineChange => C4::Context->preference('FineChange'),

Use Koha.Preference template plugin and do not pass system preferences as
template parameter

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Pierre-Marc Thibault  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #62 from Pierre-Marc Thibault  ---
The code is simpler and the formating is only on new lines. The change comment
is similar to the others and is not related to the bug, so it has not been
changed. A dialog box has been added, it's possible to reconfirm or not the
payment when the change isn't 0.00.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Pierre-Marc Thibault  changed:

   What|Removed |Added

  Attachment #79549|0   |1
is obsolete||

--- Comment #61 from Pierre-Marc Thibault  ---
Created attachment 79759
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79759=edit
Bug 11373: Show the difference between the amount collected and the amount paid
of a fine payment.

This patch adds a feature in the fine payment section. It allows to see the
change due to patrons when the amount collected is higher than the amount paid.
This includes also a new system preference called FineChange which enables or
disables the feature.

Test plan :
- Apply patch.
- Make sure FineChange is at ENABLE in System preferences > Patrons.
- Select a patron with a fine.
- Go to Fines > Pay fines.
- Click the button pay.
- Choose the amount paid equal to the outstanding amount (exemple : 3$).
- Choose the amount collected to be more than the outstanding amount (exemple :
5$).
- Confirm that the change is correct (example : 5$ - 3$ = 2$).
- Click the button confirm.
- Click on Yes in the dialog box.
- Confirm that the payment has been made (example : last amount = 3$).
- Make sure FineChange is at DISABLE in System preferences > Patrons.
- Select a patron with a fine and go to Fines > Pay fines.
- Confirm that the inputs paid and change are gone.
- Choose an amount collected (exemple : 3$).
- Click the button confirm.
- Confirm that the payment has been made.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Blou  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #60 from Blou  ---
This should be further simplified.

- if preference is set, UI should send to backend the exact amount, since we
presume the change has been given back.
- no need to overwrite the error_over behavior.  It will be necessary when the
pref is not set.
- in fact, the modification to members/paycollect.pl are not necessary, imo.
- if preference is set, make the change comment very obvious (color message?)
- The patch should focus on the functionality.  Do not rewrite all the format()
to $Price if not related to the feature.  This should be a separate patch.

To consider: making the submit button have a confirm popup when change is to be
given back.  Not need to go to the backend for that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Michal Denar  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Michal Denar  changed:

   What|Removed |Added

  Attachment #79538|0   |1
is obsolete||

--- Comment #59 from Michal Denar  ---
Created attachment 79549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79549=edit
Bug 11373: Show the difference between the amount collected and the amount paid
of a fine payment.

This patch adds a feature in the fine payment section. It allows to see the
change due to patrons when the amount collected is higher than the amount paid.
This includes also a new system preference called FineChange which enables or
disables the feature.

Test plan :
- Apply patch.
- Make sure FineChange is at ENABLE in System preferences > Patrons.
- Select a patron with a fine.
- Go to Fines > Pay fines.
- Click the button pay.
- Choose the amount paid equal to the outstanding amount (exemple : 3$).
- Choose the amount collected to be more than the outstanding amount (exemple :
5$)
- Confirm that the change is correct (example : 5$ - 3$ = 2$)
- Click the button confirm.
- Confirm that the payment has been made.
- Make sure FineChange is at DISABLE in System preferences > Patrons.
- Select a patron with a fine and go to Fines > Pay fines.
- Confirm that the input change is gone.
- Choose an amount collected (exemple : 3$).
- Click the button confirm.
- Confirm that the payment has been made.

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Pierre-Marc Thibault  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Pierre-Marc Thibault  changed:

   What|Removed |Added

  Attachment #79530|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Pierre-Marc Thibault  changed:

   What|Removed |Added

  Attachment #79529|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #58 from Pierre-Marc Thibault  ---
Created attachment 79538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79538=edit
Bug 11373: Show the difference between the amount collected and the amount paid
of a fine payment.

This patch adds a feature in the fine payment section. It allows to see the
change due to patrons when the amount collected is higher than the amount paid.
This includes also a new system preference called FineChange which enables or
disables the feature.

Test plan :
- Apply patch.
- Make sure FineChange is at ENABLE in System preferences > Patrons.
- Select a patron with a fine.
- Go to Fines > Pay fines.
- Click the button pay.
- Choose the amount paid equal to the outstanding amount (exemple : 3$).
- Choose the amount collected to be more than the outstanding amount (exemple :
5$)
- Confirm that the change is correct (example : 5$ - 3$ = 2$)
- Click the button confirm.
- Confirm that the payment has been made.
- Make sure FineChange is at DISABLE in System preferences > Patrons.
- Select a patron with a fine and go to Fines > Pay fines.
- Confirm that the input change is gone.
- Choose an amount collected (exemple : 3$).
- Click the button confirm.
- Confirm that the payment has been made.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #57 from Blou  ---
I've asked Pierre-Marc to squash these, since the second patch is mostly
useless, and the second one is mostly removing the first one's changes.

I know how QA will appreciate looking at this, so he's going to do a new one
that's easier to interpret (and will need sign off).  My apologies to Michal
who took the time already to sign it off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #56 from Michal Denar  ---
Created attachment 79530
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79530=edit
Bug 11373: System preference added, dialog removed, disabled input added to
show the change in the form.

This patch removes the dialog because it was redundant with the form. As the
numbers fields are formated when they are changed, it is convenient to
calculate and show the change at the same time. When the change value cannot be
calculated (amount collected < amount paid), its value is brought back to 0.00.
This includes also a new system preference called FineChange which enables or
disables the feature.

Test plan :
- Apply patch.
- Make sure FineChange is at ENABLE in System preferences > Patrons.
- Select a patron with a fine.
- Go to Fines > Pay fines.
- Click the button pay.
- Choose the amount paid equal to the outstanding amount (exemple : 3$).
- Choose the amount collected to be more than the outstanding amount (exemple :
5$)
- Confirm that the change is correct (example : 5$ - 3$ = 2$)
- Click the button confirm.
- Confirm that the payment has been made.
- Make sure FineChange is at DISABLE in System preferences > Patrons.
- Select a patron with a fine and go to Fines > Pay fines.
- Confirm that the input change is gone.
- Choose an amount collected (exemple : 3$).
- Click the button confirm.
- Confirm that the payment has been made.

https://bugs.koha-community.org/show_bug.cgi?id=11373

Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Michal Denar  changed:

   What|Removed |Added

  Attachment #79188|0   |1
is obsolete||
  Attachment #79509|0   |1
is obsolete||

--- Comment #55 from Michal Denar  ---
Created attachment 79529
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79529=edit
Bug 11373: Add a "cash register" feature to the fine payment form.

Works as intended.

Signed-off-by: Simon Pouchol 
Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Michal Denar  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Pierre-Marc Thibault  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #54 from Pierre-Marc Thibault  ---
Bug status put at Needs Signoff because many things have changed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Pierre-Marc Thibault  changed:

   What|Removed |Added

  Attachment #79507|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #53 from Pierre-Marc Thibault  ---
Created attachment 79509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79509=edit
Bug 11373: System preference added, dialog removed, disabled input added to
show the change in the form.

This patch removes the dialog because it was redundant with the form. As the
numbers fields are formated when they are changed, it is convenient to
calculate and show the change at the same time. When the change value cannot be
calculated (amount collected < amount paid), its value is brought back to 0.00.
This includes also a new system preference called FineChange which enables or
disables the feature.

Test plan :
- Apply patch.
- Make sure FineChange is at ENABLE in System preferences > Patrons.
- Select a patron with a fine.
- Go to Fines > Pay fines.
- Click the button pay.
- Choose the amount paid equal to the outstanding amount (exemple : 3$).
- Choose the amount collected to be more than the outstanding amount (exemple :
5$)
- Confirm that the change is correct (example : 5$ - 3$ = 2$)
- Click the button confirm.
- Confirm that the payment has been made.
- Make sure FineChange is at DISABLE in System preferences > Patrons.
- Select a patron with a fine and go to Fines > Pay fines.
- Confirm that the input change is gone.
- Choose an amount collected (exemple : 3$).
- Click the button confirm.
- Confirm that the payment has been made.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #52 from Pierre-Marc Thibault  ---
Created attachment 79507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79507=edit
System preference added, dialog removed, disabled input added to show the
change in the form.

This patch removes the dialog because it was redundant with the form. As the
numbers fields are formated when they are changed, it is convenient to
calculate and show the change at the same time. When the change value cannot be
calculated (amount collected < amount paid), its value is brought back to 0.00.
This includes also a new system preference called FineChange which enables or
disables the feature.

Test plan :
- Apply patch.
- Make sure FineChange is at ENABLE in System preferences > Patrons.
- Select a patron with a fine.
- Go to Fines > Pay fines.
- Click the button pay.
- Choose the amount paid equal to the outstanding amount (exemple : 3$).
- Choose the amount collected to be more than the outstanding amount (exemple :
5$)
- Confirm that the change is correct (example : 5$ - 3$ = 2$)
- Click the button confirm.
- Confirm that the payment has been made.
- Make sure FineChange is at DISABLE in System preferences > Patrons.
- Select a patron with a fine and go to Fines > Pay fines.
- Confirm that the input change is gone.
- Choose an amount collected (exemple : 3$).
- Click the button confirm.
- Confirm that the payment has been made.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Colin Campbell  changed:

   What|Removed |Added

 CC||colin.campbell@ptfs-europe.
   ||com

--- Comment #51 from Colin Campbell  ---
The commit should describe what the feature does. 'cash register feature' is
not enough as its is ambiguous as to what kind of functionality you are adding.

It might be better to handle this in javascript, theres no need to send to the
server for this calculation it could all be handled more efficiently in the
browser

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #50 from Martin Renvoize  ---
The bug description is really misleading.. this doesn't add a cash
register/till at all, rather it's just a method of displaying change to give.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #49 from Pierre-Marc Thibault  ---
I think simple is best. Instead of confirming on the form and the dialog and
then paying, there should be a disabled input which shows the change each time
a number input is changed. You get the change feedback instantly, just click
once for paying and there is no duplication data on the page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #48 from Josef Moravec  ---
(In reply to Pierre-Marc Thibault from comment #47)
> (In reply to Josef Moravec from comment #45)
> > The information on this page is duplicate:
> > 
> > https://screenshots.firefox.com/o2GtPtGugLjtJSqq/localhost
> > 
> > why do you even add the dialog?
> > 
> > Also this could be enabled disabled, please add system preference for this.
> 
> The dialog is here maybe to explain to the user why they are still on the
> page, because otherwise they just see a slight different formatted form when
> the change is not null. If the dialogue is not a matter but the duplication
> is, removing the "Change to give back:" line could be an option. 

Yes, the duplication is problem for me, now it is a bit confusing. I think the
form itself should not be there, only dialog with all the information and the
amount to give back to patron should be emphasized. 

> What do you want to add to system preferences precisely? The whole feature
> with the change? Is that what you mean by "this"?

Yes, that's exactly what I mean, because this change the behavior of pay
functionality.

> 
> Thanks for replying.

Not at all ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Pierre-Marc Thibault  changed:

   What|Removed |Added

 CC||pierre-marc.thibault@inlibr
   ||o.com

--- Comment #47 from Pierre-Marc Thibault  ---
(In reply to Josef Moravec from comment #45)
> The information on this page is duplicate:
> 
> https://screenshots.firefox.com/o2GtPtGugLjtJSqq/localhost
> 
> why do you even add the dialog?
> 
> Also this could be enabled disabled, please add system preference for this.

The dialog is here maybe to explain to the user why they are still on the page,
because otherwise they just see a slight different formatted form when the
change is not null. If the dialogue is not a matter but the duplication is,
removing the "Change to give back:" line could be an option. 

What do you want to add to system preferences precisely? The whole feature with
the change? Is that what you mean by "this"?

Thanks for replying.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #46 from Josef Moravec  ---
Comment on attachment 79188
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79188
Bug 11373: Add a "cash register" feature to the fine payment form.

Review of attachment 79188:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=11373=79188)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
@@ +75,5 @@
> +
> +The amount collected is greater than the total amount 
> paid.
> +Change to give back: [% give_change | $Price %] />
> +
> + href="/cgi-bin/koha/members/pay.pl?borrowernumber=[% patron.borrowernumber 
> %]">Cancel

use uri filter

@@ +120,5 @@
> +[% IF ( give_change ) %]
> +
> +Amount paid:
> + />
> +

use html filter

@@ +134,5 @@
> +
> +[% ELSE %]
> +
> +Amount paid:
> +

use $Price filter

@@ +141,3 @@
>  
> +Collect from patron:
> +

use $Price filter

@@ +233,5 @@
>  
> +[% IF ( give_change ) %]
> +
> +Amount paid:
> + />

use html filter

@@ +238,5 @@
> +[% amount_paid | $Price %]
> +
> +
> +Collected from patron:
> +

use html filter

@@ +248,5 @@
> +
> +[% ELSE %]
> +
> +Amount paid :
> + onchange="moneyFormat(document.payform.paid)" />

use $Price filter

@@ +259,3 @@
>  [% END %]
>  
> + onchange="moneyFormat(document.payform.collected)"/>

use $Price filter

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #45 from Josef Moravec  ---
The information on this page is duplicate:

https://screenshots.firefox.com/o2GtPtGugLjtJSqq/localhost

why do you even add the dialog?

Also this could be enabled disabled, please add system preference for this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #44 from Josef Moravec  ---
(In reply to Josef Moravec from comment #43)
> (In reply to Blou from comment #41)
> > Fixed the rest, but for the padding in the button, we'll need to find
> > another solution since an  under a class="dialog message" will show
> > like that.  Not sure why the staff.css specifies that padding, but clearly
> > having a confirm button in a message dialog is not the standard Koha way.
> 
> That is because you should have icon on that button - try to add a
> class="approve" to button.

And add the icon itself like this:


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Josef Moravec  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #43 from Josef Moravec  ---
(In reply to Blou from comment #41)
> Fixed the rest, but for the padding in the button, we'll need to find
> another solution since an  under a class="dialog message" will show
> like that.  Not sure why the staff.css specifies that padding, but clearly
> having a confirm button in a message dialog is not the standard Koha way.

That is because you should have icon on that button - try to add a
class="approve" to button.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Michal Denar  changed:

   What|Removed |Added

  Attachment #79171|0   |1
is obsolete||

--- Comment #42 from Michal Denar  ---
Created attachment 79188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79188=edit
Bug 11373: Add a "cash register" feature to the fine payment form.

Works as intended.

Signed-off-by: Simon Pouchol 
Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Michal Denar  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #41 from Blou  ---
Fixed the rest, but for the padding in the button, we'll need to find another
solution since an  under a class="dialog message" will show like that. 
Not sure why the staff.css specifies that padding, but clearly having a confirm
button in a message dialog is not the standard Koha way.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Blou  changed:

   What|Removed |Added

  Attachment #79122|0   |1
is obsolete||

--- Comment #40 from Blou  ---
Created attachment 79171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79171=edit
Bug 11373: Add a "cash register" feature to the fine payment form.

Works as intended.

Signed-off-by: Simon Pouchol 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Michal Denar  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #39 from Michal Denar  ---
Hi  Blou,
Great work. I've just some findings.
Patch is working,but:
- confirmation button has some formatting problem = https://prnt.sc/kwd2do
- Cancel link is broken, without borrower number
(http://localhost:8081/cgi-bin/koha/members/pay.pl?borrowernumber=)
- this funkcnionaly should be optional, so weneed enable=disable it from
administration menu

Just two steps to heaven :-)

Thank You

Mike

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #38 from Blou  ---
Patch did not apply.  Rebased.  Where is the commit message gone?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Blou  changed:

   What|Removed |Added

  Attachment #77584|0   |1
is obsolete||

--- Comment #37 from Blou  ---
Created attachment 79122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79122=edit
Bug 11373: Add a "cash register" feature to the fine payment form.

Works as intended.

Signed-off-by: Simon Pouchol 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Blou  changed:

   What|Removed |Added

  Attachment #77585|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Charles Farmer  changed:

   What|Removed |Added

  Attachment #71976|0   |1
is obsolete||

--- Comment #36 from Charles Farmer  ---
Created attachment 77585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77585=edit
Bug 11373: Follow-up after code review

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Charles Farmer  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Charles Farmer  changed:

   What|Removed |Added

  Attachment #71975|0   |1
is obsolete||

--- Comment #35 from Charles Farmer  ---
Created attachment 77584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77584=edit
Bug 11373: Add a "cash register" feature to the fine payment form.

Works as intended.

Signed-off-by: Simon Pouchol 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Charles Farmer  changed:

   What|Removed |Added

   Assignee|maxime.beaul...@inlibro.com |charles.far...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #34 from Katrin Fischer  ---
> Following your comments, I made cosmetic adjustments to the previous patch:
> -  no longer present in alert dialog
> - I also toned down from 'exclamation mark' to a simple period
> - removed the dangling space before ':'
> - server side formatting was changed from sprintf to $Price
> - I also removed the formatting in the  fields. It made no
> sense to me that formatting was used for data traveling between the page and
> the server, unbeknown to the user.

Thx!


> About the behavior of the form: I agree with you, the UX should definitely
> be more user-friendly. Now, I'm open to changes, but I'd rather implement
> everything once we reach a consensus on how it should behave than doing
> "flavors" of the same patch just for QA. Nothing personal ;)
> 
> I'll put this back to 'Needs signoff', for now, just to make it clear that I
> want people testing this patch, but feel free to dial it back to "Failed QA"
> or "In discussion". I'll be keeping a close eye on this.

I totally agree with this approach. It might make sense to ask on the mailing
list as well to get some attention on this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Charles Farmer  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #33 from Charles Farmer  ---
Hi Katrin,

Following your comments, I made cosmetic adjustments to the previous patch:
-  no longer present in alert dialog
- I also toned down from 'exclamation mark' to a simple period
- removed the dangling space before ':'
- server side formatting was changed from sprintf to $Price
- I also removed the formatting in the  fields. It made no sense
to me that formatting was used for data traveling between the page and the
server, unbeknown to the user.

About the behavior of the form: I agree with you, the UX should definitely be
more user-friendly. Now, I'm open to changes, but I'd rather implement
everything once we reach a consensus on how it should behave than doing
"flavors" of the same patch just for QA. Nothing personal ;)

I'll put this back to 'Needs signoff', for now, just to make it clear that I
want people testing this patch, but feel free to dial it back to "Failed QA" or
"In discussion". I'll be keeping a close eye on this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Charles Farmer  changed:

   What|Removed |Added

  Attachment #70043|0   |1
is obsolete||

--- Comment #31 from Charles Farmer  ---
Created attachment 71975
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71975=edit
Bug 11373: Add a "cash register" feature to the fine payment form.

Works as intended.

Signed-off-by: Simon Pouchol 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #32 from Charles Farmer  ---
Created attachment 71976
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71976=edit
Bug 11373: Follow-up after code review

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Katrin Fischer  changed:

   What|Removed |Added

 Status|In Discussion   |Failed QA
Summary|Add a "cash register"   |Add a "cash register"
   |feature to the fine payment |feature to the fine payment
   |form.   |form

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Katrin Fischer  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz,
   ||oleon...@myacpl.org
 Status|Signed Off  |In Discussion

--- Comment #30 from Katrin Fischer  ---
> I am wondering about the usability here. For paying a partial fine I am
> forced to manually edit 2 input fields which adds more steps for the busy
> circulation desk and also might cause more potential for errors. Maybe it
> would make sense to automatically change the amount collected to the amount
> paid when it's changed? Or to make this optional?
> 
> I'd like to get some librarians to weigh in on these changes if possible. 

Another idea: leave the amount collected empty initially, meaning the amount
paid equals the amount collected. And only have people enter an amount if that
isn't the case. That means you could still collect payments without extra
clicks needed as before, but when you need it use of the field will be easier
as you don't need to ovrwrite/delete the amount in it first.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #29 from Katrin Fischer  ---
Comment on attachment 70043
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70043
Bug 11373: Add a "cash register" feature to the fine payment form.

Review of attachment 70043:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=11373=70043)
-

I am wondering about the usability here. For paying a partial fine I am forced
to manually edit 2 input fields which adds more steps for the busy circulation
desk and also might cause more potential for errors. Maybe it would make sense
to automatically change the amount collected to the amount paid when it's
changed? Or to make this optional?

I'd like to get some librarians to weigh in on these changes if possible. 

Some other small issues noted below. QA tools are clean.

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
@@ +98,5 @@
>  
>  
> +[% IF (error_negative) %]
> +
> +The amount paid can't be negative!

Why the additional spans everywhere? A message inside a div should not need it
(see also other cases below).

@@ +175,5 @@
> +[% give_change %]
> +
> +[% ELSE %]
> +
> +Amount paid :

No additional spaces between text and : please :)

::: members/paycollect.pl
@@ +128,5 @@
> +elsif ($total_paid < $total_due and $total_collected ne $total_paid) {
> + $template->param(
> +amount_paid => sprintf('%.2f', $total_paid),
> +amount_collected => sprintf('%.2f', $total_collected),
> +give_change => sprintf('%.2f',($total_collected-$total_paid))

I am wondering about the formatting done in various spots in the patch. I'll
ask a second opinion about that. Please note that we have a TT plugin for
displaying prices in different ways and CurrencyFormat system preference
(entering prices still happens with . ).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Charles Farmer  changed:

   What|Removed |Added

 CC||charles.far...@inlibro.com

--- Comment #28 from Charles Farmer  ---
Necessary rebase to apply on current master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Charles Farmer  changed:

   What|Removed |Added

  Attachment #68296|0   |1
is obsolete||

--- Comment #27 from Charles Farmer  ---
Created attachment 70043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70043=edit
Bug 11373: Add a "cash register" feature to the fine payment form.

Works as intended.

Signed-off-by: Simon Pouchol 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Fiona Borthwick  changed:

   What|Removed |Added

 CC||fiona.borthwick@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Simon Pouchol  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||simon.pouc...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Simon Pouchol  changed:

   What|Removed |Added

  Attachment #67348|0   |1
is obsolete||

--- Comment #26 from Simon Pouchol  ---
Created attachment 68296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68296=edit
Bug 11373: Add a "cash register" feature to the fine payment form.

Works as intended.

Signed-off-by: Simon Pouchol 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

David Bourgault  changed:

   What|Removed |Added

  Attachment #61233|0   |1
is obsolete||
  Attachment #61234|0   |1
is obsolete||

--- Comment #25 from David Bourgault  ---
Created attachment 67348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67348=edit
Bug 11373: Add a "cash register" feature to the fine payment form.

If the amount received is greater than the amount to pay, a message is
shown to tell the employee how much money to give back.

This obsoletes (both) previous patches that did not apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

David Bourgault  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitai...@ccsr.qc.
   ||ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Philippe Audet-Fortin  changed:

   What|Removed |Added

 CC||philippe.audet-fortin@inlib
   ||ro.com

--- Comment #24 from Philippe Audet-Fortin  
---
It looks perfects!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Rozenn Davenel  changed:

   What|Removed |Added

 CC||rozenn.davenel@mairie-vitre
   ||.fr

--- Comment #23 from Rozenn Davenel  ---
It works.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Koha Team Lyon 3  changed:

   What|Removed |Added

 CC||k...@univ-lyon3.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #22 from sandbo...@biblibre.com  ---
Created attachment 61234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61234=edit
Bug 11373 - Fixed: 'Change to give back' not displaying.

I tested the last patch and found that the case 'amount oustanding == amount
paid' was not handled in paycollect.p .
The confirmation box should now appear when those values are equal and the
amount collected is higher than the amount paid.

I have found another problem while testing.
When paying all fines or selected fines, the 'The amount collected is greater
than the total amount paid.' message would appear even when the entered data
was correct.

Both issues were adressed in this patch.
modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
modified:   members/paycollect.pl

Signed-off-by: Candice Hope 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #60529|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #60528|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #20 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Candice Hope 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #19 from Mehdi Hamidi  ---
I rebased the patches and now they apply properly.
I removed the changes in the file C4/Accounts.pm since the sub
makepartialpayment was moved and renamed to sub pay in Koha/Accounts.pm, the
patch works fine with the new changes.

I obsoleted the second patch which contained the tests for C4/Accounts.pm,
because the module has it's own test files.

I added a test plan everyone can test it.

Test Plan
1) Apply patch
2) Select a patron with a fine.
3) Go to the selected details patron.
4) Go to the fines tab.
5) Click the button pay amount or pay selected.
6) Choose the amount paid equal to the outstanding amount(exemple : 3$).
7) Choose the amount collected to be more than the outstanding amount(exemple
:5$)
8) Click the button confirm.
- You should be prompted with a message saying : "Change to give back: 2.00"
9) Click on the button above Confirm payment.

The selected patron should not have an outstanding fines left.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Mehdi Hamidi  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #18 from Mehdi Hamidi  ---
Created attachment 60529
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60529=edit
Bug 11373 - Fixed: 'Change to give back' not displaying.

I tested the last patch and found that the case 'amount oustanding == amount
paid' was not handled in paycollect.p .
The confirmation box should now appear when those values are equal and the
amount collected is higher than the amount paid.

I have found another problem while testing.
When paying all fines or selected fines, the 'The amount collected is greater
than the total amount paid.' message would appear even when the entered data
was correct.

Both issues were adressed in this patch.
modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
modified:   members/paycollect.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Mehdi Hamidi  changed:

   What|Removed |Added

  Attachment #36875|0   |1
is obsolete||
  Attachment #36876|0   |1
is obsolete||
  Attachment #36877|0   |1
is obsolete||

--- Comment #17 from Mehdi Hamidi  ---
Created attachment 60528
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60528=edit
Bug 11373: Add a "cash register" feature to the fine payment form.

If the amount received is greater than the amount to pay, a message is
shown to tell the employee how much money to give back.

Signed-off-by: Joel Aloi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Mehdi Hamidi  changed:

   What|Removed |Added

 CC||mehdi.ham...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Nicole C. Engard  changed:

   What|Removed |Added

 CC|neng...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Eric Bégin  changed:

   What|Removed |Added

 CC|ahmed.sfa...@inlibro.com,   |
   |maxime.beaul...@inlibro.com |
   |,   |
   |simith.dolive...@inlibro.co |
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||ve...@veron.ch

--- Comment #16 from Marc Véron  ---
Patch does not apply.
Auto-merging members/paycollect.pl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
Auto-merging C4/Accounts.pm
CONFLICT (content): Merge conflict in C4/Accounts.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Jason Burds  changed:

   What|Removed |Added

 CC||jbu...@dubuque.lib.ia.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=15654

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #15 from M. Tompsett  ---
Comment on attachment 36875
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36875
Bug 11373: Add a "cash register" feature to the fine payment form.

Review of attachment 36875:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=11373=36875)
-

Changing the sign of what was there before would need something done during
upgrade to change it to a new way of processing. This wasn't done, so frankly,
I think the logic I highlighted is broken. Though, admittedly, I did not run
this code yet.

::: C4/Accounts.pm
@@ +722,5 @@
>  my $insert = 'INSERT INTO accountlines (borrowernumber, accountno, date, 
> amount, '
>  .  'description, accounttype, amountoutstanding, itemnumber, manager_id, 
> note) '
>  . ' VALUES (?, ?, now(), ?, ?, ?, 0, ?, ?, ?)';
>  
> +$dbh->do(  $insert, undef, $borrowernumber, $nextaccntno, $payment,

0-$amount is the negative of $amount. This is a vast change! Is this correct?

@@ +728,5 @@
>  
>  UpdateStats({
>  branch => $user,
>  type => 'payment',
> +amount => $payment,

This is 0-$amount which is the negative of what was put here before.

@@ +739,4 @@
>  action=> 'create_payment',
>  borrowernumber=> $user,
>  accountno => $nextaccntno,
> +amount=> $payment,

On a positive note, by putting $payment earlier, it can be used nicely here.

@@ +820,4 @@
>  UpdateStats({
>  branch => $branch,
>  type => 'writeoff',
> +amount => $payment,

Again, 0-$amount is negative of what was there before.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a cash register feature to the fine payment form.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Maxime Beaulieu maxime.beaul...@inlibro.com changed:

   What|Removed |Added

  Attachment #26108|0   |1
is obsolete||

--- Comment #11 from Maxime Beaulieu maxime.beaul...@inlibro.com ---
Created attachment 36875
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36875action=edit
Bug 11373: Add a cash register feature to the fine payment form.

If the amount received is greater than the amount to pay, a message is
shown to tell the employee how much money to give back.

Signed-off-by: Joel Aloi alo...@live.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a cash register feature to the fine payment form.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Maxime Beaulieu maxime.beaul...@inlibro.com changed:

   What|Removed |Added

  Attachment #29757|0   |1
is obsolete||

--- Comment #12 from Maxime Beaulieu maxime.beaul...@inlibro.com ---
Created attachment 36876
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36876action=edit
Bug 11373 - Unit tests for Accounts.pm

I added unit tests for the modified subs in C4/Accounts.pm.
makepartialpayment()
WriteOffFee()

modified:   t/db_dependent/Accounts.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a cash register feature to the fine payment form.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Maxime Beaulieu maxime.beaul...@inlibro.com changed:

   What|Removed |Added

  Attachment #29938|0   |1
is obsolete||

--- Comment #13 from Maxime Beaulieu maxime.beaul...@inlibro.com ---
Created attachment 36877
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36877action=edit
Bug 11373 - Fixed: 'Change to give back' not displaying.

I tested the last patch and found that the case 'amount oustanding == amount
paid' was not handled in paycollect.p .
The confirmation box should now appear when those values are equal and the
amount collected is higher than the amount paid.

I have found another problem while testing.
When paying all fines or selected fines, the 'The amount collected is greater
than the total amount paid.' message would appear even when the entered data
was correct.

Both issues were adressed in this patch.
modified:   koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
modified:   members/paycollect.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a cash register feature to the fine payment form.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Maxime Beaulieu maxime.beaul...@inlibro.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #14 from Maxime Beaulieu maxime.beaul...@inlibro.com ---
Fixed the conflicts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a cash register feature to the fine payment form.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Maxime Beaulieu maxime.beaul...@inlibro.com changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a cash register feature to the fine payment form.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #10 from Nicole C. Engard neng...@gmail.com ---
Am I supposed to apply to all these patches? I got the following:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 11373: Add a cash register feature to the fine payment form.
/home/nengard/kohaclone/.git/rebase-apply/patch:242: trailing whitespace.
$template-param( 
/home/nengard/kohaclone/.git/rebase-apply/patch:247: trailing whitespace.
$template-param( 
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
stdin:242: trailing whitespace.
$template-param( 
stdin:247: trailing whitespace.
$template-param( 
warning: 2 lines applied after fixing whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging members/paycollect.pl
Auto-merging C4/Accounts.pm
CONFLICT (content): Merge conflict in C4/Accounts.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 11373: Add a cash register feature to the fine
payment form.
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Patch left in
/tmp/Bug-11373-Add-a-cash-register-feature-to-the-fine--I0lypc.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a cash register feature to the fine payment form.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Ahmed ahmed.sfa...@inlibro.com changed:

   What|Removed |Added

 CC||ahmed.sfa...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a cash register feature to the fine payment form.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Blou philippe.blo...@inlibro.com changed:

   What|Removed |Added

 CC||simith.dolive...@inlibro.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a cash register feature to the fine payment form.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Maxime Beaulieu maxime.beaul...@inlibro.com changed:

   What|Removed |Added

 CC||eric.be...@inlibro.com,
   ||philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a cash register feature to the fine payment form.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Maxime Beaulieu maxime.beaul...@inlibro.com changed:

   What|Removed |Added

   Assignee|fcapovi...@live.ca  |maxime.beaul...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a cash register feature to the fine payment form.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Maxime Beaulieu maxime.beaul...@inlibro.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a cash register feature to the fine payment form.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Francois Charbonnier francois.charbonn...@inlibro.com changed:

   What|Removed |Added

 CC||francois.charbonnier@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a cash register feature to the fine payment form.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #9 from Maxime Beaulieu maxime.beaul...@inlibro.com ---
Created attachment 29938
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29938action=edit
Bug 11373 - Fixed: 'Change to give back' not displaying.

I tested the last patch and found that the case 'amount oustanding == amount
paid' was not handled in paycollect.p .
The confirmation box should now appear when those values are equal and the
amount collected is higher than the amount paid.

I have found another problem while testing.
When paying all fines or selected fines, the 'The amount collected is greater
than the total amount paid.' message would appear even when the entered data
was correct.

Both issues were adressed in this patch.
modified:   koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
modified:   members/paycollect.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] Add a cash register feature to the fine payment form.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I am sorry, but this doesn't seem to work for me. I have added various fines
and fees to my patron account. Then I chose Pay amount and changed the
collected from patron value to be higher than the total amount owed. I didn't
see anything telling me how much change to give back to the patron. The open
fines were paid and the additional money was 'lost'.

The same happens for paying individual fines.

Please retest.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/