https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Martin Renvoize changed:
What|Removed |Added
Status|Pushed to Stable|RESOLVED
Resoluti
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Martin Renvoize changed:
What|Removed |Added
CC||martin.renvoize@ptfs-europ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Katrin Fischer changed:
What|Removed |Added
CC||bar...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Pushed to Master
--- Comm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
--- Comment #41 from Kyle M Hall ---
Created attachment 74169
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74169&action=edit
Bug 12123 - Make iframe large enough to remove scroll bars
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
--- Comment #40 from Jonathan Druart
---
We are going to use iframe with a weird display (scrollbars) to catch possible
malformed notices.
I still do not like the solution.
Something else to suggest?
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Kyle M Hall changed:
What|Removed |Added
Attachment #74113|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Kyle M Hall changed:
What|Removed |Added
Status|In Discussion |Passed QA
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
--- Comment #39 from Kyle M Hall ---
(In reply to Marcel de Rooy from comment #35)
> The example Kyle suggested in comment26 is sufficient to demonstrate that
> this patch makes a difference. I recommend to restore PQA status and mov
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
--- Comment #38 from Kyle M Hall ---
It seems like the consensus is that the new alternative patch is not
acceptable.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
--- Comment #37 from David Cook ---
(In reply to Katrin Fischer from comment #36)
> Be careful with the check - HTML5 is not valid XML. Unclosed tags are
> perfectly valid. Often browsers are forgiving and probably mail clients too.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
--- Comment #36 from Katrin Fischer ---
Be careful with the check - HTML5 is not valid XML. Unclosed tags are
perfectly valid. Often browsers are forgiving and probably mail clients too. We
don't want to break display in more cases
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
--- Comment #35 from Marcel de Rooy ---
The example Kyle suggested in comment26 is sufficient to demonstrate that this
patch makes a difference. I recommend to restore PQA status and move the html
check to a new report.
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
--- Comment #34 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #32)
> I'd like your opinions on this alternative patch.
Can we add that test to saving the letter in tools/letter.pl ?
I would rather test once if we
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
--- Comment #33 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #32)
> I'd like your opinions on this alternative patch.
Your patch will definitely fix any issues with malformed html, but it doesn't
check to see if th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |In Discussion
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
--- Comment #31 from Jonathan Druart
---
Created attachment 74113
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74113&action=edit
[ALTERNATIVE-PATCH] Bug 12123: Do not render HTML in notice viewer if invalid
If
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment #30
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
--- Comment #29 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #27)
> Still working.
>
> SO is from 2014, Marcel did not confirm it recreates the issues.
>
> Switch back to NSO.
Demonstration of bug with and withou
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
--- Comment #28 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #27)
> Still working.
>
> SO is from 2014, Marcel did not confirm it recreates the issues.
Will have another look at this report tomorrow.
--
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
--- Comment #26 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #25)
> Still works:
> https://screenshots.firefox.com/XkVBMvtHEg4P3sfT/pro.kohadev.org
> https://screenshots.firefox.com/cmfWvx4WeOHNkELn/pro.kohadev.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
--- Comment #25 from Jonathan Druart
---
Still works:
https://screenshots.firefox.com/XkVBMvtHEg4P3sfT/pro.kohadev.org
https://screenshots.firefox.com/cmfWvx4WeOHNkELn/pro.kohadev.org
--
You are receiving this mail because:
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
--- Comment #24 from Kyle M Hall ---
Try something like:
<>
Thank you for visiting <>.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
--- Comment #23 from Jonathan Druart
---
I tried that:
The following items have been checked out:
<>
Thank you for visiting <>.
And it looks ok.
--
You are receiving this mail because:
You are watching all bug change
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
--- Comment #22 from Kyle M Hall ---
(In reply to Katrin Fischer from comment #21)
> I've tried it with the example from the commit message in Firefox and
> Chromium and no problems found (without patch). Maybe something is missing
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
--- Comment #21 from Katrin Fischer ---
I've tried it with the example from the commit message in Firefox and Chromium
and no problems found (without patch). Maybe something is missing from the test
plan?
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Marcel de Rooy changed:
What|Removed |Added
Attachment #73650|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Marcel de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Kyle M Hall changed:
What|Removed |Added
Attachment #33876|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Kyle M Hall changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Kyle M Hall changed:
What|Removed |Added
Status|REOPENED|Needs Signoff
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Kyle M Hall changed:
What|Removed |Added
Attachment #33876|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Kyle M Hall changed:
What|Removed |Added
Attachment #33976|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Kyle M Hall changed:
What|Removed |Added
Status|CLOSED |REOPENED
Resolution|F
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Tom Misilo changed:
What|Removed |Added
CC||misi...@fit.edu
--
You are rec
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Chris Cormack changed:
What|Removed |Added
Status|Pushed to Master|Pushed to Stable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Passed QA |Pushed to Master
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are recei
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Katrin Fischer changed:
What|Removed |Added
Attachment #33950|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--- Co
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Owen Leonard changed:
What|Removed |Added
Attachment #33885|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receiv
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Liz Rea changed:
What|Removed |Added
Attachment #33885|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
David Cook changed:
What|Removed |Added
Attachment #33885|1 |0
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Liz Rea changed:
What|Removed |Added
Attachment #33876|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Liz Rea changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--
You are receivin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
Patch complexity
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Owen Leonard changed:
What|Removed |Added
Attachment #33863|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Kyle M Hall changed:
What|Removed |Added
Attachment #27403|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are rece
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #4 from
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
jdem...@roseville.ca.us changed:
What|Removed |Added
CC||jdem...@roseville.c
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Kyle M Hall changed:
What|Removed |Added
Attachment #27402|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Kyle M Hall changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
--- Comment #1 from Kyle M Hall ---
Created attachment 27402
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27402&action=edit
Bug 12123 - HTML notices can break the notice viewer
--
You are receiving this mail beca
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123
Kyle M Hall changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are rece
62 matches
Mail list logo
