[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Brendan Lawlor changed: What|Removed |Added Text to go in the||This enhancement adds the release notes||ability for report runtime ||parameters to allow ||selecting multiple options ||from the list of authorized ||values. || ||**Usage**: `WHERE ||branchcode IN <>` -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Katrin Fischer changed: What|Removed |Added Keywords|rel_24_05_candidate,| |RM_priority | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 --- Comment #39 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 --- Comment #38 from Katrin Fischer --- Applies now! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 --- Comment #37 from Brendan Lawlor --- (In reply to Katrin Fischer from comment #34) > Can you please rebase and re-attach both of those patches? If you need help > please let us know! I think maybe the problem was that I submitted the follow up by itself. Hopefully I did it the right way this time. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 --- Comment #36 from Brendan Lawlor --- Created attachment 165660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165660=edit Bug 35746: (follow-up) Fix invalid tt in html tag -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Brendan Lawlor changed:
What|Removed |Added
Attachment #165333|0 |1
is obsolete||
Attachment #165345|0 |1
is obsolete||
--- Comment #35 from Brendan Lawlor ---
Created attachment 165659
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165659=edit
Bug 35746: add multiselect to report dropdowns
Rebased for changes to guided_reports_start.tt
This patch adds the ability to use multi select in report dropdowns.
It uses syntax similar to using a list and when using the :all option
WHERE i.homebranch in <>
Test plan:
1. Create an SQL report with with new syntax for multi select
SELECT
i.homebranch,
count(*)
FROM items i
WHERE i.homebranch in <>
GROUP BY i.homebranch
2. Save the report
3. Note that you get the error
The authorized value category (branches:in) you selected does not exist.
4. Apply the patch and repeat steps 1 and 2
5. Note the report saves successfully
6. Run the report
7. Note the select dropdown is now a multiselect
8. Run the report with multiple selections
10. Click show SQL and note that multi select parameters get inserted into the
query like:
WHERE i.homebranch in ('CPL', 'FFL', 'FPL')
11. Test other types of queries with multiple multi selects and lists etc
Sponsored-by: CLAMS
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Nick Clemens
Signed-off-by: Lucas Gass
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Brendan Lawlor changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Patch doesn't apply --- Comment #34 from Katrin Fischer --- I am sorry, I have trouble with the second patch: git bz apply 35746 Bug 35746 - Multiple selections for parameters used in the IN function 165333 - Bug 35746: add multiselect to report dropdowns 165345 - Bug 35746: (follow-up) Fix invalid tt in html tag Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 35746: add multiselect to report dropdowns Applying: Bug 35746: (follow-up) Fix invalid tt in html tag error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt). error: could not build fake ancestor Patch failed at 0001 Bug 35746: (follow-up) Fix invalid tt in html tag Can you please rebase and re-attach both of those patches? If you need help please let us know! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 --- Comment #33 from Katrin Fischer --- Thx for the follow-up! I'll be back asap. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 --- Comment #32 from Brendan Lawlor --- (In reply to Lucas Gass from comment #28) > This changes the :all option into from a single select dropdown to a multi > one. I don't think that is necessarily bad, could be handy actually! Good catch Lucas! I think that this should not happen because it would change how current reports work. There could be cases where you only want a parameter to be single choice or the all option but not multi select. The original patch relied on the value of the template variable always being put in the html tag as either the attribute 'multiple' or as an empty string for single selects. My understanding is that causes a problem with translations. I changed one conditional so that only selects that should be multi will get the multiple attribute and it doesn't have invalid TT inside the select tag so it passes the test too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Brendan Lawlor changed: What|Removed |Added Attachment #165334|0 |1 is obsolete|| --- Comment #31 from Brendan Lawlor --- Created attachment 165345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165345=edit Bug 35746: (follow-up) Fix invalid tt in html tag -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Lucas Gass changed: What|Removed |Added Attachment #165276|0 |1 is obsolete|| --- Comment #30 from Lucas Gass --- Created attachment 165334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165334=edit Bug 35746: (follow-up) Fix invalid TT syntax inside html tag Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Lucas Gass changed:
What|Removed |Added
Attachment #163921|0 |1
is obsolete||
--- Comment #29 from Lucas Gass ---
Created attachment 165333
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165333=edit
Bug 35746: add multiselect to report dropdowns
Rebased for changes to guided_reports_start.tt
This patch adds the ability to use multi select in report dropdowns.
It uses syntax similar to using a list and when using the :all option
WHERE i.homebranch in <>
Test plan:
1. Create an SQL report with with new syntax for multi select
SELECT
i.homebranch,
count(*)
FROM items i
WHERE i.homebranch in <>
GROUP BY i.homebranch
2. Save the report
3. Note that you get the error
The authorized value category (branches:in) you selected does not exist.
4. Apply the patch and repeat steps 1 and 2
5. Note the report saves successfully
6. Run the report
7. Note the select dropdown is now a multiselect
8. Run the report with multiple selections
10. Click show SQL and note that multi select parameters get inserted into the
query like:
WHERE i.homebranch in ('CPL', 'FFL', 'FPL')
11. Test other types of queries with multiple multi selects and lists etc
Sponsored-by: CLAMS
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Nick Clemens
Signed-off-by: Lucas Gass
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Lucas Gass changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #28 from Lucas Gass --- This changes the :all option into from a single select dropdown to a multi one. I don't think that is necessarily bad, could be handy actually! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 --- Comment #27 from Brendan Lawlor --- Thanks for pointing out where to run that test. I had only ran the qa test before. I fixed the invalid TT syntax inside the html tag so it now passes: $ ./xt/tt_valid.t 1..3 ok 1 - TT syntax: not using TT directive within HTML tag ok 2 - tag with id and class attributes ok 3 - Token received same as original put on stack Bug 35856 includes a hint for this in the runtime parameter modal too. Should I change the status of that bug from Blocked back to Signed off? Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Brendan Lawlor changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 --- Comment #26 from Brendan Lawlor --- Created attachment 165276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165276=edit Bug 35746: (follow-up) Fix invalid TT syntax inside html tag -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Failed QA Keywords||release-notes-needed, ||rel_24_05_candidate, ||RM_priority --- Comment #25 from Katrin Fischer --- Nice work! We have a small issue with a failing test: xt/tt_valid.t 1/3 # Failed test 'TT syntax: not using TT directive within HTML tag' # at xt/tt_valid.t line 91. # Files list: # intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt: 879 # Looks like you failed 1 test of 3. xt/tt_valid.t Dubious, test returned 1 (wstat 256, 0x100) Can you please fix? I wonder if we could also add it to the runtime parameters menu somehow for some advertising? (see bug 35856 maybe for reference, also: this is for a separate bug and not a blocker!) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Michelle Spinney changed: What|Removed |Added CC||mspin...@clamsnet.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 --- Comment #24 from Nick Clemens --- I played around to see if we could do the same thing without JS, but the way we get the params makes it tricky to use the multi-select directly. This works well, is easy to read, excellent work! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Nick Clemens changed:
What|Removed |Added
Attachment #163920|0 |1
is obsolete||
--- Comment #23 from Nick Clemens ---
Created attachment 163921
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163921=edit
Bug 35746: add multiselect to report dropdowns
Rebased for changes to guided_reports_start.tt
This patch adds the ability to use multi select in report dropdowns.
It uses syntax similar to using a list and when using the :all option
WHERE i.homebranch in <>
Test plan:
1. Create an SQL report with with new syntax for multi select
SELECT
i.homebranch,
count(*)
FROM items i
WHERE i.homebranch in <>
GROUP BY i.homebranch
2. Save the report
3. Note that you get the error
The authorized value category (branches:in) you selected does not exist.
4. Apply the patch and repeat steps 1 and 2
5. Note the report saves successfully
6. Run the report
7. Note the select dropdown is now a multiselect
8. Run the report with multiple selections
10. Click show SQL and note that multi select parameters get inserted into the
query like:
WHERE i.homebranch in ('CPL', 'FFL', 'FPL')
11. Test other types of queries with multiple multi selects and lists etc
Sponsored-by: CLAMS
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Andrew Fuerste-Henry changed:
What|Removed |Added
Attachment #163875|0 |1
is obsolete||
--- Comment #22 from Andrew Fuerste-Henry ---
Created attachment 163920
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163920=edit
Bug 35746: add multiselect to report dropdowns
Rebased for changes to guided_reports_start.tt
This patch adds the ability to use multi select in report dropdowns.
It uses syntax similar to using a list and when using the :all option
WHERE i.homebranch in <>
Test plan:
1. Create an SQL report with with new syntax for multi select
SELECT
i.homebranch,
count(*)
FROM items i
WHERE i.homebranch in <>
GROUP BY i.homebranch
2. Save the report
3. Note that you get the error
The authorized value category (branches:in) you selected does not exist.
4. Apply the patch and repeat steps 1 and 2
5. Note the report saves successfully
6. Run the report
7. Note the select dropdown is now a multiselect
8. Run the report with multiple selections
10. Click show SQL and note that multi select parameters get inserted into the
query like:
WHERE i.homebranch in ('CPL', 'FFL', 'FPL')
11. Test other types of queries with multiple multi selects and lists etc
Sponsored-by: CLAMS
Signed-off-by: Andrew Fuerste Henry
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Brendan Lawlor changed:
What|Removed |Added
Attachment #162303|0 |1
is obsolete||
--- Comment #21 from Brendan Lawlor ---
Created attachment 163875
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163875=edit
Bug 35746: add multiselect to report dropdowns
Rebased for changes to guided_reports_start.tt
This patch adds the ability to use multi select in report dropdowns.
It uses syntax similar to using a list and when using the :all option
WHERE i.homebranch in <>
Test plan:
1. Create an SQL report with with new syntax for multi select
SELECT
i.homebranch,
count(*)
FROM items i
WHERE i.homebranch in <>
GROUP BY i.homebranch
2. Save the report
3. Note that you get the error
The authorized value category (branches:in) you selected does not exist.
4. Apply the patch and repeat steps 1 and 2
5. Note the report saves successfully
6. Run the report
7. Note the select dropdown is now a multiselect
8. Run the report with multiple selections
10. Click show SQL and note that multi select parameters get inserted into the
query like:
WHERE i.homebranch in ('CPL', 'FFL', 'FPL')
11. Test other types of queries with multiple multi selects and lists etc
Sponsored-by: CLAMS
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Brendan Lawlor changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 --- Comment #20 from Brendan Lawlor --- Thanks for testing Caroline! Originally I envisioned that you would write it with parentheses something like: WHERE i.itemtype IN (<>) but it piggybacks on the code that implemented the list run time parameter so you have to write it the same way without parentheses -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #19 from Caroline Cyr La Rose ---
(In reply to Caroline Cyr La Rose from comment #18)
> I just tested it again on KTD and it gives me a weird error.
>
> For the same report, my local installation returns
>
> SELECT
> i.homebranch,
> count(*)
> FROM items i
> WHERE i.homebranch in ('CPL','MPL')
> GROUP BY i.homebranch /* saved_sql.id: 16 */
>
> And KTD returns
>
> SELECT
> i.homebranch,
> count(*)
> FROM items i
> WHERE i.homebranch in 'CPL\r\nMPL'
> GROUP BY i.homebranch /* saved_sql.id: 1 */
>
> I'm not used to KTD yet, so I don't know what causes the difference. But it
> definitely works on my local Koha.
I saw that it was the parentheses. My local Koha adds parentheses, but KTD does
not.
(In reply to Caroline Cyr La Rose from comment #18)
> I just tested it again on KTD and it gives me a weird error.
>
> For the same report, my local installation returns
>
> SELECT
> i.homebranch,
> count(*)
> FROM items i
> WHERE i.homebranch in ('CPL','MPL')
> GROUP BY i.homebranch /* saved_sql.id: 16 */
>
> And KTD returns
>
> SELECT
> i.homebranch,
> count(*)
> FROM items i
> WHERE i.homebranch in 'CPL\r\nMPL'
> GROUP BY i.homebranch /* saved_sql.id: 1 */
>
> I'm not used to KTD yet, so I don't know what causes the difference. But it
> definitely works on my local Koha.
Nevermind, I restarted KTD and it's fine! Sorry about that!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #18 from Caroline Cyr La Rose ---
I just tested it again on KTD and it gives me a weird error.
For the same report, my local installation returns
SELECT
i.homebranch,
count(*)
FROM items i
WHERE i.homebranch in ('CPL','MPL')
GROUP BY i.homebranch /* saved_sql.id: 16 */
And KTD returns
SELECT
i.homebranch,
count(*)
FROM items i
WHERE i.homebranch in 'CPL\r\nMPL'
GROUP BY i.homebranch /* saved_sql.id: 1 */
I'm not used to KTD yet, so I don't know what causes the difference. But it
definitely works on my local Koha.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 --- Comment #17 from Andrew Fuerste-Henry --- (In reply to Caroline Cyr La Rose from comment #16) > Works as advertised, very cool! > > Probably out of scope, but it would be nice to have a way to add "in" with > the parameter button. Maybe a checkbox in the pop up? That's here! https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 --- Comment #16 from Caroline Cyr La Rose --- Works as advertised, very cool! Probably out of scope, but it would be nice to have a way to add "in" with the parameter button. Maybe a checkbox in the pop up? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Pedro Amorim changed: What|Removed |Added CC||pedro.amo...@ptfs-europe.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Caroline Cyr La Rose changed:
What|Removed |Added
Attachment #162300|0 |1
is obsolete||
--- Comment #15 from Caroline Cyr La Rose ---
Created attachment 162303
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162303=edit
Bug 35746: add multiselect to report dropdowns
This patch adds the ability to use multi select in report dropdowns.
It uses syntax similar to using a list and when using the :all option
WHERE i.homebranch in <>
Test plan:
1. Create an SQL report with with new syntax for multi select
SELECT
i.homebranch,
count(*)
FROM items i
WHERE i.homebranch in <>
GROUP BY i.homebranch
2. Save the report
3. Note that you get the error
The authorized value category (branches:in) you selected does not exist.
4. Apply the patch and repeat steps 1 and 2
5. Note the report saves successfully
6. Run the report
7. Note the select dropdown is now a multiselect
8. Run the report with multiple selections
10. Click show SQL and note that multi select parameters get inserted into the
query like:
WHERE i.homebranch in ('CPL', 'FFL', 'FPL')
11. Test other types of queries with multiple multi selects and lists etc
Sponsored-by: CLAMS
Signed-off-by: Caroline Cyr La Rose
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 --- Comment #14 from Brendan Lawlor --- I just fixed the regex and perltidy issues so this patch now passes the QA scripts. Also in the work in progress patch I had deleted a block of code in C4/Reports/Guided.pm, because it didn't seem to be doing anything, but this time I left it in there just in case it was important for something else. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Brendan Lawlor changed: What|Removed |Added Attachment #161248|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #13 from Brendan Lawlor ---
Created attachment 162300
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162300=edit
Bug 35746: add multiselect to report dropdowns
This patch adds the ability to use multi select in report dropdowns.
It uses syntax similar to using a list and when using the :all option
WHERE i.homebranch in <>
Test plan:
1. Create an SQL report with with new syntax for multi select
SELECT
i.homebranch,
count(*)
FROM items i
WHERE i.homebranch in <>
GROUP BY i.homebranch
2. Save the report
3. Note that you get the error
The authorized value category (branches:in) you selected does not exist.
4. Apply the patch and repeat steps 1 and 2
5. Note the report saves successfully
6. Run the report
7. Note the select dropdown is now a multiselect
8. Run the report with multiple selections
10. Click show SQL and note that multi select parameters get inserted into the
query like:
WHERE i.homebranch in ('CPL', 'FFL', 'FPL')
11. Test other types of queries with multiple multi selects and lists etc
Sponsored-by: CLAMS
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Brendan Lawlor changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 --- Comment #12 from Andrew Fuerste-Henry --- *** Bug 16002 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||35856 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 [Bug 35856] Runtime parameter modal should provide option of ":all" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Biblibre Sandboxes changed:
What|Removed |Added
Attachment #161247|0 |1
is obsolete||
--- Comment #11 from Biblibre Sandboxes ---
Created attachment 161248
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161248=edit
Bug 35746: Add multiselect to report dropdowns
This work in progress patch adds the ability to use multi select in report
dropdowns.
It uses syntax similar to using a list and when using the :all option
WHERE i.homebranch in <>
Currently this works but fails qa scripts because of some forbidden regex
Test plan:
1. Create an SQL report with with new syntax for multi select
SELECT
i.homebranch,
count(*)
FROM items i
WHERE i.homebranch in <<<>
GROUP BY i.homebranch
2. Save the report
3. Note that you get the error
The authorized value category (branches:in) you selected does not exist.
4. Apply the patch and repeat steps 1 and 2
5. Note the report saves successfully
6. Run the report
7. Note the select dropdown is now a multiselect
8. Run the report with multiple selections
10. Click show SQL and note that multi select parameters get inserted into the
query like:
WHERE i.homebranch in ('CPL', 'FFL', 'FPL')
11. Test other types of queries with multiple multi selects and lists etc
Signed-off-by: Andrew Fuerste-Henry
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Brendan Lawlor changed:
What|Removed |Added
Attachment #161224|0 |1
is obsolete||
--- Comment #10 from Brendan Lawlor ---
Created attachment 161247
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161247=edit
Bug 35746: Add multiselect to report dropdowns
This work in progress patch adds the ability to use multi select in report
dropdowns.
It uses syntax similar to using a list and when using the :all option
WHERE i.homebranch in <>
Currently this works but fails qa scripts because of some forbidden regex
Test plan:
1. Create an SQL report with with new syntax for multi select
SELECT
i.homebranch,
count(*)
FROM items i
WHERE i.homebranch in <>
GROUP BY i.homebranch
2. Save the report
3. Note that you get the error
The authorized value category (branches:in) you selected does not exist.
4. Apply the patch and repeat steps 1 and 2
5. Note the report saves successfully
6. Run the report
7. Note the select dropdown is now a multiselect
8. Run the report with multiple selections
10. Click show SQL and note that multi select parameters get inserted into the
query like:
WHERE i.homebranch in ('CPL', 'FFL', 'FPL')
11. Test other types of queries with multiple multi selects and lists etc
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 he...@bywatersolutions.com changed: What|Removed |Added CC||he...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Brendan Lawlor changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Brendan Lawlor changed: What|Removed |Added Attachment #160995|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #9 from Brendan Lawlor ---
Created attachment 161224
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161224=edit
Bug 35746: Add multiselect to report dropdowns
This work in progress patch adds the ability to use multi select in report
dropdowns.
It uses syntax similar to using a list and when using the :all option
WHERE i.homebranch in <>
Currently this works but fails qa scripts because of some forbidden regex
Test plan:
1. Create an SQL report with with new syntax for multi select
SELECT
i.homebranch,
count(*)
FROM items i
WHERE i.homebranch in <<<>
GROUP BY i.homebranch
2. Save the report
3. Note that you get the error
The authorized value category (branches:in) you selected does not exist.
4. Apply the patch and repeat steps 1 and 2
5. Note the report saves successfully
6. Run the report
7. Note the select dropdown is now a multiselect
8. Run the report with multiple selections
10. Click show SQL and note that multi select parameters get inserted into the
query like:
WHERE i.homebranch in ('CPL', 'FFL', 'FPL')
11. Test other types of queries with multiple multi selects and lists etc
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 --- Comment #8 from Brendan Lawlor --- Thanks for the helpful link Emily, I hadn't found that part of the code yet. It's a good example to show how to split an input string into an array and then wrap the elements in quotes and separate them by commas. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Emily Lamancusa changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov --- Comment #7 from Emily Lamancusa --- Multi-select in reports would be awesome! This bug adding List parameters might be a good reference for processing the multi-select parameters: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27380 (The list-specific code is currently in Koha/Report.pm, lines 172-183 / near the end of prep_report()) I'm not sure if a list passes the parameters in exactly the same way as a multi-select drop-down, but hopefully that's a helpful starting point? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Brendan Lawlor changed: What|Removed |Added Attachment #160880|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #6 from Brendan Lawlor ---
Created attachment 160995
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160995=edit
Bug 35746: add multiselect to reports dropdowns
This is a work in progress patch to add multiselect to report dropdowns.
Test Plan:
1. Create an SQL report with with new syntax for multi select
SELECT *
FROM branches
WHERE branchcode in (<>)
2. Save the report
3. Note that you get the error
The authorized value category (branches:in) you selected does not exist.
4. Apply patch and repeat steps 1 and 2
5. Note the report saves successfully
6. Run the report
7. Note the select dropdown is now a multiselect
8. Run the report with multiple selections
9. Note that the multiselect choices are in the url like:
guided_reports.pl?reports=2=Run+this+report_name=Select+branches%7Cbranches%3Ain_params=CPL_params=FFL_params=FPL
10. Click show SQL and note that only the first parameter gets inserted intot
he query like:
WHERE branchcode in ('CPL')
TODO: Format the multiselected parameterss as a comma separated list to
generate valid SQL like:
WHERE branch in ('CPL', 'FFL', 'FPL')
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 --- Comment #5 from Brendan Lawlor --- Somehow my test plan did not get attached to this patch. This is a work in progress patch that adds a new syntax to reports for multiselect similar to adding <> Currently the patch adds the syntax to the report allowing you to select multiple authorized values when you run the report. The multiselected values are passed as multiple url parameters, but those parameters will need to be parsed and formatted for the query to work. I think this part could be done using either javascript to override the default functionality of the multiselect to send a single parameter, or done in the perl somewhere. Test Plan: 1. Try writing a report with the new syntax ie. WHERE itemtype in (<>) 2. Save the report and notice there is an error 3. Apply patch 4. Write a report with the new syntax select * from items where itype in ( <> ) 5. Note the report now saves without error 6. Run the report 7. Note that you can now select multiple parameters in the dropdown 8. Click 'Run the report' 9. Note the report fails to run 10. Check the url to see the multiselected parameters are included TODO: Make the multi selected params insert into the SQL as a comma separated list of strings. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 --- Comment #4 from Brendan Lawlor --- Created attachment 160880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160880=edit Bug 35746: add multiselect to report dropdowns -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Brendan Lawlor changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |blaw...@clamsnet.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #3 from Brendan Lawlor ---
This is a great idea.
I think the report syntax could be similar to when reports include the all
option.
<>
Then if the 'in' parameter is included guided_reports_start.tt would render
that element something like
so the user could select multiple options.
Then when the report is run the SQL would be somehow generated as a comma
separated list of the options the user selected.
For example:
WHERE branchcode IN (<>)
would become
WHERE branchcode IN ('opt1', 'opt2', 'opt3')
I think this bug contains some clues to how to implement this:
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93555=diff
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us --- Comment #2 from Rebecca Coert --- +1 this would be extremely helpful! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Barbara Johnson changed: What|Removed |Added CC||barbara.johnson@bedfordtx.g ||ov --- Comment #1 from Barbara Johnson --- +1 - We have multiple reports where this would be really useful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Brendan Lawlor changed: What|Removed |Added CC||blaw...@clamsnet.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
