https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Kyle M Hall changed:
What|Removed |Added
Blocks||27253
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #80 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #79)
> @RMaints, have a look at bug 17914, to avoid a warning when updating.
Backports with db revs always generate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #79 from Jonathan Druart
---
@RMaints, have a look at bug 17914, to avoid a warning when updating.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Jonathan Druart changed:
What|Removed |Added
Blocks|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #78 from Julian Maurice ---
Patches pushed to 3.22.x, will be in 3.22.9
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Kyle M Hall changed:
What|Removed |Added
Status|Passed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Julian Maurice changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #76 from Frédéric Demians ---
Pushed in 16.05. Will be in 16.05.01.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #75 from Marcel de Rooy ---
(In reply to Frédéric Demians from comment #74)
> I can't evaluate this patch level of dangerousness for 16.05 branch,
> especially with Thomas last comment. Any
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Frédéric Demians changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Pushed to Master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Tomás Cohen Arazi changed:
What|Removed |Added
Status|ASSIGNED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #71 from Tomás Cohen Arazi ---
Created attachment 52294
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52294=edit
Bug 10459: (followup) DBIx updates
Signed-off-by: Tomas Cohen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #70 from Tomás Cohen Arazi ---
While I agree with the timestamp, I must say systems syncing borrowers should
use borrowers.borrower_sync which links to the table borrower_sync, which is
well
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Tomás Cohen Arazi changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Kyle M Hall changed:
What|Removed |Added
Status|Passed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #67 from Jonathan Druart
---
(In reply to M. Tompsett from comment #66)
> (In reply to Jonathan Druart from comment #65)
> > I have squashed the 2 first patches (Mark, I hope
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #66 from M. Tompsett ---
(In reply to Jonathan Druart from comment #65)
> I have squashed the 2 first patches (Mark, I hope it's ok for you) and added
> tests.
I generally don't squash things of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Jonathan Druart changed:
What|Removed |Added
Attachment #51842|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #64 from Jonathan Druart
---
Created attachment 52115
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52115=edit
Bug 10459: Add tests for borrowers.updated_on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #63 from Jonathan Druart
---
Created attachment 52114
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52114=edit
Bug 10459 renamed timestamp to updated_on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #61 from Jonathan Druart
---
Comment on attachment 51867
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51867
Bug 10459: Follow up to update to atomic update
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #60 from David Cook ---
(In reply to M. Tompsett from comment #58)
> Hence the third patch which makes it updated_on, David Cook.
> Still ready for QA, like comment #56 says.
Yes, I was just
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #59 from Marcel de Rooy ---
(In reply to M. Tompsett from comment #58)
> Hence the third patch which makes it updated_on, David Cook.
> Still ready for QA, like comment #56 says.
Mark, if you
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #58 from M. Tompsett ---
Hence the third patch which makes it updated_on, David Cook.
Still ready for QA, like comment #56 says.
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
David Cook changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Brendan Gallagher changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #55 from M. Tompsett ---
(In reply to Marcel de Rooy from comment #52)
> What about filling created_on once in AddMember ?
> Mysql accepts:
> `stamp1` timestamp NULL DEFAULT NULL,
> `stamp2`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #54 from Bernardo Gonzalez Kriegel ---
(In reply to Marcel de Rooy from comment #52)
> What about filling created_on once in AddMember ?
> Mysql accepts:
> `stamp1` timestamp NULL DEFAULT NULL,
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #53 from Marcel de Rooy ---
And another question:
We may expect some libraries to have inserted a custom timestamp column already
in the borrowers table. They will run into the same problem as
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #52 from Marcel de Rooy ---
(In reply to M. Tompsett from comment #49)
> I went with an updated_on, as created_on is static, and the point was for
> diagnosis to know when something was last
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Marcel de Rooy changed:
What|Removed |Added
Attachment #51843|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Marcel de Rooy changed:
What|Removed |Added
Attachment #51844|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #49 from M. Tompsett ---
I went with an updated_on, as created_on is static, and the point was for
diagnosis to know when something was last done with the borrower record. And I
couldn't figure out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #48 from Joy Nelson ---
Signed off! Thanks!!!
joy
(In reply to M. Tompsett from comment #44)
> Okay, Joy, go sign off crazy. ;)
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Joy Nelson changed:
What|Removed |Added
Attachment #51810|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Joy Nelson changed:
What|Removed |Added
Attachment #51808|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Joy Nelson changed:
What|Removed |Added
Attachment #51809|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Joy Nelson changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
M. Tompsett changed:
What|Removed |Added
Attachment #51807|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
M. Tompsett changed:
What|Removed |Added
Attachment #50481|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
M. Tompsett changed:
What|Removed |Added
Status|In Discussion |Needs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
M. Tompsett changed:
What|Removed |Added
Attachment #50480|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #40 from M. Tompsett ---
Created attachment 51807
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51807=edit
Bug 10459 renamed timestamp to updated_on
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #39 from M. Tompsett ---
(In reply to Joy Nelson from comment #38)
> I appreciate the discussion on this issue to standardize the naming. Is
> this ticket now about renaming all timestamps or still
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Joy Nelson changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #37 from Marc Véron ---
(In reply to Kyle M Hall from comment #35)
> (In reply to Katrin Fischer from comment #33)
> > It looks like we have a 'ton' of timestamp in the database. Apart from that
> > there
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #36 from M. Tompsett ---
(In reply to Kyle M Hall from comment #35)
> I think we should standardize on a single format.
+1
> I think "updated_on" for timestamps that are set on each update
> and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #35 from Kyle M Hall ---
(In reply to Katrin Fischer from comment #33)
> It looks like we have a 'ton' of timestamp in the database. Apart from that
> there seems to be no existing other schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Katrin Fischer changed:
What|Removed |Added
Status|In Discussion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Kyle M Hall changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #30 from Marcel de Rooy ---
(In reply to M. Tompsett from comment #29)
> Because while thinking about that very problem, I found:
> DROP TABLE IF EXISTS `borrower_debarments`;
> CREATE TABLE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #29 from M. Tompsett ---
(In reply to Marcel de Rooy from comment #27)
> Thanks for reviving this.
> The reason I left this pending however, is probably as valid as then.
> If you call the field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Marcel de Rooy changed:
What|Removed |Added
Patch complexity|Trivial patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #27 from Marcel de Rooy ---
Thanks for reviving this.
The reason I left this pending however, is probably as valid as then.
If you call the field timestamp, we will have clashes in SQL joins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #26 from M. Tompsett ---
Created attachment 50481
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50481=edit
Bug 10459: Follow up to update to atomic update methodology
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
M. Tompsett changed:
What|Removed |Added
Attachment #50478|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #24 from M. Tompsett ---
kohastructure has way too many 'timestamp' named fields, so I just left this.
TEST PLAN
-
1) back up db
2) apply patch
3) run upgrade
4) confirm that timestamp is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Status|ASSIGNED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Attachment #50476|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Attachment #50475|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #21 from M. Tompsett ---
Created attachment 50476
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50476=edit
Bug 10459: Follow up to update to atomic update methodology
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
M. Tompsett changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
M. Tompsett changed:
What|Removed |Added
Attachment #33509|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Mason James changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #18 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to M. de Rooy from comment #15)
No. I will submit another patch as discussed on the dev list some time ago..
For documentation: you can find the discussion in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #17 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Katrin Fischer from comment #16)
Hi Marcel, any update on this? I'd really like to see it happen.
I will keep it on my list :) but the priority is another
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #16 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Marcel, any update on this? I'd really like to see it happen.
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #15 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Katrin Fischer from comment #13)
Should this be signed off?
No. I will submit another patch as discussed on the dev list some time ago..
--
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #14 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I am looking for a way to determine easily when a patron was deleted, I think a
timestamp in deletedborrowers would help a lot with that. So keen on seeing
this move :)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
M. de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Attachment #33435|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #6 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Had this error on 3.14.x: Column 'timestamp' in order clause is ambiguous at
/usr/share/koha/prodclone/C4/Items.pm line 1209
--
You are receiving this mail because:
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
M. de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Attachment #33435|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
M. de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Attachment #33490|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #9 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Had to reset the status. Sent a mail to the dev list about the ambiguous
timestamps in Koha. My patch now proposes bortimestamp.
--
You are receiving this mail because:
You
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
M. de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Status|BLOCKED |Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
M. de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Status|Needs Signoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
M. de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Attachment #33491|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
M. de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Attachment #33435|Bug 10459: Borrowers should
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
M. de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Attachment #33435|1 |0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #11 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Restored the patch signed off by Marc, but I will still add a patch to update
some queries to prevent ambiguous column-errors.
--
You are receiving this mail because:
You
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
M. de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Status|Signed Off |BLOCKED
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #1 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 33421
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33421action=edit
Bug 10459: Borrowers should have a timestamp
This patch adds a
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
M. de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Status|NEW |Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
M. de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
--- Comment #2 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Forgot deletedborrowers..please wait
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
M. de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Attachment #33421|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Marc Véron ve...@veron.ch changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Marc Véron ve...@veron.ch changed:
What|Removed |Added
Attachment #33424|0 |1
is
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459
Laurence Lefaucheur laurence.lefauch...@biblibre.com changed:
What|Removed |Added
See Also|
98 matches
Mail list logo