[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Depends on|10895 |14385

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Attachment #30806|0 |1

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #42 from M. Tompsett --- (In reply to M. Tompsett from comment #39) > Oops. Missed C4::Search::searchResults. That comment is right about it being > messy. On a positive note, that is dealt with in

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Resolution|DUPLICATE |---

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Resolution|---

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #39 from M. Tompsett --- Oops. Missed C4::Search::searchResults. That comment is right about it being messy. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Depends on||11592

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #38 from M. Tompsett --- Okay... thoughts on a rework include: GetHiddenItems in C4::Items would be removed. This would lead to a refactor EmbedItemsInMarcBiblio to NOT have an fourth parameter

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #37 from M. Tompsett --- (In reply to Marc Véron from comment #36) > Still valid? This patch is not the correct way to proceed. I'm working on a rewrite with filters now. -- You are receiving

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Depends on||15777

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Marc Véron changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #36 from Marc Véron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Signed Off |Failed QA

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #33 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to M. Tompsett from comment #32) See Bugs 10900 and 10895. They kind of all go together. The unit tests are on another bug report. 10895 is in

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Depends on||10900 --

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #34 from M. Tompsett mtomp...@hotmail.com --- Okay, this patch needs to be AFTER 10900, and the test cases are in 10895, but those depend on 10900 as well. Bug 10589 is an ENHANCEMENT. It was signed off rather quickly,

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Depends on|10895 |10900 --

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Blocks|10895 |

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Depends on||10895 --

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC|

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #32 from M. Tompsett mtomp...@hotmail.com --- See Bugs 10900 and 10895. They kind of all go together. The unit tests are on another bug report. 10895 is in discussion, because Galen punted it to the next release. -- You

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Marc Véron ve...@veron.ch changed: What|Removed |Added CC||ve...@veron.ch

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #22629|0 |1 is

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|In Discussion

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #30796|0 |1

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 jkpatti...@gmail.com changed: What|Removed |Added CC||jkpatti...@gmail.com

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Keywords|rel_3_16_candidate |

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |In

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Keywords|

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC|

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #22587|0 |1

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Patch complexity|--- |Small

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #21 from M. Tompsett mtomp...@hotmail.com --- Rebased again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #21620|0 |1

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Blocks||10895 --

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #21256|0 |1

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #18 from M. Tompsett mtomp...@hotmail.com --- I put the tests into a separate bug, because at the time, this was signed off. Sadly, I had to rebase. See bug 10895 for a test file, which depends on bug 10900. -- You are

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 I'm just a bot git...@bugs.koha-community.org changed: What|Removed |Added CC|

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Signed Off |Needs

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #21066|0 |1

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Signed Off |Needs

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #19954|0 |1

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #13 from M. Tompsett mtomp...@hotmail.com --- Created attachment 21063 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21063action=edit Bug 10589 - Override OpacHiddenItems based on Patron Category Two

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #21063|0 |1

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added CC|

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #19931|0 |1

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #19932|0 |1

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #8 from Srdjan Jankovic srd...@catalyst.net.nz --- Sorry, now another one: grep( /^$categorycode$/, @SingleBranchCodes ) should be replaced with any() (and @EveryBranchCodes too) -- You are receiving this mail because:

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #19933|0 |1

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|In Discussion |Needs

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #10 from Srdjan Jankovic srd...@catalyst.net.nz --- IT works and I will sign it of, however I need to raise two things (should have done earlier, but occurred to me when testing): 1. Not sure if it is appropriate to put

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #11 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 19954 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19954action=edit [SIGNED-OFF] Bug 10589 - Override OpacHiddenItems based on

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #19949|0 |1

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #19708|0 |1

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added CC|

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |In

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #19647|0 |1

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|NEW |Needs