https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Joy Nelson changed:
What|Removed |Added
Version(s)|20.05.00|20.05.00, 19.11.04
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Joy Nelson changed:
What|Removed |Added
Status|Passed QA |Pushed to stable
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Joy Nelson changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Joy Nelson changed:
What|Removed |Added
Status|REOPENED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Joy Nelson changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #71 from David Cook ---
Should this one be marked as "Pushed to stable" now?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #70 from Joy Nelson ---
Pushed to 19.11.x branch for 19.11.04
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #69 from David Cook ---
(In reply to Joy Nelson from comment #68)
> David-
> I spent some time thinking about this one. Let me get some input from our
> DevOps team here and see what their thoughts are. We meet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Joy Nelson changed:
What|Removed |Added
Status|RESOLVED|REOPENED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #67 from David Cook ---
(In reply to Joy Nelson from comment #66)
> I am hesitant to push this to 19.11.x branch as a point release. This is a
> fix to a bug, but seems like a major change for a point release. I'm not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Joy Nelson changed:
What|Removed |Added
Resolution|--- |FIXED
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #65 from David Cook ---
Martin has already pushed #24642 so should be good now
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #64 from Katrin Fischer ---
(In reply to Jonathan Druart from comment #63)
> (In reply to Jonathan Druart from comment #62)
> > We are loosing the memcached cache after this change, as the module will not
> > be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Martin Renvoize changed:
What|Removed |Added
Text to go in the||*Important Note*: You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Jonathan Druart changed:
What|Removed |Added
Blocks||24642
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #63 from Jonathan Druart
---
(In reply to Jonathan Druart from comment #62)
> We are loosing the memcached cache after this change, as the module will not
> be installed by default and is not required.
> See bug 24642.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #61 from David Cook ---
Because this adds a new dependency, I'm guessing it may not be backported to
older versions?
Would love to see this get into 19.11, but understand if that's not possible.
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #60 from David Cook ---
Hurray! Extra special thanks to Barton, Martin, Joonas, and Mason. (That
sentence actually sounds really good when you say it outloud. Excellent names
heh.)
My apologies for not getting the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #59 from Martin Renvoize ---
Nice work everyone!
Pushed to master for 20.05
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Martin Renvoize changed:
What|Removed |Added
Version(s)||20.05.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Mason James changed:
What|Removed |Added
Status|Passed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Mason James changed:
What|Removed |Added
Attachment #98546|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Passed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #56 from Joonas Kylmälä ---
(In reply to Joonas Kylmälä from comment #55)
> The fix looks good but commit message title doesn't tell what the bug does
oh, I was supposed to write it doesn't tell what the patch does. The
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Joonas Kylmälä changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #55
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Mason James changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Mason James changed:
What|Removed |Added
Attachment #92931|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Mason James changed:
What|Removed |Added
Attachment #92867|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Mason James changed:
What|Removed |Added
Attachment #92931|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Mason James changed:
What|Removed |Added
Attachment #92867|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #52 from David Cook ---
This is still on my todo list but just haven't had the time yet...
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Martin Renvoize changed:
What|Removed |Added
Severity|critical|major
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #51 from David Cook ---
(In reply to Joonas Kylmälä from comment #48)
> well, we can either make the debian package ourselves or remove the
> dependency by solving this with another way.
I'm checking with the Release
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Alexander Borkowski changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #50 from David Cook ---
Still have libraries being impacted about this in rather nasty ways.
It would be great to see progress on this one.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Katrin Fischer changed:
What|Removed |Added
Version(s)|19.11.00|
released in|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #49 from David Cook ---
(In reply to Joonas Kylmälä from comment #48)
> well, we can either make the debian package ourselves or remove the
> dependency by solving this with another way.
I don't think making the package
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #48 from Joonas Kylmälä ---
(In reply to David Cook from comment #47)
> (In reply to Joonas Kylmälä from comment #46)
> > (In reply to Katrin Fischer from comment #45)
> > > (In reply to David Cook from comment #44)
> >
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #47 from David Cook ---
(In reply to Joonas Kylmälä from comment #46)
> (In reply to Katrin Fischer from comment #45)
> > (In reply to David Cook from comment #44)
> > > Any movement on this one? I'd really like to see
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #46 from Joonas Kylmälä ---
(In reply to Katrin Fischer from comment #45)
> (In reply to David Cook from comment #44)
> > Any movement on this one? I'd really like to see this one move forward...
>
> It looks like it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #45 from Katrin Fischer ---
(In reply to David Cook from comment #44)
> Any movement on this one? I'd really like to see this one move forward...
It looks like it was pushed?
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #44 from David Cook ---
Any movement on this one? I'd really like to see this one move forward...
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Martin Renvoize changed:
What|Removed |Added
Attachment #92931|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Martin Renvoize changed:
What|Removed |Added
Attachment #92926|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Martin Renvoize changed:
What|Removed |Added
Status|Pushed to master|ASSIGNED
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #43 from Joonas Kylmälä ---
Martin, oh noes, the dependency was not added yet to the Koha repositories?
This needs to be reverted?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #42 from Martin Renvoize ---
Nice work!
Pushed to master for 19.11.00
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Martin Renvoize changed:
What|Removed |Added
Version(s)||19.11.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #41 from David Cook ---
(In reply to Joonas Kylmälä from comment #40)
> Ok, so now we just wait for Mirko's opinion on the dependency change.
I'm guessing so. Maybe we can buy him a beer to get him to look at it soon.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #40 from Joonas Kylmälä ---
(In reply to David Cook from comment #39)
> Talked to Martin on IRC last night, and he was saying that we shouldn't
> bother adding a test for this one, since it's too challenging to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
David Cook changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #39 from David Cook ---
Talked to Martin on IRC last night, and he was saying that we shouldn't bother
adding a test for this one, since it's too challenging to accurately reproduce,
and the testing I've already done
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #38 from David Cook ---
The protocol for memcached actually looks super straightforward:
https://github.com/memcached/memcached/blob/master/doc/protocol.txt
So we could probably mock a server easily enough. I took a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #37 from David Cook ---
Created attachment 92931
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92931=edit
[Draft] Integration test Koha::Cache and memcached
This test is not 100% reliable. When run
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #36 from David Cook ---
Actually testing Koha::Cache directly only looked like it was working. I think
I'm having namespacing issues... should hopefully have something better soon...
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #35 from David Cook ---
Ok so C4::Context calls the following which creates a singleton Koha::Cache in
the process where C4::Context is first loaded (after it's compiled):
my $syspref_cache =
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #34 from David Cook ---
I've tried using C4::Context->preference() instead of using
Cache::Memcached::Fast directly, but it's much less reliable, even when
including Koha::Caches->flush_L1_caches() after every call...
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #33 from David Cook ---
Martin et al: Take a look at that draft integration test I wrote?
Using 10 child processes and semi-randomized highish-volume Memcached lookups,
I'm able to seemingly reliable reproduce the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #32 from David Cook ---
Created attachment 92926
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92926=edit
[Draft] Integration test for testing memcached client
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #31 from David Cook ---
(In reply to David Cook from comment #30)
> Adding more entropy is helping. Now I can reproduce it every single time I
> run my test.
And when I swap it out with the Safe module... no errors on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #30 from David Cook ---
Adding more entropy is helping. Now I can reproduce it every single time I run
my test.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #29 from David Cook ---
I say reliable and then I have a long series of perfect runs with no errors one
after the other...
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #28 from David Cook ---
Quite the heisenbug although I'm making progress getting more reliable test
results but testing Cache::Memcached::Fast directly.
Note the \d+) is the pid of the child process.
100
hundred
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #27 from David Cook ---
But... I'll try to see if I can come up with a test that is reliable...ish...
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #26 from David Cook ---
$VAR1 = {
'localhost:11211' => '1.5.6'
};
$VAR1 = {
'localhost:11211' => '1.5.6'
};
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #25 from David Cook ---
(In reply to Martin Renvoize from comment #23)
> I'm wondering if it's worthwhile effectively porting the test from
> Cache::Memcached::Fast::Safe for forking:
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #24 from Joonas Kylmälä ---
(In reply to Martin Renvoize from comment #23)
> I'm wondering if it's worthwhile effectively porting the test from
> Cache::Memcached::Fast::Safe for forking:
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #23 from Martin Renvoize ---
I'm wondering if it's worthwhile effectively porting the test from
Cache::Memcached::Fast::Safe for forking:
https://metacpan.org/source/KAZEBURO/Cache-Memcached-Fast-Safe-0.06/t/02_fork.t.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #22 from David Cook ---
(In reply to Martin Renvoize from comment #20)
> I'd really like to see a regression test added for this if at all possible
I'm with Joonas on this one. I've tried a number of times, and the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #21 from Joonas Kylmälä ---
(In reply to Martin Renvoize from comment #20)
> I'd really like to see a regression test added for this if at all possible
This might be quite difficult to reproduce in a test because on my
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #20 from Martin Renvoize ---
I'd really like to see a regression test added for this if at all possible
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #19 from Mason James ---
Created attachment 92868
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92868=edit
about.pl page
the about.pl page looks happy and correct.. great work!
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Katrin Fischer changed:
What|Removed |Added
CC||mi...@abunchofthings.net
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #17 from David Cook ---
Updated the title to be more in-line with the actual content of the report
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
David Cook changed:
What|Removed |Added
Summary|Discussion: strategy for|Make Memcached usage fork
80 matches
Mail list logo
