[Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com

[Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation

2015-02-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 --- Comment #18 from Colin Campbell --- (In reply to Jonathan Druart from comment #12) > (In reply to Colin Campbell from comment #11) > > In the perl world using $x->{one}->{two} rather than $x->{one}{two} is the > > most common. one

[Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation

2015-02-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 --- Comment #17 from Kyle M Hall --- Created attachment 35707 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35707&action=edit [PASSED QA] Bug 13240 [QA Followup] Signed-off-by: Kyle M Hall -- You are receiving t

[Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation

2015-02-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receivin

[Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation

2015-02-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 Kyle M Hall changed: What|Removed |Added Attachment #35361|0 |1 is obsolete|

[Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation

2015-02-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 --- Comment #16 from Kyle M Hall --- Created attachment 35706 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35706&action=edit [PASSED QA] Bug 13240: Remove commented warns Signed-off-by: Marcel de Rooy Signed-off

[Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation

2015-02-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 --- Comment #14 from Kyle M Hall --- Created attachment 35704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35704&action=edit Bug 13240 [QA Followup] -- You are receiving this mail because: You are watching all bu

[Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation

2015-02-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 Kyle M Hall changed: What|Removed |Added Attachment #33478|0 |1 is obsolete|

[Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation

2015-02-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 --- Comment #13 from M. Tompsett --- (In reply to Jonathan Druart from comment #12) [SNIP] > I often use it, > > use Modern::Perl; > my $h = { foo => { bar => 'foobar' } }; > say "my string with $h->{foo}->{bar}"; > say "my

[Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation

2015-02-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 --- Comment #12 from Jonathan Druart --- (In reply to Colin Campbell from comment #11) > In the perl world using $x->{one}->{two} rather than $x->{one}{two} is the > most common. one reason is that the arrow syntax can be used in a st

[Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation

2015-02-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 Colin Campbell changed: What|Removed |Added CC||colin.campbell@ptfs-europe.

[Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation

2015-01-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 --- Comment #10 from M. Tompsett --- (In reply to Kyle M Hall from comment #9) > Maybe we should vote on this for coding guidelines. I added it as an agenda item to http://wiki.koha-community.org/wiki/Development_IRC_meeting_4_Februa

[Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation

2015-01-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com ---

[Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation

2015-01-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 --- Comment #8 from M. de Rooy --- (In reply to Jonathan Druart from comment #5) > (In reply to M. Tompsett from comment #4) > > > And the second syntax uses $h->{}{} which isn't so > > > good: $h->{}->{} should be preferred, imho. >

[Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation

2015-01-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 --- Comment #6 from M. de Rooy --- Created attachment 35361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35361&action=edit Bug 13240: Remove some code obfuscation my $bar; my $foo = $bar->{borrowernumber} ||= {};

[Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation

2015-01-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 M. de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receivin

[Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation

2015-01-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 M. de Rooy changed: What|Removed |Added Attachment #33479|0 |1 is obsolete|

[Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation

2014-11-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 --- Comment #5 from Jonathan Druart --- (In reply to M. Tompsett from comment #4) > > And the second syntax uses $h->{}{} which isn't so > > good: $h->{}->{} should be preferred, imho. > > I agree with Frédéric Demians on this, thoug

[Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation

2014-11-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comme

[Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation

2014-11-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 Frédéric Demians changed: What|Removed |Added CC||frede...@tamil.fr --- Com

[Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation

2014-11-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- Yo

[Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation

2014-11-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 --- Comment #2 from Jonathan Druart --- Created attachment 33479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33479&action=edit Bug 13240: Remove commented warns -- You are receiving this mail because: You are wa

[Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation

2014-11-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 --- Comment #1 from Jonathan Druart --- Created attachment 33478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33478&action=edit Bug 13240: Remove some code obfuscation my $bar; my $foo = $bar->{borrowernumber} ||=

[Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation

2014-11-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are

[Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation

2014-11-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED Assigne