[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Blocks|14321 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #13 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Attachment #41683|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 41707 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41707action=edit Bug 14588: Simplify merge_ajax.pl This script does not need a few modules: IO::File; CGI::Session; C4::UploadedFile. Warnings can be enabled (with Modern::Perl). Indirect object syntax replaced for CGI and CGI::Cookie. Moved the $reply line upwards (not needed twice anymore). Test plan: [1] Log in as staff user. Run the URL cataloguing/merge_ajax.pl. You should see the JSON reponse in the browser. [2] Logout. Run the URL again. Blank screen. [3] Go to addbooks.pl (Cataloging Search). Search something, select two biblios and click Merge selected, etc. Signed-off-by: Joonas Kylmala j.kylm...@gmail.com Signed-off-by: Mark Tompsett mtomp...@hotmail.com Signed-off-by: Jonathan Druart jonathan.dru...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 --- Comment #7 from M. Tompsett mtomp...@hotmail.com --- (In reply to Jonathan Druart from comment #5) (In reply to Marcel de Rooy from comment #1) (Note that Class::-method is preferred above Class-method. See perlobj.) I did not find where it's written it's better. I personally think you are adding a third way where we already have new CGI and CGI-new... I agree that better is not the word used. However, it is expressly explicit in how Perl should interpret the call. There is something to be said positively for explicitness. Because Perl allows you to use barewords for package names and subroutine names, it sometimes interprets a bareword's meaning incorrectly. http://perldoc.perl.org/perlobj.html#Invoking-Class-Methods Though, I do share Jonathan's view that CGI-new is sufficient. This explicit syntax is an example of confusing ugliness that I personally would prefer to avoid. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 --- Comment #8 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- If there is widespread concensus for removing this *ugly* construction, I will be happy to remove it quickly :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 --- Comment #6 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Jonathan Druart from comment #5) (In reply to Marcel de Rooy from comment #1) (Note that Class::-method is preferred above Class-method. See perlobj.) I did not find where it's written it's better. I personally think you are adding a third way where we already have new CGI and CGI-new... ThereIsMoreThanOneWayToDoIt The reference is few comments up, but for the rest it is completely unimportant. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #41462|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #41670|0 |1 is obsolete|| --- Comment #10 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 41676 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41676action=edit Bug 14588: Simplify merge_ajax.pl This script does not need a few modules: IO::File; CGI::Session; C4::UploadedFile. Warnings can be enabled (with Modern::Perl). Indirect object syntax replaced for CGI and CGI::Cookie. Moved the $reply line upwards (not needed twice anymore). Test plan: [1] Log in as staff user. Run the URL cataloguing/merge_ajax.pl. You should see the JSON reponse in the browser. [2] Logout. Run the URL again. Blank screen. [3] Go to addbooks.pl (Cataloging Search). Search something, select two biblios and click Merge selected, etc. Signed-off-by: Joonas Kylmala j.kylm...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 --- Comment #9 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 41670 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41670action=edit Bug 14588: Simplify merge_ajax.pl This script does not need a few modules: IO::File; CGI::Session; C4::UploadedFile. Warnings can be enabled (with Modern::Perl). Indirect object syntax replaced for CGI and CGI::Cookie. (Note that Class::-method is preferred above Class-method. See perlobj.) Moved the $reply line upwards (not needed twice anymore). Test plan: [1] Log in as staff user. Run the URL cataloguing/merge_ajax.pl. You should see the JSON reponse in the browser. [2] Logout. Run the URL again. Blank screen. [3] Go to addbooks.pl (Cataloging Search). Search something, select two biblios and click Merge selected, etc. Signed-off-by: Joonas Kylmala j.kylm...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #41676|0 |1 is obsolete|| --- Comment #11 from M. Tompsett mtomp...@hotmail.com --- Created attachment 41683 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41683action=edit Bug 14588: Simplify merge_ajax.pl This script does not need a few modules: IO::File; CGI::Session; C4::UploadedFile. Warnings can be enabled (with Modern::Perl). Indirect object syntax replaced for CGI and CGI::Cookie. Moved the $reply line upwards (not needed twice anymore). Test plan: [1] Log in as staff user. Run the URL cataloguing/merge_ajax.pl. You should see the JSON reponse in the browser. [2] Logout. Run the URL again. Blank screen. [3] Go to addbooks.pl (Cataloging Search). Search something, select two biblios and click Merge selected, etc. Signed-off-by: Joonas Kylmala j.kylm...@gmail.com Signed-off-by: Mark Tompsett mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #5 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- (In reply to Marcel de Rooy from comment #1) (Note that Class::-method is preferred above Class-method. See perlobj.) I did not find where it's written it's better. I personally think you are adding a third way where we already have new CGI and CGI-new... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 --- Comment #4 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Joonas Kylmälä from comment #3) Signed-off-by: Joonas Kylmälä j.kylm...@gmail.com Thx Joonas -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Blocks||14321 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #2 from M. Tompsett mtomp...@hotmail.com --- (In reply to Marcel de Rooy from comment #1) ... (Note that Class::-method is preferred above Class-method. See perlobj.) http://perldoc.perl.org/perlobj.html#Invoking-Class-Methods Interesting. I did not know this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 Joonas Kylmälä j.kylm...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 Joonas Kylmälä j.kylm...@gmail.com changed: What|Removed |Added Attachment #41126|0 |1 is obsolete|| --- Comment #3 from Joonas Kylmälä j.kylm...@gmail.com --- Created attachment 41462 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41462action=edit Checked the code, looks good to me. I didn't notice any changes in the behaviour of the merge functionality. Signed-off-by: Joonas Kylmälä j.kylm...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14589 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 --- Comment #1 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 41126 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41126action=edit Bug 14588: Simplify merge_ajax.pl This script does not need a few modules: IO::File; CGI::Session; C4::UploadedFile. Warnings can be enabled (with Modern::Perl). Indirect object syntax replaced for CGI and CGI::Cookie. (Note that Class::-method is preferred above Class-method. See perlobj.) Moved the $reply line upwards (not needed twice anymore). Test plan: [1] Log in as staff user. Run the URL cataloguing/merge_ajax.pl. You should see the JSON reponse in the browser. [2] Logout. Run the URL again. Blank screen. [3] Go to addbooks.pl (Cataloging Search). Search something, select two biblios and click Merge selected, etc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|gmcha...@gmail.com |m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/