[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 MichaelaSieber changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 MichaelaSieber changed: What|Removed |Added CC||michaela.sie...@kit.edu --

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Lisette Scheer changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens changed: What|Removed |Added Text to go in the|This new feature adds the |This new feature adds the

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Martin Renvoize changed: What|Removed |Added Keywords|release-notes-needed| Text to go in the|This

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens changed: What|Removed |Added Blocks||22934 Referenced Bugs: htt

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens changed: What|Removed |Added Text to go in the||This enhancement adds the

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Martin Renvoize changed: What|Removed |Added Keywords||release-notes-needed --

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Martin Renvoize changed: What|Removed |Added Keywords||Manual -- You are receiv

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|RESOLVED Resoluti

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #158 from Tomás Cohen Arazi --- Created attachment 86411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86411&action=edit Bug 15774: (follow-up) Fix TestBuilder.t so it doesn't catch wrong classes Sign

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens changed: What|Removed |Added Status|Pushed by Module Maintainer |Pushed to Master -- You are

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Katrin Fischer changed: What|Removed |Added Severity|enhancement |new feature -- You are re

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed by Module Maintainer

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #154 from Josef Moravec --- Created attachment 85822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85822&action=edit Bug 15774: (follow-up) fix rebase issues Signed-off-by: Josef Moravec -- You are

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #156 from Josef Moravec --- Created attachment 85824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85824&action=edit Bug 15774: (QA follow-up) Remove asset of datables.css, and corresponding plugins I

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #153 from Josef Moravec --- Created attachment 85821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85821&action=edit Bug 15774: Add permission for managing additional fields To test: 1 - Have three b

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #155 from Josef Moravec --- Created attachment 85823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85823&action=edit Bug 15774: (QA follow-up) Fix use statemenets Signed-off-by: Josef Moravec -- Yo

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #152 from Josef Moravec --- Created attachment 85820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85820&action=edit Bug 15774: Remove unecessary returned value for ->delete Signed-off-by: Jonathan Dr

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #145 from Josef Moravec --- Created attachment 85813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85813&action=edit Bug 15774: Fix JS check when AV and MARC field are both selected Signed-off-by: Jon

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #151 from Josef Moravec --- Created attachment 85819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85819&action=edit Bug 15774: Do not fetch additional fields from GetSubscription Finally we do not wa

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #147 from Josef Moravec --- Created attachment 85815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85815&action=edit Bug 15774: Use the include file to display the subscription's additional fields We

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #144 from Josef Moravec --- Created attachment 85812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85812&action=edit Bug 15774: (follow-up) Add html filters Signed-off-by: Séverine QUEUNE Signed-off

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #148 from Josef Moravec --- Created attachment 85816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85816&action=edit Bug 15774: Fix insert and update for subscription Call it a typo Signed-off-by: Jo

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #149 from Josef Moravec --- Created attachment 85817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85817&action=edit Bug 15774: Add missing tests for Koha::Object::Mixin::AdditionalFields Signed-off-b

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #146 from Josef Moravec --- Created attachment 85814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85814&action=edit Bug 15774: (follow-up) Address QA issues Signed-off-by: Jonathan Druart Signed-of

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #150 from Josef Moravec --- Created attachment 85818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85818&action=edit Bug 15774: Fix and unify additional_fields in C4::Serials Signed-off-by: Jonathan D

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #143 from Josef Moravec --- Created attachment 85811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85811&action=edit Bug 15774: Show additional field values in edit form Signed-off-by: Séverine QUEUNE

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #142 from Josef Moravec --- Created attachment 85810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85810&action=edit Bug 15774: Add POD and license notices Signed-off-by: Séverine QUEUNE Signed-off-

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #139 from Josef Moravec --- Created attachment 85807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85807&action=edit Bug 15774: (QA follow-up) Make sure that tablename is correctly saved Signed-off-by

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #141 from Josef Moravec --- Created attachment 85809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85809&action=edit Bug 15774: Use Koha::Object(s) for additional fields A lot of code can be removed j

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #140 from Josef Moravec --- Created attachment 85808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85808&action=edit Bug 15774: Fix additional fields filters Addresses the following QA comments: 1/ R

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Josef Moravec changed: What|Removed |Added Attachment #85333|0 |1 is obsolete|

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #137 from Josef Moravec --- (In reply to Jonathan Druart from comment #133) > (In reply to Josef Moravec from comment #132) > > Also, I have one concern: this patchset does much more than this report > > describes. > > I

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #136 from Nick Clemens --- (In reply to Josef Moravec from comment #132) > Sorry, but QA tools are not happy: Fixed QA tool errors -- You are receiving this mail because: You are watching all bug changes. _

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off Patch complexit

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #135 from Nick Clemens --- Created attachment 85792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85792&action=edit Bug 15774: (follow-up) fix rebase issues -- You are receiving this mail because: Yo

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #134 from Jonathan Druart --- /broke/break/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-communit

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #133 from Jonathan Druart --- (In reply to Josef Moravec from comment #132) > Also, I have one concern: this patchset does much more than this report > describes. > I would like to see, at least the refactoring part of t

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #130 from Nick Clemens --- Created attachment 85347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85347&action=edit Bug 15774: Remove unecessary returned value for ->delete Signed-off-by: Jonathan Dru

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #131 from Nick Clemens --- Created attachment 85348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85348&action=edit Bug 15774: Add permission for managing additional fields To test: 1 - Have three bo

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #129 from Nick Clemens --- Created attachment 85346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85346&action=edit Bug 15774: Do not fetch additional fields from GetSubscription Finally we do not wan

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #125 from Nick Clemens --- Created attachment 85342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85342&action=edit Bug 15774: Use the include file to display the subscription's additional fields We h

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #127 from Nick Clemens --- Created attachment 85344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85344&action=edit Bug 15774: Add missing tests for Koha::Object::Mixin::AdditionalFields Signed-off-by

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #128 from Nick Clemens --- Created attachment 85345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85345&action=edit Bug 15774: Fix and unify additional_fields in C4::Serials Signed-off-by: Jonathan Dr

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #126 from Nick Clemens --- Created attachment 85343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85343&action=edit Bug 15774: Fix insert and update for subscription Call it a typo Signed-off-by: Jon

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #121 from Nick Clemens --- Created attachment 85338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85338&action=edit Bug 15774: Show additional field values in edit form Signed-off-by: Séverine QUEUNE

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens changed: What|Removed |Added Attachment #83444|0 |1 is obsolete|

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #124 from Nick Clemens --- Created attachment 85341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85341&action=edit Bug 15774: (follow-up) Address QA issues Signed-off-by: Jonathan Druart -- You ar

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #120 from Nick Clemens --- Created attachment 85337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85337&action=edit Bug 15774: Add POD and license notices Signed-off-by: Séverine QUEUNE Signed-off-b

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #123 from Nick Clemens --- Created attachment 85340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85340&action=edit Bug 15774: Fix JS check when AV and MARC field are both selected Signed-off-by: Jona

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #122 from Nick Clemens --- Created attachment 85339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85339&action=edit Bug 15774: (follow-up) Add html filters Signed-off-by: Séverine QUEUNE Signed-off-

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #119 from Nick Clemens --- Created attachment 85336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85336&action=edit Bug 15774: Use Koha::Object(s) for additional fields A lot of code can be removed ju

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are recei

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #118 from Nick Clemens --- Created attachment 85335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85335&action=edit Bug 15774: Fix additional fields filters Addresses the following QA comments: 1/ Re

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #117 from Nick Clemens --- Created attachment 85334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85334&action=edit Bug 15774: (QA follow-up) Make sure that tablename is correctly saved Signed-off-by:

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Co

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Katrin Fischer changed: What|Removed |Added Keywords|rel_18_11_candidate | -- You are receiving thi

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- Y

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #114 from Nick Clemens --- (In reply to Katrin Fischer from comment #96) > I like the approach of the new permission depending on order_manage and > edit_subscription Excellent! > 1) You need to update installer/data/mys

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #113 from Katrin Fischer --- ah, I think I understand 2) now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@li

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #112 from Nick Clemens --- Created attachment 83459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83459&action=edit Bug 15774: Add permission for managing additional fields To test: 1 - Have three bo

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #111 from Nick Clemens --- Created attachment 83458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83458&action=edit Bug 15774: Remove unecessary returned value for ->delete Signed-off-by: Jonathan Dru

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #110 from Nick Clemens --- Created attachment 83457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83457&action=edit Bug 15774: Do not fetch additional fields from GetSubscription Finally we do not wan

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #109 from Nick Clemens --- Created attachment 83456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83456&action=edit Bug 15774: Fix and unify additional_fields in C4::Serials Signed-off-by: Jonathan Dr

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #107 from Nick Clemens --- Created attachment 83454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83454&action=edit Bug 15774: Fix insert and update for subscription Call it a typo Signed-off-by: Jon

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #108 from Nick Clemens --- Created attachment 83455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83455&action=edit Bug 15774: Add missing tests for Koha::Object::Mixin::AdditionalFields Signed-off-by

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #105 from Nick Clemens --- Created attachment 83452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83452&action=edit Bug 15774: (follow-up) Address QA issues Signed-off-by: Jonathan Druart -- You ar

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #106 from Nick Clemens --- Created attachment 83453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83453&action=edit Bug 15774: Use the include file to display the subscription's additional fields We h

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #98 from Nick Clemens --- Created attachment 83445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83445&action=edit Bug 15774: (QA follow-up) Make sure that tablename is correctly saved Signed-off-by:

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #104 from Nick Clemens --- Created attachment 83451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83451&action=edit Bug 15774: Fix JS check when AV and MARC field are both selected Signed-off-by: Jona

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #103 from Nick Clemens --- Created attachment 83450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83450&action=edit Bug 15774: (follow-up) Add html filters Signed-off-by: Séverine QUEUNE Signed-off-

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #101 from Nick Clemens --- Created attachment 83448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83448&action=edit Bug 15774: Add POD and license notices Signed-off-by: Séverine QUEUNE Signed-off-b

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #99 from Nick Clemens --- Created attachment 83446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83446&action=edit Bug 15774: Fix additional fields filters Addresses the following QA comments: 1/ Reg

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #102 from Nick Clemens --- Created attachment 83449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83449&action=edit Bug 15774: Show additional field values in edit form Signed-off-by: Séverine QUEUNE

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #100 from Nick Clemens --- Created attachment 83447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83447&action=edit Bug 15774: Use Koha::Object(s) for additional fields A lot of code can be removed ju

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are recei

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens changed: What|Removed |Added Attachment #83349|0 |1 is obsolete|

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #96 from Katrin Fischer --- Comment on attachment 83364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83364 Bug 15774: Add permission for managing additional fields Review of attachment 83364: --> (

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA -- You are rece

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #90 from Nick Clemens --- Created attachment 83359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83359&action=edit Bug 15774: Fix insert and update for subscription Call it a typo Signed-off-by: Jona

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #93 from Nick Clemens --- Created attachment 83362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83362&action=edit Bug 15774: Do not fetch additional fields from GetSubscription Finally we do not want

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #92 from Nick Clemens --- Created attachment 83361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83361&action=edit Bug 15774: Fix and unify additional_fields in C4::Serials Signed-off-by: Jonathan Dru

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #91 from Nick Clemens --- Created attachment 83360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83360&action=edit Bug 15774: Add missing tests for Koha::Object::Mixin::AdditionalFields Signed-off-by:

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #95 from Nick Clemens --- Created attachment 83364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83364&action=edit Bug 15774: Add permission for managing additional fields To test: 1 - Have three bor

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #94 from Nick Clemens --- Created attachment 83363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83363&action=edit Bug 15774: Remove unecessary returned value for ->delete Signed-off-by: Jonathan Drua

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #84 from Nick Clemens --- Created attachment 83353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83353&action=edit Bug 15774: Add POD and license notices Signed-off-by: Séverine QUEUNE Signed-off-by

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #85 from Nick Clemens --- Created attachment 83354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83354&action=edit Bug 15774: Show additional field values in edit form Signed-off-by: Séverine QUEUNE

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #87 from Nick Clemens --- Created attachment 83356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83356&action=edit Bug 15774: Fix JS check when AV and MARC field are both selected Signed-off-by: Jonat

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #89 from Nick Clemens --- Created attachment 83358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83358&action=edit Bug 15774: Use the include file to display the subscription's additional fields We ha

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #82 from Nick Clemens --- Created attachment 83351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83351&action=edit Bug 15774: Fix additional fields filters Addresses the following QA comments: 1/ Reg

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #88 from Nick Clemens --- Created attachment 83357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83357&action=edit Bug 15774: (follow-up) Address QA issues Signed-off-by: Jonathan Druart -- You are

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #86 from Nick Clemens --- Created attachment 83355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83355&action=edit Bug 15774: (follow-up) Add html filters Signed-off-by: Séverine QUEUNE Signed-off-b

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #83 from Nick Clemens --- Created attachment 83352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83352&action=edit Bug 15774: Use Koha::Object(s) for additional fields A lot of code can be removed jus

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens changed: What|Removed |Added Attachment #81837|0 |1 is obsolete|

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #81 from Nick Clemens --- Created attachment 83350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83350&action=edit Bug 15774: (QA follow-up) Make sure that tablename is correctly saved Signed-off-by:

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are recei

[Koha-bugs] [Bug 15774] Additional fields for baskets

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #79 from Jonathan Druart --- Patches rebased: https://gitlab.com/joubu/Koha/commits/bug_15774 -- You are receiving this mail because: You are watching all bug changes. ___ Ko

  1   2   >