[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18804

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18305


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18305
[Bug 18305] jquery.fixFloat.js breaks advanced MARC editor for some browsers
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Frédéric Demians  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #32 from Frédéric Demians  ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #31 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Jonathan, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #30 from Nick Clemens  ---
I like this a lot, the styling feels more consistent with existing functions
than the save button on its own.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Nick Clemens  changed:

   What|Removed |Added

  Attachment #51569|0   |1
is obsolete||

--- Comment #29 from Nick Clemens  ---
Created attachment 52770
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52770=edit
Bug 16400 [Follow-up] Proposal to uniform the placement of submit buttons

This follow-up makes some corrections to the markup of the cancel
button:

- Use  instead of  to eliminate the need for an "onclick"
  attribute.
- Remove the "cancel" class which adds unwanted padding.
- Correct the destination of the cancel button when cancelling during an
  edit (should redirect to the patron detail page).

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Nick Clemens  changed:

   What|Removed |Added

  Attachment #51550|0   |1
is obsolete||

--- Comment #28 from Nick Clemens  ---
Created attachment 52769
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52769=edit
Bug 16400: Use the fa-times icon for Cancel

Signed-off-by: Owen Leonard 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Nick Clemens  changed:

   What|Removed |Added

  Attachment #51549|0   |1
is obsolete||

--- Comment #27 from Nick Clemens  ---
Created attachment 52768
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52768=edit
Bug 16400: Restore the previous stack order behavior

When updating the plugin, the stack order behavior has changed. This
patch restores the prevous behavior (not always z-index: 1000)

Signed-off-by: Owen Leonard 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Nick Clemens  changed:

   What|Removed |Added

  Attachment #51548|0   |1
is obsolete||

--- Comment #26 from Nick Clemens  ---
Created attachment 52767
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52767=edit
Bug 16400: Reintroduce the floating class

Signed-off-by: Owen Leonard 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Nick Clemens  changed:

   What|Removed |Added

  Attachment #51547|0   |1
is obsolete||

--- Comment #25 from Nick Clemens  ---
Created attachment 52766
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52766=edit
Bug 16400: Let's hack the fixFloat plugin to fix our needs

On comment bug 11088 comment 2, Owen explained the problem with the
fixFloat toolbar. Since we have a hidden div, the plugin does not manage
to place the toolbar correctly.
In order to make it work, this patch adds some changes to the plugin to
add the ability to define our own offset.
When the div is extended (+, filteraction_on), the offset should be
updated to move the toolbar. Same when the div is folded (-,
filteraction_off)

Signed-off-by: Owen Leonard 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Nick Clemens  changed:

   What|Removed |Added

  Attachment #51546|0   |1
is obsolete||

--- Comment #24 from Nick Clemens  ---
Created attachment 52765
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52765=edit
Bug 16400: Update the fixFloat plugin

I have updated it just in case it fixed the issue.
I don't think there are big changes between our current version and this
one, so keep it up-to-date

Signed-off-by: Owen Leonard 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #51551|0   |1
is obsolete||

--- Comment #23 from Jonathan Druart  
---
Created attachment 51569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51569=edit
Bug 16400 [Follow-up] Proposal to uniform the placement of submit buttons

This follow-up makes some corrections to the markup of the cancel
button:

- Use  instead of  to eliminate the need for an "onclick"
  attribute.
- Remove the "cancel" class which adds unwanted padding.
- Correct the destination of the cancel button when cancelling during an
  edit (should redirect to the patron detail page).

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #22 from Owen Leonard  ---
I don't think every save and submit button should be in a scrolling toolbar,
but I'm not sure how we should define the rules. Right now the rule is "if the
form is big," but I'm not sure how you make that more specific.

I think our guidelines should allow for simpler forms to have simpler controls.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #21 from Aleisha Amohia  ---
This is looking good.

So is the purpose of this to have every Save and Submit button a scrolling
toolbar? In which cases can we just have the buttons at the bottom? Are we
going to add patches with toolbars for all the modules etc. to this bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #20 from Owen Leonard  ---
Created attachment 51551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51551=edit
Bug 16400 [Follow-up] Proposal to uniform the placement of submit buttons

This follow-up makes some corrections to the markup of the cancel
button:

- Use  instead of  to eliminate the need for an "onclick"
  attribute.
- Remove the "cancel" class which adds unwanted padding.
- Correct the destination of the cancel button when cancelling during an
  edit (should redirect to the patron detail page).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Owen Leonard  changed:

   What|Removed |Added

  Attachment #51144|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Owen Leonard  changed:

   What|Removed |Added

  Attachment #51145|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Owen Leonard  changed:

   What|Removed |Added

  Attachment #51043|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Owen Leonard  changed:

   What|Removed |Added

  Attachment #51471|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Owen Leonard  changed:

   What|Removed |Added

  Attachment #51517|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #18 from Owen Leonard  ---
Created attachment 51549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51549=edit
[SIGNED-OFF] Bug 16400: Restore the previous stack order behavior

When updating the plugin, the stack order behavior has changed. This
patch restores the prevous behavior (not always z-index: 1000)

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #19 from Owen Leonard  ---
Created attachment 51550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51550=edit
[SIGNED-OFF] Bug 16400: Use the fa-times icon for Cancel

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #17 from Owen Leonard  ---
Created attachment 51548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51548=edit
[SIGNED-OFF] Bug 16400: Reintroduce the floating class

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #15 from Owen Leonard  ---
Created attachment 51546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51546=edit
[SIGNED-OFF] Bug 16400: Update the fixFloat plugin

I have updated it just in case it fixed the issue.
I don't think there are big changes between our current version and this
one, so keep it up-to-date

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #16 from Owen Leonard  ---
Created attachment 51547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51547=edit
[SIGNED-OFF] Bug 16400: Let's hack the fixFloat plugin to fix our needs

On comment bug 11088 comment 2, Owen explained the problem with the
fixFloat toolbar. Since we have a hidden div, the plugin does not manage
to place the toolbar correctly.
In order to make it work, this patch adds some changes to the plugin to
add the ability to define our own offset.
When the div is extended (+, filteraction_on), the offset should be
updated to move the toolbar. Same when the div is folded (-,
filteraction_off)

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #14 from Jonathan Druart  
---
Created attachment 51517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51517=edit
Bug 16400: Use the fa-times icon for Cancel

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #13 from Aleisha Amohia  ---
Hi Jonathan,

I like this. The buttons on the member entry page for adding a new patron don't
have any space between them, but that's the only thing I could find wrong.

Something else did come to mind - I think the cancel buttons should use the fa
fa-times icon like many of our other cancel buttons. Thoughts?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #11 from Jonathan Druart  
---
Created attachment 51471
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51471=edit
Bug 16400: Restore the previous stack order behavior

When updating the plugin, the stack order behavior has changed. This
patch restores the prevous behavior (not always z-index: 1000)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #12 from Jonathan Druart  
---
Aleisha, thanks for testing!
The last patch fixes the issue you got.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #10 from Aleisha Amohia  ---
Created attachment 51449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51449=edit
Toolbar covers drop down menu

I'm getting this problem where the syspref toolbar covers the drop down menu.

Agreed that it would be nice to have some consistency across the buttons.
Having just 'Save' and 'Cancel' in the toolbar alone doesn't bother me too much
imo!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Jonathan Druart  changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com,
   ||katrin.fisc...@bsz-bw.de,
   ||tomasco...@gmail.com

--- Comment #9 from Jonathan Druart  
---
Adding Aleisha, Tomas and Katrin to the discussion.

What are your thoughts about the 2 displays/behaviors?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #51044|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  
---
Created attachment 51144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51144=edit
Bug 16400: Let's hack the fixFloat plugin to fix our needs

On comment bug 11088 comment 2, Owen explained the problem with the
fixFloat toolbar. Since we have a hidden div, the plugin does not manage
to place the toolbar correctly.
In order to make it work, this patch adds some changes to the plugin to
add the ability to define our own offset.
When the div is extended (+, filteraction_on), the offset should be
updated to move the toolbar. Same when the div is folded (-,
filteraction_off)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #8 from Jonathan Druart  
---
(In reply to Owen Leonard from comment #5)
> I'm having some problems with this patch:
> 
> - It needs to be rebased (although I think I was able to correctly fix the
> merge problems for testing).

Done.

> - In my tests the toolbar doesn't "stick' to the top of the viewport because
> it has a margin on it.
> - When it is floating, the toolbar isn't styled like it is on other pages
> without this patch. There is a "floating" class which isn't getting added.

Last patch reintroduces the floating class.

> - It breaks other instances of the floating toolbar. I'm getting a JS error
> on the cataloging page, for instance.

Fixed, I have updated the second patch.

> I'm not sure why, but having only "save" and "cancel" in the toolbar doesn't
> feel right to me. But I agree that we need to be consistent, and I agree
> that this page really needs some form of always-visible save button.

As I said, the patches are here for discussion.
I have understood from the discussion on bug 11088 that it's what you needed
but you did not manage to implement it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #7 from Jonathan Druart  
---
Created attachment 51145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51145=edit
Bug 16400: Reintroduce the floating class

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #5 from Owen Leonard  ---
I'm having some problems with this patch:

- It needs to be rebased (although I think I was able to correctly fix the
merge problems for testing).
- In my tests the toolbar doesn't "stick' to the top of the viewport because it
has a margin on it.
- When it is floating, the toolbar isn't styled like it is on other pages
without this patch. There is a "floating" class which isn't getting added.
- It breaks other instances of the floating toolbar. I'm getting a JS error on
the cataloging page, for instance.

I'm not sure why, but having only "save" and "cancel" in the toolbar doesn't
feel right to me. But I agree that we need to be consistent, and I agree that
this page really needs some form of always-visible save button.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|In Discussion

--- Comment #4 from Jonathan Druart  
---
These patches are here for discussion, but it would be good to reach a
consensus for the next release.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #3 from Jonathan Druart  
---
Created attachment 51044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51044=edit
Bug 16400: Let's hack the fixFloat plugin to fix our needs

On comment bug 11088 comment 2, Owen explained the problem with the
fixFloat toolbar. Since we have a hidden div, the plugin does not manage
to place the toolbar correctly.
In order to make it work, this patch adds some changes to the plugin to
add the ability to define our own offset.
When the div is extended (+, filteraction_on), the offset should be
updated to move the toolbar. Same when the div is folded (-,
filteraction_off)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #2 from Jonathan Druart  
---
Created attachment 51043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51043=edit
Bug 16400: Update the fixFloat plugin

I have updated it just in case it fixed the issue.
I don't think there are big changes between our current version and this
one, so keep it up-to-date

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

--- Comment #1 from Owen Leonard  ---
And in some places, fixed at the top. For example, when editing MARC authority
record subfields:

/cgi-bin/koha/admin/auth_subfields_structure.pl?op=add_form=000=

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/