[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Magnus Enger  changed:

   What|Removed |Added

 Blocks||19221


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19221
[Bug 19221] Onboarding tool says user needs to be made superlibrarian
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19041


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19041
[Bug 19041] footerjs = 1 removed by bug 17855
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18749


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18749
[Bug 18749] xt/sample notices fails with "No sample notice to delete"
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18673


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18673
[Bug 18673] News author does not display on staff client home page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Liz Rea  changed:

   What|Removed |Added

  Text to go in the|After the web installer has |Koha now has a new tool to
  release notes|finished the user is|get Koha users up and
   |redirected to the   |running quickly after a new
   |onboarding tool (with no|install. The user is
   |authentication required in  |prompted to create their
   |between). In the onboarding |first user, library,
   |tool they create a: |category code, item type,
   |Library, Patron category,   |and circulation rule just
   |Item type (if they were not |after the database install
   |installed in the web|has completed. Getting
   |installer).
|started with Koha has never
   |In addition to  |been easier.
   |always creating a:
 |
   |Patron  |
   |(which has super librarian  |
   |privileges which the user   |
   |will use to log into Koha   |
   |with), Circulation rule |
   |Then the user is redirected |
   |to a login page where they  |
   |login using the patron they |
   |just created. If they   |
   |entered the correct patron  |
   |account credentials the |
   |Koha homepage will appear,  |
   |and the user can start  |
   |using Koha as intended due  |
   |to all necessary data being |
   |installed.  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Zeno Tajoli  changed:

   What|Removed |Added

  Text to go in the||After the web installer has
  release notes||finished the user is
   ||redirected to the
   ||onboarding tool (with no
   ||authentication required in
   ||between). In the onboarding
   ||tool they create a:
   ||Library, Patron category,
   ||Item type (if they were not
   ||installed in the web
   ||installer).
   ||In addition to
   ||always creating a:
   ||Patron
   ||(which has super librarian
   ||privileges which the user
   ||will use to log into Koha
   ||with), Circulation rule
   ||Then the user is redirected
   ||to a login page where they
   ||login using the patron they
   ||just created. If they
   ||entered the correct patron
   ||account credentials the
   ||Koha homepage will appear,
   ||and the user can start
   ||using Koha as intended due
   ||to all necessary data being
   ||installed.
 CC||z.taj...@cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

--- Comment #234 from Katrin Fischer  ---
This won't get ported back to 16.11.x as it is a new feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |new feature

--- Comment #233 from Katrin Fischer  ---
This is a new idea - I suggest marking it as 'new' instead of 'enhancement'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #232 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Alex, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Jonathan Druart  changed:

   What|Removed |Added

Version|17.05   |unspecified

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #230 from Jonathan Druart  
---
Created attachment 62674
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62674=edit
Bug 17855: No need to resend the library list to the template

This has been done at the beginning of the script

Signed-off-by: Alex Buckley 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #228 from Jonathan Druart  
---
Created attachment 62672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62672=edit
Bug 17855: Do not create a new dbh, get it from C4::Context->dbh

Signed-off-by: Alex Buckley 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #229 from Jonathan Druart  
---
Created attachment 62673
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62673=edit
Bug 17855: Redirect to the installer if installation process is not done yet

Signed-off-by: Alex Buckley 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #231 from Jonathan Druart  
---
Created attachment 62675
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62675=edit
Bug 17855: Simplify the onboarding tool

This patch should not modify a lot the behaviours of the onboarding
tool.
Its goal is mainly to remove duplicated as well as useless (because
copy/pasted from existing script files) code.

It assumes that the onboarding tool will be done on an empty database
and will skip steps that are not needed. For instance if a library
already exists, the first step will be skipped.

One of the main problem was the lack of feedback messages sent to the
user when something wrong/ok happened.

Explanation on main changes:
1. Use checkauth first, then get_template_and_user
=> As we do not know the template to use, it's better to use checkauth
first to know if the user is logged in, then retrieve the template we
need, depending on the success or the failure of the action
2. Create a @messages variables
Pushing messages to this variable and handling the messages via an
include files (onboarding_messages.inc) simplify error handling. Note
that we could remove this include file if we merge all the
onboardingstepX.tt files altogether
3. Simplify creation of the admnistrator user
This patch removes some unecessary checks done on the user's info
(passwd to short, mandatory fields

Todo (minor): Add style to feedback messages

Signed-off-by: Alex Buckley 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #226 from Jonathan Druart  
---
Created attachment 62670
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62670=edit
Bug 17855 - Followup patch following requests in comments 176 and 177

Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #227 from Jonathan Druart  
---
Created attachment 62671
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62671=edit
Bug 17855: perltidy onboarding.pl

Signed-off-by: Alex Buckley 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #225 from Jonathan Druart  
---
Created attachment 62669
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62669=edit
Bug 17855 - Reverted back to original step 3 in the web installer so there is
no basic and advanced setup mode and consequently no need for SQL files to be
moved to a 'default' directory for all languages.

Onboarding tool and the rest of the web installer still exists in this
commit

How I tested in my VM (Current master):
- Dropped database
- Recreated database
- Went through installer
- Language en, Marc21
- Installed mandatory data only
- Went through Onboarding tool
- After finishing, logged in as superlibrarian
  that was created by onboarding tool
Everything worked fine.

Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #62281|0   |1
is obsolete||
  Attachment #62282|0   |1
is obsolete||
  Attachment #62283|0   |1
is obsolete||
  Attachment #62284|0   |1
is obsolete||
  Attachment #62285|0   |1
is obsolete||
  Attachment #62286|0   |1
is obsolete||
  Attachment #62287|0   |1
is obsolete||
  Attachment #62288|0   |1
is obsolete||

--- Comment #224 from Jonathan Druart  
---
Created attachment 62668
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62668=edit
Bug 17855: Onboarding tool

Tested 3 patches together on current master
- Dropped database
- Recreated database
- Went through installer
- Language en, Marc21
- Installed mandatory data only
- Went through Onboarding tool
- After finishing, logged in as superlibrarian
  that was created by onboarding tool
Everything worked fine.

Signed-off-by: Marc Véron 

Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Owen Leonard  changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Blocks|18346   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18346
[Bug 18346] Improved web installer containing basic and advanced setup modes
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Marc Véron  changed:

   What|Removed |Added

 Blocks||18346


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18346
[Bug 18346] Improved web installer containing basic and advanced setup modes
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Marc Véron  changed:

   What|Removed |Added

 Blocks|18346   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18346
[Bug 18346] Improved web installer containing basic and advanced setup modes
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18462

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #220 from Jonathan Druart  
---
Created attachment 62285
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62285=edit
Bug 17855: Do not create a new dbh, get it from C4::Context->dbh

Signed-off-by: Alex Buckley 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #222 from Jonathan Druart  
---
Created attachment 62287
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62287=edit
Bug 17855: No need to resend the library list to the template

This has been done at the beginning of the script

Signed-off-by: Alex Buckley 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #218 from Jonathan Druart  
---
Created attachment 62283
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62283=edit
Bug 17855 - Followup patch following requests in comments 176 and 177

Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #221 from Jonathan Druart  
---
Created attachment 62286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62286=edit
Bug 17855: Redirect to the installer if installation process is not done yet

Signed-off-by: Alex Buckley 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #223 from Jonathan Druart  
---
Created attachment 62288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62288=edit
Bug 17855: Simplify the onboarding tool

This patch should not modify a lot the behaviours of the onboarding
tool.
Its goal is mainly to remove duplicated as well as useless (because
copy/pasted from existing script files) code.

It assumes that the onboarding tool will be done on an empty database
and will skip steps that are not needed. For instance if a library
already exists, the first step will be skipped.

One of the main problem was the lack of feedback messages sent to the
user when something wrong/ok happened.

Explanation on main changes:
1. Use checkauth first, then get_template_and_user
=> As we do not know the template to use, it's better to use checkauth
first to know if the user is logged in, then retrieve the template we
need, depending on the success or the failure of the action
2. Create a @messages variables
Pushing messages to this variable and handling the messages via an
include files (onboarding_messages.inc) simplify error handling. Note
that we could remove this include file if we merge all the
onboardingstepX.tt files altogether
3. Simplify creation of the admnistrator user
This patch removes some unecessary checks done on the user's info
(passwd to short, mandatory fields

Todo (minor): Add style to feedback messages

Signed-off-by: Alex Buckley 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #217 from Jonathan Druart  
---
Created attachment 62282
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62282=edit
Bug 17855 - Reverted back to original step 3 in the web installer so there is
no basic and advanced setup mode and consequently no need for SQL files to be
moved to a 'default' directory for all languages.

Onboarding tool and the rest of the web installer still exists in this
commit

How I tested in my VM (Current master):
- Dropped database
- Recreated database
- Went through installer
- Language en, Marc21
- Installed mandatory data only
- Went through Onboarding tool
- After finishing, logged in as superlibrarian
  that was created by onboarding tool
Everything worked fine.

Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #219 from Jonathan Druart  
---
Created attachment 62284
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62284=edit
Bug 17855: perltidy onboarding.pl

Signed-off-by: Alex Buckley 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #62251|0   |1
is obsolete||
  Attachment #62252|0   |1
is obsolete||
  Attachment #62253|0   |1
is obsolete||
  Attachment #62259|0   |1
is obsolete||
  Attachment #62260|0   |1
is obsolete||
  Attachment #62261|0   |1
is obsolete||
  Attachment #62262|0   |1
is obsolete||
  Attachment #62263|0   |1
is obsolete||

--- Comment #216 from Jonathan Druart  
---
Created attachment 62281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62281=edit
Bug 17855: Onboarding tool

Tested 3 patches together on current master
- Dropped database
- Recreated database
- Went through installer
- Language en, Marc21
- Installed mandatory data only
- Went through Onboarding tool
- After finishing, logged in as superlibrarian
  that was created by onboarding tool
Everything worked fine.

Signed-off-by: Marc Véron 

Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #62258|0   |1
is obsolete||

--- Comment #215 from Alex Buckley  ---
Created attachment 62263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62263=edit
Bug 17855: Simplify the onboarding tool

This patch should not modify a lot the behaviours of the onboarding
tool.
Its goal is mainly to remove duplicated as well as useless (because
copy/pasted from existing script files) code.

It assumes that the onboarding tool will be done on an empty database
and will skip steps that are not needed. For instance if a library
already exists, the first step will be skipped.

One of the main problem was the lack of feedback messages sent to the
user when something wrong/ok happened.

Explanation on main changes:
1. Use checkauth first, then get_template_and_user
=> As we do not know the template to use, it's better to use checkauth
first to know if the user is logged in, then retrieve the template we
need, depending on the success or the failure of the action
2. Create a @messages variables
Pushing messages to this variable and handling the messages via an
include files (onboarding_messages.inc) simplify error handling. Note
that we could remove this include file if we merge all the
onboardingstepX.tt files altogether
3. Simplify creation of the admnistrator user
This patch removes some unecessary checks done on the user's info
(passwd to short, mandatory fields

Todo (minor): Add style to feedback messages

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #62257|0   |1
is obsolete||

--- Comment #214 from Alex Buckley  ---
Created attachment 62262
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62262=edit
Bug 17855: No need to resend the library list to the template

This has been done at the beginning of the script

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #62256|0   |1
is obsolete||

--- Comment #213 from Alex Buckley  ---
Created attachment 62261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62261=edit
Bug 17855: Redirect to the installer if installation process is not done yet

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #62255|0   |1
is obsolete||

--- Comment #212 from Alex Buckley  ---
Created attachment 62260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62260=edit
Bug 17855: Do not create a new dbh, get it from C4::Context->dbh

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #62254|0   |1
is obsolete||

--- Comment #211 from Alex Buckley  ---
Created attachment 62259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62259=edit
Bug 17855: perltidy onboarding.pl

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #210 from Alex Buckley  ---
Created attachment 62258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62258=edit
Bug 17855: Simplify the onboarding tool

This patch should not modify a lot the behaviours of the onboarding
tool.
Its goal is mainly to remove duplicated as well as useless (because
copy/pasted from existing script files) code.

It assumes that the onboarding tool will be done on an empty database
and will skip steps that are not needed. For instance if a library
already exists, the first step will be skipped.

One of the main problem was the lack of feedback messages sent to the
user when something wrong/ok happened.

Explanation on main changes:
1. Use checkauth first, then get_template_and_user
=> As we do not know the template to use, it's better to use checkauth
first to know if the user is logged in, then retrieve the template we
need, depending on the success or the failure of the action
2. Create a @messages variables
Pushing messages to this variable and handling the messages via an
include files (onboarding_messages.inc) simplify error handling. Note
that we could remove this include file if we merge all the
onboardingstepX.tt files altogether
3. Simplify creation of the admnistrator user
This patch removes some unecessary checks done on the user's info
(passwd to short, mandatory fields

Todo (minor): Add style to feedback messages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #209 from Alex Buckley  ---
Created attachment 62257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62257=edit
Bug 17855: No need to resend the library list to the template

This has been done at the beginning of the script

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #208 from Alex Buckley  ---
Created attachment 62256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62256=edit
Bug 17855: Redirect to the installer if installation process is not done yet

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #207 from Alex Buckley  ---
Created attachment 62255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62255=edit
Bug 17855: Do not create a new dbh, get it from C4::Context->dbh

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #205 from Alex Buckley  ---
Created attachment 62253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62253=edit
Bug 17855 - Followup patch following requests in comments 176 and 177

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #206 from Alex Buckley  ---
Created attachment 62254
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62254=edit
Bug 17855: perltidy onboarding.pl

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #204 from Alex Buckley  ---
Created attachment 62252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62252=edit
Bug 17855 - Reverted back to original step 3 in the web installer so there is
no basic and advanced setup mode and consequently no need for SQL files to be
moved to a 'default' directory for all languages.

Onboarding tool and the rest of the web installer still exists in this
commit

How I tested in my VM (Current master):
- Dropped database
- Recreated database
- Went through installer
- Language en, Marc21
- Installed mandatory data only
- Went through Onboarding tool
- After finishing, logged in as superlibrarian
  that was created by onboarding tool
Everything worked fine.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #203 from Alex Buckley  ---
Created attachment 62251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62251=edit
Bug 17855: Onboarding tool

Tested 3 patches together on current master
- Dropped database
- Recreated database
- Went through installer
- Language en, Marc21
- Installed mandatory data only
- Went through Onboarding tool
- After finishing, logged in as superlibrarian
  that was created by onboarding tool
Everything worked fine.

Signed-off-by: Marc Véron 

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #62193|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #62192|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #62191|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #62239|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #62240|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #62241|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #62242|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #62243|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #62238|0   |1
is obsolete||

--- Comment #202 from Alex Buckley  ---
Created attachment 62243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62243=edit
Bug 17855: perltidy onboarding.pl

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #201 from Jonathan Druart  
---
Created attachment 62242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62242=edit
Bug 17855: Simplify the onboarding tool

This patch should not modify a lot the behaviours of the onboarding
tool.
Its goal is mainly to remove duplicated as well as useless (because
copy/pasted from existing script files) code.

It assumes that the onboarding tool will be done on an empty database
and will skip steps that are not needed. For instance if a library
already exists, the first step will be skipped.

One of the main problem was the lack of feedback messages sent to the
user when something wrong/ok happened.

Explanation on main changes:
1. Use checkauth first, then get_template_and_user
=> As we do not know the template to use, it's better to use checkauth
first to know if the user is logged in, then retrieve the template we
need, depending on the success or the failure of the action
2. Create a @messages variables
Pushing messages to this variable and handling the messages via an
include files (onboarding_messages.inc) simplify error handling. Note
that we could remove this include file if we merge all the
onboardingstepX.tt files altogether
3. Simplify creation of the admnistrator user
This patch removes some unecessary checks done on the user's info
(passwd to short, mandatory fields

Todo (minor): Add style to feedback messages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #200 from Jonathan Druart  
---
Created attachment 62241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62241=edit
Bug 17855: No need to resend the library list to the template

This has been done at the beginning of the script

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #199 from Jonathan Druart  
---
Created attachment 62240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62240=edit
Bug 17855: Redirect to the installer if installation process is not done yet

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #198 from Jonathan Druart  
---
Created attachment 62239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62239=edit
Bug 17855: Do not create a new dbh, get it from C4::Context->dbh

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #62233|0   |1
is obsolete||
  Attachment #62234|0   |1
is obsolete||
  Attachment #62235|0   |1
is obsolete||
  Attachment #62236|0   |1
is obsolete||
  Attachment #62237|0   |1
is obsolete||

--- Comment #197 from Jonathan Druart  
---
Created attachment 62238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62238=edit
Bug 17855: perltidy onboarding.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #62231|0   |1
is obsolete||

--- Comment #196 from Alex Buckley  ---
Created attachment 62237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62237=edit
Bug 17855: Simplify the onboarding tool

This patch should not modify a lot the behaviours of the onboarding
tool.
Its goal is mainly to remove duplicated as well as useless (because
copy/pasted from existing script files) code.

It assumes that the onboarding tool will be done on an empty database
and will skip steps that are not needed. For instance if a library
already exists, the first step will be skipped.

One of the main problem was the lack of feedback messages sent to the
user when something wrong/ok happened.

Explanation on main changes:
1. Use checkauth first, then get_template_and_user
=> As we do not know the template to use, it's better to use checkauth
first to know if the user is logged in, then retrieve the template we
need, depending on the success or the failure of the action
2. Create a @messages variables
Pushing messages to this variable and handling the messages via an
include files (onboarding_messages.inc) simplify error handling. Note
that we could remove this include file if we merge all the
onboardingstepX.tt files altogether
3. Simplify creation of the admnistrator user
This patch removes some unecessary checks done on the user's info
(passwd to short, mandatory fields

Todo (minor): Add style to feedback messages

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #62223|0   |1
is obsolete||

--- Comment #195 from Alex Buckley  ---
Created attachment 62236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62236=edit
Bug 17855: No need to resend the library list to the template

This has been done at the beginning of the script

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #6|0   |1
is obsolete||

--- Comment #194 from Alex Buckley  ---
Created attachment 62235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62235=edit
Bug 17855: Redirect to the installer if installation process is not done yet

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #62221|0   |1
is obsolete||

--- Comment #193 from Alex Buckley  ---
Created attachment 62234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62234=edit
Bug 17855: Do not create a new dbh, get it from C4::Context->dbh

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

  Attachment #62220|0   |1
is obsolete||

--- Comment #192 from Alex Buckley  ---
Created attachment 62233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62233=edit
Bug 17855: perltidy onboarding.pl

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #191 from Jonathan Druart  
---
Alex, use `git show -w` to see the modifications without the indentation
changes (especially for .tt files).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #190 from Jonathan Druart  
---
Hi Alex and Marc,
Would you mind taking a look at this patch?
I have removed and simplified some code.
Hope it makes sense to you.

Sorry to ask for another signoff again...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #189 from Jonathan Druart  
---
Created attachment 62231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62231=edit
Bug 17855: Simplify the onboarding tool

This patch should not modify a lot the behaviours of the onboarding
tool.
Its goal is mainly to remove duplicated as well as useless (because
copy/pasted from existing script files) code.

It assumes that the onboarding tool will be done on an empty database
and will skip steps that are not needed. For instance if a library
already exists, the first step will be skipped.

One of the main problem was the lack of feedback messages sent to the
user when something wrong/ok happened.

Explanation on main changes:
1. Use checkauth first, then get_template_and_user
=> As we do not know the template to use, it's better to use checkauth
first to know if the user is logged in, then retrieve the template we
need, depending on the success or the failure of the action
2. Create a @messages variables
Pushing messages to this variable and handling the messages via an
include files (onboarding_messages.inc) simplify error handling. Note
that we could remove this include file if we merge all the
onboardingstepX.tt files altogether
3. Simplify creation of the admnistrator user
This patch removes some unecessary checks done on the user's info
(passwd to short, mandatory fields

Todo (minor): Add style to feedback messages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|alexbuck...@catalyst.net.nz |jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #188 from Jonathan Druart  
---
I am on it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #187 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #176)
> - If I hit onboarding.pl or install.pl once the install is done, I login
> with DB user, click on "next" twice and end  on a "Koha web installer › Step
> 3" with a button "Back to Installation".
> Before this patch it was a "Continue to log in to Koha".
> This is wrong.

This was not only a wording issue, to recreate:
Go throw the install process, do not use the onboarding tool.
Hit /cgi-bin/koha/installer/install.pl, login.
You are redirected to
http://pro.kohadev.vm/cgi-bin/koha/installer/install.pl?step=3, then click
"update your database", then "Continue to log in to Koha"
But actually the current behaviour should be sufficient, do not worry about
that.

However there are several other things wrong (sorry to always find something
wrong...)
The errors are not correctly handled. For instance if the branchcode already
exists when you create a new library, you do not get the correct error.
I do not know how we could achieve that easily with 1 template per step. Indeed
we need to call get_template_and_user to know if the user is logged in, but we
pass the template file we need at that point.

I will think a bit more about that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #186 from Jonathan Druart  
---
Created attachment 62223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62223=edit
Bug 17855: No need to resend the library list to the template

This has been done at the beginning of the script

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #183 from Jonathan Druart  
---
Created attachment 62220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62220=edit
Bug 17855: perltidy onboarding.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #184 from Jonathan Druart  
---
Created attachment 62221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62221=edit
Bug 17855: Do not create a new dbh, get it from C4::Context->dbh

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #185 from Jonathan Druart  
---
Created attachment 6
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6=edit
Bug 17855: Redirect to the installer if installation process is not done yet

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Marc Véron  changed:

   What|Removed |Added

  Attachment #61986|0   |1
is obsolete||

--- Comment #181 from Marc Véron  ---
Created attachment 62192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62192=edit
Bug 17855 - Reverted back to original step 3 in the web installer so there is
no basic and advanced setup mode and consequently no need for SQL files to be
moved to a 'default' directory for all languages.

Onboarding tool and the rest of the web installer still exists in this
commit

How I tested in my VM (Current master):
- Dropped database
- Recreated database
- Went through installer
- Language en, Marc21
- Installed mandatory data only
- Went through Onboarding tool
- After finishing, logged in as superlibrarian
  that was created by onboarding tool
Everything worked fine.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Marc Véron  changed:

   What|Removed |Added

  Attachment #62186|0   |1
is obsolete||

--- Comment #182 from Marc Véron  ---
Created attachment 62193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62193=edit
Bug 17855 - Followup patch following requests in comments 176 and 177

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Marc Véron  changed:

   What|Removed |Added

  Attachment #61667|0   |1
is obsolete||

--- Comment #180 from Marc Véron  ---
Created attachment 62191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62191=edit
Bug 17855: Onboarding tool

Tested 3 patches together on current master
- Dropped database
- Recreated database
- Went through installer
- Language en, Marc21
- Installed mandatory data only
- Went through Onboarding tool
- After finishing, logged in as superlibrarian
  that was created by onboarding tool
Everything worked fine.

Signed-off-by: Marc Véron 

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #179 from Alex Buckley  ---
In the 'Bug 17855 - Followup patch following requests in comments 176 and 177'
patch I have addressed all issues brought up in comments 176 and 177, see
below:

1. Removed the  tag from all installer/*.tt files

2. I cannot remember the rationale for the change of the wording from 'update
your database' so I have changed it back to 'Update your database'. Note: I
have made only the first letter capitalised thus meeting coding guidelines. 

3. I have changed 'Install Basic Configuration Settings' to 'Install basic
configuration settings' so it meets the coding guidelines

4. In onboarding/onboardingstep5.tt I have removed max="10" limit on input
boxes

5. I have written in default values for checkouts, loan, renewals and renewal
period based on the values in the example circulation rule in the Koha 16.11
manual

6. Implemented min="0" attribute for months in "Create a new patron category"
step

7. Implemented the "Continue to log in to Koha" link (which works successfully)
if the install.pl is run after installation has been completed

8. I have checked and I can confirm that $step variable is an integer

9. I have set the $enrolementperioddate variable as a DateTime object, see
below code snippet. I  tried removing the dateformat field altogether however
that made the enrolementperioddate field empty. 

187 #Converts the string into a date format
188 if ($enrolmentperioddate) {
189 $enrolmentperioddate = output_pref(
190 {
191 dt => dt_from_string($enrolmentperioddate),
192 dateformat => 'DateTime',
193 dateonly   => 1,
194 }
195 );
196 }

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #178 from Alex Buckley  ---
Created attachment 62186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62186=edit
Bug 17855 - Followup patch following requests in comments 176 and 177

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #177 from Jonathan Druart  
---
*
+template_name => "/onboarding/onboardingstep"
+  . ( $step ? $step : 1 ) . ".tt",

Do a check on $step to make sure it is an integer, just in case...

*
+#Adds a new patron category to the database
+$category = Koha::Patron::Category->new(
+{
[SNIP]
+enrolmentperioddate   => $enrolmentperioddate,

$enrolmentperioddate is a date in iso format, I think you should be able to
give a DateTime object (return by dt_from_string) directly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #176 from Jonathan Druart  
---
- On installer/step3.tt:
I'd remove the  tag, it does not display as other buttons. Let's style
it later.
Same for the other ones (search for '' in installer/*.tt)

Why did you change the wording "update your database" to "Update Database"?

Same for "Install Basic Configuration Settings", uppercases on each word is
wrong.

- On onboarding/onboardingstep5.tt:
  * max="10" => Why? Unnecessary limitation
  * No default value for checkouts, loan, renewals and renewal period

- Step "Create a new patron category", I can choose pick negative value for
"months" (cannot confirm the form but would be good to min="0")

- If I hit onboarding.pl or install.pl once the install is done, I login with
DB user, click on "next" twice and end  on a "Koha web installer › Step 3" with
a button "Back to Installation".
Before this patch it was a "Continue to log in to Koha".
This is wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18039
 Depends on|18039   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039
[Bug 18039] Move the mandatory and optional files for non-english languages
into 'default' directory so bug 17855 permits use of other languages
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18420

--- Comment #175 from Marc Véron  ---
(In reply to Katrin Fischer from comment #173)
> Hm, should we not fix the test instead? Not sure I understood correctly, but
> having a category of 'S' should not be mandatory for the tests to pass in a
> normal environment.

No problem for me. I filed a bug:
Bug 18420 - t/dbdependent/Budgets.t fails without patron category 'S'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #174 from Liz Rea  ---
Agree with Cait, this is a problem with the test.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #173 from Katrin Fischer  ---
Hm, should we not fix the test instead? Not sure I understood correctly, but
having a category of 'S' should not be mandatory for the tests to pass in a
normal environment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #172 from Marc Véron  ---
Hi Alex,

Just found a small problem while testing around with an installation that was
configured using the onboarding tool. 

The problem was a test failing: t/dbdependent/Budgets.t
I figured out that while onboarding, step 'Create a new patron category', I had
put a Categorycode that was not 'S' (something like 'STAFF'). The test assumes
that a category 'S' exists and fails without it.
I can imagine that other tests and other scripts could fail as well.

I went again through installation / onboarding and set the category code to
'S'. Now the test passed.

Maybe it is a good idea to have in the Onboarding tool a fix value 'S' for the
new patron category. What do you think about?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
   Patch complexity|--- |Medium patch
 Status|Needs Signoff   |Signed Off

--- Comment #171 from Marc Véron  ---
Note: 
Signed off after test on current master. I did not test on top of 18039; this
dependency seems not to be necessary.
It would be fine to have some text in 'Text to go to the release notes'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Marc Véron  changed:

   What|Removed |Added

  Attachment #61668|0   |1
is obsolete||

--- Comment #170 from Marc Véron  ---
Created attachment 61986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61986=edit
Bug 17855 - Reverted back to original step 3 in the web installer so there is
no basic and advanced setup mode and consequently no need for SQL files to be
moved to a 'default' directory for all languages.

Onboarding tool and the rest of the web installer still exists in this
commit

How I tested in my VM (Current master):
- Dropped database
- Recreated database
- Went through installer
- Language en, Marc21
- Installed mandatory data only
- Went through Onboarding tool
- After finishing, logged in as superlibrarian
  that was created by onboarding tool
Everything worked fine.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Alex Buckley  changed:

   What|Removed |Added

Summary|Updated Koha web installer  |New onboarding tool feature
   |and new onboarding tool |to guide users through
   |feature to guide users  |setting up Koha, and minor
   |through setting up Koha |web installer UI
   ||improvements

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/