[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

Charles Farmer  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #14 from Charles Farmer  ---
> This is much better handled at the template level. We don't want to give 
> syspref permissions to the volunteer who prints labels.

But I'm not asking you to, I'm saying that most libraries we work with have a
systematic approach to printing barcodes. They configure it once and forget
about it, I don't understand which use case you're describing where every
barcode printed has to be padded differently.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||wizzy...@gmail.com

--- Comment #13 from Liz Rea  ---
Hi,

This is much better handled at the template level. We don't want to give
syspref permissions to the volunteer who prints labels.

Does once suffice for your three times requirement? I don't want to be rude. :)

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

Charles Farmer  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #12 from Charles Farmer  ---
(In reply to M. Tompsett from comment #7)
> Why have an enabled AND length? If the length is 0, then what is the point
> of enabled?
I agree with you, we definitely could get rid of the property if the
BarcodePaddingLength's description makes it clear that a value of 0 disables
that part of the code.

(In reply to Julian Maurice from comment #9)
> Why new system preferences ? Shouldn't it be configurable at the layout
> level ?
It depends. If you have multiple employees doing this repeatedly, and you wanna
make sure everything prints out the same way every time, it makes sense to
offer a syspref instead of forcing users to enter values over and over,
especially if the defaults aren't what they need.

Usability-wise, I think there's merit to the sysprefs, but I can see why
someone who prints barcodes once every blue moon wouldn't want to clutter its
database with additional preferences.

---

I did an in-between for now: removed the BarcodePaddingEnable pref, and changed
the  BarcodePaddingLength's description to imply that a value of 0 disables
padding.

If you say three times that the sysprefs have to go, I'll make it configurable
at the template level.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

--- Comment #11 from Charles Farmer  ---
Created attachment 77591
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77591=edit
Bug 19325: (QA follow-up) Remove a syspref, change the backend accordingly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

Charles Farmer  changed:

   What|Removed |Added

 CC||charles.far...@inlibro.com
   Assignee|david.bourga...@inlibro.com |charles.far...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

Katrin Fischer  changed:

   What|Removed |Added

 Status|In Discussion   |Failed QA

--- Comment #10 from Katrin Fischer  ---
I agree with Julian that it would be cleaner to keep all the configuration
options for the labels within the layouts.

So far only the options for the quick label print are in prefs, so this would
be a first one too.

Alex, could you take a look at the comments please and give us some feedback?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

Julian Maurice  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #9 from Julian Maurice  ---
Why new system preferences ? Shouldn't it be configurable at the layout level ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

David Bourgault  changed:

   What|Removed |Added

  Attachment #67150|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

--- Comment #8 from Alex Buckley  ---
Created attachment 68308
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68308=edit
Bug 19325 - Add an option to pad barcode length

Inserts a small change to C4::Label::barcode()

Test case:

1) Apply patch
2) Run updatedatabase.pl
3) Print some barcodes to PDF. They should look as usual.
4) Go in systempreferences and enable "BarcodePaddingEnable". Set the a
   length and a character.
5) Print some barcodes to PDF. They should now be of fixed length.

Followed test plan patch worked as described, also passed QA test tool
Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

Alex Buckley  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||mtomp...@hotmail.com

--- Comment #7 from M. Tompsett  ---
Why have an enabled AND length? If the length is 0, then what is the point of
enabled?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

Chris Nighswonger  changed:

   What|Removed |Added

   Assignee|cnighswon...@foundations.ed |david.bourga...@inlibro.com
   |u   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

--- Comment #6 from David Bourgault  ---
The main use case I had in mind when developping this patch is to add the
option to standardize barcode length when printing a range (Bug 7468).

Short barcodes can give very ugly results when printed as Code39, this helps
fix that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Manual
 CC||katrin.fisc...@bsz-bw.de

--- Comment #5 from Katrin Fischer  ---
Hi Chris, I agree about the use cases. I am tagging this with keyword "Manual"
in hope someone will submit a patch to the manual. Instructions can be found
here:
https://wiki.koha-community.org/wiki/Editing_the_Koha_Manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

--- Comment #4 from Chris Nighswonger  ---
I'm sure it would help Nicole with the documentation of it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

--- Comment #3 from Chris Nighswonger  ---
Perhaps a description of a use case or two might be beneficial to the end user.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

David Bourgault  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

David Bourgault  changed:

   What|Removed |Added

  Attachment #67149|0   |1
is obsolete||

--- Comment #2 from David Bourgault  ---
Created attachment 67150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67150=edit
Bug 19325 - Adds an option to pad barcode length

Inserts a small change to C4::Label::barcode()

Test case:

1) Apply patch
2) Run updatedatabase.pl
3) Print some barcodes to PDF. They should look as usual.
4) Go in systempreferences and enable "BarcodePaddingEnable". Set the a
   length and a character.
5) Print some barcodes to PDF. They should now be of fixed length.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

--- Comment #1 from David Bourgault  ---
Created attachment 67149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67149=edit
Bug 19325 - Add an option to pad barcode length

Inserts a small change to C4::Label::barcode()

Test case:

1) Apply patch
2) Run updatedatabase.pl
3) Print some barcodes to PDF. They should look as usual.
4) Go in systempreferences and enable "BarcodePaddingEnable". Set the a
   length and a character.
5) Print some barcodes to PDF. They should now be of fixed length.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/