https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
Martin Renvoize changed:
What|Removed |Added
CC||martin.renvoize@ptfs-europ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Pushed to Master
--- Comm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
Jonathan Druart changed:
What|Removed |Added
Attachment #74284|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
--- Comment #39 from Jonathan Druart
---
(In reply to Jon Knight from comment #38)
> Ah that's a good point. Do you want me to generate a new patch without them?
I will do it.
--
You are receiving this mail because:
You are watch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
--- Comment #38 from Jon Knight ---
Ah that's a good point. Do you want me to generate a new patch without them?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
--- Comment #37 from Jonathan Druart
---
So we should remove the 2x2 lines you add in the .pl to retrieve the active
currency, right?
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
--- Comment #36 from Katrin Fischer ---
Thx for your patience and perseverance, Jon!
I've fixed a few tabs in basketgroup.pl, be careful: Koha uses 4 spaces for
indenting.
--
You are receiving this mail because:
You are watching a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Passed QA
Patch complexi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
Katrin Fischer changed:
What|Removed |Added
Attachment #74274|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
--- Comment #34 from Séverine Queune ---
This price display seems clearer to me even though we don't have currency
symbols.
As user, this patch is good for me :)
--
You are receiving this mail because:
You are watching all bug chan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
Séverine Queune changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
Séverine Queune changed:
What|Removed |Added
Attachment #73677|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
--- Comment #32 from Katrin Fischer ---
Ok, if you prefer another set of eyes, I am not against that at all :)
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
--- Comment #31 from Jon Knight ---
(In reply to Katrin Fischer from comment #30)
> Hi Jon, if QA demands a follow-up what you can usually do is make a small
> extra patch with the additional changes and attach it. In this case it wo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
--- Comment #30 from Katrin Fischer ---
Hi Jon, if QA demands a follow-up what you can usually do is make a small extra
patch with the additional changes and attach it. In this case it would have
just been removing the attribute. Thi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
Jon Knight changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
Jon Knight changed:
What|Removed |Added
Attachment #73491|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
--- Comment #29 from Jon Knight ---
Created attachment 73677
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73677&action=edit
Bug 19479: Display price in basket group formatted according to CurrencyFormat
syspref u
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
--- Comment #28 from Katrin Fischer ---
> That's how I had it before Jonathan Druart asked me to put the symbols in
> place in comment #18 above. I don't mind either way as long as the QA team
> and RM can agree (or do I have to add
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
--- Comment #27 from Jonathan Druart
---
(In reply to Jon Knight from comment #26)
> (In reply to Katrin Fischer from comment #25)
> > Hi Séverine, there is no a setting in administration > currency for each
> > currency, where you
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
--- Comment #26 from Jon Knight ---
(In reply to Katrin Fischer from comment #25)
> Hi Séverine, there is no a setting in administration > currency for each
> currency, where you can define if there should be a space or not.
>
> I a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #25
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
--- Comment #24 from Séverine Queune ---
The 3 formats defined on 'CurrencyFormat' correctly apply with this patch.
Maybe for a better visibility (especially for 'FR format') we could have a
space between the currency and the prices,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
Séverine Queune changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
Séverine Queune changed:
What|Removed |Added
Attachment #73379|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
Jon Knight changed:
What|Removed |Added
Attachment #73377|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
--- Comment #21 from Jon Knight ---
Created attachment 73377
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73377&action=edit
Bug 19479: Display price in basket group formatted according to CurrencyFormat
syspref u
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
Jon Knight changed:
What|Removed |Added
Attachment #73376|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
--- Comment #20 from Jon Knight ---
The most recently uploaded version of this patch uses the currency symbols
instead of the currency code. I've not done anything about per basket currency
defaults as I think that is a separate, la
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
Jon Knight changed:
What|Removed |Added
Attachment #73291|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
--- Comment #19 from Jon Knight ---
Created attachment 73376
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73376&action=edit
Bug 19479: Display price in basket group formatted according to CurrencyFormat
syspref u
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
--- Comment #18 from Jonathan Druart
---
Jon,
Total: [% selectedbasket.total | $Price %] ([% selectedbasket.currency %])
Will display: 42 (EUR) or 42 (USD)
With bug 4078 you can use the with_symbol flag to display the symbol.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
M. Tompsett changed:
What|Removed |Added
CC||mtomp...@hotmail.com
--- Comm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
Jon Knight changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
--- Comment #16 from Jon Knight ---
Created attachment 73291
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73291&action=edit
Bug 19479: Display price in basked group formatted according to CurrencyFormat
syspref u
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
Jon Knight changed:
What|Removed |Added
Attachment #71313|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
Jon Knight changed:
What|Removed |Added
Attachment #73290|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
--- Comment #15 from Jon Knight ---
Created attachment 73290
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73290&action=edit
Attempt to display price formatted according to CurrencyFormat syspref using
templates,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
Bug 19479 depends on bug 4078, which changed state.
Bug 4078 Summary: Add the ability to customize and display the symbol for a
currency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078
What|Removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
--- Comment #14 from Jon Knight ---
I'll wait until 4078 is in master (its Passed QA at the moment) before changing
this patch again just so that I'm aiming for a stable target!
--
You are receiving this mail because:
You are watch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
Jonathan Druart changed:
What|Removed |Added
Depends on||4078
--- Comment #13 from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
--- Comment #11 from Jon Knight ---
One thing to note is that if I use the templates rather than my original patch
that just altered basketgroup.pl to do the formatting, I'm guessing that each
language that Koha is in will also need
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
Jon Knight changed:
What|Removed |Added
Attachment #71312|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
Jon Knight changed:
What|Removed |Added
Attachment #68972|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
Jon Knight changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
Jonathan Druart changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |j.p.kni...@lboro.ac.uk
49 matches
Mail list logo
