[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 M. Tompsett changed: What|Removed |Added Attachment #70485|0 |1

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 --- Comment #22 from M. Tompsett --- > (In reply to Jonathan Druart from comment #20) > > The dashboard's info should be fetched only if a patron is logged in. Re-read checkoverdue code... The problem case is

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 --- Comment #21 from M. Tompsett --- (In reply to Jonathan Druart from comment #20) > So actually we are trying to remove a warning because there are wrong calls > in opac-main. > The dashboard's info should be

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 --- Comment #19 from Jonathan Druart --- Created attachment 70489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70489=edit Bug 19938: Do not fetch dashboard's info if no

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 Julian Maurice changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 Julian Maurice changed: What|Removed |Added Attachment #70472|0

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 Julian Maurice changed: What|Removed |Added Attachment #70473|0

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 --- Comment #16 from Julian Maurice --- (In reply to M. Tompsett from comment #15) > It seemed from comment #11 and comment #12, that the FailedQA was for the > git commit messages, not the actual code.

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 M. Tompsett changed: What|Removed |Added Status|Failed QA |Signed

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 M. Tompsett changed: What|Removed |Added Attachment #70397|0 |1

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 --- Comment #13 from M. Tompsett --- Created attachment 70472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70472=edit Bug 19938: Refactor checkoverdues call in C4/Members.pm Due to

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 M. Tompsett changed: What|Removed |Added Attachment #70396|0 |1

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 --- Comment #12 from Julian Maurice --- (In reply to Julian Maurice from comment #10) > I don't see how they can conflict. Bug 19933 only adds a comment to > C4/Members.pm, and not very close to the

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 Julian Maurice changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 --- Comment #11 from Julian Maurice --- (In reply to Jonathan Druart from comment #7) > (In reply to M. Tompsett from comment #0) > > While retesting a bug, I ran a prove -r -v t, which generated a lot

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 --- Comment #10 from Julian Maurice --- (In reply to M. Tompsett from comment #9) > (In reply to Jonathan Druart from comment #8) > > "Bug 19938: Split C4/Members.pm to avoid conflict issues" > > > >

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 Julian Maurice changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 --- Comment #9 from M. Tompsett --- (In reply to Jonathan Druart from comment #8) > "Bug 19938: Split C4/Members.pm to avoid conflict issues" > > => What does it mean? because 19933 might trigger a conflict

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 --- Comment #8 from Jonathan Druart --- "Bug 19938: Split C4/Members.pm to avoid conflict issues" => What does it mean? -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 Lee Jamison changed: What|Removed |Added Attachment #70383|0 |1

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 Lee Jamison changed: What|Removed |Added Attachment #70382|0 |1

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 Lee Jamison changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 M. Tompsett changed: What|Removed |Added Attachment #70375|0 |1

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 --- Comment #3 from M. Tompsett --- Created attachment 70382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70382=edit Bug 19938: Split C4/Members.pm to avoid conflict issues -- You are

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 M. Tompsett changed: What|Removed |Added Severity|enhancement |minor

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 --- Comment #1 from M. Tompsett --- Created attachment 70375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70375=edit Bug 19938: Refactor checkoverdues TEST PLAN - 0) back up plack

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 M. Tompsett changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 M. Tompsett changed: What|Removed |Added Status|NEW |Needs