[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 Fridolin SOMERS changed: What|Removed |Added Resolution|--- |FIXED

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 --- Comment #21 from Jonathan Druart --- Created attachment 80732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80732=edit Bug 20592: Return early in ModItem if nothing to update Two lines of code and move them

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 Jonathan Druart changed: What|Removed |Added Attachment #78453|0 |1 is obsolete|

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 Cori Lynn Arnold changed: What|Removed |Added CC||carn...@dgiinc.com

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 Cori Lynn Arnold changed: What|Removed |Added Attachment #78454|0 |1 is obsolete|

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 M. Tompsett changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 M. Tompsett changed: What|Removed |Added Attachment #74824|0 |1 is obsolete|

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 M. Tompsett changed: What|Removed |Added Attachment #74825|0 |1 is obsolete|

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 M. Tompsett changed: What|Removed |Added Attachment #74826|0 |1 is obsolete|

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 --- Comment #12 from David Cook --- (In reply to Jonathan Druart from comment #11) > (In reply to David Cook from comment #6) > > But I agree that a better solution would be to change ModItem rather than >

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 --- Comment #11 from Jonathan Druart --- (In reply to David Cook from comment #6) > But I agree that a better solution would be to change ModItem rather than > updateitem.pl. I considered

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 Jonathan Druart changed: What|Removed |Added

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 --- Comment #8 from Jonathan Druart --- Created attachment 74825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74825=edit Bug 20592: Checks for itemnumber sooner Two

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 Jonathan Druart changed: What|Removed |Added Attachment #74286|0

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 --- Comment #9 from Jonathan Druart --- Created attachment 74826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74826=edit Bug 20592: Scope creep - fix other noise --

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 Jonathan Druart changed: What|Removed |Added Status|In Discussion

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 --- Comment #6 from David Cook --- (In reply to M. Tompsett from comment #2) > I believe this is the wrong way to do it. The problem is ModItem requires an > itemnumber, and the itemnumber check is too late

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 --- Comment #5 from M. Tompsett --- Test plan is the same as comment #1. Testing on a kohadevbox after a reset all. blanking the log before clicking update: echo | sudo tee

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 --- Comment #3 from M. Tompsett --- Created attachment 74399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74399=edit Bug 20592: Checks for itemnumber sooner Two lines of code and move them

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 --- Comment #4 from M. Tompsett --- Created attachment 74400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74400=edit Bug 20592: Scope creep - fix other noise -- You are receiving this

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 M. Tompsett changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 David Cook changed: What|Removed |Added Status|NEW

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 --- Comment #1 from David Cook --- Created attachment 74286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74286=edit Bug 20592 - updateitem.pl causes database errors when empty