https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Andrew Isherwood changed:
What|Removed |Added
CC|bugzi...@warmlight.co.uk|
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Andrew Isherwood changed:
What|Removed |Added
Depends on|18589 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Martin Renvoize changed:
What|Removed |Added
Resolution|--- |FIXED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Nick Clemens changed:
What|Removed |Added
Status|Passed QA |Pushed to Master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Josef Moravec changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
--- Comment #34 from Josef Moravec ---
Created attachment 88681
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88681=edit
Bug 21460: (follow-up) Fix bugs found in QA
Fix silly bugs mentioned in comment #29
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Josef Moravec changed:
What|Removed |Added
Attachment #88444|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
--- Comment #33 from Josef Moravec ---
Created attachment 88680
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88680=edit
Bug 21460: (follow-up) Filter params in .pl
This patch filters the passed parameters in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Andrew Isherwood changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
--- Comment #30 from Andrew Isherwood ---
Created attachment 88626
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88626=edit
But 21460: (follow-up) Fix bugs found in QA
Fix silly bugs mentioned in comment #29
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Josef Moravec changed:
What|Removed |Added
QA Contact||josef.mora...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Andrew Isherwood changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Andrew Isherwood changed:
What|Removed |Added
Attachment #83185|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Andrew Isherwood changed:
What|Removed |Added
Attachment #83305|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Andrew Isherwood changed:
What|Removed |Added
Attachment #83272|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Andrew Isherwood changed:
What|Removed |Added
Attachment #83674|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Andrew Isherwood changed:
What|Removed |Added
Attachment #83435|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Andrew Isherwood changed:
What|Removed |Added
Attachment #83184|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Andrew Isherwood changed:
What|Removed |Added
Attachment #83119|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
--- Comment #25 from Andrew Isherwood ---
The problem described in this bug appears to have been fixed in Bug 18589 as I
can no longer replicate it. The fix implemented in 18589 seems to have been
largely the same as what was in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
--- Comment #24 from Owen Leonard ---
Bug 18589 is fixed, so this should be ready for a rebase.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Bug 21460 depends on bug 18589, which changed state.
Bug 18589 Summary: Show ILLs as part of patron profile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589
What|Removed |Added
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Andrew Isherwood changed:
What|Removed |Added
Depends on||18589
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
--- Comment #22 from Josef Moravec ---
Could you rebase please?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Josef Moravec changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Marcel de Rooy changed:
What|Removed |Added
Patch complexity|Trivial patch |Small patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
--- Comment #21 from Andrew Isherwood ---
Created attachment 83674
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83674=edit
Bug 21460: (follow-up) Filter params in .pl
This patch filters the passed parameters in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Andrew Isherwood changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
--- Comment #20 from Andrew Isherwood ---
Thanks for taking the time to post that patch Jonathan, it makes for an
interesting experiment!
I'll create a patch that will iterate the and escape the prefilters in the .pl
then
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
--- Comment #19 from Jonathan Druart
---
Andrew, if it is not clear for you I invite you to apply this (silly) patch.
Hit the mainpage and click on the different links it adds.
Check the logs and see the content of the variable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
--- Comment #18 from Jonathan Druart
---
Created attachment 83435
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83435=edit
DO NOT PUSH - example of building filters for uri parameters
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
--- Comment #17 from Andrew Isherwood ---
(In reply to Jonathan Druart from comment #16)
> You will be stuck, you will not manage to filter all situations correctly.
I'm not clear on how this could be problematic. Whether I escape
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
--- Comment #16 from Jonathan Druart
---
You will be stuck, you will not manage to filter all situations correctly.
You should either escape in the pl, or split the $var=$value into a structure {
var => $var, value => $value }
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
--- Comment #15 from Andrew Isherwood ---
Created attachment 83305
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83305=edit
Bug 21460: (follow-up) $raw -> html filter
We're filtering a string that is derived
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
--- Comment #14 from Andrew Isherwood ---
Hi Jonathan, nope, you're absolutely right, this shouldn't be a $raw. These
prefilters are supplied by the client via a URL param, they should most
certainly be escaped if appropriate. Patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
--- Comment #13 from Jonathan Druart
---
(In reply to Andrew Isherwood from comment #12)
> Created attachment 83272 [details] [review]
> Bug 21460: (follow-up) Add filter to prefilters
>
> Addressing
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
--- Comment #12 from Andrew Isherwood ---
Created attachment 83272
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83272=edit
Bug 21460: (follow-up) Add filter to prefilters
Addressing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
--- Comment #10 from Andrew Isherwood ---
Bug added for the extraneous parameters in the definition:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22000
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
--- Comment #9 from Andrew Isherwood ---
OK, well, now I'm really confused. Looking in
api/v1/swagger/paths/illrequests.json
(https://github.com/PTFS-Europe/koha/blob/master/api/v1/swagger/paths/illrequests.json#L7-L95),
the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
--- Comment #8 from Andrew Isherwood ---
(In reply to Jonathan Druart from comment #7)
> Should not we teach the api definition that there is a new parameter?
Yes, we should. Patch incoming...
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
--- Comment #5 from Jonathan Druart
---
Created attachment 83184
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83184=edit
Bug 21460: Add tests
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
--- Comment #6 from Jonathan Druart
---
Created attachment 83185
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83185=edit
Bug 21460: Simplify the code to have only 1 assignment
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Magnus Enger changed:
What|Removed |Added
Attachment #82858|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Magnus Enger changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
Patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Magnus Enger changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Andrew Isherwood changed:
What|Removed |Added
Blocks||18589
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
--- Comment #3 from Andrew Isherwood ---
Created attachment 82858
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82858=edit
Bug 21460: Fix patron ILL request filtering
This patch fixes the non-functioning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Andrew Isherwood changed:
What|Removed |Added
Status|NEW |ASSIGNED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
--- Comment #2 from Magnus Enger ---
This is fixed by bug 18589, according to Andrew. But since that enh did not
make it into 18.11.x, the problem described here is still a bug in 18.11.x that
needs to be fixed.
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Magnus Enger changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
--- Comment #1 from Owen Leonard ---
Part of Bug 7317 (06f9e5fe) adds code to convert GET parameters to template
variables ("prefilters"), presumably to pass these values to the DataTables
call. But I don't see corresponding changes
53 matches
Mail list logo
