[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|RESOLVED

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #48 from Fridolin Somers --- *** Bug 14974 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Martin Renvoize changed: What|Removed |Added Keywords|rel_20_05_candidate | -- You are receiving

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Katrin Fischer changed: What|Removed |Added Component|System Administration |REST API -- You are

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com ---

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #46 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Tomás Cohen Arazi changed: What|Removed |Added Blocks||25288 Referenced

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #45 from Tomás Cohen Arazi --- Created attachment 104510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104510=edit Bug 25279: (QA follow-up) Use .escapeHtml Signed-off-by: Tomas Cohen Arazi -- You

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #44 from Jonathan Druart --- Created attachment 104435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104435=edit Bug 25279: Replace encodeURI with encodeURIComponent Signed-off-by: Jonathan Druart

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #41 from Jonathan Druart --- Created attachment 104432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104432=edit Bug 25279: HTML escape cells This patch makes HTML entities be escaped. It is done in

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #40 from Jonathan Druart --- Created attachment 104431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104431=edit Bug 25279: (QA follow-up) Original behaviour This patch does the following things: -

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #43 from Jonathan Druart --- Created attachment 104434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104434=edit Bug 25279: URI-escape city_id in links This patch escapes city_id uses in URLs, and

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #42 from Jonathan Druart --- Created attachment 104433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104433=edit Bug 25279: Use another var name for the filter It prevents: * The screen to display

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #38 from Jonathan Druart --- Created attachment 104429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104429=edit Bug 25279: Fix edit and delete links Signed-off-by: Kyle M Hall Signed-off-by:

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #39 from Jonathan Druart --- Created attachment 104430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104430=edit Bug 25279: (QA follow-up) Make button texts translatable Signed-off-by: Tomas Cohen

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #37 from Jonathan Druart --- Created attachment 104428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104428=edit Bug 25279: Use the API to list cities This patch makes the general cities datatable

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Jonathan Druart changed: What|Removed |Added Attachment #103802|0 |1 is obsolete|

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Tomás Cohen Arazi changed: What|Removed |Added Attachment #104421|0 |1 is obsolete|

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #34 from Tomás Cohen Arazi --- Created attachment 104421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104421=edit Bug 25279: URI-escape city_id in links This patch escapes city_id uses in URLs, and

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #33 from Tomás Cohen Arazi --- Created attachment 104420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104420=edit Bug 25279: Use another var name for the filter It prevents: * The screen to display

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Tomás Cohen Arazi changed: What|Removed |Added Attachment #104417|0 |1 is obsolete|

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #32 from Jonathan Druart --- (In reply to Jonathan Druart from comment #31) > Created attachment 104417 [details] [review] > Bug 25279: Use another var name for the filter > > It prevents: > * The screen to display "no

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #31 from Jonathan Druart --- Created attachment 104417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104417=edit Bug 25279: Use another var name for the filter It prevents: * The screen to display

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #30 from Jonathan Druart --- (In reply to Jonathan Druart from comment #29) > When searching for something that does not return any results: > https://snipboard.io/TGwL4v.jpg Same behaviour in master. -- You are

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #29 from Jonathan Druart --- When searching for something that does not return any results: https://snipboard.io/TGwL4v.jpg -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #28 from Jonathan Druart --- https://snipboard.io/0VXrTZ.jpg https://snipboard.io/ho6wZf.jpg -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #27 from Tomás Cohen Arazi --- (In reply to Tomás Cohen Arazi from comment #26) > (In reply to Jonathan Druart from comment #21) > > (In reply to Tomás Cohen Arazi from comment #20) > > > (In reply to Jonathan Druart

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #26 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #21) > (In reply to Tomás Cohen Arazi from comment #20) > > (In reply to Jonathan Druart from comment #19) > > > > > 4. We reached a point where we

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 104416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104416=edit Bug 25279: HTML escape cells This patch makes HTML entities be escaped. It is done

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Signed Off -- You are

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #24 from Tomás Cohen Arazi --- Created attachment 104387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104387=edit Bug 25279: (QA follow-up) Original behaviour This patch does the following things: -

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #23 from Tomás Cohen Arazi --- (In reply to Tomás Cohen Arazi from comment #20) > (In reply to Jonathan Druart from comment #19) > > (In reply to Tomás Cohen Arazi from comment #18) > > > (In reply to Jonathan Druart

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #22 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #21) > (In reply to Tomás Cohen Arazi from comment #20) > > (In reply to Jonathan Druart from comment #19) > > > > > 4. We reached a point where we

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #21 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #20) > (In reply to Jonathan Druart from comment #19) > > > > 4. We reached a point where we don't have XSS issue in our templates, > > > > all >

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #20 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #19) > (In reply to Tomás Cohen Arazi from comment #18) > > (In reply to Jonathan Druart from comment #17) > > > 1. Small UI changes (not

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #19 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #18) > (In reply to Jonathan Druart from comment #17) > > 1. Small UI changes (not advertised) > > > > Before: https://snipboard.io/cRdEWA.jpg >

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA -- You are

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #18 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #17) > 1. Small UI changes (not advertised) > > Before: https://snipboard.io/cRdEWA.jpg > After : https://snipboard.io/qep6rS.jpg > > a) No more

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #17 from Jonathan Druart --- 1. Small UI changes (not advertised) Before: https://snipboard.io/cRdEWA.jpg After : https://snipboard.io/qep6rS.jpg a) No more pagination (should be restored imo) b) Missing space between

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_05_candidate --

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #16 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #14) > That does not work, please restest. > > https://snipboard.io/PR9nxJ.jpg > > SyntaxError: unexpected token: string literal Thanks, I've

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 104359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104359=edit Bug 25279: (QA follow-up) Make button texts translatable Signed-off-by: Tomas Cohen

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Tomás Cohen Arazi changed: What|Removed |Added Attachment #104072|0 |1 is obsolete|

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #13 from Katrin Fischer --- (In reply to Tomás Cohen Arazi from comment #12) > (In reply to Katrin Fischer from comment #8) > > > > + > > > > +var result = ' Edit'; > > > > > > The button

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #12 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #8) > > > + > > > +var result = ' Edit'; > > > > The button label is not translatable > > Not sure if the QA tools

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Tomás Cohen Arazi changed: What|Removed |Added Attachment #104065|0 |1 is obsolete|

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #10 from Tomás Cohen Arazi --- (In reply to Josef Moravec from comment #7) > > The button label is not translatable Done -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 104065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104065=edit Bug 25279: (QA follow-up) Make button texts translatable Signed-off-by: Tomas Cohen

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Signed Off

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #8 from Katrin Fischer --- > > + > > +var result = ' Edit'; > > The button label is not translatable Not sure if the QA tools catches it, but the icon it should also have the aria attribute

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #7 from Josef Moravec --- Comment on attachment 103803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103803 Bug 25279: Use the API to list cities Review of attachment 103803: -->

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #5 from Kyle M Hall --- Created attachment 103803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103803=edit Bug 25279: Use the API to list cities This patch makes the general cities datatable use the

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #6 from Kyle M Hall --- Created attachment 103804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103804=edit Bug 25279: Fix edit and delete links Signed-off-by: Kyle M Hall -- You are receiving

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Kyle M Hall changed: What|Removed |Added Attachment #103693|0 |1 is obsolete|

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Jonathan Druart changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 103694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103694=edit Bug 25279: Use the API to list cities This patch makes the general cities datatable

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 103693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103693=edit Bug 25279: Add general query parameters to the /cities route Signed-off-by: Tomas

[Koha-bugs] [Bug 25279] Make the cities list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Tomás Cohen Arazi changed: What|Removed |Added Depends on||24561