[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Martin Renvoize changed: What|Removed |Added Attachment #146004|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Martin Renvoize changed: What|Removed |Added Attachment #146003|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Martin Renvoize changed: What|Removed |Added Attachment #146002|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Martin Renvoize changed: What|Removed |Added Attachment #146001|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 --- Comment #24 from Martin Renvoize --- Created attachment 146004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146004&action=edit Bug 25503: Add option to export items bundle contents in checkouts table Test plan: 1. Enable system preference ExportCircHistory 2. Create an item bundle (see bug 28854 comment 458) 3. Check out the item bundle 4. In the checkouts table, check the box in column "Export", choose export format 'MARC with items', check "Export items bundle contents" and click on "Export" button The exported file should contain the biblio and item created at step 2, but also the biblio and items that are part of the bundle Signed-off-by: Marie-Luce Signed-off-by: Katrin Fischer Signed-off-by: Marie-Luce Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 --- Comment #23 from Martin Renvoize --- Created attachment 146003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146003&action=edit Bug 25503: Make _get_biblio_for_export test pass Signed-off-by: Marie-Luce Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 --- Comment #22 from Martin Renvoize --- Created attachment 146002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146002&action=edit Bug 25503: Add failing test for _get_biblio_for_export Signed-off-by: Marie-Luce Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 --- Comment #21 from Martin Renvoize --- Created attachment 146001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146001&action=edit Bug 25503: Make Koha::Exporter::Record tests pass with unimarc Signed-off-by: Marie-Luce Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Andrew Isherwood changed: What|Removed |Added CC|bugzi...@warmlight.co.uk| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #20 from Victor Grousset/tuxayo --- Missing dependencies for 19.11.x, it shouldn't be affected, no backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Andrew Fuerste-Henry changed: What|Removed |Added Version(s)|21.05.00,20.11.05 |21.05.00,20.11.05,20.05.11 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #19 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|21.05.00|21.05.00,20.11.05 released in|| CC||fridolin.som...@biblibre.co ||m --- Comment #18 from Fridolin Somers --- Pushed to 20.11.x for 20.11.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 --- Comment #17 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Jonathan Druart changed: What|Removed |Added Blocks||28156 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28156 [Bug 28156] Koha::Account::Line->renewable must be named is_renewable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 --- Comment #16 from Jonathan Druart --- Created attachment 119702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119702&action=edit Bug 25508: Add info about caller responsabilities We are removing the test on the existence of item and patron, callers must call renewable before. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 --- Comment #15 from Nick Clemens --- Created attachment 119641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119641&action=edit Bug 25508: (QA follow-up) Add interface These patches are making the call for an amount match the call for a specific line, we should also match the passing of interface to ensure the correct pref is checked Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Nick Clemens changed: What|Removed |Added Attachment #119214|0 |1 is obsolete|| --- Comment #14 from Nick Clemens --- Created attachment 119640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119640&action=edit Bug 25508: Only return renewal outcomes to the controller There are a few cases where the `renew_item` method in Koha::Account::Line will return `undef`. For these cases, we should not pass the error up the chain to the controllers as it leads to malformed error messages in the UI. Test plan 1 - Make sure FinesMode is on, RenewAccruingItemWhenPaid is off 2 - Checkout an item to a patron and make it overdue (can backdate the checkout) 3 - Make sure the itemtype has fines that will be charged 4 - Charge the fines: Set finesMode = production perl misc/cronjobs/fines.pl -v 5 - Check the fine appears on the patrons account 6 - Pay off the fine 7 - Receive alert after payment that reads: "The fines on the following items were paid off, renewal results are displayed below: No title ( ): Not renewed - Unknown error" 8 - Apply the patch 9 - Repeat steps 1 through 6 and note that you no longer trigger the error message. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Nick Clemens changed: What|Removed |Added Attachment #119213|0 |1 is obsolete|| --- Comment #13 from Nick Clemens --- Created attachment 119639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119639&action=edit Bug 25508: Add Unit Tests Enhance the unit tests to check for the return values of Koha::Account->pay. Test plan 1/ Apply just this patch 2/ Run t/db_dependent/Koha/Account.t and watch it fail 3/ Apply the rest of the patch series 4/ Run t/db_dependent/Koha/Account.t and watch it pass 5/ Signoff Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #119192|0 |1 is obsolete|| --- Comment #12 from Andrew Fuerste-Henry --- Created attachment 119214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119214&action=edit Bug 25508: Only return renewal outcomes to the controller There are a few cases where the `renew_item` method in Koha::Account::Line will return `undef`. For these cases, we should not pass the error up the chain to the controllers as it leads to malformed error messages in the UI. Test plan 1 - Make sure FinesMode is on, RenewAccruingItemWhenPaid is off 2 - Checkout an item to a patron and make it overdue (can backdate the checkout) 3 - Make sure the itemtype has fines that will be charged 4 - Charge the fines: Set finesMode = production perl misc/cronjobs/fines.pl -v 5 - Check the fine appears on the patrons account 6 - Pay off the fine 7 - Receive alert after payment that reads: "The fines on the following items were paid off, renewal results are displayed below: No title ( ): Not renewed - Unknown error" 8 - Apply the patch 9 - Repeat steps 1 through 6 and note that you no longer trigger the error message. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #119191|0 |1 is obsolete|| --- Comment #11 from Andrew Fuerste-Henry --- Created attachment 119213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119213&action=edit Bug 25508: Add Unit Tests Enhance the unit tests to check for the return values of Koha::Account->pay. Test plan 1/ Apply just this patch 2/ Run t/db_dependent/Koha/Account.t and watch it fail 3/ Apply the rest of the patch series 4/ Run t/db_dependent/Koha/Account.t and watch it pass 5/ Signoff Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Martin Renvoize changed: What|Removed |Added Attachment #118778|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 119192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119192&action=edit Bug 25508: Only return renewal outcomes to the controller There are a few cases where the `renew_item` method in Koha::Account::Line will return `undef`. For these cases, we should not pass the error up the chain to the controllers as it leads to malformed error messages in the UI. Test plan 1 - Make sure FinesMode is on, RenewAccruingItemWhenPaid is off 2 - Checkout an item to a patron and make it overdue (can backdate the checkout) 3 - Make sure the itemtype has fines that will be charged 4 - Charge the fines: Set finesMode = production perl misc/cronjobs/fines.pl -v 5 - Check the fine appears on the patrons account 6 - Pay off the fine 7 - Receive alert after payment that reads: "The fines on the following items were paid off, renewal results are displayed below: No title ( ): Not renewed - Unknown error" 8 - Apply the patch 9 - Repeat steps 1 through 6 and note that you no longer trigger the error message. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 --- Comment #9 from Martin Renvoize --- Created attachment 119191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119191&action=edit Bug 25508: Add Unit Tests Enhance the unit tests to check for the return values of Koha::Account->pay. Test plan 1/ Apply just this patch 2/ Run t/db_dependent/Koha/Account.t and watch it fail 3/ Apply the rest of the patch series 4/ Run t/db_dependent/Koha/Account.t and watch it pass 5/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Martin Renvoize changed: What|Removed |Added Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Martin Renvoize changed: What|Removed |Added Blocks||27927 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Martin Renvoize changed: What|Removed |Added Attachment #118777|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 --- Comment #8 from Martin Renvoize --- Created attachment 118778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118778&action=edit Bug 25508: Only return renewal outcomes to the controller There are a few cases where the `renew_item` method in Koha::Account::Line will return `undef`. For these cases, we should not pass the error up the chain to the controllers as it leads to malformed error messages in the UI. Test plan 1 - Make sure FinesMode is on, RenewAccruingItemWhenPaid is off 2 - Checkout an item to a patron and make it overdue (can backdate the checkout) 3 - Make sure the itemtype has fines that will be charged 4 - Charge the fines: Set finesMode = production perl misc/cronjobs/fines.pl -v 5 - Check the fine appears on the patrons account 6 - Pay off the fine 7 - Receive alert after payment that reads: "The fines on the following items were paid off, renewal results are displayed below: No title ( ): Not renewed - Unknown error" 8 - Apply the patch 9 - Repeat steps 1 through 6 and note that you no longer trigger the error message. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Martin Renvoize changed: What|Removed |Added Attachment #118776|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 118777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118777&action=edit Bug 25508: Do not attempt renewals if syspref is disabled In the case where 'RenewAccruingItemWhenPaid' is disabled we were still testing whether the fine item was renewable ragerdless. This has two issued: 1. A minor performance issue with us running more code than required. 2. The return value from renew_item when the syspref is disabled was empty, but it would still get appended to the 'renew_outcomes' array which results in some 'dirty' messages in the UI. Test plan 1 - Make sure FinesMode is on, RenewAccruingItemWhenPaid is off 2 - Checkout an item to a patron and make it overdue (can backdate the checkout) 3 - Make sure the itemtype has fines that will be charged 4 - Charge the fines: Set finesMode = production perl misc/cronjobs/fines.pl -v 5 - Check the fine appears on the patrons account 6 - Pay off the fine 7 - Receive alert after payment that reads: "The fines on the following items were paid off, renewal results are displayed below: No title ( ): Not renewed - Unknown error" 8 - Apply the patch 9 - Repeat steps 1 through 6 and note that you no longer trigger the error message. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Martin Renvoize changed: What|Removed |Added Attachment #118765|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 118776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118776&action=edit Bug 25508: Do not attempt renewals if syspref is disabled In the case where 'RenewAccruingItemWhenPaid' is disabled we were still testing whether the fine item was renewable ragerdless. This has two issued: 1. A minor performance issue with us running more code than required. 2. The return value from renew_item when the syspref is disabled was empty, but it would still get appended to the 'renew_outcomes' array which results in some 'dirty' messages in the UI. Test plan 1 - Make sure FinesMode is on, RenewAccruingItemWhenPaid is off 2 - Checkout an item to a patron and make it overdue (can backdate the checkout) 3 - Make sure the itemtype has fines that will be charged 4 - Charge the fines: Set finesMode = production perl misc/cronjobs/fines.pl -v 5 - Check the fine appears on the patrons account 6 - Pay off the fine 7 - Receive alert after payment that reads: "The fines on the following items were paid off, renewal results are displayed below: No title ( ): Not renewed - Unknown error" 8 - Apply the patch 9 - Repeat steps 1 through 6 and note that you no longer trigger the error message. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27916 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Martin Renvoize changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Martin Renvoize changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Martin Renvoize changed: What|Removed |Added Blocks||14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #5 from Martin Renvoize --- Oops.. I'd meant to walk David through this one.. seems I completely forgot to do that. Patch attached as I noticed it today by coincidence too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Martin Renvoize changed: What|Removed |Added Assignee|david.roberts@ptfs-europe.c |martin.renvoize@ptfs-europe |om |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 --- Comment #4 from Martin Renvoize --- Created attachment 118765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118765&action=edit Bug 25508: Do not attempt renewals if syspref is disabled In the case where 'RenewAccruingItemWhenPaid' is disabled we were still testing whether the fine item was renewable ragerdless. This has two issued: 1. A minor performance issue with us running more code than required. 2. The return value from renew_item when the syspref is disabled was empty, but it would still get appended to the 'renew_outcomes' array which results in some 'dirty' messages in the UI. Test plan 1 - Make sure FinesMode is on, RenewAccruingItemWhenPaid is off 2 - Checkout an item to a patron and make it overdue (can backdate the checkout) 3 - Make sure the itemtype has fines that will be charged 4 - Charge the fines: Set finesMode = production perl misc/cronjobs/fines.pl -v 5 - Check the fine appears on the patrons account 6 - Pay off the fine 7 - Receive alert after payment that reads: "The fines on the following items were paid off, renewal results are displayed below: No title ( ): Not renewed - Unknown error" 8 - Apply the patch 9 - Repeat steps 1 through 6 and note that you no longer trigger the error message. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Mark changed: What|Removed |Added CC||m.tho...@dover.nh.gov --- Comment #3 from Mark --- Can confirm that our librarians double take every time they see this erroneous message. Thanks for any work to get this fixed! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Donna changed: What|Removed |Added CC||bwsdo...@gmail.com --- Comment #2 from Donna --- While there is not a problem with the functionality, it is very confusing for users to see a string of error messages like this! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Bug 25508 depends on bug 23051, which changed state. Bug 23051 Summary: Add ability to optionally renew fine accruing items when all fines on item are paid off https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Andrew Fuerste-Henry changed: What|Removed |Added Summary|Confusing renewal message |Confusing renewal message |when paying accruing fine |when paying accruing fine ||with ||RenewAccruingItemWhenPaid ||turned off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Martin Renvoize changed: What|Removed |Added Assignee|martin.renvoize@ptfs-europe |david.roberts@ptfs-europe.c |.com|om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Katrin Fischer changed: What|Removed |Added Depends on||23051 --- Comment #1 from Katrin Fischer --- Adding the original bug introducing the feature in depends on - this will also help to get the developers and original testers informed :) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Andrew Fuerste-Henry changed: What|Removed |Added CC||andrew.isherwood@ptfs-europ ||e.com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
