https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Brendan Lawlor changed:
What|Removed |Added
Text to go in the||This enhancement adds the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Katrin Fischer changed:
What|Removed |Added
Keywords|rel_24_05_candidate,|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #39 from Katrin Fischer ---
Pushed for 24.05!
Well done everyone, thank you!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Katrin Fischer changed:
What|Removed |Added
Version(s)||24.05.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #38 from Katrin Fischer ---
Applies now!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #37 from Brendan Lawlor ---
(In reply to Katrin Fischer from comment #34)
> Can you please rebase and re-attach both of those patches? If you need help
> please let us know!
I think maybe the problem was that I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #36 from Brendan Lawlor ---
Created attachment 165660
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165660=edit
Bug 35746: (follow-up) Fix invalid tt in html tag
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Brendan Lawlor changed:
What|Removed |Added
Attachment #165333|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Brendan Lawlor changed:
What|Removed |Added
Status|Patch doesn't apply |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Katrin Fischer changed:
What|Removed |Added
Status|Passed QA |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #33 from Katrin Fischer ---
Thx for the follow-up! I'll be back asap.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #32 from Brendan Lawlor ---
(In reply to Lucas Gass from comment #28)
> This changes the :all option into from a single select dropdown to a multi
> one. I don't think that is necessarily bad, could be handy actually!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Brendan Lawlor changed:
What|Removed |Added
Attachment #165334|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Lucas Gass changed:
What|Removed |Added
Attachment #165276|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Lucas Gass changed:
What|Removed |Added
Attachment #163921|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Lucas Gass changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #27 from Brendan Lawlor ---
Thanks for pointing out where to run that test. I had only ran the qa test
before.
I fixed the invalid TT syntax inside the html tag so it now passes:
$ ./xt/tt_valid.t
1..3
ok 1 - TT syntax:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Brendan Lawlor changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #26 from Brendan Lawlor ---
Created attachment 165276
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165276=edit
Bug 35746: (follow-up) Fix invalid TT syntax inside html tag
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Katrin Fischer changed:
What|Removed |Added
Status|Passed QA |Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Michelle Spinney changed:
What|Removed |Added
CC||mspin...@clamsnet.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #24 from Nick Clemens ---
I played around to see if we could do the same thing without JS, but the way we
get the params makes it tricky to use the multi-select directly. This works
well, is easy to read, excellent work!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Nick Clemens changed:
What|Removed |Added
Attachment #163920|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Nick Clemens changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Andrew Fuerste-Henry changed:
What|Removed |Added
Attachment #163875|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Andrew Fuerste-Henry changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Brendan Lawlor changed:
What|Removed |Added
Attachment #162303|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Brendan Lawlor changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #20 from Brendan Lawlor ---
Thanks for testing Caroline!
Originally I envisioned that you would write it with parentheses something
like:
WHERE i.itemtype IN (<>)
but it piggybacks on the code that implemented the list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #19 from Caroline Cyr La Rose ---
(In reply to Caroline Cyr La Rose from comment #18)
> I just tested it again on KTD and it gives me a weird error.
>
> For the same report, my local installation returns
>
> SELECT
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #18 from Caroline Cyr La Rose ---
I just tested it again on KTD and it gives me a weird error.
For the same report, my local installation returns
SELECT
i.homebranch,
count(*)
FROM items i
WHERE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #17 from Andrew Fuerste-Henry ---
(In reply to Caroline Cyr La Rose from comment #16)
> Works as advertised, very cool!
>
> Probably out of scope, but it would be nice to have a way to add "in" with
> the parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #16 from Caroline Cyr La Rose ---
Works as advertised, very cool!
Probably out of scope, but it would be nice to have a way to add "in" with the
parameter button. Maybe a checkbox in the pop up?
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Pedro Amorim changed:
What|Removed |Added
CC||pedro.amo...@ptfs-europe.co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Caroline Cyr La Rose changed:
What|Removed |Added
Attachment #162300|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Caroline Cyr La Rose changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #14 from Brendan Lawlor ---
I just fixed the regex and perltidy issues so this patch now passes the QA
scripts.
Also in the work in progress patch I had deleted a block of code in
C4/Reports/Guided.pm, because it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Brendan Lawlor changed:
What|Removed |Added
Attachment #161248|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #13 from Brendan Lawlor ---
Created attachment 162300
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162300=edit
Bug 35746: add multiselect to report dropdowns
This patch adds the ability to use multi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Brendan Lawlor changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #12 from Andrew Fuerste-Henry ---
*** Bug 16002 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Andrew Fuerste-Henry changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Andrew Fuerste-Henry changed:
What|Removed |Added
Blocks||35856
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Biblibre Sandboxes changed:
What|Removed |Added
Attachment #161247|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Brendan Lawlor changed:
What|Removed |Added
Attachment #161224|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
he...@bywatersolutions.com changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Brendan Lawlor changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Brendan Lawlor changed:
What|Removed |Added
Attachment #160995|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #9 from Brendan Lawlor ---
Created attachment 161224
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161224=edit
Bug 35746: Add multiselect to report dropdowns
This work in progress patch adds the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #8 from Brendan Lawlor ---
Thanks for the helpful link Emily, I hadn't found that part of the code yet.
It's a good example to show how to split an input string into an array and then
wrap the elements in quotes and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Katie Bliss changed:
What|Removed |Added
CC||kebl...@dmpl.org
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Emily Lamancusa changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Caroline Cyr La Rose changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Brendan Lawlor changed:
What|Removed |Added
Attachment #160880|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #6 from Brendan Lawlor ---
Created attachment 160995
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160995=edit
Bug 35746: add multiselect to reports dropdowns
This is a work in progress patch to add
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #5 from Brendan Lawlor ---
Somehow my test plan did not get attached to this patch.
This is a work in progress patch that adds a new syntax to reports for
multiselect similar to adding <>
Currently the patch adds the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #4 from Brendan Lawlor ---
Created attachment 160880
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160880=edit
Bug 35746: add multiselect to report dropdowns
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Brendan Lawlor changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |blaw...@clamsnet.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #3 from Brendan Lawlor ---
This is a great idea.
I think the report syntax could be similar to when reports include the all
option.
<>
Then if the 'in' parameter is included guided_reports_start.tt would render
that
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Rebecca Coert changed:
What|Removed |Added
CC||rco...@arlingtonva.us
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Barbara Johnson changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Brendan Lawlor changed:
What|Removed |Added
CC||blaw...@clamsnet.org
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
Andrew Fuerste-Henry changed:
What|Removed |Added
CC|
65 matches
Mail list logo