https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #135 from Katrin Fischer ---
Pushed for 24.05!
Well done everyone, thank you!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Katrin Fischer changed:
What|Removed |Added
Status|Passed QA |Pushed to main
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Katrin Fischer changed:
What|Removed |Added
Keywords|rel_24_05_candidate |release-notes-needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Keywords||rel_24_05_candidate
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
URL|https://github.com/PTFS-Eur |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #165435|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #134 from Martin Renvoize ---
Tests all passing now and full set rebased.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #133 from Martin Renvoize ---
Created attachment 166002
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166002=edit
Bug 36120: (QA follow-up) Fix api/v1/bookings.t
We now require pickup_library_id and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #132 from Martin Renvoize ---
Created attachment 166001
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166001=edit
Bug 36120: (QA follow-up) Fix Circulation.t
We now require pickup_library_id and so
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #131 from Martin Renvoize ---
Created attachment 166000
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166000=edit
Bug 36120: (QA follow-up) Fix /biblios.t unit test
This patch adds some mock data for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #165434|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #165433|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #165432|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #165431|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #165430|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #165429|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #165428|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #123 from Martin Renvoize ---
Created attachment 165992
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165992=edit
Bug 36120: Schema update
Signed-off-by: Nick Clemens
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #165426|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #165425|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #165424|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #165423|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #165422|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #165421|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #165420|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #165419|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #114 from Nick Clemens ---
Also:
t/db_dependent/Circulation.t
t/db_dependent/api/v1/bookings.t
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Nick Clemens changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #113
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #112 from Nick Clemens ---
Created attachment 165435
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165435=edit
Bug 36120: (QA follow-up) Tidy
Signed-off-by: Nick Clemens
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #111 from Nick Clemens ---
Created attachment 165434
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165434=edit
Bug 36120: Restore edit
Signed-off-by: Nick Clemens
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #110 from Nick Clemens ---
Created attachment 165433
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165433=edit
Bug 36120: (follow-up) Only display locations for bookable items
This patch updates the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #109 from Nick Clemens ---
Created attachment 165432
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165432=edit
Bug 36120: Ensure pickup location and item can be picked in either order
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #108 from Nick Clemens ---
Created attachment 165431
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165431=edit
Bug 36120: Account for both pickup_location and date selection in items
This patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #107 from Nick Clemens ---
Created attachment 165430
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165430=edit
Bug 36120: Re-enable 'Any item' selectable
Signed-off-by: Nick Clemens
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #106 from Nick Clemens ---
Created attachment 165429
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165429=edit
Bug 36120: Unit tests for pickup_locations change
This patch adds unit tests for the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #105 from Nick Clemens ---
Created attachment 165428
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165428=edit
Bug 36120: Add unit test for pickup_library relation accessor
This patch adds a unit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #104 from Nick Clemens ---
Created attachment 165427
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165427=edit
Bug 36120: Schema update
Signed-off-by: Nick Clemens
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #103 from Nick Clemens ---
Created attachment 165426
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165426=edit
Bug 36120: Ensure pickup_library_id is NOT NULL
This patch updates the database schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #102 from Nick Clemens ---
Created attachment 165425
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165425=edit
Bug 36120: Ensure existing bookings are assigned a pickup library
Sponsored-by: Cuyahoga
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #101 from Nick Clemens ---
Created attachment 165424
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165424=edit
Bug 36120: Add pickup library to bookings list table
Sponsored-by: Cuyahoga County
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #100 from Nick Clemens ---
Created attachment 165423
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165423=edit
Bug 36120: Add pickup locations to place bookings modal
This patch adds a call to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #99 from Nick Clemens ---
Created attachment 165422
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165422=edit
Bug 36120: Add pickup_library support to bookings API
Sponsored-by: Cuyahoga County
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #98 from Nick Clemens ---
Created attachment 165421
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165421=edit
Bug 36120: Add pickup_items to the pickup_locations response
This patch adds pickup_items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #97 from Nick Clemens ---
Created attachment 165420
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165420=edit
Bug 36120: Schema update
Sponsored-by: Cuyahoga County Public Library
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Nick Clemens changed:
What|Removed |Added
Attachment #165175|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Nick Clemens changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #165215|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #94 from Martin Renvoize ---
Created attachment 165215
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165215=edit
Bug 36120: Restore edit
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #93 from Martin Renvoize ---
Created attachment 165214
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165214=edit
Bug 36120: (follow-up) Only display locations for bookable items
This patch updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #92 from Martin Renvoize ---
Created attachment 165188
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165188=edit
Bug 36120: Ensure pickup location and item can be picked in either order
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #165140|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163635|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163613|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163612|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #87 from Martin Renvoize ---
Created attachment 165183
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165183=edit
Bug 36120: Schema update
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163610|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163609|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163608|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163607|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163606|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163605|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163604|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163603|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163636|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Nick Clemens changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #76
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #75 from Martin Renvoize ---
(In reply to Nick Clemens from comment #60)
> 3 - When changing branches, item options are disabled - if there are 100+
> items you may have to scroll through all the disabled options to find
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #74 from Martin Renvoize ---
Created attachment 163636
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163636=edit
Bug 36120: Account for both pickup_location and date selection in items
This patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #73 from Martin Renvoize ---
Created attachment 163635
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163635=edit
Bug 36120: Re-enable 'Any item' selectable
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #72 from Martin Renvoize ---
(In reply to Nick Clemens from comment #60)
> This works great in a lot of ways, but I found a couple issues:
> 1 - We need unit tests for the pickup_locations change and the API
API tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #71 from Martin Renvoize ---
Created attachment 163613
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163613=edit
Bug 36120: Unit tests for pickup_locations change
This patch adds unit tests for the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #70 from Martin Renvoize ---
Created attachment 163612
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163612=edit
Bug 36120: Add unit test for pickup_library relation accessor
This patch adds a unit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #69 from Martin Renvoize ---
Created attachment 163611
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163611=edit
Bug 36120: Schema update
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #68 from Martin Renvoize ---
Created attachment 163610
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163610=edit
Bug 36120: Ensure pickup_library_id is NOT NULL
This patch updates the database schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163571|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163570|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163569|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163568|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163567|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163566|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163565|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #60 from Nick Clemens ---
This works great in a lot of ways, but I found a couple issues:
1 - We need unit tests for the pickup_locations change and the API
2 - The pickup_locations for items should be set from the list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #59 from Martin Renvoize ---
Just a rebase on the tidy up bug.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163448|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163447|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163446|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163445|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163444|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163443|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163442|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Depends on||36374
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Blocks||34440
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Bug 36120 depends on bug 35248, which changed state.
Bug 35248 Summary: Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248
What|Removed |Added
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #51 from Martin Renvoize ---
Credit where credits are due.. I added the Sponsored-by lines to the commits
having forgotten until now.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163441|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163440|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163439|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
Martin Renvoize changed:
What|Removed |Added
Attachment #163438|0 |1
is obsolete|
1 - 100 of 156 matches
Mail list logo