[Koha-bugs] [Bug 9016] Multi transport types for notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What|Removed |Added Blocks||27534 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27534 [Bug 27534] koha upgrade throws SQL error while applying Bug 25333 - Change message transport type for Talking Tech from "phone" to "itiva" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Fridolin SOMERS fridolin.som...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14666 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #158 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Katrin Fischer from comment #157) If feed is not implemented, shouldn't we remove it from the sample data and maybe even from existing installations as a transport type? How to be sure nobody uses it? Does someone remember who/why introduced it into Koha? I didn't find a clear explanation using git log. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #159 from Katrin Fischer katrin.fisc...@bsz-bw.de --- My understanding is there are no configuration options for it and it as hidden from the display until the newer changes. I think if a library built functionality for it, it's not in current Koha and they could still add back the entry in the database easily. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #160 from mathieu saby mathsaby...@gmail.com --- (In reply to Katrin Fischer from comment #159) My understanding is there are no configuration options for it and it as hidden from the display until the newer changes. I think if a library built functionality for it, it's not in current Koha and they could still add back the entry in the database easily. Hello This puzzled me when I tested last year when I was working in Rennes. I made an enquiry in git history, which I don't remember the result... but I wrote it in the Mantis ticket we used to track this ENH. MAybe it can help. For me it looked like a mistake. Mathieu Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12298 --- Comment #161 from Jonathan Druart jonathan.dru...@biblibre.com --- Bug 12298 created. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #157 from Katrin Fischer katrin.fisc...@bsz-bw.de --- If feed is not implemented, shouldn't we remove it from the sample data and maybe even from existing installations as a transport type? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #155 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Nicole C. Engard from comment #154) (In reply to Jonathan Druart from comment #153) Hello Nicole, The feed entry was not introduced by this patch. The entry in the message_transport_types seems to be there for a long time. I think it is (was?) used to generated RSS feeds. But I don't know how it works and if it works. Then we might want to hide those options - it seems very misleading to have options that do nothing on these pages in the release. Nicole Sorry but which pages are you talking about? The message transport types displayed on the Notices and slips pages can be managed deleting/adding values in the message_transport_types tables. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #156 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Nicole C. Engard from comment #154) Then we might want to hide those options - it seems very misleading to have options that do nothing on these pages in the release. Sounds like the discussion around comment91: [Now you see the 4 or 5 types (and that could grow..?) But I miss a field like Status that activates or deactivates the transport type for that notice. We could also use that status somehow to warn people that activating a certain type is not useful or even possible when there is no code to support it yet.] And comment107: [This means that not everything this patch seems to offer now, is actually used. For instance, you can edit sms notices now or click phone in overdue rules, but this will not produce any results. Given that I am told that these changes are still coming in the follow-up reports, this should just be considered as temporary confusion. I note however that marking these options as not-in-use-yet (somehow..) and releasing them further on in the process would have had my (personal) preference.] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #154 from Nicole C. Engard neng...@gmail.com --- (In reply to Jonathan Druart from comment #153) Hello Nicole, The feed entry was not introduced by this patch. The entry in the message_transport_types seems to be there for a long time. I think it is (was?) used to generated RSS feeds. But I don't know how it works and if it works. Then we might want to hide those options - it seems very misleading to have options that do nothing on these pages in the release. Nicole -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added CC||neng...@gmail.com --- Comment #152 from Nicole C. Engard neng...@gmail.com --- I'm writing up the documentation for this and don't see any explanation of how the 'feed' is supposed to work. I know how to document all other new values, but what is 'feed' and how do I access it? Thanks Nicole -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #153 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Nicole C. Engard from comment #152) I'm writing up the documentation for this and don't see any explanation of how the 'feed' is supposed to work. I know how to document all other new values, but what is 'feed' and how do I access it? Hello Nicole, The feed entry was not introduced by this patch. The entry in the message_transport_types seems to be there for a long time. I think it is (was?) used to generated RSS feeds. But I don't know how it works and if it works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #151 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #26659|0 |1 is obsolete|| --- Comment #137 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27797 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27797action=edit Bug 9016: DB changes: new table overduerules_transport_types This patch adds: - a new table overduerules_transport_types. - a new column letter.message_transport_type. - a new primary key for letter. - fill the new table with existing values. Test plan: After applying this patch and executing the updatedatabase entry, verify that the overduerules_transport_types table contains a row for each entry in the overduerules table. The message_transport_type column should contain 'email'. Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #26662|0 |1 is obsolete|| --- Comment #140 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27800 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27800action=edit Bug 9016: Fix some translate issues On tools/letter.pl and tools/overduerules.pl, some strings were not translatable. This patch should fix that. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #26656|0 |1 is obsolete|| --- Comment #134 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27794 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27794action=edit Bug 9016: Create a message for each transport type. This patch adds: - a new jquery plugin : insertatcaret. - the ability to define a notice template for each transport type. - a new routine C4::Letters::GetMessageTransportTypes. Test plan: - Go on tools/letter.pl and check that all existing notices are still there. - Modify one. A new empty message is present for sms, print, etc. The email message is filled with the existant value. - Add a message for sms for example (don't forget the subject) and save. - edit again and verify the sms message has been saved. Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #26661|0 |1 is obsolete|| --- Comment #139 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27799 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27799action=edit Bug 9016: QA Followup Fix tab characters and POD. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #26657|0 |1 is obsolete|| --- Comment #135 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27795 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27795action=edit Bug 9016: Define different transport types for overdues This patch adds: - a new routine C4::Overdues::GetOverdueMessageTransportTypes. - the ability to define one or more transport types for an overdue level. Test plan: - go on tools/overduerules.pl. - verify that previous rules still exist and that the 'email' checkboxes is checked if a rule is defined. - redefined rules at different levels and check the transport type needed. Currently, only email, sms and print are relevant - Save the changes. Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #26660|0 |1 is obsolete|| --- Comment #138 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27798 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27798action=edit Bug 9016: Fix unit tests The unit tests should insert overdue rules. + Fix the doc for GetOverdueMessageTransportTypes Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #26658|0 |1 is obsolete|| --- Comment #136 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27796 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27796action=edit Bug 9016: FIX GetMessageTransportTypes returns an arrayref, not hashref Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #26665|0 |1 is obsolete|| --- Comment #143 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27803 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27803action=edit Bug 9016: FIX GetLetters should return all letters GetLetters only returns letters with a mtt = email. It should return all letter codes in the DB. The message_transport_type parameter is never used. To reproduce the issue: Create a notice with a sms template and no email template. Go on the overdue rules configucation page. The notice does not appear in the notice list. Signed-off-by: Olli-Antti Kivilahti kivilahtio@ProBook6570b --- Testing report: --- Testing this subroutine from a test stub. Calling the method without arguments and with argument 'circulation' and 'circulat'. Works as supposed to. Related Bug 11931 discovered but not within the scope of this featureset. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #26663|0 |1 is obsolete|| --- Comment #141 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27801 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27801action=edit Bug 9016 [QA Followup] - Add insertAtCaret library to about page Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #26664|0 |1 is obsolete|| --- Comment #142 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27802 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27802action=edit Bug 9016: (follow-up) qa fixes * Fixes POD of GetMessageTransportTypes. * Removes the useless map in GetMessageTransportTypes. * Textual: You must specify a title and a content - Please specify title and content. * Reintroduces and around the field name. * Change message for the update DB entry. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #26667|0 |1 is obsolete|| --- Comment #145 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27805 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27805action=edit Bug 9016: FIX letter name is not displayed on editing a letter On editing a letter, the letter name is not displayed. So if you save it, the letter name is erased with an empty string. Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi Tested by setting the Name-field in letter.pl, saving, re-editing and verifying that the email is present in the letter's Name-field. The letter Name is replicated for each template in the DB, but that doesn't incur any performance penalty. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #2|0 |1 is obsolete|| --- Comment #144 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27804 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27804action=edit Bug 9016: FIX additional mtt's name should be displayed in header if you insert a new line in your message_transport_types table, the overdues configuration table did not displayed an header. Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi Yes sir works great! Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #26668|0 |1 is obsolete|| --- Comment #146 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27806 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27806action=edit Bug 9016: (followup) FIX letter name is not displayed on editing a letter If the name is not in email, the name is not correctly retrieved. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #26670|0 |1 is obsolete|| --- Comment #147 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27807 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27807action=edit Bug 9016: Add some validation on the letter form 1/ Code and Name are mandatory. 2/ At least 1 template should be filled on saving. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #26673|0 |1 is obsolete|| --- Comment #149 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27809 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27809action=edit Bug 9016: [QA Follow-up] Remove warning from content.length test If the letter.content is undef, the content.length test in the letter template will trigger warning: Argument isn't numeric in numeric gt (). This patch eliminates that warning. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #26672|0 |1 is obsolete|| --- Comment #148 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27808 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27808action=edit Bug 9016: Improve number of characters display when mtt=sms Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #150 from Jonathan Druart jonathan.dru...@biblibre.com --- Last patches fix conflict with bug 11497. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #133 from Jonathan Druart jonathan.dru...@biblibre.com --- Note for RM, and others: To complete the feature (MTT), bug 11867 and bug 11209 should reach the Passed QA status. They are bugfixes and quite easy to test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Keywords||rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #131 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Katrin Fischer from comment #130) Hi Marcel - do you plan to continue on the other patches? I am not sure in which state that is and if you already started. Could you give a quick update? Thx! I plan to continue with some of these reports, but I did not start yet. And I certainly have no monopoly on them. It could be advantageous if some other people also look at this line of development. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #132 from Katrin Fischer katrin.fisc...@bsz-bw.de --- As feature freeze will be upon us quite soon I was wondering if we can figure out a way to get this QA'd in time. I am currently still working on some other big patches, but maybe someone else will be able to help you with those before I can? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #130 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Marcel - do you plan to continue on the other patches? I am not sure in which state that is and if you already started. Could you give a quick update? Thx! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #25415|0 |1 is obsolete|| Attachment #25416|0 |1 is obsolete|| Attachment #25417|0 |1 is obsolete|| Attachment #25418|0 |1 is obsolete|| Attachment #25419|0 |1 is obsolete|| Attachment #25420|0 |1 is obsolete|| Attachment #25421|0 |1 is obsolete|| Attachment #25422|0 |1 is obsolete|| Attachment #25606|0 |1 is obsolete|| Attachment #26182|0 |1 is obsolete|| Attachment #26216|0 |1 is obsolete|| Attachment #26233|0 |1 is obsolete|| Attachment #26648|0 |1 is obsolete|| Attachment #26649|0 |1 is obsolete|| Attachment #26650|0 |1 is obsolete|| --- Comment #114 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 26656 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26656action=edit Bug 9016: Create a message for each transport type. This patch adds: - a new jquery plugin : insertatcaret. - the ability to define a notice template for each transport type. - a new routine C4::Letters::GetMessageTransportTypes. Test plan: - Go on tools/letter.pl and check that all existing notices are still there. - Modify one. A new empty message is present for sms, print, etc. The email message is filled with the existant value. - Add a message for sms for example (don't forget the subject) and save. - edit again and verify the sms message has been saved. Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #115 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 26657 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26657action=edit Bug 9016: Define different transport types for overdues This patch adds: - a new routine C4::Overdues::GetOverdueMessageTransportTypes. - the ability to define one or more transport types for an overdue level. Test plan: - go on tools/overduerules.pl. - verify that previous rules still exist and that the 'email' checkboxes is checked if a rule is defined. - redefined rules at different levels and check the transport type needed. Currently, only email, sms and print are relevant - Save the changes. Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #119 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 26661 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26661action=edit Bug 9016: QA Followup Fix tab characters and POD. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #117 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 26659 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26659action=edit Bug 9016: DB changes: new table overduerules_transport_types This patch adds: - a new table overduerules_transport_types. - a new column letter.message_transport_type. - a new primary key for letter. - fill the new table with existing values. Test plan: After applying this patch and executing the updatedatabase entry, verify that the overduerules_transport_types table contains a row for each entry in the overduerules table. The message_transport_type column should contain 'email'. Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #118 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 26660 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26660action=edit Bug 9016: Fix unit tests The unit tests should insert overdue rules. + Fix the doc for GetOverdueMessageTransportTypes Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #116 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 26658 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26658action=edit Bug 9016: FIX GetMessageTransportTypes returns an arrayref, not hashref Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #120 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 26662 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26662action=edit Bug 9016: Fix some translate issues On tools/letter.pl and tools/overduerules.pl, some strings were not translatable. This patch should fix that. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #121 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 26663 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26663action=edit Bug 9016 [QA Followup] - Add insertAtCaret library to about page Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #122 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 26664 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26664action=edit Bug 9016: (follow-up) qa fixes * Fixes POD of GetMessageTransportTypes. * Removes the useless map in GetMessageTransportTypes. * Textual: You must specify a title and a content - Please specify title and content. * Reintroduces and around the field name. * Change message for the update DB entry. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #124 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 2 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2action=edit Bug 9016: FIX additional mtt's name should be displayed in header if you insert a new line in your message_transport_types table, the overdues configuration table did not displayed an header. Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi Yes sir works great! Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #125 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 26667 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26667action=edit Bug 9016: FIX letter name is not displayed on editing a letter On editing a letter, the letter name is not displayed. So if you save it, the letter name is erased with an empty string. Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi Tested by setting the Name-field in letter.pl, saving, re-editing and verifying that the email is present in the letter's Name-field. The letter Name is replicated for each template in the DB, but that doesn't incur any performance penalty. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #123 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 26665 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26665action=edit Bug 9016: FIX GetLetters should return all letters GetLetters only returns letters with a mtt = email. It should return all letter codes in the DB. The message_transport_type parameter is never used. To reproduce the issue: Create a notice with a sms template and no email template. Go on the overdue rules configucation page. The notice does not appear in the notice list. Signed-off-by: Olli-Antti Kivilahti kivilahtio@ProBook6570b --- Testing report: --- Testing this subroutine from a test stub. Calling the method without arguments and with argument 'circulation' and 'circulat'. Works as supposed to. Related Bug 11931 discovered but not within the scope of this featureset. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #128 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 26672 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26672action=edit Bug 9016: Improve number of characters display when mtt=sms Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #129 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 26673 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26673action=edit Bug 9016: [QA Follow-up] Remove warning from content.length test If the letter.content is undef, the content.length test in the letter template will trigger warning: Argument isn't numeric in numeric gt (). This patch eliminates that warning. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #127 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 26670 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26670action=edit Bug 9016: Add some validation on the letter form 1/ Code and Name are mandatory. 2/ At least 1 template should be filled on saving. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #126 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 26668 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26668action=edit Bug 9016: (followup) FIX letter name is not displayed on editing a letter If the name is not in email, the name is not correctly retrieved. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #106 from M. de Rooy m.de.r...@rijksmuseum.nl --- Still applies. I will try to pick up now where I left this.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #107 from M. de Rooy m.de.r...@rijksmuseum.nl --- Follow-up QA Comment: Good/promising feature. Looks good, but with some comments: 1) This patch series provides some groundwork for subsequent changes in follow-up reports. This means that not everything this patch seems to offer now, is actually used. For instance, you can edit sms notices now or click phone in overdue rules, but this will not produce any results. Given that I am told that these changes are still coming in the follow-up reports, this should just be considered as temporary confusion. I note however that marking these options as not-in-use-yet (somehow..) and releasing them further on in the process would have had my (personal) preference. 2) At the last transport_type of tools/letter.pl a counter is displayed like: Message body: 11/160. It was not evident at the start for me that it meant 11 chars from max 160. No blocker, but could be improved later? 3) When adding a new notice the first time, I was forced to add subject and contents for each transport type (Which I did not really like). BUT then I tried to reproduce this once again, and I couldn't. (Caching problem?) So no blocker. But I discovered one small thing: If I enter code and name on the top, and do not fill anything further. The program seems to accept that and save, but actually it just ignores what I typed. Maybe we should catch that situation. No blocker btw. And another more annoying one (maybe more theoretical indeed): Fill in code, name and the SECOND mtt. Now it will save one letter (including the name). But it will not pickup the name again when editing this notice. (One of the last patches dealt with something similar.) 4) In this report overdue notices are still handled by transport type email only. The commit message in one of the patches suggests otherwise. As I understand, the next patch series (10832) takes care of it. 5) On Overdue rules, I can enter a delay value and select a notice without selecting a transport type. The action is saved, but reads to me that Koha will not do anything with it. Should we warn the user here? No blocker for now. But could be improved. 6) From a commit message: if you insert a new line in your message_transport_types table, the overdues configuration table did not displayed an header. How would you add such a type? Just via sql? I understood that the interface will not offer such a functionality. I think that it is great that the interface immediately shows me overdue rules and notices for the new type. But on the other hand, we could discuss how sensible it really is to do so. No blocker, but an interesting discussion :) 7) Just noting that tools/overduerules.pl contains sql code and you also add some. (Admin scripts are marked as an exception...) Changed tests pass. No complaints from qa tools. I am inclined to pass QA, but do you have a quick fix for some of the stuff under point 3? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #108 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to M. de Rooy from comment #107) Follow-up QA Comment: Thanks! Good/promising feature. Looks good, but with some comments: 1) This patch series provides some groundwork for subsequent changes in follow-up reports. This means that not everything this patch seems to offer now, is actually used. Actually it does not make sense to push this patch set alone. All patches from linked reports should be pushed at the same time. 2) At the last transport_type of tools/letter.pl a counter is displayed like: Message body: 11/160. It was not evident at the start for me that it meant 11 chars from max 160. No blocker, but could be improved later? Hum, what do you propose? 3) When adding a new notice the first time, I was forced to add subject and contents for each transport type (Which I did not really like). BUT then I tried to reproduce this once again, and I couldn't. (Caching problem?) So no blocker. But I discovered one small thing: If I enter code and name on the top, and do not fill anything further. The program seems to accept that and save, but actually it just ignores what I typed. Maybe we should catch that situation. No blocker btw. And another more annoying one (maybe more theoretical indeed): Fill in code, name and the SECOND mtt. Now it will save one letter (including the name). But it will not pickup the name again when editing this notice. (One of the last patches dealt with something similar.) I will try to have a look at this too. 4) In this report overdue notices are still handled by transport type email only. The commit message in one of the patches suggests otherwise. As I understand, the next patch series (10832) takes care of it. Same as 1). Patches from bug 10832 should be pushed at the same time as this one. 5) On Overdue rules, I can enter a delay value and select a notice without selecting a transport type. The action is saved, but reads to me that Koha will not do anything with it. Should we warn the user here? No blocker for now. But could be improved. I will try to provide a followup. 6) From a commit message: if you insert a new line in your message_transport_types table, the overdues configuration table did not displayed an header. Yes, Olli found this problem on testing the patch. I agreed with him, it is an issue and fixed it. It was in order to avoid further issues. How would you add such a type? Just via sql? I understood that the interface will not offer such a functionality. I think that it is great that the interface immediately shows me overdue rules and notices for the new type. But on the other hand, we could discuss how sensible it really is to do so. No blocker, but an interesting discussion :) I think it is more flexible to display all mtt existing in DB rather than dealing with authorized mtt in templates. 7) Just noting that tools/overduerules.pl contains sql code and you also add some. (Admin scripts are marked as an exception...) Hum, yes... I didn't try to refactor this code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #109 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Jonathan Druart from comment #108) 2) At the last transport_type of tools/letter.pl a counter is displayed like: Message body: 11/160. It was not evident at the start for me that it meant 11 chars from max 160. No blocker, but could be improved later? Hum, what do you propose? I have no perfect solution at hand, but maybe just adding 11/160 characters would already be more clear? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #110 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 26648 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26648action=edit Bug 9016: (followup) FIX letter name is not displayed on editing a letter If the name is not in email, the name is not correctly retrieved. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #111 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 26649 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26649action=edit Bug 9016: Add some validation on the letter form 1/ Code and Name are mandatory. 2/ At least 1 template should be filled on saving. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #112 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 26650 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26650action=edit Bug 9016: Improve number of characters display when mtt=sms Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #113 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to M. de Rooy from comment #107) 3) When adding a new notice the first time, I was forced to add subject and contents for each transport type (Which I did not really like). BUT then I tried to reproduce this once again, and I couldn't. (Caching problem?) So no blocker. But I discovered one small thing: If I enter code and name on the top, and do not fill anything further. The program seems to accept that and save, but actually it just ignores what I typed. Maybe we should catch that situation. No blocker btw. And another more annoying one (maybe more theoretical indeed): Fill in code, name and the SECOND mtt. Now it will save one letter (including the name). But it will not pickup the name again when editing this notice. (One of the last patches dealt with something similar.) Done. 5) On Overdue rules, I can enter a delay value and select a notice without selecting a transport type. The action is saved, but reads to me that Koha will not do anything with it. Should we warn the user here? No blocker for now. But could be improved. Not trivial. Javascript code to write will be horrible... In my opinion, it's a lot of ugly code for a small added value. (In reply to M. de Rooy from comment #109) I have no perfect solution at hand, but maybe just adding 11/160 characters would already be more clear? Done. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #103 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 26226 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26226action=edit Bug 9016: FIX letter name is not displayed on editing a letter On editing a letter, the letter name is not displayed. So if you save it, the letter name is erased with an empty string. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #26226|0 |1 is obsolete|| --- Comment #104 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 26233 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26233action=edit Bug 9016: FIX letter name is not displayed on editing a letter On editing a letter, the letter name is not displayed. So if you save it, the letter name is erased with an empty string. Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi Tested by setting the Name-field in letter.pl, saving, re-editing and verifying that the email is present in the letter's Name-field. The letter Name is replicated for each template in the DB, but that doesn't incur any performance penalty. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added URL||http://wiki.koha-community. ||org/wiki/Message_transport_ ||types -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #105 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Check out the awesome documentation we wrapped up here http://wiki.koha-community.org/wiki/Message_transport_types -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016
--- Comment #96 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
(In reply to Jonathan Druart from comment #95)
Created attachment 25899 [details] [review]
Bug 9016: FIX GetLetters should return all letters
GetLetters only returns letters with a mtt = email. It should return all
letter codes in the DB.
The message_transport_type parameter is never used.
To reproduce the issue:
Create a notice with a sms template and no email template.
Go on the overdue rules configucation page.
The notice does not appear in the notice list.
Hi there Joubu!
Design fault here. The letter/template is identified by module and code.
You can have duplicate codes.
$letters{ $letter-{'code'} } = $letter-{'name'};
This overwrites the code when there are overlapping codes in modules.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #25899|0 |1 is obsolete|| --- Comment #97 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 26182 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26182action=edit Bug 9016: FIX GetLetters should return all letters GetLetters only returns letters with a mtt = email. It should return all letter codes in the DB. The message_transport_type parameter is never used. To reproduce the issue: Create a notice with a sms template and no email template. Go on the overdue rules configucation page. The notice does not appear in the notice list. Signed-off-by: Olli-Antti Kivilahti kivilahtio@ProBook6570b --- Testing report: --- Testing this subroutine from a test stub. Calling the method without arguments and with argument 'circulation' and 'circulat'. Works as supposed to. Related Bug 11931 discovered but not within the scope of this featureset. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016
Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment #98 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
(In reply to Olli-Antti Kivilahti from comment #96)
Hi there Joubu!
Design fault here. The letter/template is identified by module and code.
You can have duplicate codes.
$letters{ $letter-{'code'} } = $letter-{'name'};
This overwrites the code when there are overlapping codes in modules.
Sorry this doesn't apply here, I made a new bug 11931 for this finding.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #99 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 26209 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26209action=edit Bug 9016: FIX additional mtt's name should be displayed in header if you insert a new line in your message_transport_types table, the overdues configuration table did not displayed an header. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #26209|0 |1 is obsolete|| --- Comment #100 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 26210 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26210action=edit Bug 9016: FIX additional mtt's name should be displayed in header if you insert a new line in your message_transport_types table, the overdues configuration table did not displayed an header. Signed-off-by: Olli-Antti Kivilahti kivilahtio@ProBook6570b Yes sir works great! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #26210|0 |1 is obsolete|| --- Comment #101 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 26211 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26211action=edit Bug 9016: FIX additional mtt's name should be displayed in header if you insert a new line in your message_transport_types table, the overdues configuration table did not displayed an header. Signed-off-by: Olli-Antti Kivilahti kivilahtio@ProBook6570b Yes sir works great! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #26211|0 |1 is obsolete|| --- Comment #102 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 26216 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26216action=edit Bug 9016: FIX additional mtt's name should be displayed in header if you insert a new line in your message_transport_types table, the overdues configuration table did not displayed an header. Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi Yes sir works great! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #95 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25899 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25899action=edit Bug 9016: FIX GetLetters should return all letters GetLetters only returns letters with a mtt = email. It should return all letter codes in the DB. The message_transport_type parameter is never used. To reproduce the issue: Create a notice with a sms template and no email template. Go on the overdue rules configucation page. The notice does not appear in the notice list. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #94 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- (In reply to Jonathan Druart from comment #92) If some transport type are not relevant for someone, he cans completely remove the mtt in the message_transport_types table. I don't see a proper way to implement what you propose. For instance, on tools/overduerules.pl, all notices and mtt are listed. We could imagine a tricky js stuff for disabling/enabling mtt function of the notice selected. But is it really useful? Well this feature probably should be documented in the manual, but I don't think a feature is needed to add/remove $mtt's. If in the manual we had the information just discussed about adding/removing $mtt's via SQL, that would be enough. Also descriptions about which $mtt's are in use and instructions on writing your own cronjobs to handle them is a good solution. Atleast for us the print notice sending process is pretty complex and making a suitable UI for defining that process in a unified way might be quite difficult. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||11868 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||11867 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks|11867, 11868| --- Comment #93 from Jonathan Druart jonathan.dru...@biblibre.com --- I submitted 2 new patches on bug 11867 and bug 11868, related to this feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||11868 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||11867 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #91 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Jonathan Druart from comment #88) Thanks for your quick response and changes. At this moment in the process, it is not clear what is used (probably only email) and what is not. That makes a push not very obvious? I tried to explain the complete feature in a previous email to koha-devel: all patches should be reviewed together and pushed together, in order to keep thing consistent (for the review, not the same day :)) Sorry, I have seen your email passing by, but it got lost :) Imo it would be easier to have all information on the report. (Perhaps a document attachment explaining some thing or so..) * Functionality: I can imagine that I have filled in multiple transport types but want to activate or deactivate some of them. Would you need some status on each of them? I am sorry but I don't understand what you mean here. Now you see the 4 or 5 types (and that could grow..?) But I miss a field like Status that activates or deactivates the transport type for that notice. We could also use that status somehow to warn people that activating a certain type is not useful or even possible when there is no code to support it yet. * Functionality clash? For Overdue notice (phone notice): I can select all transport types. Confusing.. I don't find this notice in sql files. Normally, with this feature, all notices created for a specific transport type, should be moved into the main notice. For instance, Overdue notice (phone notice) should be moved into the phone template for the Overdue notice. Yes, that sounds more logical to me. This notice must have come from some earlier test perhaps.. * From commit: [Currently, only email, sms and print are relevant.] Note that you could hide what is not relevant now? Maybe someone else would like to implement phone, etc. So I did not restrict the mtts to display on the interface. OK Same comment as above actually: What about not allowing to enable the types that are not yet supported? I do not change the status for now. Appreciate feedback on the questions raised. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #92 from Jonathan Druart jonathan.dru...@biblibre.com --- If some transport type are not relevant for someone, he cans completely remove the mtt in the message_transport_types table. I don't see a proper way to implement what you propose. For instance, on tools/overduerules.pl, all notices and mtt are listed. We could imagine a tricky js stuff for disabling/enabling mtt function of the notice selected. But is it really useful? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016
--- Comment #88 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to M. de Rooy from comment #87)
First QA comment:
\o/ Thanks Marcel!
* General: Feature looks good (although not complete yet). Seems to be a
welcome addition.
At this moment in the process, it is not clear what is used (probably
only email) and what is not. That makes a push not very obvious?
I tried to explain the complete feature in a previous email to koha-devel: all
patches should be reviewed together and pushed together, in order to keep thing
consistent (for the review, not the same day :))
* Patch 1
* Functionality: I can imagine that I have filled in multiple transport
types but want to activate or deactivate some of them. Would you need some
status on each of them?
I am sorry but I don't understand what you mean here.
* POD of GetMessageTransportTypes says: returns a list of hashes?? But it
returns an arrayref! (See also Patch 3, yes.)
* BTW why not use my $mtts = $dbh-selectcol_arrayref.. instead of the
more complex map { } .. in GetMessageTransportTypes?
Yes, will be fixed.
* Just noting that we still have lots of SQL code in tools/letter.pl. Too
bad you didn't move it ;) No blocker for me.
Not too much at the same time :)
* Textual: You must specify a title and a content - Please specify title
and content [a content sounds funny to me as non-native speaker]
* IMPORTANT: The Insert button does no longer surround the fieldname with
and .
Good catch, will be fixed!
When resolving bugs crosses the boundaries of a patch set, it could be
hard to perform QA. (I simply cannot qa 30 patches at 8 reports at one time
[numbers at random, no offense]..)
I tried to fix issues on the same report, all linked reports do something
different.
Except if it is a bug on master, I open a new report.
* Patch 2
* Functionality clash? For Overdue notice (phone notice): I can select all
transport types. Confusing..
I don't find this notice in sql files. Normally, with this feature, all notices
created for a specific transport type, should be moved into the main
notice. For instance, Overdue notice (phone notice) should be moved into the
phone template for the Overdue notice.
* From commit: [Currently, only email, sms and print are relevant.] Note
that you could hide what is not relevant now?
Maybe someone else would like to implement phone, etc.
So I did not restrict the mtts to display on the interface.
* Glancing through tools/overduerules.pl: If you move First, Second, etc.
from template to script, you do not translate them anymore?
Yes, they are translatable:
var tab_map = { 1 : _(First), 2 : _(Second), 3 : _(Third)};
* Patch 4
The dbrev prints: Upgrade done (Bug 9016: Adds the association table
overduerules_transport_types)
The db rev does a lot more than that (or more important things..)
It also adds e.g. message_transport_type to letter which is closer to
the 'general theme'.
Please change the print message to a more generic one.
Will be fixed.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #89 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25606 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25606action=edit Bug 9016: (follow-up) qa fixes * Fixes POD of GetMessageTransportTypes. * Removes the useless map in GetMessageTransportTypes. * Textual: You must specify a title and a content - Please specify title and content. * Reintroduces and around the field name. * Change message for the update DB entry. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #90 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I think phone notifications are already implemented to some degree at least least for one vendor - bug 4246. I noticed a few phone related notices in one of my installations, but I seem not to have them at all my dev installations? Found this: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=installer/data/mysql/atomicupdate/Bug-4246-Talking-Tech-itiva-phone-notifications.pl;hb=4677bb52616794457f616571479aab6425be75f9 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #83 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- (In reply to M. de Rooy from comment #82) Olli, Since this is a larger set of patches, it could be helpful while reviewing it to know what you exactly tested when signing off? Is it possible to elaborate on that? Thanks in advance.. Wow, this is a big guestion. Basically I followed the test plan for this bug and for each dependant bug. Verifying from the SQL-client that data is preserved and the described database changes happen. I didn't do any Perl::Critic runs, as I am not very familiar with those and I get pretty uncontrolled results with it :) We are using this featureset in our semi-production server and have uncovered some bugs and subsequently reported them in other bug entries (which Joubu has promptly fixed). Unfortunately I didn't keep track of the test paths I took, but I can guarantee I didn't reach a 100% test coverage. Maybe 70% for this patch + the critical path. Tho I would applaud a unified Koha testing methodology to be adopted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #84 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Olli-Antti Kivilahti from comment #83) Thanks for responding. Wow, this is a big guestion. Really? Everything you could add, is helpful. Perhaps something for a next time: If you include more information in your signoff comment about what you tested especially when testing larger patches, your signoff gets even more weight. Basically I followed the test plan for this bug and for each dependant bug. Always feel free to leave the test plan too. This could reveal the bugs where the author was not thinking of.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #85 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Thanks for the feedback Mr. de Rooy. From now on I will attach a testing report for all of my sign offs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #86 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Olli-Antti Kivilahti from comment #85) Thanks for the feedback Mr. de Rooy. You are welcome. From now on I will attach a testing report for all of my sign offs. olli++ Marcel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016
--- Comment #87 from M. de Rooy m.de.r...@rijksmuseum.nl ---
First QA comment:
* General: Feature looks good (although not complete yet). Seems to be a
welcome addition.
At this moment in the process, it is not clear what is used (probably only
email) and what is not. That makes a push not very obvious?
* Patch 1
* Functionality: I can imagine that I have filled in multiple transport types
but want to activate or deactivate some of them. Would you need some status on
each of them?
* t/db_dependent/Letters.t passed
Just noting that the value 'feed' is not added in the test. Seems no
problem..
* POD of GetMessageTransportTypes says: returns a list of hashes?? But it
returns an arrayref! (See also Patch 3, yes.)
* BTW why not use my $mtts = $dbh-selectcol_arrayref.. instead of the more
complex map { } .. in GetMessageTransportTypes?
* Just noting that we still have lots of SQL code in tools/letter.pl. Too bad
you didn't move it ;) No blocker for me.
* Textual: You must specify a title and a content - Please specify title and
content [a content sounds funny to me as non-native speaker]
* IMPORTANT: The Insert button does no longer surround the fieldname with
and .
This line (among others) got killed: myQuery.value = chaineSql.substring(0,
startPos) +''+ chaineAj+'' + chaineSql.substring(endPos, chaineSql.length);
Note that this does not build up confidence in the test stage. (Did you
perhaps repair this on another report already?)
When resolving bugs crosses the boundaries of a patch set, it could be hard
to perform QA. (I simply cannot qa 30 patches at 8 reports at one time [numbers
at random, no offense]..)
* Patch 2
* Test t/db_dependent/Overdues.t passed
* Functionality clash? For Overdue notice (phone notice): I can select all
transport types. Confusing..
* From commit: [Currently, only email, sms and print are relevant.] Note that
you could hide what is not relevant now?
* Glancing through tools/overduerules.pl: If you move First, Second, etc.
from template to script, you do not translate them anymore?
Note that I would not disapprove the idea of more flexibility there..
* Patch 4
The dbrev prints: Upgrade done (Bug 9016: Adds the association table
overduerules_transport_types)
The db rev does a lot more than that (or more important things..)
It also adds e.g. message_transport_type to letter which is closer to the
'general theme'.
Please change the print message to a more generic one.
* Other patches: no specific comments at this time.
Changing status for now.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25124|0 |1 is obsolete|| --- Comment #74 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25416 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25416action=edit Bug 9016: Define different transport types for overdues This patch adds: - a new routine C4::Overdues::GetOverdueMessageTransportTypes. - the ability to define one or more transport types for an overdue level. Test plan: - go on tools/overduerules.pl. - verify that previous rules still exist and that the 'email' checkboxes is checked if a rule is defined. - redefined rules at different levels and check the transport type needed. Currently, only email, sms and print are relevant - Save the changes. Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25125|0 |1 is obsolete|| --- Comment #75 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25417 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25417action=edit Bug 9016: FIX GetMessageTransportTypes returns an arrayref, not hashref Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25123|0 |1 is obsolete|| --- Comment #73 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25415 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25415action=edit Bug 9016: Create a message for each transport type. This patch adds: - a new jquery plugin : insertatcaret. - the ability to define a notice template for each transport type. - a new routine C4::Letters::GetMessageTransportTypes. Test plan: - Go on tools/letter.pl and check that all existing notices are still there. - Modify one. A new empty message is present for sms, print, etc. The email message is filled with the existant value. - Add a message for sms for example (don't forget the subject) and save. - edit again and verify the sms message has been saved. Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25129|0 |1 is obsolete|| --- Comment #79 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25421 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25421action=edit Bug 9016: Fix some translate issues On tools/letter.pl and tools/overduerules.pl, some strings were not translatable. This patch should fix that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25127|0 |1 is obsolete|| --- Comment #77 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25419 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25419action=edit Bug 9016: Fix unit tests The unit tests should insert overdue rules. + Fix the doc for GetOverdueMessageTransportTypes Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25128|0 |1 is obsolete|| --- Comment #78 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25420 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25420action=edit Bug 9016: QA Followup Fix tab characters and POD. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25126|0 |1 is obsolete|| --- Comment #76 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25418 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25418action=edit Bug 9016: DB changes: new table overduerules_transport_types This patch adds: - a new table overduerules_transport_types. - a new column letter.message_transport_type. - a new primary key for letter. - fill the new table with existing values. Test plan: After applying this patch and executing the updatedatabase entry, verify that the overduerules_transport_types table contains a row for each entry in the overduerules table. The message_transport_type column should contain 'email'. Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25130|0 |1 is obsolete|| --- Comment #80 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25422 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25422action=edit Bug 9016 [QA Followup] - Add insertAtCaret library to about page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
