[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
--- Comment #54 from Marcel de Rooy ---
This change has interesting side-effects !
-$sth = $dbh->prepare("UPDATE biblioitems SET marc=?,marcxml=? WHERE
biblionumber=?");
-$sth->execute( $record->as_usmarc(), $record->as_xml_record($encoding),
$biblionumber );
+$sth = $dbh->prepare("UPDATE biblioitems SET marcxml=? WHERE
biblionumber=?");
+$sth->execute( $record->as_xml_record($encoding), $biblionumber );
It seems that since we do no longer call the sub as_usmarc, the automatic field
lengths in the marc are not calculated anymore.
This needs our attention. Will open a new report now!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455
--- Comment #55 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #54)
> This change has interesting side-effects !
>
> -$sth = $dbh->prepare("UPDATE biblioitems SET marc=?,marcxml=? WHERE
> biblionumber=?");
> -$sth->execute( $record->as_usmarc(), $record->as_xml_record($encoding),
> $biblionumber );
> +$sth = $dbh->prepare("UPDATE biblioitems SET marcxml=? WHERE
> biblionumber=?");
> +$sth->execute( $record->as_xml_record($encoding), $biblionumber );
>
> It seems that since we do no longer call the sub as_usmarc, the automatic
> field lengths in the marc are not calculated anymore.
> This needs our attention. Will open a new report now!
Trivial fix submitted. Please have a look and sign off.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Marcel de Rooy changed: What|Removed |Added Blocks||20126 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20126 [Bug 20126] Saving a biblio does no longer update MARC field lengths -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Jonathan Druart changed: What|Removed |Added Blocks||17731 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 [Bug 17731] Remove the noxml option from rebuild_zebra.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Katrin Fischer changed: What|Removed |Added Status|Pushed to Stable|Pushed to Master --- Comment #53 from Katrin Fischer --- 16.11 is stable now, but this was pushed pre-release and won't be backported. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Mason James changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Frédéric Demians changed: What|Removed |Added CC||frede...@tamil.fr --- Comment #52 from Frédéric Demians --- Great. Rather an 'enhancement' than a 'normal' bug for me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||k...@bywatersolutions.com --- Comment #51 from Kyle M Hall --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #50 from David Cook --- Woo team! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #49 from Nick Clemens --- Created attachment 55853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55853&action=edit Bug 10455 (QA Followup) Fix record matching in misc/cronjobs/delete_records_via_leader.pl Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Nick Clemens changed: What|Removed |Added Attachment #55410|0 |1 is obsolete|| --- Comment #48 from Nick Clemens --- Created attachment 55852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55852&action=edit Bug 10455: Fix tests Signed-off-by: Mason James Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Nick Clemens changed: What|Removed |Added Attachment #55407|0 |1 is obsolete|| --- Comment #45 from Nick Clemens --- Created attachment 55849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55849&action=edit Bug 10455: (follow-up 2) Remove biblioitems.marc Signed-off-by: Mason James Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Nick Clemens changed: What|Removed |Added Attachment #55409|0 |1 is obsolete|| --- Comment #47 from Nick Clemens --- Created attachment 55851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55851&action=edit Bug 10455: Remove MARC21_utf8_flag_fix.pl Is this script still in use? It uses the biblioitems.marc field so if it's still useful it will need to be rewritten. Signed-off-by: Mason James Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Nick Clemens changed: What|Removed |Added Attachment #55408|0 |1 is obsolete|| --- Comment #46 from Nick Clemens --- Created attachment 55850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55850&action=edit Bug 10455: (follow-up 3) Remove biblioitems.marc Signed-off-by: Mason James Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Nick Clemens changed: What|Removed |Added Attachment #55405|0 |1 is obsolete|| --- Comment #43 from Nick Clemens --- Created attachment 55847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55847&action=edit Bug 10455: Remove biblioitems.marc - update delete_records_via_leader.pl Recently added, delete_records_via_leader.pl reads biblioitems.marc as a text field and search for record to delete regarding the leader 5. This can be acchieve doing the same thing on biblioitems.marcxml (will certainly be slower) waiting for a patch on bug 15537. Test plan: Confirm that this script works as before, to do so the easiest way would be to dump your DB before executing the update DB entry, execute the script to delete records, reinsert the DB, execute the udpate DB entry (remove biblioitems.marc), execute the script to delete records. You should get the same number of records deleted. Signed-off-by: Mason James Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Nick Clemens changed: What|Removed |Added Attachment #55406|0 |1 is obsolete|| --- Comment #44 from Nick Clemens --- Created attachment 55848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55848&action=edit Bug 10455: (follow-up) Remove biblioitems.marc Signed-off-by: Mason James Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Nick Clemens changed: What|Removed |Added Attachment #55404|0 |1 is obsolete|| --- Comment #42 from Nick Clemens --- Created attachment 55846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55846&action=edit Bug 10455: Remove biblioitems.marc - rm MARC21_parse_test.pl This script seems to be unused and it won't be of any usefulness after the removal of biblioitems.marc Signed-off-by: Mason James Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Nick Clemens changed: What|Removed |Added Attachment #55402|0 |1 is obsolete|| --- Comment #40 from Nick Clemens --- Created attachment 55844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55844&action=edit Bug 10455: Remove biblioitems.marc - DB changes Signed-off-by: Mason James Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Nick Clemens changed: What|Removed |Added Attachment #55403|0 |1 is obsolete|| --- Comment #41 from Nick Clemens --- Created attachment 55845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55845&action=edit Bug 10455: Remove biblioitems.marc Any discussions about biblioitems.marc bring to the same conclusion: This field is useless and should be removed. We are storing MARC data into 2 different fields, that does not make sense. Test plan: Add / update / export / import /delete records should work as before Signed-off-by: Mason James Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Nick Clemens changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455
Nick Clemens changed:
What|Removed |Added
Status|Signed Off |Failed QA
CC||n...@bywatersolutions.com
--- Comment #39 from Nick Clemens ---
In:
misc/cronjobs/delete_records_via_leader.pl
I think you need:
$schema->resultset('Biblioitem')->search( { marcxml => { LIKE =>
'%_d%' } } );
Instead of:
$schema->resultset('Biblioitem')->search( { marcxml => { LIKE =>
'_d%' } } );
Otherwise seems to be working well
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Mason James changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #38 from Mason James --- I've tested Jonathan's 9 patches. Everything seems to work as expected, and the patches all look good to me I used the misc/devel/update_dbix_class_files.pl script to build the Koha/Scheme/Results/* files, before testing delete_records_via_leader.pl thanks Jonathan! :0) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #37 from Mason James --- Created attachment 55410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55410&action=edit Bug 10455: Fix tests Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #35 from Mason James --- Created attachment 55408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55408&action=edit Bug 10455: (follow-up 3) Remove biblioitems.marc Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #32 from Mason James --- Created attachment 55405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55405&action=edit Bug 10455: Remove biblioitems.marc - update delete_records_via_leader.pl Recently added, delete_records_via_leader.pl reads biblioitems.marc as a text field and search for record to delete regarding the leader 5. This can be acchieve doing the same thing on biblioitems.marcxml (will certainly be slower) waiting for a patch on bug 15537. Test plan: Confirm that this script works as before, to do so the easiest way would be to dump your DB before executing the update DB entry, execute the script to delete records, reinsert the DB, execute the udpate DB entry (remove biblioitems.marc), execute the script to delete records. You should get the same number of records deleted. Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #36 from Mason James --- Created attachment 55409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55409&action=edit Bug 10455: Remove MARC21_utf8_flag_fix.pl Is this script still in use? It uses the biblioitems.marc field so if it's still useful it will need to be rewritten. Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #33 from Mason James --- Created attachment 55406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55406&action=edit Bug 10455: (follow-up) Remove biblioitems.marc Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #31 from Mason James --- Created attachment 55404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55404&action=edit Bug 10455: Remove biblioitems.marc - rm MARC21_parse_test.pl This script seems to be unused and it won't be of any usefulness after the removal of biblioitems.marc Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #34 from Mason James --- Created attachment 55407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55407&action=edit Bug 10455: (follow-up 2) Remove biblioitems.marc Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #30 from Mason James --- Created attachment 55403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55403&action=edit Bug 10455: Remove biblioitems.marc Any discussions about biblioitems.marc bring to the same conclusion: This field is useless and should be removed. We are storing MARC data into 2 different fields, that does not make sense. Test plan: Add / update / export / import /delete records should work as before Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Mason James changed: What|Removed |Added Attachment #54844|0 |1 is obsolete|| Attachment #54845|0 |1 is obsolete|| Attachment #54846|0 |1 is obsolete|| Attachment #54847|0 |1 is obsolete|| Attachment #54850|0 |1 is obsolete|| Attachment #54858|0 |1 is obsolete|| Attachment #54860|0 |1 is obsolete|| Attachment #54875|0 |1 is obsolete|| --- Comment #29 from Mason James --- Created attachment 55402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55402&action=edit Bug 10455: Remove biblioitems.marc - DB changes Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Mason James changed: What|Removed |Added Depends on|15537 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 [Bug 15537] Hide records on Leader 05 = d in OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Mason James changed: What|Removed |Added Depends on||15537 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 [Bug 15537] Hide records on Leader 05 = d in OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Mason James changed: What|Removed |Added Attachment #55401|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Mason James changed: What|Removed |Added Attachment #54881|0 |1 is obsolete|| --- Comment #28 from Mason James --- Created attachment 55401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55401&action=edit Bug 10455: Fix tests Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #27 from Jonathan Druart --- Created attachment 54881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54881&action=edit Bug 10455: Fix tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #26 from Jonathan Druart --- Created attachment 54875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54875&action=edit Bug 10455: Remove MARC21_utf8_flag_fix.pl Is this script still in use? It uses the biblioitems.marc field so if it's still useful it will need to be rewritten. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Jonathan Druart changed: What|Removed |Added Blocks||17196 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 [Bug 17196] Move marcxml out of the biblioitems table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Jonathan Druart changed: What|Removed |Added Attachment #54859|0 |1 is obsolete|| --- Comment #25 from Jonathan Druart --- Created attachment 54860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54860&action=edit Bug 10455: (follow-up 3) Remove biblioitems.marc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #24 from Jonathan Druart --- Created attachment 54859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54859&action=edit Bug 10455: (follow-up 3) Remove biblioitems.marc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Jonathan Druart changed: What|Removed |Added Attachment #54857|0 |1 is obsolete|| --- Comment #23 from Jonathan Druart --- Created attachment 54858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54858&action=edit Bug 10455: (follow-up 2) Remove biblioitems.marc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Jonathan Druart changed: What|Removed |Added Attachment #54856|0 |1 is obsolete|| --- Comment #22 from Jonathan Druart --- Created attachment 54857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54857&action=edit Bug 10455: (follow-up 2) Remove biblioitems.marc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Jonathan Druart changed: What|Removed |Added Attachment #54855|0 |1 is obsolete|| --- Comment #21 from Jonathan Druart --- Created attachment 54856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54856&action=edit Bug 10455: (follow-up 2) Remove biblioitems.marc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #20 from Jonathan Druart --- Created attachment 54855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54855&action=edit Bug 10455: (follow-up 2) Remove biblioitems.marc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Jonathan Druart changed: What|Removed |Added Attachment #54849|0 |1 is obsolete|| --- Comment #19 from Jonathan Druart --- Created attachment 54850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54850&action=edit Bug 10455: (follow-up) Remove biblioitems.marc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #18 from Jonathan Druart --- Created attachment 54849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54849&action=edit Bug 10455: (follow-up) Remove biblioitems.marc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=11084 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #14 from Jonathan Druart --- Created attachment 54844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54844&action=edit Bug 10455: Remove biblioitems.marc - DB changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #17 from Jonathan Druart --- Created attachment 54847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54847&action=edit Bug 10455: Remove biblioitems.marc - update delete_records_via_leader.pl Recently added, delete_records_via_leader.pl reads biblioitems.marc as a text field and search for record to delete regarding the leader 5. This can be acchieve doing the same thing on biblioitems.marcxml (will certainly be slower) waiting for a patch on bug 15537. Test plan: Confirm that this script works as before, to do so the easiest way would be to dump your DB before executing the update DB entry, execute the script to delete records, reinsert the DB, execute the udpate DB entry (remove biblioitems.marc), execute the script to delete records. You should get the same number of records deleted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #15 from Jonathan Druart --- Created attachment 54845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54845&action=edit Bug 10455: Remove biblioitems.marc Any discussions about biblioitems.marc bring to the same conclusion: This field is useless and should be removed. We are storing MARC data into 2 different fields, that does not make sense. Test plan: Add / update / export / import /delete records should work as before -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #16 from Jonathan Druart --- Created attachment 54846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54846&action=edit Bug 10455: Remove biblioitems.marc - rm MARC21_parse_test.pl This script seems to be unused and it won't be of any usefulness after the removal of biblioitems.marc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Jonathan Druart changed: What|Removed |Added Assignee|gmcha...@gmail.com |jonathan.dru...@bugs.koha-c ||ommunity.org Status|NEW |ASSIGNED Blocks||15342 --- Comment #13 from Jonathan Druart --- As of a topic on the ML (http://lists.koha-community.org/pipermail/koha-devel/2016-July/042821.html) removing this column would bring performance gains. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342 [Bug 15342] Performance 3.22 - Omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #12 from Jonathan Druart --- (In reply to David Cook from comment #11) > (In reply to Jonathan Druart from comment #10) > > I have just used it right now. > > For testing purpose I have removed the marcxml field. > > Using --fix, I was able to repopulate it from the marc. > > But why did you remove the marcxml field at all? :p I have no idea, really :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #11 from David Cook --- (In reply to Jonathan Druart from comment #10) > I have just used it right now. > For testing purpose I have removed the marcxml field. > Using --fix, I was able to repopulate it from the marc. But why did you remove the marcxml field at all? :p -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #10 from Jonathan Druart --- (In reply to Jonathan Druart from comment #6) > (In reply to David Cook from comment #5) > > (In reply to Jonathan Druart from comment #4) > > > biblioitems.marc is used by misc/cronjobs/MARC21_parse_test.pl. Does this > > > script still used? > > > > I've never even heard of this script before, so I don't think that we use > > it. However, I suppose it's possible that someone uses it? > > > > Could we just remove the references to biblioitems.marc in this one script? > > Yes we could, if nobody uses the --fix option: > > 243-f --fix Replace biblioitems.marcxml from data in marc field, > default OFF I have just used it right now. For testing purpose I have removed the marcxml field. Using --fix, I was able to repopulate it from the marc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #9 from David Cook --- Just noticed that http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 is using biblioitems.marc as a string... that would block this bug... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #8 from Katrin Fischer --- I tend to agree with Magnus - I am not sure that this script makes that much sense. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #7 from Magnus Enger --- (In reply to Jonathan Druart from comment #6) > Yes we could, if nobody uses the --fix option: > > 243-f --fix Replace biblioitems.marcxml from data in marc field, > default OFF The script was added in 2009 and not touched since: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=84ff3747b80d42914a8d570b6b4ff5667eab663b >From the commit message: "When marcxml cannot be parsed into a MARC::Record object, the biblio is undisplayable and it obviously breaks many features in Koha. This script can test to parse every marcxml, and alert on failures. Optionally, the marcxml can be replaced from the marc field." Didn't we at some point switch from treating marc (ISO2709) as the authoritative format, to treating marcxml as the authoritative format? I'd say loosing the ability to recreate marcxml from marc is no big deal. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #6 from Jonathan Druart --- (In reply to David Cook from comment #5) > (In reply to Jonathan Druart from comment #4) > > biblioitems.marc is used by misc/cronjobs/MARC21_parse_test.pl. Does this > > script still used? > > I've never even heard of this script before, so I don't think that we use > it. However, I suppose it's possible that someone uses it? > > Could we just remove the references to biblioitems.marc in this one script? Yes we could, if nobody uses the --fix option: 243-f --fix Replace biblioitems.marcxml from data in marc field, default OFF -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #5 from David Cook --- (In reply to Jonathan Druart from comment #4) > biblioitems.marc is used by misc/cronjobs/MARC21_parse_test.pl. Does this > script still used? I've never even heard of this script before, so I don't think that we use it. However, I suppose it's possible that someone uses it? Could we just remove the references to biblioitems.marc in this one script? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart --- biblioitems.marc is used by misc/cronjobs/MARC21_parse_test.pl. Does this script still used? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Galen Charlton changed: What|Removed |Added Status|In Discussion |ASSIGNED --- Comment #3 from Galen Charlton --- (In reply to Magnus Enger from comment #1) > I seem to remember someone saying that we should keep the iso2709 in > biblioitems.marc, because if you want to export e.g. 500k records in iso2709 > format, transforming all those records from marcxml on the fly would be > *really* heavy. But I might be wrong... Sure, if you want ISO2709 and are starting from MARCXML, converting to ISO2709 for an export will consume a bit more CPU than dumping pre-existing ISO2709 directly... but (a) the cost of conversion is not that much, (b) exports are relatively infrequent operations, (c) and as such, better to pay the cost during exports than to (admittedly slightly) slow down the operation of saving or modifying a bib record. I'm taking of removing the "In Discussion" status in the hopes that somebody takes up writing a patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Galen Charlton changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 paxed changed: What|Removed |Added CC||pasi.kalli...@pttk.fi --- Comment #2 from paxed --- (In reply to Magnus Enger from comment #1) > > I seem to remember someone saying that we should keep the iso2709 in > biblioitems.marc, because if you want to export e.g. 500k records in iso2709 > format, transforming all those records from marcxml on the fly would be > *really* heavy. But I might be wrong... I'd think not having to take care of twice the data would weigh more than possibly having a hypothetical situation of exporting 500k iso2709 records... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Magnus Enger changed: What|Removed |Added Status|NEW |In Discussion CC||mag...@enger.priv.no --- Comment #1 from Magnus Enger --- The data might be the same, but the format is different, because biblioitems.marc is iso2709, right? I seem to remember someone saying that we should keep the iso2709 in biblioitems.marc, because if you want to export e.g. 500k records in iso2709 format, transforming all those records from marcxml on the fly would be *really* heavy. But I might be wrong... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Mason James changed: What|Removed |Added Summary|remove duplicated/redundant |remove redundant |bibltioitems.marc field |'biblioitems.marc' field -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
