[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2022-12-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Katrin Fischer changed: What|Removed |Added Blocks||32505 Referenced Bugs:

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2020-01-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Katrin Fischer changed: What|Removed |Added Blocks|17374 | See Also|

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2017-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Jonathan Druart changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Katrin Fischer changed: What|Removed |Added Component|Staff Client

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #49 from Kyle M Hall --- Followup pushed to master, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #48 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #47) > Created attachment 57009 [details] [review] > Bug 14874: (followup) Fix typo introduced in

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #47 from Tomás Cohen Arazi --- Created attachment 57009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57009=edit Bug 14874: (followup) Fix typo introduced in sysprefs.sql

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-10-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Kyle M Hall changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-10-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Kyle M Hall changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-10-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Kyle M Hall changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #43 from Jonathan Druart --- I'd like to see a patch on bug 17374 in order to have them in the same release. -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Jonathan Druart changed: What|Removed |Added Depends on|

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #41 from Jonathan Druart --- Great Nick, this version is much more better :) The type of the pref should not be "multi" but it does not seem to hurt and bug 17374 has been

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #40 from Jonathan Druart --- Created attachment 56028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56028=edit Bug 14874: Set default

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Jonathan Druart changed: What|Removed |Added Attachment #55919|0

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-09-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-09-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Marc Véron changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-09-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Marc Véron changed: What|Removed |Added Blocks||17374

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-09-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Marc Véron changed: What|Removed |Added Attachment #55913|0 |1 is

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-09-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Marc Véron changed: What|Removed |Added Attachment #55899|0 |1 is

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-09-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Nick Clemens changed: What|Removed |Added Attachment #55912|0 |1

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-09-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #34 from Nick Clemens --- Created attachment 55912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55912=edit Bug 14874 (QA Followup) Fix atomicupdate file name -- You are

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-09-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #33 from Nick Clemens --- (In reply to Marc Véron from comment #32) > Updating database did not work because > /installer/data/mysql/atomicupdate/bug14874- >

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-09-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-09-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #31 from Nick Clemens --- Rebased and squashed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-09-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Nick Clemens changed: What|Removed |Added Attachment #52998|0 |1

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-09-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Nick Clemens changed: What|Removed |Added Attachment #52998|1 |0

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-09-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Nick Clemens changed: What|Removed |Added Attachment #52999|1 |0

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-09-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Nick Clemens changed: What|Removed |Added Attachment #52999|0 |1

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-09-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Nick Clemens changed: What|Removed |Added Attachment #52998|0 |1

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #29 from Nick Clemens --- Created attachment 55589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55589=edit Bug 14874 - Use a syspref to determine the 'standard' search

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Nick Clemens changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Nicole C. Engard changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #28 from Martin Renvoize --- (In reply to Jonathan Druart from comment #26) > (In reply to Jonathan Druart from comment #13) > > I am wondering if this behavior is not too arbitrary: Why

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #27 from Martin Renvoize --- Cheers for the explaination regarding performance. I also see that the DateTime identification code is s simple regex so I'm happy on that front. Martin --

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #26 from Jonathan Druart --- (In reply to Jonathan Druart from comment #13) > I am wondering if this behavior is not too arbitrary: Why date of birth and > not another date

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Nick Clemens changed: What|Removed |Added Status|In Discussion

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #25 from Nick Clemens --- Created attachment 53001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53001=edit Bug 14874 (QA Followup) Add dateofbirth column to checkout

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Nick Clemens changed: What|Removed |Added Attachment #51972|0 |1

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Nick Clemens changed: What|Removed |Added Attachment #51971|0 |1

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Nick Clemens changed: What|Removed |Added Attachment #52079|0 |1

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #21 from Nick Clemens --- (In reply to Martin Renvoize from comment #20) > Performance wise, I tend to like to see a benchmark script rather than > conjecture to prove the point I didn't mean

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-06-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-06-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #19 from Nick Clemens --- (In reply to Katrin Fischer from comment #18) > But apart from that, I am mostly worried about how this will impact the > performance of the patron search - will it

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Katrin Fischer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #17 from Jonathan Druart --- Hi Mike, Thanks for your answer. If you are on /cgi-bin/koha/members/members-home.pl there is a patron search form in the header where you can

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-06-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Nick Clemens changed: What|Removed |Added Status|In Discussion

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Mike Kerth changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-06-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #15 from Jonathan Druart --- (In reply to Nick Clemens from comment #14) > (In reply to Jonathan Druart from comment #13) > > Could you detail the use case? > > I am wondering if

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-06-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #14 from Nick Clemens --- (In reply to Jonathan Druart from comment #13) > Could you detail the use case? > I am wondering if this behavior is not too arbitrary: Why date of birth and > not

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-06-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-06-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #12 from Jonathan Druart --- Created attachment 52079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52079=edit Bug 14874: Tidy previous patch remove debug

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #11 from PTFS Europe Sandboxes --- Created attachment 51972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51972=edit Bug 14874 - (followup) Refactor

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #51654|0

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 PTFS Europe Sandboxes changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #51653|0

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #10 from PTFS Europe Sandboxes --- Created attachment 51971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51971=edit Bug 14874 - Add ability to search for patrons by date of

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #8 from Nick Clemens --- (In reply to Owen Leonard from comment #4) > > 4 - Search combined with other terms, results should be returned as > > expected > Is that how it's supposed to work or

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Nick Clemens changed: What|Removed |Added Attachment #51505|0 |1

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Nick Clemens changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Nick Clemens changed: What|Removed |Added Attachment #51652|0 |1

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Nick Clemens changed: What|Removed |Added Attachment #51504|0 |1

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-05-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-05-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-05-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Nick Clemens changed: What|Removed |Added Status|NEW

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-05-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #1 from Nick Clemens --- Created attachment 51503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51503=edit Bug 14874 - Add ability to search for patrons by date of birth

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-05-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Nick Clemens changed: What|Removed |Added Attachment #51503|0 |1

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

2016-05-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #3 from Nick Clemens --- Created attachment 51505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51505=edit Bug 14874 - (followup) Refactor