[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #296 from Lisette Scheer --- Worked great in all cases. Thanks David! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Lisette Scheer changed: What|Removed |Added Attachment #163092|0 |1 is obsolete|

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #295 from Lisette Scheer --- Created attachment 163093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163093=edit Bug 15565: Place multiple holds on one record on staff interface Signed-off-by:

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Lisette Scheer changed: What|Removed |Added Attachment #163052|0 |1 is obsolete|

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #293 from Nick Clemens --- Created attachment 163055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163055=edit Bug 15565: Add 'DisplayMultiItemHolds' system preference to toggle display of multi item

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #292 from Nick Clemens --- Created attachment 163054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163054=edit Bug 15565: Place multiple holds on one or more records in OPAC -- You are receiving

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #291 from Nick Clemens --- Created attachment 163053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163053=edit Bug 15565: Tidy reserve/placerequest.pl -- You are receiving this mail because: You are

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Nick Clemens changed: What|Removed |Added Attachment #162071|0 |1 is obsolete|

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply ---

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #288 from David Cook --- I noticed there is a FAIL in the QA tools, but it's not related to this change: -- testing 4 commit(s) (applied to d130a6c '6b Bug 35962: (bug 35843 follow-up 2)') Processing files before

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Assignee|alei...@catalyst.net.nz |dc...@prosentient.com.au --

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Text to go in the|Allow borrowers to place|Allow borrowers to place

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #287 from David Cook --- Created attachment 162074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162074=edit Bug 15565: Add 'DisplayMultiItemHolds' system preference to toggle display of multi item

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #286 from David Cook --- Created attachment 162073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162073=edit Bug 15565: Place multiple holds on one or more records in OPAC -- You are receiving this

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #285 from David Cook --- Created attachment 162072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162072=edit Bug 15565: Tidy reserve/placerequest.pl -- You are receiving this mail because: You are

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Attachment #120639|0 |1 is obsolete|

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #283 from David Cook --- (In reply to David Cook from comment #282) > The difference with the past patches is that we don't get the > warnings/restrictions in the UI *before* placing the hold. We only get the > warnings

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #282 from David Cook --- (In reply to David Cook from comment #281) > I've rewritten the staff-interface code to be much more minimal yet still > effective. Its error handling is patterned off the OPAC, which makes it >

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #281 from David Cook --- I've rewritten the staff-interface code to be much more minimal yet still effective. Its error handling is patterned off the OPAC, which makes it consistent across the interfaces as well. --

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Text to go in the|Allow borrowers to place|Allow borrowers to place

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #280 from David Cook --- (In reply to David Cook from comment #279) > Looking at this code again, and I think one of the reasons it never got > accepted was that it was trying to fix too many sins in the Reserves/Holds >

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #279 from David Cook --- Looking at this code again, and I think one of the reasons it never got accepted was that it was trying to fix too many sins in the Reserves/Holds area. We'd be better off getting rid of

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Text to go in the|Allow borrowers to place|Allow borrowers to place

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Text to go in the|Allow borrowers to place|Allow borrowers to place

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Lisette Scheer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Ilona R changed: What|Removed |Added CC||hatt...@gmail.com -- You are

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #278 from Aleisha Amohia --- (In reply to David Cook from comment #277) > Aleisha, do you have clients using this functionality? Catalyst had received sponsorship to work on this for a library years ago, they may still

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #277 from David Cook --- Aleisha, do you have clients using this functionality? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #276 from David Cook --- As per my comment at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695#c242, it looks like multi-hold doesn't properly process Pickup location at the item-level... -- You are

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Amanda Campbell changed: What|Removed |Added CC||acampb...@hmcpl.org --

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Martin Renvoize changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #275 from David Cook --- (In reply to David Cook from comment #274) > (In reply to David Cook from comment #273) > > I fixed the merge conflict but the Javascript in the staff interface doesn't > > work anymore. Probably

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #274 from David Cook --- (In reply to David Cook from comment #273) > I fixed the merge conflict but the Javascript in the staff interface doesn't > work anymore. Probably due to other changes that have happened to the >

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #273

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #272 from David Cook --- Getting a merge conflict for "Place multiple holds on one record on staff client" I'll see if I can work it out.. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #271 from David Cook --- Created attachment 122098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122098=edit Bug 15565: Allow multiple hold for multiple bib in OPAC This patch allows an OPAC user to

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #270 from David Cook --- In the OPAC, you can select multiple specific items for multiple records at the same time from the result page, but not all of your selections make it into the holds. It looks like just the first

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #269 from David Cook --- It looks like the "Unlimited" bug happens on the staff interface but not the OPAC... -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #268 from David Cook --- I think I found another problem. From the results page, it looks like you can place multiple item holds for multiple bibs, but it doesn't work. It just places a hold on the first item for each

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #267 from Aleisha Amohia --- Created attachment 121941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121941=edit Bug 15565: Work in progress, calculating holds remaining Not ready for testing! --

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #266 from David Cook --- I need to finish up for the day, but... I reckon we need something like this: Koha::Holds->remaining_reserves_total({ patron => $patron, }); maxreserves (global system preference) "Holds allowed

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #265 from David Cook --- Ok so there are 4 different settings that control the allowable number of holds: maxreserves (global system preference) "Holds allowed (total)" (circ rule: reservesallowed) "Holds allowed

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #264 from David Cook --- Test plan: 0) git bz apply 15565 1) restart_all 2) Set up a record with 4 items E.g. add 3 items to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 Staff Interface: 3) Set

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Andrew Fuerste-Henry changed: What|Removed |Added CC|

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Tomás Cohen Arazi changed: What|Removed |Added Summary|Place multiple item-level |Place multiple

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record in OPAC and staff interface

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #263

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record in OPAC and staff interface

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #262 from David Cook --- Updating title from "Place multiple holds at once for the same record in OPAC" to "Place multiple item-level holds at once for the same record in OPAC and staff interface" since I think that's

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record in OPAC and staff interface

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Summary|Place multiple holds at |Place multiple item-level