[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #296 from Lisette Scheer --- Worked great in all cases. Thanks David! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Lisette Scheer changed: What|Removed |Added Attachment #163092|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #295 from Lisette Scheer --- Created attachment 163093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163093=edit Bug 15565: Place multiple holds on one record on staff interface Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Lisette Scheer changed: What|Removed |Added Attachment #163052|0 |1 is obsolete|| --- Comment #294 from Lisette Scheer --- Created attachment 163092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163092=edit Attachment to Bug 15565 - Place multiple item-level holds at once for the same record Bug 15565: Place multiple holds on one record on staff interface Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #293 from Nick Clemens --- Created attachment 163055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163055=edit Bug 15565: Add 'DisplayMultiItemHolds' system preference to toggle display of multi item holds These patches allow the display of checkboxes instead of radio buttons for placing specific item holds in the OPAC and staff interface. This display is controlled by the system preference 'DisplayMultiItemHolds'. When disabled, the hold display is the same as in the past. When enabled, the user can select multiple items to place holds on at the same time. If there is an error placing one or more holds, an error will display on the following screen. Test plan: 0. Apply the patches and koha-plack --reload kohadev 1. Enable 'DisplayMultiItemHolds' syspref 2. In staff interface, go to a record with multiple holdable items 3. Check the boxes next to 2+ items and click the button to place the holds 4. Note that the holds are all placed (unless there is a failure) 5. Cancel the holds, and try again (but this time make Holds per record (count) only 1 in the circ rules) 6. Note that one of the holds is placed, but the others are not and an error message is displayed saying that one or more holds could not be placed because the holds per record was exceeded 7. Perform the same above procedure on the OPAC 8. If DisplayMultiPlaceHold is enabled, you can test placing multiple specific item holds across multiple bibs in the OPAC via the search results 9. If EnableItemGroups and EnableItemGroupHolds is enabled, you can test that you can either place item group holds or specific item holds. Toggling the checkboxes in the staff interface will uncheck the item group hold radio button. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #292 from Nick Clemens --- Created attachment 163054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163054=edit Bug 15565: Place multiple holds on one or more records in OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #291 from Nick Clemens --- Created attachment 163053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163053=edit Bug 15565: Tidy reserve/placerequest.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Nick Clemens changed: What|Removed |Added Attachment #162071|0 |1 is obsolete|| Attachment #162072|0 |1 is obsolete|| Attachment #162073|0 |1 is obsolete|| Attachment #162074|0 |1 is obsolete|| --- Comment #290 from Nick Clemens --- Created attachment 163052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163052=edit Bug 15565: Place multiple holds on one record on staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #289 from Lisette Scheer --- CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #288 from David Cook --- I noticed there is a FAIL in the QA tools, but it's not related to this change: -- testing 4 commit(s) (applied to d130a6c '6b Bug 35962: (bug 35843 follow-up 2)') Processing files before patches The PO directory has not been found. There is a problem in your Koha installation. at /kohadevbox/koha/Koha/I18N.pm line 197. |>| 5 / 5 (100.00%) Processing files after patches |>| 5 / 5 (100.00%) FAIL installer/data/mysql/mandatory/sysprefs.sql FAIL sysprefs_order Not blocker: Sysprefs hidelostitems is bad placed (see bug 10610) OK koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt OK koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt OK reserve/placerequest.pl OK reserve/request.pl Processing additional checks OK! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Assignee|alei...@catalyst.net.nz |dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Text to go in the|Allow borrowers to place|Allow borrowers to place release notes|multiple item-level holds |multiple item-level holds |on a record in the staff|on a record in the staff |interface and OPAC. |interface and OPAC. | | |Item|Item |radio buttons are replaced |radio buttons are replaced |with checkboxes.|with checkboxes. || ||This ||feature is enabled/disabled ||via the system preference ||"DisplayMultiItemHolds". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #287 from David Cook --- Created attachment 162074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162074=edit Bug 15565: Add 'DisplayMultiItemHolds' system preference to toggle display of multi item holds These patches allow the display of checkboxes instead of radio buttons for placing specific item holds in the OPAC and staff interface. This display is controlled by the system preference 'DisplayMultiItemHolds'. When disabled, the hold display is the same as in the past. When enabled, the user can select multiple items to place holds on at the same time. If there is an error placing one or more holds, an error will display on the following screen. Test plan: 0. Apply the patches and koha-plack --reload kohadev 1. Enable 'DisplayMultiItemHolds' syspref 2. In staff interface, go to a record with multiple holdable items 3. Check the boxes next to 2+ items and click the button to place the holds 4. Note that the holds are all placed (unless there is a failure) 5. Cancel the holds, and try again (but this time make Holds per record (count) only 1 in the circ rules) 6. Note that one of the holds is placed, but the others are not and an error message is displayed saying that one or more holds could not be placed because the holds per record was exceeded 7. Perform the same above procedure on the OPAC 8. If DisplayMultiPlaceHold is enabled, you can test placing multiple specific item holds across multiple bibs in the OPAC via the search results 9. If EnableItemGroups and EnableItemGroupHolds is enabled, you can test that you can either place item group holds or specific item holds. Toggling the checkboxes in the staff interface will uncheck the item group hold radio button. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #286 from David Cook --- Created attachment 162073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162073=edit Bug 15565: Place multiple holds on one or more records in OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #285 from David Cook --- Created attachment 162072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162072=edit Bug 15565: Tidy reserve/placerequest.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Attachment #120639|0 |1 is obsolete|| Attachment #120640|0 |1 is obsolete|| Attachment #120641|0 |1 is obsolete|| Attachment #121941|0 |1 is obsolete|| Attachment #122098|0 |1 is obsolete|| --- Comment #284 from David Cook --- Created attachment 162071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162071=edit Bug 15565: Place multiple holds on one record on staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #283 from David Cook --- (In reply to David Cook from comment #282) > The difference with the past patches is that we don't get the > warnings/restrictions in the UI *before* placing the hold. We only get the > warnings about failures *after* trying to place the hold. > > I think warning *before* the hold is actually a separate feature. I actually don't know if there is a practical bug-free way of doing it *before*, since each individual item can have different rules. There's a complex interplay of rules. For instance, item A could have 1 "Holds per record", while item B could have 10 "Holds per record". Trying to pre-emptively calculate holdability on selected holds rather than placed holds... is tough to do without potential for errors. One could argue that it's unlikely a bib record would have items of different types, but I see it all the time. That said, only warning *after* trying to place the holds isn't great, because it might not be obvious which holds were placed and which weren't placed. But we can't do much about that while our hold placing scripts use redirects. Replacing those redirects with API calls would work better, because the user would be able to see immediately which holds were placed and which weren't. (But that also involves messing around with the DOM in unfun ways - unless we use Vue.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #282 from David Cook --- (In reply to David Cook from comment #281) > I've rewritten the staff-interface code to be much more minimal yet still > effective. Its error handling is patterned off the OPAC, which makes it > consistent across the interfaces as well. The difference with the past patches is that we don't get the warnings/restrictions in the UI *before* placing the hold. We only get the warnings about failures *after* trying to place the hold. I think warning *before* the hold is actually a separate feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35754 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #281 from David Cook --- I've rewritten the staff-interface code to be much more minimal yet still effective. Its error handling is patterned off the OPAC, which makes it consistent across the interfaces as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Text to go in the|Allow borrowers to place|Allow borrowers to place release notes|multiple item-level holds |multiple item-level holds |on a record in the staff|on a record in the staff |interface and OPAC. |interface and OPAC. | | |Item|Item |radio buttons are replaced |radio buttons are replaced |with checkboxes, and once a |with checkboxes. |borrower has reached the| |circulation rules 'Holds| |per record (count)' value | |the remaining unticked | |checkboxes are disabled.| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #280 from David Cook --- (In reply to David Cook from comment #279) > Looking at this code again, and I think one of the reasons it never got > accepted was that it was trying to fix too many sins in the Reserves/Holds > area. > > We'd be better off getting rid of placerequest.pl all together. We do have > the /api/v1/holds endpoint these days, so it is tempting to actually replace > it with some Javascript. > > I think I might try to do a quick and dirty server-side version locally, but > I think the API-driven workflow is the future for the community. Of course, that's only for the staff-side. We don't have the API endpoint for the OPAC side. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #279 from David Cook --- Looking at this code again, and I think one of the reasons it never got accepted was that it was trying to fix too many sins in the Reserves/Holds area. We'd be better off getting rid of placerequest.pl all together. We do have the /api/v1/holds endpoint these days, so it is tempting to actually replace it with some Javascript. I think I might try to do a quick and dirty server-side version locally, but I think the API-driven workflow is the future for the community. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Text to go in the|Allow borrowers to place|Allow borrowers to place release notes|multiple item-level holds |multiple item-level holds |on a record in the OPAC. |on a record in the staff ||interface and OPAC. |Item radio buttons are | |replaced with checkboxes, |Item |and once a borrower has |radio buttons are replaced |reached the circulation |with checkboxes, and once a |rules 'Holds per record |borrower has reached the |(count)' value the |circulation rules 'Holds |remaining unticked |per record (count)' value |checkboxes are disabled.|the remaining unticked ||checkboxes are disabled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Text to go in the|Allow borrowers to place|Allow borrowers to place release notes|multiple item-level holds |multiple item-level holds |on a record in the OPAC. |on a record in the OPAC. || |Item radio buttons are |Item radio buttons are |replaced with checkboxes, |replaced with checkboxes, |and once a borrower has |and once a borrower has |reached the circulation |reached the circulation |rules 'Holds per record |rules 'Holds per record |(count)' value the |(count)' value the |remaining unticked |remaining unticked |checkboxes are disabled. |checkboxes are disabled. || |This feature was previously | |only available in the staff | |client. | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Ilona R changed: What|Removed |Added CC||hatt...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #278 from Aleisha Amohia --- (In reply to David Cook from comment #277) > Aleisha, do you have clients using this functionality? Catalyst had received sponsorship to work on this for a library years ago, they may still be using a version of this in production but I'm not sure as we don't work with that library anymore and sponsorship has run out. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #277 from David Cook --- Aleisha, do you have clients using this functionality? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15516 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #276 from David Cook --- As per my comment at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695#c242, it looks like multi-hold doesn't properly process Pickup location at the item-level... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Amanda Campbell changed: What|Removed |Added CC||acampb...@hmcpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24857 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #275 from David Cook --- (In reply to David Cook from comment #274) > (In reply to David Cook from comment #273) > > I fixed the merge conflict but the Javascript in the staff interface doesn't > > work anymore. Probably due to other changes that have happened to the > > templates on master. > > This is so weird... I swear that I successfully backported to 21.05 but now > it's not working... Ah, those Javascript issues are with hold limits. The problem I encountered was due to Bug 28338... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #274 from David Cook --- (In reply to David Cook from comment #273) > I fixed the merge conflict but the Javascript in the staff interface doesn't > work anymore. Probably due to other changes that have happened to the > templates on master. This is so weird... I swear that I successfully backported to 21.05 but now it's not working... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25260 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #273 from David Cook --- I fixed the merge conflict but the Javascript in the staff interface doesn't work anymore. Probably due to other changes that have happened to the templates on master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28338 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #272 from David Cook --- Getting a merge conflict for "Place multiple holds on one record on staff client" I'll see if I can work it out.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #271 from David Cook --- Created attachment 122098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122098=edit Bug 15565: Allow multiple hold for multiple bib in OPAC This patch allows an OPAC user to select multiple item holds from multiple bibs when placing holds/reserves from the OPAC search result page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #270 from David Cook --- In the OPAC, you can select multiple specific items for multiple records at the same time from the result page, but not all of your selections make it into the holds. It looks like just the first selection. I'm looking at patching this now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #269 from David Cook --- It looks like the "Unlimited" bug happens on the staff interface but not the OPAC... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #268 from David Cook --- I think I found another problem. From the results page, it looks like you can place multiple item holds for multiple bibs, but it doesn't work. It just places a hold on the first item for each bib. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #267 from Aleisha Amohia --- Created attachment 121941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121941=edit Bug 15565: Work in progress, calculating holds remaining Not ready for testing! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #266 from David Cook ---
I need to finish up for the day, but... I reckon we need something like this:
Koha::Holds->remaining_reserves_total({ patron => $patron, });
maxreserves (global system preference)
"Holds allowed (total)" (circ rule: reservesallowed)
Koha::Holds->remaining_reserves_record({ patron => $patron, record => $biblio,
});
"Holds per record (count)" (circ rule: holds_per_record)
Koha::Holds->remaining_reserves_today({ patron => $patron, record => $biblio,
});
"Holds allowed (daily)" (circ rule: holds_per_day)
And each needs to consider an unlimited number (although in theory maxreserves
should always be a positive integer).
Then when you're checking boxes you check each of those totals in turn. (The
reason for having separate functions is so that you can tell the user what
limit they've exceeded...).
An unlimited rule should probably return a null response, so that you only
consider counts that are digits.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #265 from David Cook ---
Ok so there are 4 different settings that control the allowable number of
holds:
maxreserves (global system preference)
"Holds allowed (total)" (circ rule: reservesallowed)
"Holds allowed (daily)" (circ rule: holds_per_day)
"Holds per record (count)" (circ rule: holds_per_record)
C4::Reserves is a mess...
If the following are blank/empty (notably not null), then 15565 doesn't work.
select * from circulation_rules where rule_name IN ('reservesallowed',
'holds_per_day', 'holds_per_record');
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #264 from David Cook --- Test plan: 0) git bz apply 15565 1) restart_all 2) Set up a record with 4 items E.g. add 3 items to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 Staff Interface: 3) Set the maxreserves system preference to 2 (from 50) 4) Go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51=29 5) Try to place a hold on all the items Unfortunately, as soon as I choose 1 item, it says "Patron reached the maximum number of holds". It looks like these patches don't work with "Unlimited" holds, so this functionality is fundamentally broken... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Tomás Cohen Arazi changed: What|Removed |Added Summary|Place multiple item-level |Place multiple item-level |holds at once for the same |holds at once for the same |record in OPAC and staff|record |interface | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record in OPAC and staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #263 from David Cook --- Marking as Failed QA due to Victor's comment about "Holds allowed (total)". I think I should be more thorough in my testing of the different hold counts too, even if it means making the test plan longer. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record in OPAC and staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #262 from David Cook --- Updating title from "Place multiple holds at once for the same record in OPAC" to "Place multiple item-level holds at once for the same record in OPAC and staff interface" since I think that's more accurate. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record in OPAC and staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Summary|Place multiple holds at |Place multiple item-level |once for the same record in |holds at once for the same |OPAC|record in OPAC and staff ||interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
