[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Katrin Fischer changed: What|Removed |Added CC||ro...@catalyst.net.nz ---

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Pete Edwards changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Nick Clemens changed: What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Jonathan Druart changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving th

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Katrin Fischer changed: What|Removed |Added Text to go in the|REST API route for managing |REST API route for managing

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Benjamin Rokseth changed: What|Removed |Added Text to go in the||REST API route for managi

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #125 from Jonathan Druart --- (In reply to Jonathan Druart from comment #124) > Created attachment 73434 [details] [review] > Bug 16330: Remove unecessary Koha::Patron->store method > > Signed-off-by: Jonathan Druart

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #124 from Jonathan Druart --- Created attachment 73434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73434&action=edit Bug 16330: Remove unecessary Koha::Patron->store method Signed-off-by: Jonathan

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #123 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #112) > (In reply to Jonathan Druart from comment #111) > > 1. I have squashed the patches to review them and see that > > Koha::Patron->store onl

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comm

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #121 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #119) > (In reply to Tomás Cohen Arazi from comment #118) > > (In reply to Jonathan Druart from comment #117) > > > With bug 20287 we will have to

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #120 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #119) > (In reply to Tomás Cohen Arazi from comment #118) > > (In reply to Jonathan Druart from comment #117) > > > With bug 20287 we will have to

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #119 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #118) > (In reply to Jonathan Druart from comment #117) > > With bug 20287 we will have to redo it again... > > Not a problem! You are volunteer

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #118 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #117) > With bug 20287 we will have to redo it again... Not a problem! -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #117 from Jonathan Druart --- With bug 20287 we will have to redo it again... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed --

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Claudio changed: What|Removed |Added CC||cost...@gmail.com -- You are rec

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #116 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #115) > (In reply to Jonathan Druart from comment #114) > > From AddMember, added by bug 19841: > > > > my $category = Koha::Patron::Categori

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #115 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #114) > From AddMember, added by bug 19841: > > my $category = Koha::Patron::Categories->find( $data{categorycode} ); > unless ($category)

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #114 from Jonathan Druart --- >From AddMember, added by bug 19841: my $category = Koha::Patron::Categories->find( $data{categorycode} ); unless ($category) { Koha::Exceptions::BadParameter->throw(

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #113 from Benjamin Rokseth --- (In reply to Jonathan Druart from comment #110) > Benjamin, do you agree with Tomas's changes? Nothing to add, well done pushing this forward! -- You are receiving this mail because: You

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #112 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #111) > 1. I have squashed the patches to review them and see that > Koha::Patron->store only calls SUPER->store. > > 2. Koha::REST::V1::{Patrons,

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #111 from Jonathan Druart --- 1. I have squashed the patches to review them and see that Koha::Patron->store only calls SUPER->store. 2. Koha::REST::V1::{Patrons,Cities}->list are different, must not be identical? Jus

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #110 from Jonathan Druart --- Benjamin, do you agree with Tomas's changes? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing lis

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #107 from Josef Moravec --- Created attachment 71936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71936&action=edit Bug 16330: (QA follow-up) ModMember requires borrowernumber Works perfectly. Well d

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #108 from Josef Moravec --- Created attachment 71937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71937&action=edit Bug 16330: Remove validation code from Koha::Patron This patch removes previously a

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #109 from Josef Moravec --- Created attachment 71938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71938&action=edit Bug 16330: (QA follow-up) Update usage of search plugin because of bug 19686 Test p

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #106 from Josef Moravec --- Created attachment 71935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71935&action=edit Bug 16330: (QA follow-up) Repect guidelines on plurals Patron > Patrons Signed-off-

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #105 from Josef Moravec --- Created attachment 71934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71934&action=edit Bug 16330: Move patches to OpenAPI This patch refactors the original work so it imp

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Josef Moravec changed: What|Removed |Added Attachment #71920|0 |1 is obsolete|

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Josef Moravec changed: What|Removed |Added Status|Failed QA |Passed QA -- You are recei

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #103 from Josef Moravec --- (In reply to Tomás Cohen Arazi from comment #102) > (In reply to Josef Moravec from comment #100) > > > > > > 5) Use PUT /patrons/ for a patron without borrowers > > >flag. This should go

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #102 from Tomás Cohen Arazi --- (In reply to Josef Moravec from comment #100) > > > > 5) Use PUT /patrons/ for a patron without borrowers > >flag. This should go into pending patron modification status and > >nee

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #101 from Tomás Cohen Arazi --- (In reply to Josef Moravec from comment #100) > > > > 5) Use PUT /patrons/ for a patron without borrowers > >flag. This should go into pending patron modification status and > >nee

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Josef Moravec changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #100

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #97 from Josef Moravec --- Created attachment 71923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71923&action=edit Bug 16330: (QA follow-up) ModMember requires borrowernumber Works perfectly. Well do

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #99 from Josef Moravec --- Created attachment 71925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71925&action=edit Bug 16330: (QA follow-up) Update usage of search plugin because of bug 19686 Test pl

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #98 from Josef Moravec --- Created attachment 71924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71924&action=edit Bug 16330: Remove validation code from Koha::Patron This patch removes previously ad

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #96 from Josef Moravec --- Created attachment 71922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71922&action=edit Bug 16330: (QA follow-up) Repect guidelines on plurals Patron > Patrons Signed-off-b

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #95 from Josef Moravec --- Created attachment 71921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71921&action=edit Bug 16330: Move patches to OpenAPI This patch refactors the original work so it impl

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Josef Moravec changed: What|Removed |Added Attachment #71667|0 |1 is obsolete|

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Josef Moravec changed: What|Removed |Added QA Contact||josef.mora...@gmail.com --

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|tomasco...@gmail.com| -- You are receiving

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #93 from Katrin Fischer --- Tomas, you are still QA contact for this - remove? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #92 from Tomás Cohen Arazi --- Rebased the patches. Please... Anyone... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Ko

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Tomás Cohen Arazi changed: What|Removed |Added Attachment #70038|0 |1 is obsolete|

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Tomás Cohen Arazi changed: What|Removed |Added Attachment #70037|0 |1 is obsolete|

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Tomás Cohen Arazi changed: What|Removed |Added Attachment #70036|0 |1 is obsolete|

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Tomás Cohen Arazi changed: What|Removed |Added Attachment #70035|0 |1 is obsolete|

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Tomás Cohen Arazi changed: What|Removed |Added Attachment #70034|0 |1 is obsolete|

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #86 from Bob Birchall --- (In reply to Tomás Cohen Arazi from comment #85) > Created attachment 70038 [details] [review] > Bug 16330: Remove validation code from Koha::Patron > > This patch removes previously added valid

[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Tomás Cohen Arazi changed: What|Removed |Added Summary|REST API: add routes to |Add routes to add, updat