[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Martin Renvoize changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving th

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 koha-US bug tracker changed: What|Removed |Added CC|bugzi...@koha-us.org| -- You are receivin

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.c

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Martin Renvoize changed: What|Removed |Added Keywords|rel_19_11_candidate | -- You are receiving th

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Martin Renvoize changed: What|Removed |Added Keywords||Manual,

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #47 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koh

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are rec

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Jesse Maseto changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are recei

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Jesse Maseto changed: What|Removed |Added Attachment #93553|0 |1 is obsolete|

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Jesse Maseto changed: What|Removed |Added Attachment #93554|0 |1 is obsolete|

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Jesse Maseto changed: What|Removed |Added Attachment #93678|0 |1 is obsolete|

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #43 from Nick Clemens --- Created attachment 93678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93678&action=edit Bug 17140: Atomic update file -- You are receiving this mail because: You are watchi

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Nick Clemens changed: What|Removed |Added Blocks||23728 Referenced Bugs: htt

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Nick Clemens changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are re

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Nick Clemens changed: What|Removed |Added Attachment #86051|0 |1 is obsolete|

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #42 from Nick Clemens --- Created attachment 93554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93554&action=edit Bug 17140: Make rounding syspref controlled Signed-off-by: Nick Clemens -- You are

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Martin Renvoize changed: What|Removed |Added Keywords||rel_19_11_candidate

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Katrin Fischer changed: What|Removed |Added QA Contact|josef.mora...@gmail.com |n...@bywatersolutions.com

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Blou changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #40 from Blou

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #38 from Blou --- Interesting. Showing the extent of what to consider for a complete solution. That said, I wouldn't call it a "bug". The report would still work, but have a 0.005 discrepancy somewhere, right? To which

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #37 from Josef Moravec --- (In reply to Blou from comment #36) > To quote "if we are able to fix it right until 19.05, then we should do > it..." > > This was opened in 2016, so good luck with that. It IS a complicated

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #36 from Blou --- To quote "if we are able to fix it right until 19.05, then we should do it..." This was opened in 2016, so good luck with that. It IS a complicated issue to fix right. The patch allows librarian to mo

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Josef Moravec changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #35 f

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #34 from Jonathan Druart --- I am not against a quick fix, but things are weird (with or without the patch): Add a 1.035 fine, you see: https://snag.gy/hmFX51.jpg Go to make a payment, you see: https://snag.gy/0MuCxY.j

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Josef Moravec changed: What|Removed |Added Attachment #86044|0 |1 is obsolete|

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #31 from Josef Moravec --- I obsoleted first two patches, they do not apply anymore, the updated part of code was refactored and the original issue from comment 1 is fixed. -- You are receiving this mail because: You ar

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com At

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Josef Moravec changed: What|Removed |Added Attachment #54611|0 |1 is obsolete|

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Hayley Mapley changed: What|Removed |Added Attachment #83467|0 |1 is obsolete|

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Hayley Mapley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are rece

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Hayley Mapley changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #28 from Blou --- Hi Hayley, Have you tried applying only 83467 (the last one), which is separated from the others (see my previous comments)? Or maybe its solution is not what you're looking for... -- You are receivin

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Blou changed: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment #26 from B

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #25 from Blou --- Created attachment 83467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83467&action=edit Bug 17140: fix rounding errors when paying fines Whenever a fine (accountlines in DB) has a p

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Blou changed: What|Removed |Added CC||philippe.blo...@inlibro.com

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Christopher Davis changed: What|Removed |Added CC||cgda...@uintah.utah.gov

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #23 from Katrin Fischer --- (In reply to Nick Clemens from comment #22) > I think this is resolved somewhat by bug 21673 - it changes the method for > summing which seems to resolve the issue. > > The separate issue of '

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Nick Clemens changed: What|Removed |Added Status|Failed QA |In Discussion --- Comment #2

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #21 from Nick Clemens --- Created attachment 82375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82375&action=edit Demonstration of List::Util->sum0 vs MySQL sum + 0 Run this file to compare the total

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Katrin Fischer changed: What|Removed |Added Assignee|la...@live.fi |koha-b...@lists.koha-commun

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Barton Chittenden changed: What|Removed |Added Severity|normal |major --- Comment #18 f

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Martha Fuerst changed: What|Removed |Added CC||mfue...@hmcpl.org --- Comme

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Brian changed: What|Removed |Added CC||bkl...@dubuque.lib.ia.us --- Commen

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com --

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Marc Véron changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Marc Véron changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Nick Clemens changed: What|Removed |Added CC||bar...@bywatersolutions.com

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Nick Clemens changed: What|Removed |Added CC||mtomp...@hotmail.com --- Com

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Marc Véron changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Alex Buckley changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #12 from Marc Véron --- Created attachment 54643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54643&action=edit Screenshots with some notes added Added the same screenshots with some notes on them.

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #11 from Marc Véron --- Created attachment 54642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54642&action=edit Illustration of precision problem with calculated rental fees and manual invoices I mad

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #10 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #4) > I think we should remove the * 1000 / 1000 +1, it isn't really serving any useful purpose, it's not warranted that the result of the multiplicat

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #9 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #8) > Prices should be stored with a big precision (6 is largely enough) and > displayed with 2 decimals. Hm, maybe charges / fines should be treated a

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #8 from Jonathan Druart --- Prices should be stored with a big precision (6 is largely enough) and displayed with 2 decimals. That is how it's done in the acq module and almost everywhere else I think. -- You are recei

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #7 from Marc Véron --- In table accountlines, definition of amount is decimal 28,6 http://schema.koha-community.org/tables/accountlines.html I am able to enter a manual invoice like 0.008 (displays as 0.01) or 0.004 (dis

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Marc Véron changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #6 from Lari Taskula --- Is the precision of 2 decimal places enough? I saw it is used in boraccount.pl, pay.pl and moremember.pl and maybe this discussion has been had before? I think there can still be weird cases if yo

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Lari Taskula changed: What|Removed |Added Attachment #54566|0 |1 is obsolete|

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Jacek Ablewicz changed: What|Removed |Added CC||a...@biblos.pk.edu.pl --

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are rec

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |la...@student.uef.fi

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Lari Taskula changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are re

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Lari Taskula changed: What|Removed |Added Attachment #54565|0 |1 is obsolete|

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Lari Taskula changed: What|Removed |Added Status|NEW |Needs Signoff -- You are re

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #2 from Lari Taskula --- Created attachment 54565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54565&action=edit Bug 17140: Fix rounding in total fines calculations, part 2 This patch fixes still occ

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Lari Taskula changed: What|Removed |Added Depends on||15741 Referenced Bugs: htt

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #1 from Lari Taskula --- Created attachment 54542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54542&action=edit Bug 17140: Test to cover more rounding issues in fines calculations To test: 1. Run t/