https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #64 from Tomás Cohen Arazi ---
*** Bug 22159 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Zeno Tajoli changed:
What|Removed |Added
Resolution|--- |FIXED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Mason James changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Julian Maurice changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Jonathan Druart changed:
What|Removed |Added
Blocks|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #61 from Jonathan Druart
---
(In reply to Jonathan Druart from comment #60)
> Created attachment 59003 [details] [review]
> [16.05.x] Bug 17234: Add foreign_key_exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #60 from Jonathan Druart
---
Created attachment 59003
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59003=edit
[16.05.x] Bug 17234: Add foreign_key_exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Katrin Fischer changed:
What|Removed |Added
Status|Pushed to Master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #58 from Kyle M Hall ---
Followup "Bug 17234: Need to separate KEY and FOREIGN KEY checks" has been
pushed to master!
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #57 from Jonathan Druart
---
(In reply to Jonathan Druart from comment #55)
> There is something wrong here, I will open a new bug report soon.
I finally did not, we really
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #56 from Jonathan Druart
---
Created attachment 58865
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58865=edit
Bug 17234: Need to separate KEY and FOREIGN KEY
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #55 from Jonathan Druart
---
There is something wrong here, I will open a new bug report soon.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Kyle M Hall changed:
What|Removed |Added
Status|Passed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #52 from Jonathan Druart
---
Created attachment 58552
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58552=edit
Bug 17234: Test the column and constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Jonathan Druart changed:
What|Removed |Added
Attachment #58548|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
M. Tompsett changed:
What|Removed |Added
Status|Failed QA |Needs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #49 from M. Tompsett ---
Created attachment 58548
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58548=edit
Bug 17234: Two new functions lack tests
This adds two tests to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Tomás Cohen Arazi changed:
What|Removed |Added
Keywords|rel_3_20_candidate |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Jonathan Druart changed:
What|Removed |Added
Blocks|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
M. Tompsett changed:
What|Removed |Added
Status|Needs Signoff |Signed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #45 from M. Tompsett ---
I followed my test plan in comment #39. I've not set it to signed off, because
perhaps another sign off might be a good idea, as some of the code is mine. I
approve of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
M. Tompsett changed:
What|Removed |Added
Attachment #55704|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
M. Tompsett changed:
What|Removed |Added
Attachment #55833|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
M. Tompsett changed:
What|Removed |Added
Attachment #55729|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
M. Tompsett changed:
What|Removed |Added
Attachment #55635|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #40 from M. Tompsett ---
(In reply to M. Tompsett from comment #39)
> In fact, just the -00-00 messages (see bug 17320).
Oops and one other unrelated.
Upgrade to 3.23.00.049 done (Bug 12267 -
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #39 from M. Tompsett ---
This is beautiful!
TEST PLAN
-
On an Ubuntu 16.04 LTS git install:
git checkout -b bug_17234 origin/3.18.x
git bz apply 17234
i
-- apply the DO NOT PUSH (yes it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
M. Tompsett changed:
What|Removed |Added
Attachment #56821|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #38 from M. Tompsett ---
Created attachment 56821
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56821=edit
Bug 17234 [DO NOT PUSH] Make v3.00.00 "install"
Tweak fields, so
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
M. Tompsett changed:
What|Removed |Added
Attachment #55634|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
M. Tompsett changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #36 from M. Tompsett ---
(In reply to Jonathan Druart from comment #35)
> (In reply to Blou from comment #21)
> > How long do you intend to postpone this change?
>
> Regarding the delay to get a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #35 from Jonathan Druart
---
(In reply to Blou from comment #21)
> How long do you intend to postpone this change?
Regarding the delay to get a signoff, it seems that it was not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #34 from M. Tompsett ---
(In reply to Jonathan Druart from comment #33)
> So, signoff?
Item number three on my TO DO list. Sorry. It does eyeball well.
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #33 from Jonathan Druart
---
So, signoff?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Jonathan Druart changed:
What|Removed |Added
Blocks|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Jonathan Druart changed:
What|Removed |Added
See
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Jonathan Druart changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #31 from Jonathan Druart
---
Created attachment 55833
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55833=edit
Bug 17234: Move new subroutines to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
M. Tompsett changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #30 from M. Tompsett ---
(In reply to Liz Rea from comment #29)
> Just wondering, I don't think the subs where they are are usable by say,
> perl atomicupdates. (or, please tell how to use them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Liz Rea changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #28 from M. Tompsett ---
I followed test plan on bug 17324 to test this.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
M. Tompsett changed:
What|Removed |Added
Attachment #55722|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
M. Tompsett changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #26 from M. Tompsett ---
Oooo JD, I'm looking forward to testing this later.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Jonathan Druart changed:
What|Removed |Added
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Jonathan Druart changed:
What|Removed |Added
Status|ASSIGNED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #24 from Jonathan Druart
---
Created attachment 55722
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55722=edit
Bug 17234: Add constraint_exists and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #22 from Jonathan Druart
---
(In reply to Blou from comment #21)
> Right now, updatedatabase.pl does not work for mysql5.7.
> And IGNORE will never work for mysql5.7+
> How long
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Blou changed:
What|Removed |Added
Status|Failed QA |Needs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #19 from Tomás Cohen Arazi ---
FTR: I still don't think it is a good measure to just remove the IGNORE
keywords. We need to deal with those errors in a better way for end users.
Right now Koha will
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
M. Tompsett changed:
What|Removed |Added
Status|Signed Off |Needs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #18 from M. Tompsett ---
Created attachment 55704
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55704=edit
Bug 17234: Follow up to handle new problems
Bug 16276 added two more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #17 from M. Tompsett ---
$ git grep "ALTER IGNORE"
DOH! Bug 16276 pushed 6 days ago.
Please patch for that.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
M. Tompsett changed:
What|Removed |Added
Status|Needs Signoff |Signed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
M. Tompsett changed:
What|Removed |Added
Attachment #55113|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #15 from M. Tompsett ---
Created attachment 55634
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55634=edit
Bug 17234: [DO NOT PUSH] Make 3.18.x install at least.
This patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
M. Tompsett changed:
What|Removed |Added
Keywords|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #13 from M. Tompsett ---
On a positive note, this runs on Debian 8, mysql 5.5.
I need to set up Ubuntu and test on that.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #12 from M. Tompsett ---
Blou: https://wiki.koha-community.org/wiki/Developers_Handbook#Database
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Blou changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Blou changed:
What|Removed |Added
Attachment #55144|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #10 from M. Tompsett ---
`type` ENUM('', 'string', 'date', 'number', 'boolean', 'sum') NOT NULL COMMENT
'what type of data this holds, relevant when storing it in the search engine',
(In reply to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #9 from Blou ---
(In reply to M. Tompsett from comment #4)
> > + `type` ENUM('', 'string', 'date', 'number', 'boolean', 'sum')
> > NOT NULL COMMENT 'what type of data this holds,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #8 from M. Tompsett ---
(In reply to Jonathan Druart from comment #7)
> Could someone explain me why I don't get the same error:
>
> mysql> set sql_mode="STRICT_TRANS_TABLES";
> Query OK, 0 rows
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Jonathan Druart changed:
What|Removed |Added
Blocks|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
M. Tompsett changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Tomás Cohen Arazi changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
M. Tompsett changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #4 from M. Tompsett ---
Comment on attachment 55144
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55144
Bug 17234 - updatedatabase.pl fails on invalid entry in ENUM column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #3 from M. Tompsett ---
Comment on attachment 55113
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55113
Bug 17234 - updatedatabase.pl's ALTER IGNORE break with mysql 5.7.4+
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #2 from Blou ---
Created attachment 55144
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55144=edit
Bug 17234 - updatedatabase.pl fails on invalid entry in ENUM column
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Blou changed:
What|Removed |Added
Status|NEW |Needs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Blou changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
--- Comment #1 from Blou ---
Created attachment 55113
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55113=edit
Bug 17234 - updatedatabase.pl's ALTER IGNORE break with mysql 5.7.4+
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234
Blou changed:
What|Removed |Added
Patch complexity|--- |Trivial
86 matches
Mail list logo