[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Jonathan Druart changed: What|Removed |Added Blocks||22713 Referenced Bugs:

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 kh...@roseville.ca.us changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #45 from Nick Clemens --- (In reply to Nick Clemens from comment #44) > Created attachment 79789 [details] [review] > Bug 18639: (follow-up) Remove debugging code Followup pushed to master, thanks Jonathan -- You are

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #44 from Nick Clemens --- Created attachment 79789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79789=edit Bug 18639: (follow-up) Remove debugging code -- You are receiving this mail because: You

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #43 from Jonathan Druart --- Debugging leftover in finishreceive.pl +warn "Replacement $replacementprice"; -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Martin Renvoize changed: What|Removed |Added Blocks||21324 Referenced Bugs:

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|RESOLVED

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master ---

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #40 from Katrin Fischer --- Created attachment 78256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78256=edit Bug 18639: (QA follow-up) Fix formatting of replacement cost when modifying an order --

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #34 from Katrin Fischer --- Created attachment 78250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78250=edit Bug 18639: Schema updates (DO NOT PUSH) Signed-off-by: Martin Renvoize Signed-off-by:

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #33 from Katrin Fischer --- Created attachment 78249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78249=edit Bug 18639: Add replacementprice field to aqorders Signed-off-by: Martin Renvoize

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #37 from Katrin Fischer --- Created attachment 78253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78253=edit Bug 18639: Use replacementprice when creating order from quote Updates column name from

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #36 from Katrin Fischer --- Created attachment 78252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78252=edit Bug 18639: Unit tests Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer --

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Katrin Fischer changed: What|Removed |Added Attachment #78189|0 |1 is obsolete|

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Katrin Fischer changed: What|Removed |Added Attachment #78191|0 |1 is obsolete|

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #35 from Katrin Fischer --- Created attachment 78251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78251=edit Bug 18639: Add replacementprice field to acquisitions workflow To test: 0 - Apply

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Katrin Fischer changed: What|Removed |Added Text to go in the|This patch attempts to |This patch attempts to

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #31 from Katrin Fischer --- (In reply to Nick Clemens from comment #30) > Created attachment 78191 [details] [review] > Bug 18639: Alter DB update to populate replacementprice from rpp initially Hi Nick, hoping to get

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #30 from Nick Clemens --- Created attachment 78191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78191=edit Bug 18639: Alter DB update to populate replacementprice from rpp initially -- You are

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #29 from Nick Clemens --- Created attachment 78189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78189=edit Bug 18639: (follow-up) Populate replacement price from list price during ordering -- You

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #28 from Nick Clemens --- Created attachment 78188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78188=edit Bug 18639 Use replacementprice when creating order from quote Updates column name from rrp

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #27 from Nick Clemens --- Created attachment 78187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78187=edit Bug 18639 - Unit tests Signed-off-by: Martin Renvoize -- You are receiving this mail

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #25 from Nick Clemens --- Created attachment 78185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78185=edit Bug 18639 - Schema updates (DO NOT PUSH) Signed-off-by: Martin Renvoize -- You are

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #26 from Nick Clemens --- Created attachment 78186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78186=edit Bug 18639 - Add replacementprice field to acquisitions workflow To test: 0 - Apply patches

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Nick Clemens changed: What|Removed |Added Attachment #76867|0 |1 is obsolete|

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #23 from Katrin Fischer --- Thinking about it some more... maybe the better option would be to fill in the field in the order form automatically (rrp = replacement cost), and then allow it to be adjusted. That would

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #22

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Nick Clemens changed: What|Removed |Added Text to go in the||This patch attempts to

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #21 from Nick Clemens --- (In reply to Katrin Fischer from comment #20) > Some notes from reading through the bug and code review: > 1) Leftover warn in finishreceive.pl Indeed, apologies > 2) Database update > I also

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #20 from Katrin Fischer --- Some notes from reading through the bug and code review: 1) Leftover warn in finishreceive.pl +$replacementprice = Koha::Number::Price->new( $replacementprice )->unformat(); +warn

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #19 from Katrin Fischer --- As it includes database changes and such I would not backport it. I think it's somewhat in a grey area between enh and bug. Too much of a change for a backport is my feel, but not a strict enh

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Martin Renvoize changed: What|Removed |Added Keywords||Manual -- You are

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #18 from Martin Renvoize --- If I had my QA hat on, I'd be asking for a corresponding documentation update patch linked to here (as a merge request on the gitlab koha-manual) and some release notes text summarising the

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #17 from Martin Renvoize --- >From a RMaint perspective, I agree that I'd treat it as an enhancement. Although it's somewhat of a bugfix in that it makes functionality clearer, it is a change of said functionality which

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #16 from Nick Clemens --- (In reply to Marcel de Rooy from comment #15) > Moving to enh > Please explain why it should be seen as a bugfix. The naming and use of this field has caused a lot of confusion for libraries -

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Marcel de Rooy changed: What|Removed |Added Severity|major |enhancement

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Martin Renvoize changed: What|Removed |Added Attachment #75946|0 |1 is obsolete|

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Martin Renvoize changed: What|Removed |Added Attachment #70213|0 |1 is obsolete|

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Martin Renvoize changed: What|Removed |Added Attachment #70215|0 |1 is obsolete|

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Martin Renvoize changed: What|Removed |Added Attachment #70216|0 |1 is obsolete|

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #13 from Martin Renvoize --- Created attachment 76871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76871=edit Bug 18639 Use replacementprice when creating order from quote Updates column name from

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Martin Renvoize changed: What|Removed |Added Attachment #70214|0 |1 is obsolete|

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #8 from Colin Campbell --- Created attachment 75946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75946=edit patch to rename field in Koha/EDI.pm Change the column name in order creation to match

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Katrin Fischer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Nick Clemens changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Nick Clemens changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #5 from Nick Clemens --- Created attachment 70215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70215=edit Bug 18639 - Add replacementprice field to acquisitions workflow

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #6 from Nick Clemens --- Created attachment 70216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70216=edit Bug 18639 - Unit tests -- You are receiving this mail because:

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #4 from Nick Clemens --- Created attachment 70214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70214=edit Bug 18639 - Schema updates (DO NOT PUSH) -- You are receiving

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #3 from Nick Clemens --- Created attachment 70213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70213=edit Bug 18639 - Add replacementprice field to aqorders -- You are

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Nick Clemens changed: What|Removed |Added Status|NEW

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 jdem...@roseville.ca.us changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Bug 18639 depends on bug 13321, which changed state. Bug 13321 Summary: Fix tax and prices calculation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 What|Removed |Added

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Jonathan Druart changed: What|Removed |Added Severity|enhancement

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Jonathan Druart changed: What|Removed |Added Depends on|

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Jonathan Druart changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Laurence Rault changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun