[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #41 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #74284|0   |1
is obsolete||

--- Comment #40 from Jonathan Druart  
---
Created attachment 74739
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74739=edit
Bug 19479: Display price in basket group formatted according to CurrencyFormat
syspref using templates.

On the page acqui/basketgroup.pl the prices of baskets should be shown
formatted according to the selected CurrencyFormat syspref, with no
currency symbol or code.

Test plan:

1) Create a basket with items in it worth more than 1000 currency units.
2) Close the basket.
3) Go to acqui/basketgroup.pl page and check that the price format matches
   the current CurrencyFormat syspref.
4) Go to Administration and change CurrencyFormat syspref to one of the
   other available options and recheck step 3.

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 
Fixed some tabs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #39 from Jonathan Druart  
---
(In reply to Jon Knight from comment #38)
> Ah that's a good point. Do you want me to generate a new patch without them?

I will do it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #38 from Jon Knight  ---
Ah that's a good point. Do you want me to generate a new patch without them?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #37 from Jonathan Druart  
---
So we should remove the 2x2 lines you add in the .pl to retrieve the active
currency, right?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #36 from Katrin Fischer  ---
Thx for your patience and perseverance, Jon!

I've fixed a few tabs in basketgroup.pl, be careful: Koha uses 4 spaces for
indenting.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #74274|0   |1
is obsolete||

--- Comment #35 from Katrin Fischer  ---
Created attachment 74284
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74284=edit
Bug 19479: Display price in basket group formatted according to CurrencyFormat
syspref using templates.

On the page acqui/basketgroup.pl the prices of baskets should be shown
formatted according to the selected CurrencyFormat syspref, with no
currency symbol or code.

Test plan:

1) Create a basket with items in it worth more than 1000 currency units.
2) Close the basket.
3) Go to acqui/basketgroup.pl page and check that the price format matches
   the current CurrencyFormat syspref.
4) Go to Administration and change CurrencyFormat syspref to one of the
   other available options and recheck step 3.

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 
Fixed some tabs.

https://bugs.koha-community.org/show_bug.cgi?id=19497

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #34 from Séverine Queune  ---
This price display seems clearer to me even though we don't have currency
symbols.
As user, this patch is good for me :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Séverine Queune  changed:

   What|Removed |Added

  Attachment #73677|0   |1
is obsolete||

--- Comment #33 from Séverine Queune  ---
Created attachment 74274
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74274=edit
Bug 19479: Display price in basket group formatted according to CurrencyFormat
syspref using templates.

On the page acqui/basketgroup.pl the prices of baskets should be shown
formatted according to the selected CurrencyFormat syspref, with no
currency symbol or code.

Test plan:

1) Create a basket with items in it worth more than 1000 currency units.
2) Close the basket.
3) Go to acqui/basketgroup.pl page and check that the price format matches
   the current CurrencyFormat syspref.
4) Go to Administration and change CurrencyFormat syspref to one of the
   other available options and recheck step 3.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #32 from Katrin Fischer  ---
Ok, if you prefer another set of eyes, I am not against that at all :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #31 from Jon Knight  ---
(In reply to Katrin Fischer from comment #30)
> Hi Jon, if QA demands a follow-up what you can usually do is make a small
> extra patch with the additional changes and attach it. In this case it would
> have just been removing the attribute. This way you can keep the sign-off on
> your first patch and the signed-off status and it goes directly back to QA.
> Do you want to change it and restore the signed off patch with a little
> addition?

No, because the last patch changed the behaviour (again), rather than just
being a small change to get rid of the commented out line.  That really needs
someone to check that it is what people actually want and sign that off
(again).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #30 from Katrin Fischer  ---
Hi Jon, if QA demands a follow-up what you can usually do is make a small extra
patch with the additional changes and attach it. In this case it would have
just been removing the attribute. This way you can keep the sign-off on your
first patch and the signed-off status and it goes directly back to QA. Do you
want to change it and restore the signed off patch with a little addition?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Jon Knight  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Jon Knight  changed:

   What|Removed |Added

  Attachment #73491|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #29 from Jon Knight  ---
Created attachment 73677
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73677=edit
Bug 19479: Display price in basket group formatted according to CurrencyFormat
syspref using templates.

On the page acqui/basketgroup.pl the prices of baskets should be shown
formatted according to the selected CurrencyFormat syspref, with no
currency symbol or code.

Test plan:

1) Create a basket with items in it worth more than 1000 currency units.
2) Close the basket.
3) Go to acqui/basketgroup.pl page and check that the price format matches
   the current CurrencyFormat syspref.
4) Go to Administration and change CurrencyFormat syspref to one of the
   other available options and recheck step 3.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #28 from Katrin Fischer  ---

> That's how I had it before Jonathan Druart asked me to put the symbols in
> place in comment #18 above. I don't mind either way as long as the QA team
> and RM can agree (or do I have to add in a syspref for this? :-) ).
> 
> I'll await a decision before changing this simple patch again.

I talked to Joubu and removing the currency symbols will be safe ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #27 from Jonathan Druart  
---
(In reply to Jon Knight from comment #26)
> (In reply to Katrin Fischer from comment #25)
> > Hi Séverine, there is no a setting in administration > currency for each
> > currency, where you can define if there should be a space or not.
> > 
> > I am torn about seeing the currency. I think we agreed a long while ago that
> > we should not show the currency symbols in acq as long as it's the active
> > currency as it would clutter a lot of the displays, where you deal with a
> > lot of numbers and prices. Would you agree to remove the currency symbol
> > display?
> >  $Price with_symbol => 1 
> 
> That's how I had it before Jonathan Druart asked me to put the symbols in
> place in comment #18 above. I don't mind either way as long as the QA team
> and RM can agree (or do I have to add in a syspref for this? :-) ).
> 
> I'll await a decision before changing this simple patch again.

IIRC you displayed the currency code :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #26 from Jon Knight  ---
(In reply to Katrin Fischer from comment #25)
> Hi Séverine, there is no a setting in administration > currency for each
> currency, where you can define if there should be a space or not.
> 
> I am torn about seeing the currency. I think we agreed a long while ago that
> we should not show the currency symbols in acq as long as it's the active
> currency as it would clutter a lot of the displays, where you deal with a
> lot of numbers and prices. Would you agree to remove the currency symbol
> display?
>  $Price with_symbol => 1 

That's how I had it before Jonathan Druart asked me to put the symbols in place
in comment #18 above. I don't mind either way as long as the QA team and RM can
agree (or do I have to add in a syspref for this? :-) ).

I'll await a decision before changing this simple patch again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #25 from Katrin Fischer  ---
Hi Séverine, there is no a setting in administration > currency for each
currency, where you can define if there should be a space or not.

Hi Jon, thank you for your perseverance! 2 small things:

If this line is no longer needed, please remove it, instead of commenting out:
+#$total .= " " . ($bookseller->invoiceprice // 0);

I am torn about seeing the currency. I think we agreed a long while ago that we
should not show the currency symbols in acq as long as it's the active currency
as it would clutter a lot of the displays, where you deal with a lot of numbers
and prices. Would you agree to remove the currency symbol display?
 $Price with_symbol => 1 

Please switch back to signed off if you add a follow up patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #24 from Séverine Queune  ---
The 3 formats defined on 'CurrencyFormat' correctly apply with this patch.
Maybe for a better visibility (especially for 'FR format') we could have a
space between the currency and the prices, but excepted that detail, everything
looked good for me.
Thank you Jon for rebase !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Séverine Queune  changed:

   What|Removed |Added

  Attachment #73379|0   |1
is obsolete||

--- Comment #23 from Séverine Queune  ---
Created attachment 73491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73491=edit
Bug 19479: Display price in basket group formatted according to CurrencyFormat
syspref using templates and currency symbols.

On the page acqui/basketgroup.pl the prices of baskets should be shown
formatted according to the selected CurrencyFormat syspref, using the
currency symbol rather than three letter currency code.

Test plan:

1) Create a basket with items in it worth more than 1000 currency units.
2) Close the basket.
3) Go to acqui/basketgroup.pl page and check that the price format matches
   the current CurrencyFormat syspref.
4) Go to Administration and change CurrencyFormat syspref to one of the
   other available options and recheck step 3.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Jon Knight  changed:

   What|Removed |Added

  Attachment #73377|0   |1
is obsolete||

--- Comment #22 from Jon Knight  ---
Created attachment 73379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73379=edit
Bug 19479: Display price in basket group formatted according to CurrencyFormat
syspref using templates and currency symbols.

On the page acqui/basketgroup.pl the prices of baskets should be shown
formatted according to the selected CurrencyFormat syspref, using the
currency symbol rather than three letter currency code.

Test plan:

1) Create a basket with items in it worth more than 1000 currency units.
2) Close the basket.
3) Go to acqui/basketgroup.pl page and check that the price format matches
   the current CurrencyFormat syspref.
4) Go to Administration and change CurrencyFormat syspref to one of the
   other available options and recheck step 3.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #21 from Jon Knight  ---
Created attachment 73377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73377=edit
Bug 19479: Display price in basket group formatted according to CurrencyFormat
syspref using templates and currency symbols.

On the page acqui/basketgroup.pl the prices of baskets should be shown
formatted according to the selected CurrencyFormat syspref, using the
currency symbol rather than three letter currency code.

Test plan:

1) Create a basket with items in it worth more than 1000 currency units.
2) Close the basket.
3) Go to acqui/basketgroup.pl page and check that the price format matches
   the current CurrencyFormat syspref.
   4) Go to Administration and change CurrencyFormat syspref to one of the
  other available options and recheck step 3.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Jon Knight  changed:

   What|Removed |Added

  Attachment #73376|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #20 from Jon Knight  ---
The most recently uploaded version of this patch uses the currency symbols
instead of the currency code.  I've not done anything about per basket currency
defaults as I think that is a separate, larger change to this (which was
supposed to be a simple formatting change).  That really needs a new bug report
(and probably someone other than me who understands the nuances of how
libraries want to handle multiple currency international orders, as the items,
baskets and basketgroups would all be affected).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Jon Knight  changed:

   What|Removed |Added

  Attachment #73291|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #19 from Jon Knight  ---
Created attachment 73376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73376=edit
Bug 19479: Display price in basket group formatted according to CurrencyFormat
syspref using templates and currency symbols.

On the page acqui/basketgroup.pl the prices of baskets should be shown
formatted according to the selected CurrencyFormat syspref, using the
currency symbol rather than three letter currency code.

Test plan:

1) Create a basket with items in it worth more than 1000 currency units.
2) Close the basket.
3) Go to acqui/basketgroup.pl page and check that the price format matches
   the current CurrencyFormat syspref.
4) Go to Administration and change CurrencyFormat syspref to one of the
   other available options and recheck step 3.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #18 from Jonathan Druart  
---
Jon,

  Total: [% selectedbasket.total | $Price %] ([% selectedbasket.currency %])
Will display: 42 (EUR) or 42 (USD)

With bug 4078 you can use the with_symbol flag to display the symbol.
  Total: [% selectedbasket.total | $Price with_symbol => 1
Will display: €42 or $42

I think it is what we want here.

Actually what we really want is: "42 €" and "$42", but it's not configurable
(yet).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #17 from M. Tompsett  ---
It seems to me the more I read code, the more I wish to cry over the state of
Currency code. While it may be the current methodology to grab the active
currency, it seems to me that baskets should have their own currency, and the
currency grabbed should be from that. However, I don't have time to refactor
all currency code. :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Jon Knight  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #16 from Jon Knight  ---
Created attachment 73291
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73291=edit
Bug 19479: Display price in basked group formatted according to CurrencyFormat
syspref using templates.

On the page acqui/basketgroup.pl the prices of baskets should be shown
formatted according to the selected CurrencyFormat syspref.

Test plan:

1) Create a basket with items in it worth more than 1000 currency units.
2) Close the basket.
3) Go to acqui/basketgroup.pl page and check that the price format matches
   the current CurrencyFormat syspref.
4) Go to Administration and change CurrencyFormat syspref to one of the
   other available options and recheck step 3.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Jon Knight  changed:

   What|Removed |Added

  Attachment #71313|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Jon Knight  changed:

   What|Removed |Added

  Attachment #73290|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #15 from Jon Knight  ---
Created attachment 73290
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73290=edit
Attempt to display price formatted according to CurrencyFormat syspref using
templates, with the English template as an example.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
Bug 19479 depends on bug 4078, which changed state.

Bug 4078 Summary: Add the ability to customize and display the symbol for a 
currency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #14 from Jon Knight  ---
I'll wait until 4078 is in master (its Passed QA at the moment) before changing
this patch again just so that I'm aiming for a stable target!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||4078

--- Comment #13 from Jonathan Druart  
---
You should base your patch on top of bug 4078 instead.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078
[Bug 4078] Add the ability to customize and display the symbol for a currency
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #12 from Katrin Fischer  ---
(In reply to Jon Knight from comment #11)
> One thing to note is that if I use the templates rather than my original
> patch that just altered basketgroup.pl to do the formatting, I'm guessing
> that each language that Koha is in will also need its basketgroup.tt
> template updated? Is that right?  I've only done the en (default English)
> one in this current patch.

Thx for thinking about translations :) But you are fine - the translated
templates are generated automatically from the English templates with scripts.
Changing the English 'master' template is enough.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #11 from Jon Knight  ---
One thing to note is that if I use the templates rather than my original patch
that just altered basketgroup.pl to do the formatting, I'm guessing that each
language that Koha is in will also need its basketgroup.tt template updated? Is
that right?  I've only done the en (default English) one in this current patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Jon Knight  changed:

   What|Removed |Added

  Attachment #71312|0   |1
is obsolete||

--- Comment #10 from Jon Knight  ---
Created attachment 71313
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71313=edit
Bug 19479 - Display prices in basket group with correct currency formatting

Attempt to display price formatted according to CurrencyFormat syspref using
templates, with the English template as an example.

1) Create some baskets with items in them.
2) Go to acqui/basketgroup.pl page and check that the price format matches
   the current CurrencyFormat syspref.
3) Go to Administration and change CurrencyFormat syspref to one of the other
   available options and recheck step 2.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Jon Knight  changed:

   What|Removed |Added

  Attachment #68972|0   |1
is obsolete||

--- Comment #9 from Jon Knight  ---
Created attachment 71312
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71312=edit
Attempt to display price formatted according to CurrencyFormat syspref using
templates, with the English template as an example.

1) Create some baskets with items in them.
2) Go to acqui/basketgroup.pl page and check that the price format matches
   the current CurrencyFormat syspref.
3) Go to Administration and change CurrencyFormat syspref to one of the other
   available options and recheck step 2.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Jon Knight  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #8 from Jonathan Druart  
---
The price formatting must be done template side, search for '$Price' or '[% USE
Price %]' in **/*.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |j.p.kni...@lboro.ac.uk
   |ity.org |
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
Summary|Price diplay on a   |Price display on a
   |basketgroup |basketgroup

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/