[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Martin Renvoize  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Master|RESOLVED
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #35 from Martin Renvoize  ---
Enhancement, this will not be backported to 18.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #34 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

--- Comment #33 from Jonathan Druart  
---
(In reply to Julian Maurice from comment #32)
> > > > I was talking about this warning:
> > > > "Warning: Any changes to the configuration [...]"
> > > > 
> > > > I think it does not make sense to display it on the confirmation screen.
> > > 
> > > Why not ? Resetting indexes is a change to the configuration, so the 
> > > warning
> > > is  relevant in my opinion.
> > 
> > I guess the important part was "on the confirmation screen".
> 
> I've read this part too, and I don't understand why you would want to hide
> this warning on the confirmation screen. Can you explain why showing it does
> not make sense to you ?

It was minor, just saying that 2 warnings on the same page seems wrong.
We could instead add a note about the full reindex to the confirmation box,
like 'do not forget to reindex'.

Let's push as it and improve later if needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

--- Comment #32 from Julian Maurice  ---
> > > I was talking about this warning:
> > > "Warning: Any changes to the configuration [...]"
> > > 
> > > I think it does not make sense to display it on the confirmation screen.
> > 
> > Why not ? Resetting indexes is a change to the configuration, so the warning
> > is  relevant in my opinion.
> 
> I guess the important part was "on the confirmation screen".

I've read this part too, and I don't understand why you would want to hide this
warning on the confirmation screen. Can you explain why showing it does not
make sense to you ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

--- Comment #31 from Jonathan Druart  
---
(In reply to Julian Maurice from comment #26)
> (In reply to Jonathan Druart from comment #23)
> > (In reply to Ere Maijala from comment #22)
> > > Jonathan, thanks, that was indeed bad. Is it ok now? I wasn't quite sure
> > > what you meant with "The warning should not be displayed".
> > 
> > I was talking about this warning:
> > "Warning: Any changes to the configuration [...]"
> > 
> > I think it does not make sense to display it on the confirmation screen.
> 
> Why not ? Resetting indexes is a change to the configuration, so the warning
> is  relevant in my opinion.

I guess the important part was "on the confirmation screen".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Julian Maurice  changed:

   What|Removed |Added

  Attachment #77571|0   |1
is obsolete||

--- Comment #30 from Julian Maurice  ---
Created attachment 77573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77573=edit
Bug 20248: (QA follow-up) Remove unnecessary stuff

- Remove useless 'action' attribute in forms
- $op should never be equal to 'reset', so remove the test
- Move 'op' parameter inside s to avoid having different HTML
  tags for elements that have the same kind of behaviour

Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Julian Maurice  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

--- Comment #29 from Julian Maurice  ---
Created attachment 77572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77572=edit
Bug 20248: Improve Elasticsearch mappings UI and rebuild_elastic_search.pl

Improvements:
1) Mappings UI now has button that allows one to reset the mappings.
2) Mappings UI displays the items in alphabetical order.
3) Indexing script drops and recreates the index right away, which
helps prevent ES from autocreating a bad index if someone does something
while the first batch of records is being processed.
4) Indexing script has nicer output.

To test:
1) Change mappings.yaml file
2) Reset mappings in UI in mappings.pl
3) Verify the mappings have been changed in UI
4) The field order is alphabetical
5) Rebuild script has clean output
6) Run test t/db_dependent/Koha_Elasticsearch_Indexer.t

Signed-off-by: Bouzid Fergani 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

--- Comment #28 from Julian Maurice  ---
Created attachment 77571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77571=edit
Bug 20248: (QA follow-up) Remove unnecessary stuff

- Remove useless 'action' attribute in forms
- $op should never be equal to 'reset', so remove the test
- Move 'op' parameter inside s to avoid having different HTML
  tags for elements that have the same kind of behaviour

Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Julian Maurice  changed:

   What|Removed |Added

  Attachment #73798|0   |1
is obsolete||

--- Comment #27 from Julian Maurice  ---
Created attachment 77570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77570=edit
Bug 20248 - Improve Elasticsearch mappings UI and rebuild_elastic_search.pl.

Improvements:
1) Mappings UI now has button that allows one to reset the mappings.
2) Mappings UI displays the items in alphabetical order.
3) Indexing script drops and recreates the index right away, which
helps prevent ES from autocreating a bad index if someone does something
while the first batch of records is being processed.
4) Indexing script has nicer output.

To test:
1) Change mappings.yaml file
2) Reset mappings in UI in mappings.pl
3) Verify the mappings have been changed in UI
4) The field order is alphabetical
5) Rebuild script has clean output
6) Run test t/db_dependent/Koha_Elasticsearch_Indexer.t

Signed-off-by: Bouzid Fergani 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #26 from Julian Maurice  ---
(In reply to Jonathan Druart from comment #23)
> (In reply to Ere Maijala from comment #22)
> > Jonathan, thanks, that was indeed bad. Is it ok now? I wasn't quite sure
> > what you meant with "The warning should not be displayed".
> 
> I was talking about this warning:
> "Warning: Any changes to the configuration [...]"
> 
> I think it does not make sense to display it on the confirmation screen.

Why not ? Resetting indexes is a change to the configuration, so the warning is
 relevant in my opinion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Bouzid Fergani  changed:

   What|Removed |Added

 CC||bouzid.ferg...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Bouzid Fergani  changed:

   What|Removed |Added

  Attachment #73796|0   |1
is obsolete||

--- Comment #25 from Bouzid Fergani  ---
Created attachment 73798
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73798=edit
Bug 20248 - Improve Elasticsearch mappings UI and rebuild_elastic_search.pl.

Improvements:
1) Mappings UI now has button that allows one to reset the mappings.
2) Mappings UI displays the items in alphabetical order.
3) Indexing script drops and recreates the index right away, which
helps prevent ES from autocreating a bad index if someone does something
while the first batch of records is being processed.
4) Indexing script has nicer output.

To test:
1) Change mappings.yaml file
2) Reset mappings in UI in mappings.pl
3) Verify the mappings have been changed in UI
4) The field order is alphabetical
5) Rebuild script has clean output
6) Run test t/db_dependent/Koha_Elasticsearch_Indexer.t

Signed-off-by: Bouzid Fergani 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Bouzid Fergani  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Bouzid Fergani  changed:

   What|Removed |Added

  Attachment #73374|0   |1
is obsolete||

--- Comment #24 from Bouzid Fergani  ---
Created attachment 73796
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73796=edit
Bug 20248 - Improve Elasticsearch mappings UI and rebuild_elastic_search.pl.

Improvements:
1) Mappings UI now has button that allows one to reset the mappings.
2) Mappings UI displays the items in alphabetical order.
3) Indexing script drops and recreates the index right away, which
helps prevent ES from autocreating a bad index if someone does something
while the first batch of records is being processed.
4) Indexing script has nicer output.

To test:
1) Change mappings.yaml file
2) Reset mappings in UI in mappings.pl
3) Verify the mappings have been changed in UI
4) The field order is alphabetical
5) Rebuild script has clean output
6) Run test t/db_dependent/Koha_Elasticsearch_Indexer.t

Signed-off-by: Bouzid Fergani 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

--- Comment #23 from Jonathan Druart  
---
(In reply to Ere Maijala from comment #22)
> Jonathan, thanks, that was indeed bad. Is it ok now? I wasn't quite sure
> what you meant with "The warning should not be displayed".

I was talking about this warning:
"Warning: Any changes to the configuration [...]"

I think it does not make sense to display it on the confirmation screen.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

--- Comment #22 from Ere Maijala  ---
Jonathan, thanks, that was indeed bad. Is it ok now? I wasn't quite sure what
you meant with "The warning should not be displayed".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

--- Comment #21 from Ere Maijala  ---
Alex, please note that the test should already append __test to any index name
(see line 71). I don't think 'biblios' in the new() call should be modified.
It's always either biblios or authorities (might be better to use the
constants, but the string was used in other places so I kept it).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Ere Maijala  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Ere Maijala  changed:

   What|Removed |Added

  Attachment #72932|0   |1
is obsolete||
  Attachment #72933|0   |1
is obsolete||

--- Comment #20 from Ere Maijala  ---
Created attachment 73374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73374=edit
Bug 20248 - Improve Elasticsearch mappings UI and rebuild_elastic_search.pl.

Improvements:
1) Mappings UI now has button that allows one to reset the mappings.
2) Mappings UI displays the items in alphabetical order.
3) Indexing script drops and recreates the index right away, which
helps prevent ES from autocreating a bad index if someone does something
while the first batch of records is being processed.
4) Indexing script has nicer output.

To test:
1) Change mappings.yaml file
2) Reset mappings in UI in mappings.pl
3) Verify the mappings have been changed in UI
4) The field order is alphabetical
5) Rebuild script has clean output
6) Run test t/db_dependent/Koha_Elasticsearch_Indexer.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #19 from Jonathan Druart  
---
It does not look correct to me:
https://screenshots.firefox.com/EeG5M4P78NVOdnr5/pro.kohadev.org

- Nothing is displayed on the screen
- The warning should not be displayed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|koha-b...@lists.koha-commun |ere.maij...@helsinki.fi
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Alex Arnaud  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #18 from Alex Arnaud  ---
Ok for me. So, passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Alex Arnaud  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #72922|0   |1
is obsolete||

--- Comment #17 from Alex Arnaud  ---
Created attachment 72933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72933=edit
Bug 20248: (follow-up) Improve Elasticsearch mappings UI and
rebuild_elastic_search.pl

- change index name

Signed-off-by: Koha User 
Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #72921|0   |1
is obsolete||

--- Comment #16 from Alex Arnaud  ---
Created attachment 72932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72932=edit
Bug 20248 - Improve Elasticsearch mappings UI and rebuild_elastic_search.pl.

Improvements:
1) Mappings UI now has button that allows one to reset the mappings.
2) Mappings UI displays the items in alphabetical order.
3) Indexing script drops and recreates the index right away, which
helps prevent ES from autocreating a bad index if someone does something
while the first batch of records is being processed.
4) Indexing script has nicer output.

To test:
1) Change mappings.yaml file
2) Reset mappings in UI in mappings.pl
3) Verify the mappings have been changed in UI
4) The field order is alphabetical
5) Rebuild script has clean output
6) Run test t/db_dependent/Koha_Elasticsearch_Indexer.t

Signed-off-by: Nicolas Legrand 
Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #72861|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

--- Comment #15 from claire.hernan...@biblibre.com 
 ---
Created attachment 72922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72922=edit
Bug 20248: (follow-up) Improve Elasticsearch mappings UI and
rebuild_elastic_search.pl

- change index name

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

claire.hernan...@biblibre.com  changed:

   What|Removed |Added

  Attachment #72907|0   |1
is obsolete||

--- Comment #14 from claire.hernan...@biblibre.com 
 ---
Created attachment 72921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72921=edit
Bug 20248 - Improve Elasticsearch mappings UI and rebuild_elastic_search.pl.

Improvements:
1) Mappings UI now has button that allows one to reset the mappings.
2) Mappings UI displays the items in alphabetical order.
3) Indexing script drops and recreates the index right away, which
helps prevent ES from autocreating a bad index if someone does something
while the first batch of records is being processed.
4) Indexing script has nicer output.

To test:
1) Change mappings.yaml file
2) Reset mappings in UI in mappings.pl
3) Verify the mappings have been changed in UI
4) The field order is alphabetical
5) Rebuild script has clean output
6) Run test t/db_dependent/Koha_Elasticsearch_Indexer.t

Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

claire.hernan...@biblibre.com  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

--- Comment #13 from Alex Arnaud  ---
(In reply to Ere Maijala from comment #11)
> I think I managed to address the issues.
> 
> 1) I used correct indentation where it was possible without changing large
> blocks.
> 2) Added. Is this how it's supposed to be?
Can you change the index name please? biblios => biblios_test for example.
biblios is the one we use in real

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

--- Comment #12 from Nicolas Legrand  ---
Created attachment 72907
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72907=edit
Bug 20248 - Improve Elasticsearch mappings UI and rebuild_elastic_search.pl.

Improvements:
1) Mappings UI now has button that allows one to reset the mappings.
2) Mappings UI displays the items in alphabetical order.
3) Indexing script drops and recreates the index right away, which
helps prevent ES from autocreating a bad index if someone does something
while the first batch of records is being processed.
4) Indexing script has nicer output.

To test:
1) Change mappings.yaml file
2) Reset mappings in UI in mappings.pl
3) Verify the mappings have been changed in UI
4) The field order is alphabetical
5) Rebuild script has clean output
6) Run test t/db_dependent/Koha_Elasticsearch_Indexer.t

Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Nicolas Legrand  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

--- Comment #11 from Ere Maijala  ---
I think I managed to address the issues.

1) I used correct indentation where it was possible without changing large
blocks.
2) Added. Is this how it's supposed to be?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Ere Maijala  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Ere Maijala  changed:

   What|Removed |Added

  Attachment #72801|0   |1
is obsolete||

--- Comment #10 from Ere Maijala  ---
Created attachment 72861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72861=edit
Bug 20248 - Elasticsearch - Improvements to mappings UI and indexing script

Improvements:
1) Mappings UI now has button that allows one to reset the mappings.
2) Mappings UI displays the items in alphabetical order.
3) Indexing script drops and recreates the index right away, which
helps prevent ES from autocreating a bad index if someone does something
while the first batch of records is being processed.
4) Indexing script has nicer output.

To test:
1) Change mappings.yaml file
2) Reset mappings in UI in mappings.pl
3) Verify the mappings have been changed in UI
4) The field order is alphabetical
5) Rebuild script has clean output
6) Run test t/db_dependent/Koha_Elasticsearch_Indexer.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

--- Comment #9 from Ere Maijala  ---
Thanks for comments.

1) I tried to use the prevalent style in the file, but I'll change the
indentation. 
2) I'll add a test.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Alex Arnaud  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #8 from Alex Arnaud  ---
Here is my first QA review:

1) please check indenting, mainly in templates (i see some "2 spaces"),
2) you could provide unit tests for create_index function. Take a look at one
wrote for update_index in t/db_dependent/Koha_Elasticsearch_Indexer.t. Don't
forget to delete this "test" index after (which is not done for update_index).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

claire.hernan...@biblibre.com  changed:

   What|Removed |Added

  Attachment #71954|0   |1
is obsolete||

--- Comment #7 from claire.hernan...@biblibre.com 
 ---
Created attachment 72801
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72801=edit
Bug 20248: Improve Elasticsearch mapppings UI and rebuild_elastic_search.pl.

Improvements:
1) Mappings UI now has button that allows one to reset the mappings.
2) Mappings UI displays the items in alphabetical order.
3) Indexing script drops and recreates the index right away, which
helps prevent ES from autocreating a bad index if someone does something
while the first batch of records is being processed.
4) Indexing script has nicer output.

To test:
1) Change mappings.yaml file
2) Reset mappings in UI in mappings.pl
3) Verify the mappings have been changed in UI
4) The field order is alphabetical
5) Rebuild script has an clean output

Signed-off-by: Claire Hernandez 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

claire.hernan...@biblibre.com  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

--- Comment #6 from Ere Maijala  ---
3.) Currently the indexing script, when used with the -d parameter, does the
following:
  1. Drops the existing index
  2. Start collecting records in a buffer
  3. Commit the buffer when it's full

The ES index will only be recreated at the first commit. This means that
there's a time window between steps 1 and 3 during which it's possible that
someone/something else saves a record, which causes the index to be
automatically created by ES, but without all the settings it should have.
That's why it's a good idea to recreate the index right away after dropping the
old one. Another possibility is to instruct the ES instance to never autocreate
indexes, but that's outside the scope of indexing here, and I believe it's in
any case a good practice to at least have an empty but working index in place
if the indexing script is interrupted before first commit.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

claire.hernan...@biblibre.com  changed:

   What|Removed |Added

 CC||claire.hernandez@biblibre.c
   ||om

--- Comment #5 from claire.hernan...@biblibre.com 
 ---

1.) Mappings UI now has button that allows one to reset the mappings.

It works for me. Maybe, we could be a little more specific in the confirm form.
Something like "The current mappings you seen on the screen will be erased and
relaced by the mappings in the mappings.yaml file"

2.) Mappings UI displays the items in alphabetical order.

Ok it works for me.

3.) Indexing script drops and recreates the index right away, which helps
prevent ES from autocreating a bad index if someone does something while the
first batch of records is being processed.

I don't understand this part.

4.) Indexing script has nicer output.

Ok for me.

I cannot SO with the doubt on 3. Thanks for your patch :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

--- Comment #4 from Ere Maijala  ---
I put all this in a single patch because the UI requires the indexer changes,
but I'm fine with splitting it into two parts if that's required. It's not a
large patch as it is, though.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Alex Arnaud  changed:

   What|Removed |Added

 CC||alex.arn...@biblibre.com

--- Comment #3 from Alex Arnaud  ---
I think this should be splited into 2 parts. One for the indexing things and
one for what is related to mapping UI. Are you ok?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Ere Maijala  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #2 from Ere Maijala  ---
The patch provides the following improvements:

1.) Mappings UI now has button that allows one to reset the mappings.
2.) Mappings UI displays the items in alphabetical order.
3.) Indexing script drops and recreates the index right away, which helps
prevent ES from autocreating a bad index if someone does something while the
first batch of records is being processed.
4.) Indexing script has nicer output.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

--- Comment #1 from Ere Maijala  ---
Created attachment 71954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71954=edit
Improve Elasticsearch mapppings UI and rebuild_elastic_search.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/