[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Stable|RESOLVED

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #57 from Fridolin SOMERS --- (In reply to Andrew Isherwood from comment #56) > Hi Fridolin - It seems that Kyle has added support for it in the Kitchen > Sink plugin. The test plan for Bug 21905 tests this area and

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #56 from Andrew Isherwood --- Hi Fridolin - It seems that Kyle has added support for it in the Kitchen Sink plugin. The test plan for Bug 21905 tests this area and requires use of the Kitchen Sink -- You are receiving

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Kyle M Hall changed: What|Removed |Added Blocks||21905 Referenced Bugs:

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Fridolin SOMERS changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood changed: What|Removed |Added Blocks||21900 Referenced Bugs:

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Martin Renvoize changed: What|Removed |Added Text to go in the||Sponsored by PTFS Europe

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable ---

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #50 from Kyle M Hall --- Created attachment 80617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80617=edit Bug 20968: Add unit tests Signed-off-by: Stephen Graham Signed-off-by: Kyle M Hall --

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #52 from Kyle M Hall --- Created attachment 80619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80619=edit Bug 20968: (follow-up) Replace tabs with spaces Signed-off-by: Stephen Graham

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Kyle M Hall changed: What|Removed |Added Attachment #80394|0 |1 is obsolete|

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #49 from Kyle M Hall --- Created attachment 80616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80616=edit Bug 20968: (follow-up) Respond to feedback This patch: - Removes the unecessary testing for

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #79807|0 |1 is

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #79808|0 |1 is

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #79805|0 |1 is

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #79806|0 |1 is

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #79804|0 |1 is

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #42 from Andrew Isherwood --- More detailed test plan: - Follow the installation and configuration instructions from: https://github.com/PTFS-Europe/cla-permissions-check-plugin - Go to the bib details for a record,

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff ---

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Martin Renvoize changed: What|Removed |Added Attachment #78459|0 |1 is obsolete|

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Martin Renvoize changed: What|Removed |Added Attachment #78461|0 |1 is obsolete|

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Martin Renvoize changed: What|Removed |Added Attachment #78457|0 |1 is obsolete|

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Martin Renvoize changed: What|Removed |Added Attachment #78460|0 |1 is obsolete|

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Martin Renvoize changed: What|Removed |Added Attachment #78458|0 |1 is obsolete|

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Fiona Borthwick changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood changed: What|Removed |Added Attachment #77783|0 |1 is obsolete|

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood changed: What|Removed |Added Attachment #77782|0 |1 is obsolete|

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood changed: What|Removed |Added Attachment #77785|0 |1 is obsolete|

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood changed: What|Removed |Added Attachment #77784|0 |1 is obsolete|

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood changed: What|Removed |Added Attachment #77786|0 |1 is obsolete|

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff ---

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood changed: What|Removed |Added Attachment #76567|0 |1 is obsolete|

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood changed: What|Removed |Added Attachment #76568|0 |1 is obsolete|

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood changed: What|Removed |Added Attachment #76566|0 |1 is obsolete|

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood changed: What|Removed |Added Attachment #76564|0 |1 is obsolete|

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood changed: What|Removed |Added Attachment #76565|0 |1 is obsolete|

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #24 from Kyle M Hall --- (In reply to Andrew Isherwood from comment #23) > Any clue as to why this patch isn't applying for you Jonathan? It's > literally replacing tabs with spaces, so no idea why it wouldn't apply. >

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #23 from Andrew Isherwood --- Any clue as to why this patch isn't applying for you Jonathan? It's literally replacing tabs with spaces, so no idea why it wouldn't apply. Presumably since Kyle signed it off, it applied

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #21 from Kyle M Hall --- Created attachment 76568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76568=edit Bug 20968: (follow-up) Replace tabs with spaces Signed-off-by: Kyle M Hall -- You are

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #20 from Kyle M Hall --- Created attachment 76567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76567=edit Bug 20968: Rename method get_intranet_catalog_toolbar_button to

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #19 from Kyle M Hall --- Created attachment 76566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76566=edit Bug 20968: Add unit tests Signed-off-by: Kyle M Hall Signed-off-by: Andrew Isherwood --

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #18 from Kyle M Hall --- Created attachment 76565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76565=edit Bug 20968: (follow-up) Respond to feedback This patch: - Removes the unecessary testing for

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Kyle M Hall changed: What|Removed |Added Attachment #76375|0 |1 is obsolete|

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #16 from Andrew Isherwood --- Created attachment 76555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76555=edit Bug 20968: (follow-up) Replace tabs with spaces -- You are receiving this mail

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #15 from Andrew Isherwood --- Hi Kyle Perfect, thanks very much for that. I've tested and signed off (I think) your patches. Cheers -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood changed: What|Removed |Added Attachment #76531|0 |1 is obsolete|

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood changed: What|Removed |Added Attachment #76532|0 |1 is obsolete|

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #12 from Kyle M Hall --- Apologies for all the typos in my last reply. It's just one of those days I guess ;) -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #11 from Kyle M Hall --- > 4) I'm not clear whether you're suggesting we should ditch the > intranet_catalog_biblio_enhancements method entirely. I don't think we can > do this as we need to be able to test in

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #9 from Kyle M Hall --- Created attachment 76531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76531=edit Bug 20968: Add unit tests -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #10 from Kyle M Hall --- Created attachment 76532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76532=edit Bug 20968: Rename method get_intranet_catalog_toolbar_button to

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #8 from Andrew Isherwood --- Created attachment 76530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76530=edit Bug 20968: (follow-up) Respond to feedback This patch: - Removes the unecessary testing

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #7 from Andrew Isherwood --- Hi Kyle Looking at 1), I'm not sure writing tests for this tiny amount of core integration is even possible. All we're doing is populating a template parameter under a certain condition, I

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #6 from Andrew Isherwood --- Hi Kyle Many thanks for this feedback, very helpful indeed. 1) Yes indeed, I completely overlooked tests, I'll address this. 2) Good point, well spotted. I'll fix this. 3) Yes, will do 4)

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #5 from Kyle M Hall --- On further inspection, I go with something even more specific, get_opac_catalog_toolbar_button, which completely disambiguates where this button will appear. -- You are receiving this mail

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #4 from Kyle M Hall --- 4) I forgot to make explicit that it seems like the method intranet_catalog_biblio_enhancements is not really necessary and should be removed and replaced with a GetPlugins call for

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #3

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de,

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood changed: What|Removed |Added Attachment #76374|0 |1 is obsolete|

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #2 from Andrew Isherwood --- Created attachment 76375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76375=edit Bug 20968: Add hooks into cat-toolbar.inc to display buttons This commit adds hooks into

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 --- Comment #1 from Andrew Isherwood --- Created attachment 76374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76374=edit Add hooks into cat-toolbar.inc to display buttons This commit adds hooks into

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com --

[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Andrew Isherwood changed: What|Removed |Added Status|NEW |ASSIGNED