[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What|Removed |Added Target Milestone|19.05 |--- CC|

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 --- Comment #25 from Martin Renvoize --- *** Bug 22374 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|RESOLVED

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 --- Comment #23 from Nick Clemens --- (In reply to Jonathan Druart from comment #22) > Created attachment 85795 [details] [review] > Bug 21747: Insert fine_increase and fine_decrease for new installs > > This fixes Circulation.t >

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 --- Comment #22 from Jonathan Druart --- Created attachment 85795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85795=edit Bug 21747: Insert fine_increase and fine_decrease for new installs This fixes

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What|Removed |Added Blocks|21683 |21722 Referenced Bugs:

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Tomás Cohen Arazi changed: What|Removed |Added Attachment #84816|0 |1 is obsolete|

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 85180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85180=edit Bug 21747: (follow-up) Intelligent rename of offsets This patch intelligently renames

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 85179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85179=edit Bug 21747: Use Koha::Account:: routines in UpdateFine Set to use

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Tomás Cohen Arazi changed: What|Removed |Added Attachment #84817|0 |1 is obsolete|

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What|Removed |Added Attachment #84810|0 |1 is obsolete|

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What|Removed |Added Attachment #84811|0 |1 is obsolete|

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 --- Comment #18 from Martin Renvoize --- Updated to use _increase and _decrease as Katrin agreed they're clearer terms for the average user. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 --- Comment #15 from Martin Renvoize --- I've implemented the follow-up as suggested now so that we use 'fine_update' as the 'type' to pass to the method and then 'fine_increment' or 'fine_decrement' for the two cases in the

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What|Removed |Added Attachment #84808|0 |1 is obsolete|

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What|Removed |Added Attachment #84807|0 |1 is obsolete|

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What|Removed |Added Attachment #84726|0 |1 is obsolete|

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What|Removed |Added Attachment #84725|0 |1 is obsolete|

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off -- You are

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 --- Comment #10 from Martin Renvoize --- Created attachment 84726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84726=edit Bug 21747: (follow-up) Intelligent rename of offsets This patch intelligently renames

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What|Removed |Added Attachment #83252|0 |1 is obsolete|

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 --- Comment #7 from Tomás Cohen Arazi --- (In reply to Tomás Cohen Arazi from comment #6) > > I think we need to consider the backdated returns use case, and have another > offset for those, as fine_increment doesn't look right.

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Bug 21747 depends on bug 21002, which changed state. Bug 21002 Summary: Add Koha::Account::add_debit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 What|Removed |Added

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 --- Comment #6 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #5) > Created attachment 83252 [details] [review] > Bug 21747: Use Koha::Account:: routines in UpdateFine > > Set to use Koha::Account->add_debit

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What|Removed |Added Blocks|14825 | Referenced Bugs:

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What|Removed |Added Blocks||21683 Referenced Bugs:

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Bug 21747 depends on bug 21727, which changed state. Bug 21727 Summary: Add Koha::Account::Line->adjust https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 What|Removed |Added

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Bug 21747 depends on bug 21753, which changed state. Bug 21753 Summary: issuingrules.chargename is unused and should be removed https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21753 What|Removed

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What|Removed |Added Target Milestone|--- |19.05 -- You are

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What|Removed |Added Attachment #83234|0 |1 is obsolete|

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What|Removed |Added Attachment #83130|0 |1 is obsolete|

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Josef Moravec changed: What|Removed |Added Attachment #81890|0 |1 is obsolete|

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Josef Moravec changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What|Removed |Added CC||josef.mora...@gmail.com,

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 --- Comment #2 from Martin Renvoize --- Created attachment 81890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81890=edit Bug 21747: Use Koha::Account:: routines in UpdateFine Set to use Koha::Account->add_debit

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What|Removed |Added Depends on||21727 Referenced Bugs:

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 --- Comment #1 from Martin Renvoize --- *** Bug 21748 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What|Removed |Added Blocks||14825 Referenced Bugs:

[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What|Removed |Added Summary|Update |Update