[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 Jonathan Druart changed: What|Removed |Added Blocks||23038 Referenced Bugs:

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 --- Comment #23 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 Bug 22049 depends on bug 22051, which changed state. Bug 22051 Summary: Make Koha::Object->store translate 'Incorrect value' exceptions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051 What|Removed

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 --- Comment #22 from Nick Clemens --- (In reply to Jonathan Druart from comment #21) > Created attachment 85498 [details] [review] > Bug 22049: Do not pass Koha::Patron to AddIssue > > The tests are not supposed to pass with such

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 --- Comment #21 from Jonathan Druart --- Created attachment 85498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85498=edit Bug 22049: Do not pass Koha::Patron to AddIssue The tests are not supposed to pass with

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 --- Comment #20 from Jonathan Druart --- Comment on attachment 83728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83728 Bug 22049: Add tests Review of attachment 83728: -->

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 --- Comment #19 from Jonathan Druart --- We should hide the SQL error: t/db_dependent/Circulation/MarkIssueReturned.t .. 1/3 DBD::mysql::st execute failed: Incorrect datetime value: 'bad_date' for column 'returndate' at row 1

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|RESOLVED

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 --- Comment #15 from Josef Moravec --- Created attachment 83730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83730=edit Bug 22049: (QA follow-up) update MarkIssueReturned call in process_koc.pl Test plan: Try

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 --- Comment #13 from Josef Moravec --- Created attachment 83728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83728=edit Bug 22049: Add tests The current tests only check some failure use cases. This patch makes

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 --- Comment #14 from Josef Moravec --- Created attachment 83729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83729=edit Bug 22049: (follow-up) Remove leftover variable The $circControlBranch variable was

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 Josef Moravec changed: What|Removed |Added Attachment #83654|0 |1 is obsolete|

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 Charles Farmer changed: What|Removed |Added Attachment #83625|0 |1 is obsolete|

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 Charles Farmer changed: What|Removed |Added Attachment #83627|0 |1 is obsolete|

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 Charles Farmer changed: What|Removed |Added Attachment #83626|0 |1 is obsolete|

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 --- Comment #8 from Owen Leonard --- Created attachment 83627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83627=edit Bug 22049: (follow-up) Remove leftover variable The $circControlBranch variable was

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 --- Comment #7 from Owen Leonard --- Created attachment 83626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83626=edit Bug 22049: Add tests The current tests only check some failure use cases. This patch makes

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 Owen Leonard changed: What|Removed |Added Attachment #83543|0 |1 is obsolete|

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 Tomás Cohen Arazi changed: What|Removed |Added Depends on||22051 Referenced

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 83549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83549=edit Bug 22049: (follow-up) Remove leftover variable The $circControlBranch variable was

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 Tomás Cohen Arazi changed: What|Removed |Added Attachment #83544|0 |1 is obsolete|

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Small patch -- You

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff -- You

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 83544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83544=edit Bug 22049: Add tests The current tests only check failure use cases. As we are changing

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 Tomás Cohen Arazi changed: What|Removed |Added Attachment #83542|0 |1 is obsolete|

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 Tomás Cohen Arazi changed: What|Removed |Added CC|

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 83542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83542=edit Bug 22049: Make MarkIssueReturned rely on returndate only This patch changes the params

[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com