[Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 Martin Renvoize changed: What|Removed |Added Target Milestone|Oldversions |--- Jonathan Druart changed: What|Removed |Added Blocks||25643 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 [Bug 25643] Remove maxreserves syspref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 Lisette changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #74 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 M. de Rooy changed: What|Removed |Added Attachment #30051|0 |1 is obsolete|| --- Comment #73 from M. de Rooy --- Created attachment 30448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30448&action=edit Bug 4045 - No check for maximum number of allowed holds. Re-add the system preference maxreserves. All the code using maxreserves is still in place. Though it is not used in the Reserves module, it is used in all the scripts where holds are placed. Also adds a check so that a borrower cannot exceed the maximum number of allowed holds by using the multi-hold feature via the opac. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Set maxreserves to 3, set opactheme to bootstrap 4) Log into the opac as a patron 5) Place 3 holds 6) Attempt to place a 4th hold 7) Note you get an error message and cannot place a forth hold 8) Delete two of those holds 9) Attempt to place 3 or more holds as a multi-hold 10) You should see a warning that you cannot place this many holds 11) Try to anyway 12) You should see an alert to tell you to reduce the number of holds you are placing. 13) Reduce the number for holds you are placing to 2 14) Your holds should now be placed Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 M. de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #72 from M. de Rooy --- QA Comment If maxreserves would have been a new development and Holds was a perfect module, this should have failed QA :) But we are in another situation. The missing maxreserves for long time already is really bad. My test results show me that there are still some discrepancies and points to resolve. We could see this patch as the starting point for that. Since this report already has quite a history, I am passing QA on it in the perspective noted. Leaving final judgement to RM or perhaps a second QA opinion? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 --- Comment #71 from M. de Rooy --- Still another test after deleting the reserves from the fourth run: I select four biblios and place hold. I get a warning to uncheck. I uncheck one biblio and select three items (BK) with a hold limit on BK=2. Without a warning I had two holds placed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 --- Comment #70 from M. de Rooy --- Test results: Hopefully understandable enough (bl=bib level; il=item level; numbers are bibs) Will refer to this in my QA comment. First test (biblevel maxreserves=3 issuingrules=10 on all itypes) bl 668 OK bl 1178 OK req on two biblios: get warning when submitting: ERROR: Internal error: incomplete hold request. So both holds are blocked. But the error message is kind of vague. Result of bad_data flag in opac-reserve.pl No blocker, but this could still be improved. bl 1234 on third OK try no 4 (1235) message fine OK try 4 via staff warning, but hold is placed [staff overrules: design??] Note that I had AllowHoldPolicyOverride=Do not allow override! try 5 via opac: You cannot place more than 4 holds. (Oops: actually more than 3 should not be allowed..) Second test (itemlevel maxres=3 issu=2 on all itypes) il 668 il 1178 req on two: Funny: Four warnings: None can be placed on hold (Fine). Sorry, you can only place 1 more holds (Small spelling issue too! But it is not true! I have gone above the number of 2 in issuingrules. Please uncheck boxes (Impossible: there are no boxes to uncheck..) Per biblio a warning: No available items. il 1234 None can be placed on hold (OK) Changing issu=2 to issu=3: repeat il 1234 (OK) try no 4 (1235): You cannot place more than 3 holds (OK) try 4 via staff Cannot place hold on some items (No items are available) So, this time I cannot overrule it. Third test (item level maxres=3 issu=2 on BK only) il 668 BK il 1178 BK try il 1234 BK None can be placed (OK) try il 1331 CF Sorry none can be placed (Not true: I just have 2 holds; For itype CF I should have one to go?) try il 1331 CF on staff: Cannot place a hold. No items av. (Not true?) delete two reserves, try il 1331 CF: Still impossible. Fourth test (item level issu BK=2 issu CF=4) il 668 BK il 1178 BK try il 1234 BK None placed: OK try il 1331 CF Can be done: OK retry il 1331 CF No more than 3: OK (maxreserves overrules the CF=4 rule here.. Debatable?) try il 1235 BK You cannot place more than 3: OK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 M. de Rooy changed: What|Removed |Added QA Contact|m...@kohaaloha.com |m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 M. de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 Chris Cormack changed: What|Removed |Added Attachment #28492|0 |1 is obsolete|| --- Comment #69 from Chris Cormack --- Created attachment 30051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30051&action=edit Bug 4045 - No check for maximum number of allowed holds. Re-add the system preference maxreserves. All the code using maxreserves is still in place. Though it is not used in the Reserves module, it is used in all the scripts where holds are placed. Also adds a check so that a borrower cannot exceed the maximum number of allowed holds by using the multi-hold feature via the opac. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Set maxreserves to 3, set opactheme to bootstrap 4) Log into the opac as a patron 5) Place 3 holds 6) Attempt to place a 4th hold 7) Note you get an error message and cannot place a forth hold 8) Delete two of those holds 9) Attempt to place 3 or more holds as a multi-hold 10) You should see a warning that you cannot place this many holds 11) Try to anyway 12) You should see an alert to tell you to reduce the number of holds you are placing. 13) Reduce the number for holds you are placing to 2 14) Your holds should now be placed Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 --- Comment #68 from Kyle M Hall --- I see now that it did work for multi-holds in the past. Considering I started this patch 2 years ago I'm not surprised I forgot ; ) (In reply to Christopher Brannon from comment #67) > (In reply to Kyle M Hall from comment #66) > > I don't think this should fail qa for not being a complete fix. A partial > > fix is better than no fix at all! > > > > Kyle > > > > (In reply to Christopher Brannon from comment #65) > > > Got the sandbox to work this time around. > > > > > > The limit works great for individually placed holds, but still gives no > > > warning and places holds over limit if holding multiple items. > > > > > > Christopher > > I respectfully disagree. You placed the multi-hold as a test condition. > > > 9) Attempt to place 3 or more holds as a multi-hold > > The patch does not pass your test. If the patch is only to test items > placed on hold one at a time, then it works just fine. I don't think this > should pass, based on your parameters. > > Christopher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 --- Comment #67 from Christopher Brannon --- (In reply to Kyle M Hall from comment #66) > I don't think this should fail qa for not being a complete fix. A partial > fix is better than no fix at all! > > Kyle > > (In reply to Christopher Brannon from comment #65) > > Got the sandbox to work this time around. > > > > The limit works great for individually placed holds, but still gives no > > warning and places holds over limit if holding multiple items. > > > > Christopher I respectfully disagree. You placed the multi-hold as a test condition. > 9) Attempt to place 3 or more holds as a multi-hold The patch does not pass your test. If the patch is only to test items placed on hold one at a time, then it works just fine. I don't think this should pass, based on your parameters. Christopher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #66 from Kyle M Hall --- I don't think this should fail qa for not being a complete fix. A partial fix is better than no fix at all! Kyle (In reply to Christopher Brannon from comment #65) > Got the sandbox to work this time around. > > The limit works great for individually placed holds, but still gives no > warning and places holds over limit if holding multiple items. > > Christopher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 Christopher Brannon changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #65 from Christopher Brannon --- Got the sandbox to work this time around. The limit works great for individually placed holds, but still gives no warning and places holds over limit if holding multiple items. Christopher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #64 from Bernardo Gonzalez Kriegel --- (In reply to Christopher Brannon from comment #63) > Tried applying this to a sandbox. Got the following errors: > > The sandbox you've requested is not ready. ... > Apply? [(y)es, (n)o, (i)nteractive] Patch left in > /tmp/Bug-4045---No-check-for-maximum-number-of-allowed--QeoM3b.patch . > Hi, seems to be a problem with the sandbox ~/kohaclone$ git checkout master Switched to branch 'master' ~/kohaclone$ git pull Already up-to-date. ~/kohaclone$ git bz apply 4045 Bug 4045 - No check for maximum number of allowed holds from OPAC. 28492 - Bug 4045 - No check for maximum number of allowed holds. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 4045 - No check for maximum number of allowed holds. ~/kohaclone$ Switch again to Needs signoff, waiting Kyle's comment -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 Christopher Brannon changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||cbran...@cdalibrary.org --- Comment #63 from Christopher Brannon --- Tried applying this to a sandbox. Got the following errors: The sandbox you've requested is not ready. Some problems occurred applying patches from bug 4045: Something went wrong !Applying: Bug 4045 - No check for maximum number of allowed holds. fatal: sha1 information is lacking or useless (installer/data/mysql/updatedatabase.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 4045 - No check for maximum number of allowed holds. When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 4045 - No check for maximum number of allowed holds from OPAC. 28492 - Bug 4045 - No check for maximum number of allowed holds. Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-4045---No-check-for-maximum-number-of-allowed--QeoM3b.patch . Christopher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 --- Comment #62 from Bernardo Gonzalez Kriegel --- Testing: > Test Plan: > 1) Apply this patch > 2) Run updatedatabase > 3) Set maxreserves to 3, set opactheme to bootstrap > 4) Log into the opac as a patron > 5) Place 3 holds > 6) Attempt to place a 4th hold > 7) Note you get an error message and cannot place a forth hold > 8) Delete two of those holds > 9) Attempt to place 3 or more holds as a multi-hold > 10) You should see a warning that you cannot place this many holds All Ok up to this point > 11) Try to anyway > 12) You should see an alert to tell you to reduce the number of holds > you are placing. Here I don't see an alert, but "ERROR: Internal error: incomplete hold request." On logs: opac-reserve.pl: Use of uninitialized value $biblionumbers in split at /home/bgkriegel/kohaclone/opac/opac-reserve.pl line 110 No holds placed > 13) Reduce the number for holds you are placing to 2 > 14) Your holds should now be placed Final two Ok Is that error message the expected result? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 Kyle M Hall changed: What|Removed |Added Blocks||12197 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 Jacek Ablewicz changed: What|Removed |Added CC||a...@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 Kyle M Hall changed: What|Removed |Added Attachment #28491|0 |1 is obsolete|| --- Comment #61 from Kyle M Hall --- Created attachment 28492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28492&action=edit Bug 4045 - No check for maximum number of allowed holds. Re-add the system preference maxreserves. All the code using maxreserves is still in place. Though it is not used in the Reserves module, it is used in all the scripts where holds are placed. Also adds a check so that a borrower cannot exceed the maximum number of allowed holds by using the multi-hold feature via the opac. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Set maxreserves to 3, set opactheme to bootstrap 4) Log into the opac as a patron 5) Place 3 holds 6) Attempt to place a 4th hold 7) Note you get an error message and cannot place a forth hold 8) Delete two of those holds 9) Attempt to place 3 or more holds as a multi-hold 10) You should see a warning that you cannot place this many holds 11) Try to anyway 12) You should see an alert to tell you to reduce the number of holds you are placing. 13) Reduce the number for holds you are placing to 2 14) Your holds should now be placed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 Kyle M Hall changed: What|Removed |Added Summary|No check for maximum number |No check for maximum number |of allowed holds. |of allowed holds from OPAC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/