https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Fridolin SOMERS changed:
What|Removed |Added
Blocks||26594
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Mason James changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Mason James changed:
What|Removed |Added
Blocks||21648
Referenced Bugs:
https
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Fridolin SOMERS changed:
What|Removed |Added
Blocks||21113
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Jonathan Druart changed:
What|Removed |Added
Blocks||21041
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Martin Renvoize changed:
What|Removed |Added
Resolution|--- |FIXED
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Lisette changed:
What|Removed |Added
CC||lisettesla...@gmail.com
--
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Niamh changed:
What|Removed |Added
CC||niamh.walker-headon@it-tall
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Kyle M Hall changed:
What|Removed |Added
Text to go in the|Koha now has the ability to |Koha now has the ability to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Jonathan Druart changed:
What|Removed |Added
Keywords|release-notes-needed|
--
You are receiving thi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Katrin Fischer changed:
What|Removed |Added
Text to go in the|Koha now add the ability to |Koha now has the ability to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Séverine Queune changed:
What|Removed |Added
CC||severine.que...@bulac.fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #65 from Kyle M Hall ---
(In reply to Kyle M Hall from comment #64)
> > Can we use the is_boolean approach on the screens files? is_patron_id?
>
> We could be I don't think it solves the root problem. A developer who woul
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #64 from Kyle M Hall ---
> Can we use the is_boolean approach on the screens files? is_patron_id?
We could be I don't think it solves the root problem. A developer who would
forget to add a new column to the merge patron'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #63 from Tomás Cohen Arazi ---
(In reply to Kyle M Hall from comment #62)
> (In reply to Jonathan Druart from comment #60)
> > (In reply to Kyle M Hall from comment #55)
> > > (In reply to Jonathan Druart from comment #54)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Kyle M Hall changed:
What|Removed |Added
Blocks||20636
Referenced Bugs:
https
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #62 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #60)
> (In reply to Kyle M Hall from comment #55)
> > (In reply to Jonathan Druart from comment #54)
> > > Thanks for the follow-ups.
> > >
> > > (In repl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Pushed to Master
--- Comme
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #60 from Jonathan Druart
---
(In reply to Kyle M Hall from comment #55)
> (In reply to Jonathan Druart from comment #54)
> > Thanks for the follow-ups.
> >
> > (In reply to Jonathan Druart from comment #38)
> > > 1. How
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Jonathan Druart changed:
What|Removed |Added
Keywords||release-notes-needed
--
Y
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #59 from Kyle M Hall ---
Created attachment 74653
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74653&action=edit
Bug 9302: Add error message if keeper patron is invalid
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #58 from Jonathan Druart
---
(In reply to Kyle M Hall from comment #57)
> This followup adds errors for the first and last situations. The middle one
> only occurs if you apply the patch set but don't restart plack ( at l
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #57 from Kyle M Hall ---
This followup adds errors for the first and last situations. The middle one
only occurs if you apply the patch set but don't restart plack ( at least for
me ) so it's not a valid production error a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #56 from Kyle M Hall ---
Created attachment 74585
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74585&action=edit
Bug 9302: Add error messages, correct number of unit tests in subtest 'Test
Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Passed QA
--
You are receivin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #55 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #54)
> Thanks for the follow-ups.
>
> (In reply to Jonathan Druart from comment #38)
> > 1. How did you generate $RESULTSET_PATRON_ID_MAPPING?
> > How are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Failed QA
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #54 from Jonathan Druart
---
Thanks for the follow-ups.
(In reply to Jonathan Druart from comment #38)
> 1. How did you generate $RESULTSET_PATRON_ID_MAPPING?
> How are we going to keep it up-to-date?
Answer still neede
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #53 from Kyle M Hall ---
Created attachment 74451
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74451&action=edit
Bug 9302: Update div classes
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #51 from Kyle M Hall ---
Created attachment 74449
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74449&action=edit
Bug 9302: Use patron-title.inc
--
You are receiving this mail because:
You are watchin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #52 from Kyle M Hall ---
Created attachment 74450
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74450&action=edit
Bug 9302: Wrap display_names block line with a span tag
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #50 from Kyle M Hall ---
Created attachment 74448
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74448&action=edit
Bug 9302: Add button directing use to keeper's patron record
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #49 from Kyle M Hall ---
Created attachment 74447
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74447&action=edit
Bug 9302: Make the patron search show/hide more links work
--
You are receiving this m
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #48 from Kyle M Hall ---
Created attachment 74446
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74446&action=edit
Bug 9302: Use new 'edit borrowers' permission
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #46 from Kyle M Hall ---
Created attachment 7
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7&action=edit
Bug 9302: (QA follow-up) Consistency follow-up
This patch moves the Koha::Patrons->merg
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #44 from Kyle M Hall ---
Created attachment 74442
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74442&action=edit
Bug 9302: (QA follow-up) Merge should be a transaction
Signed-off-by: Tomas Cohen Arazi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #47 from Kyle M Hall ---
Created attachment 74445
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74445&action=edit
Bug 9302: Add aq tables to mapping
--
You are receiving this mail because:
You are wat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #43 from Kyle M Hall ---
Created attachment 74441
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74441&action=edit
Bug 9302: (QA follow-up) Copy merged patrons to deletedborrowers table
Signed-off-by: O
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #45 from Kyle M Hall ---
Created attachment 74443
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74443&action=edit
Bug 9302: (QA follow-up) Dumper plugin isn't used
Signed-off-by: Tomas Cohen Arazi
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Kyle M Hall changed:
What|Removed |Added
Attachment #74439|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Kyle M Hall changed:
What|Removed |Added
Attachment #73660|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Passed QA
--
You are receivin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #40 from Owen Leonard ---
> 10. Not sure about that part, I am going to ping Owen:
> 60
> 61
> 62
I recommend this be replaced with:
I'll work on updating the interface patter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #39
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #38 from Jonathan Druart
---
1. How did you generate $RESULTSET_PATRON_ID_MAPPING?
How are we going to keep it up-to-date?
2. Looks like acquisition tables are missing.
3. Since bug 18403 we should use CAN_user_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Kyle M Hall changed:
What|Removed |Added
Attachment #73668|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #36 from Tomás Cohen Arazi ---
Created attachment 73668
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73668&action=edit
Bug 9302: (QA follow-up) Consistency follow-up
This patch moves the Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #73664|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #73649|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #35 from Tomás Cohen Arazi ---
Created attachment 73664
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73664&action=edit
Bug 9302: (QA follow-up) reverse try/catch block
Signed-off-by: Tomas Cohen Arazi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #73648|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #73646|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #73645|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #30 from Kyle M Hall ---
Created attachment 73649
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73649&action=edit
Bug 9302 [QA Followup]: Dumper plugin isn't used
--
You are receiving this mail becaus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Kyle M Hall changed:
What|Removed |Added
Attachment #73647|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #28 from Kyle M Hall ---
Created attachment 73647
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73647&action=edit
Bug 9302 [QA Followup]: Merge should be a transaction
--
You are receiving this mail b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #27 from Kyle M Hall ---
Created attachment 73646
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73646&action=edit
Bug 9302 [QA Followup]: Copy merged patrons to deletedborrowers table
Signed-off-by: Ow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Kyle M Hall changed:
What|Removed |Added
Attachment #72082|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #25 from Tomás Cohen Arazi ---
I tested the patches and they work as expected. Great job!
Some remarks:
Major: I'd say the ->merge method should execute code wrapped by a transaction.
There are risky operations taking pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Chris Slone changed:
What|Removed |Added
CC||cslone@camdencountylibrary.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Tomás Cohen Arazi changed:
What|Removed |Added
QA Contact||tomasco...@gmail.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Kyle M Hall changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Kyle M Hall changed:
What|Removed |Added
Attachment #70482|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #24 from Kyle M Hall ---
Created attachment 72083
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72083&action=edit
Bug 9302 [QA Followup] Copy merged patrons to deletedborrowers table
Signed-off-by: Owe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
George Williams (NEKLS) changed:
What|Removed |Added
CC||geo...@nekls.org
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #20 from bywatersandbo...@gmail.com ---
Created attachment 70482
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70482&action=edit
Bug 9302 - Add ability to merge patron records
It would be great if there
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
bywatersandbo...@gmail.com changed:
What|Removed |Added
Attachment #70479|0 |1
is obso
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #21 from bywatersandbo...@gmail.com ---
Created attachment 70483
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70483&action=edit
Bug 9302 [QA Followup] Copy merged patrons to deletedborrowers table
Sign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
bywatersandbo...@gmail.com changed:
What|Removed |Added
Attachment #70478|0 |1
is obso
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
bywatersandbo...@gmail.com changed:
What|Removed |Added
CC||bywatersandbo...@
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Owen Leonard changed:
What|Removed |Added
Attachment #70477|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #18 from Owen Leonard ---
Created attachment 70479
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70479&action=edit
Bug 9302 [QA Followup] Copy merged patrons to deletedborrowers table
Signed-off-by: Ow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Owen Leonard changed:
What|Removed |Added
Patch complexity|--- |Medium patch
Stat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Owen Leonard changed:
What|Removed |Added
Attachment #70474|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #16 from Kyle M Hall ---
Created attachment 70477
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70477&action=edit
Bug 9302 [QA Followup] - Copy merged patrons to deletedborrowers table
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Kyle M Hall changed:
What|Removed |Added
Attachment #68606|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #14 from Nick Clemens ---
*** Bug 19567 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Ed Veal changed:
What|Removed |Added
CC||ev...@mckinneytexas.org
--
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Jessie Zairo changed:
What|Removed |Added
CC||jza...@bywatersolutions.com
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #13 from Owen Leonard ---
This doesn't work for me at all. When I select the patron record to keep and
submit the form, I'm redirected to a page which says "Patron records merged
into ()" and the records have not been merg
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
John DeLooper changed:
What|Removed |Added
CC||jdeloo...@hccc.edu
--- Comme
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Josef Moravec changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
CC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Kyle M Hall changed:
What|Removed |Added
Attachment #66617|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #9 from Kyle M Hall ---
(In reply to Tomás Cohen Arazi from comment #8)
> Kyle, I'm failing it so it is obvious that some changes are needed for its
> inclusion!
>
> (In reply to Jonathan Druart from comment #7)
> > Reado
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Tomás Cohen Arazi changed:
What|Removed |Added
CC||tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #6 from Katrin Fischer ---
Hi Hugo, please add your sign-off line to patche that you mark as signed off.
Instructions on how to do this can be found on the wiki.
--
You are receiving this mail because:
You are watching a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Hugo Agud changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Kyle M Hall changed:
What|Removed |Added
Attachment #66615|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
--- Comment #3 from Kyle M Hall ---
Created attachment 66615
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66615&action=edit
Bug 9302 - Add ability to merge patron records
It would be great if there were a merge p
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Kyle M Hall changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302
Kyle M Hall changed:
What|Removed |Added
Summary|merge patrons |Add ability to merge patron
96 matches
Mail list logo