Re: [Koha-devel] Coding guidelines

Hi Marcel, Sorry for the late reply. All looks ok to me as well, only a couple of things: 15b: better to point to C4 than c/p code from there to Koha :) Ideally the code should be moved to Koha, then used from there. But no always a solution I guess. 15c: On 22407 comment 3 I listed the

Re: [Koha-devel] Coding guidelines

Ooops, I forgot to reply to this. It looks good to me Marcel. *Martin Renvoize* Development Team Manager Community Release Manager (19.11, 20.05) *Phone:* +44 (0) 1483 378728 *Mobile:* +44 (0) 7725 985 636 *Email:* martin.renvo...@ptfs-europe.com *Fax:* +44

[Koha-devel] Coding guidelines

Referring to the dev meeting and bug 22407, I propose the following rewording: PERL15 Using Koha::Object[s] PERL15(a) Code added to the Koha:: namespace should be object-oriented unless there is a very good reason to do otherwise. In that case the reason should be documented clearly. PERL15(b)

Re: [Koha-devel] Coding Guidelines: POD Documentation

+1 requite and inline On 11.01.2017 19:25, Chris Cormack wrote: Yes to the requiring POD and 1 vote for inline (the majority is inline already) Chris On 12 January 2017 7:21:49 AM NZDT, Nick Clemens wrote: Hello Koha developers, At the last developers

Re: [Koha-devel] Coding Guidelines: POD Documentation

Yes to the requiring POD and 1 vote for inline (the majority is inline already) Chris On 12 January 2017 7:21:49 AM NZDT, Nick Clemens wrote: >Hello Koha developers, > >At the last developers meeting there was some discussion about >guidelines >for requiring POD

[Koha-devel] Coding Guidelines: POD Documentation

Hello Koha developers, At the last developers meeting there was some discussion about guidelines for requiring POD during QA. Our current guideline is here: https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL13:_POD The discussion centered on a few questions: 1 - Should (basic) POD be

Re: [Koha-devel] Coding guidelines question

The question is does the following fail too? span style=block title=[% SEARCH_RESULT.biblionumber |url %] class=[% SEARCH_RESULT.normalized_ean || SEARCH_RESULT.normalized_isbn %] id=coce-thumbnail[% loop.count %]/span Yes, it apparently fails too. This is a current limitation of the

Re: [Koha-devel] Coding guidelines question

El Wed Oct 29 2014 at 1:40:34, Mark Tompsett (mtomp...@hotmail.com) escribió: Greetings, span style=block title=[% SEARCH_RESULT.biblionumber |url %] class=[% IF ( SEARCH_RESULT.normalized_ean ) %][% SEARCH_RESULT.normalized_ean %][% ELSE %][% SEARCH_RESULT.normalized_isbn %][% END %]

Re: [Koha-devel] Coding guidelines question

span style=block title=[% SEARCH_RESULT.biblionumber |url %] ...and if you're modifying the markup you're quoting, please remove 'style=block' for something which is actually valid. 'style=display:block' if the inline CSS is really necessary. Or even better set the style in the class. I don't

[Koha-devel] Coding guidelines question

Greetings, span style=block title=[% SEARCH_RESULT.biblionumber |url %] class=[% IF ( SEARCH_RESULT.normalized_ean ) %][% SEARCH_RESULT.normalized_ean %][% ELSE %][% SEARCH_RESULT.normalized_isbn %][% END %] id=coce-thumbnail[% loop.count %]/span This fails to meet coding guidelines

Re: [Koha-devel] Coding guidelines and Plack

Le 23/09/2013 07:40, Marcel de Rooy a écrit : Hi all, Had a discussion with Jonathan on bug 9032 about the use of variables and requirements for Plack. Our coding guidelines do not yet mention Plack. Should we add a PERL rule that prohibits defining lexical variables (my $var) at the

Re: [Koha-devel] Coding guidelines and Plack

Hi, On Sun, Sep 22, 2013 at 10:40 PM, Marcel de Rooy m.de.r...@rijksmuseum.nlwrote: Should we add a PERL rule that prohibits defining lexical variables (my $var) at the outermost block (file level) ? -1 for scripts -- it's not necessary, and doing anything to tempt folks to use 'our'

[Koha-devel] Coding guidelines and Plack

Hi all, Had a discussion with Jonathan on bug 9032 about the use of variables and requirements for Plack. Our coding guidelines do not yet mention Plack. Should we add a PERL rule that prohibits defining lexical variables (my $var) at the outermost block (file level) ? Is it also needed

[Koha-devel] Coding guidelines updated with correct license

Hi, I've updated the license section on the coding guidelines wiki page with the correct text to use in source files, now that Koha's license is the GPL 3 or later: http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence As a general reminder, when creating a new source file, please copy

Re: [Koha-devel] Coding guidelines for command-line scripts

Op 29-08-12 16:14, Owen Leonard schreef: Would everyone agree that new command-line scripts must accept --help (and include relevant help, of course) ? It also should say what it does. Stuff like: $ mcomp --help usage: /usr/bin/mcomp dosfile [cmpoptions] unixfile is bad. Should it also be

[Koha-devel] Coding guidelines for command-line scripts

We have the beginnings of some coding guidelines for command-line scripts, but it doesn't look like they are firm: http://wiki.koha-community.org/wiki/Coding_Guidelines#Command-line_argument_conventions I was testing Bug 8674, Need a delete biblios script

Re: [Koha-devel] Coding guidelines for command-line scripts

Greetings, http://wiki.koha-community.org/wiki/Coding_Guidelines#Command-line_argument_conventions Good start, particularly the reference to the gnu link. [snip] Would everyone agree that new command-line scripts must accept --help (and include relevant help, of course) ? I was thinking

Re: [Koha-devel] Coding guidelines for command-line scripts

Owen, et. al., Would everyone agree that new command-line scripts must accept --help (and include relevant help, of course) ? +1 Should it also be the standard that command-line scripts should not perform any action unless an argument is passed? I like this idea. +1 too Regards, Jared --

Re: [Koha-devel] Coding guidelines for command-line scripts

On 2012-08-30, at 8:14 AM, Chris Cormack wrote: * Galen Charlton (g...@esilibrary.com) wrote: Hi, On 08/29/2012 10:14 AM, Owen Leonard wrote: Would everyone agree that new command-line scripts must accept --help (and include relevant help, of course) ? +1 Should it also be the