[Koha-patches] [PATCH] Fix for Bug 4534, Box for SQL not visible in "Create Report from SQL"

2010-05-20 Thread Owen Leonard
Changed style of SQL box and altered markup for a somewhat cleaner layout --- .../en/modules/reports/guided_reports_start.tmpl | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tmpl b/koha-tmp

[Koha-patches] [PATCH] Fix for Bug 4532, Use include file for bibliodefaultview logic

2010-05-19 Thread Owen Leonard
Note that this new include builds only the first half of the anchor tag (). Because title and subtitle are output differently on some pages, rendering of the second half of the tag is left to individual pages. Includes fixes for staff client templates. Change to basket.pl fixes a bug wherein the

Re: [Koha-patches] [PATCH] Fix for Bug 4529, columns on circ history all screwy

2010-05-19 Thread Owen Leonard
Please ignore, see corrected follow-up. On Wed, May 19, 2010 at 9:43 AM, Owen Leonard wrote: > - fix formatting of last renew date > - Add table zebra striping > - Other markup structure changes > - Revised template assumes that issues.branchcode == checkout library and > display

[Koha-patches] [PATCH] Corrected: Fix for Bug 4529, columns on circ history all screwy

2010-05-19 Thread Owen Leonard
- fix formatting of last renew date - Add table zebra striping - Other markup structure changes - Revised template assumes that issues.branchcode == checkout library and displays that value instead of issues.issuingbranch (which is always empty, see Bug 2806) issues.branchcode seems to reflec

[Koha-patches] [PATCH] Fix for Bug 4529, columns on circ history all screwy

2010-05-19 Thread Owen Leonard
- fix formatting of last renew date - Add table zebra striping - Other markup structure changes - Revised template assumes that issues.branchcode == checkout library and displays that value instead of issues.issuingbranch (which is always empty, see Bug 2806) issues.branchcode seems to reflec

[Koha-patches] [PATCH] Alternate fix for Bug 2981, removing onclick redirect

2010-05-18 Thread Owen Leonard
--- circ/circulation.pl |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/circ/circulation.pl b/circ/circulation.pl index 4b67920..ac00ab0 100755 --- a/circ/circulation.pl +++ b/circ/circulation.pl @@ -524,7 +524,6 @@ if ($borrowerslist) { -id => 'borrowernumb

[Koha-patches] [PATCH] Correct position of non-sorted table column

2010-05-12 Thread Owen Leonard
--- koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tmpl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tmpl b/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tmpl index 1f3f38b..4749985 100644 --- a/koha-tmpl/opac-tmpl/prog/en/

[Koha-patches] [PATCH] Fix for Bug 4485, System preferences page uses non-standard warning style

2010-05-11 Thread Owen Leonard
--- .../prog/en/modules/admin/preferences.tmpl |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tmpl index 832be87..80035bb 100644 --- a/ko

[Koha-patches] [PATCH] A couple of CSS and markup corrections

2010-05-11 Thread Owen Leonard
- moving inline style declaration to the default stylesheet - correcting markup structure on advanced search screen to allow consistent custom styling --- koha-tmpl/opac-tmpl/prog/en/css/opac.css |4 +++- .../opac-tmpl/prog/en/modules/opac-advsearch.tmpl |2 ++ .../opac-tmpl/p

[Koha-patches] [PATCH] Fix for Bug 4475, AmazonLocale not used consistently

2010-05-11 Thread Owen Leonard
--- .../opac-tmpl/prog/en/modules/opac-detail.tmpl |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl index 7f319e0..b1fdf84 100644 --- a/koha-tmpl/opac-tmpl/pr

[Koha-patches] [PATCH] Markup corrections for validity and to eliminate horizontal scrollbar

2010-05-11 Thread Owen Leonard
--- .../prog/en/modules/opac-suggestions.tmpl |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-suggestions.tmpl b/koha-tmpl/opac-tmpl/prog/en/modules/opac-suggestions.tmpl index 27019ea..dfbd432 100644 --- a/koha-tmpl/

[Koha-patches] [PATCH] Fix for Bug 4400, BIBTEX export from OPAC results in empty file

2010-05-11 Thread Owen Leonard
opac-export.pl tries to get two variables from marc2bibtex(), but it only returns one. --- opac/opac-export.pl |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/opac/opac-export.pl b/opac/opac-export.pl index 0e2d94f..4c53aff 100755 --- a/opac/opac-export.pl +++ b/opac/opa

[Koha-patches] [PATCH] Fix template errors introduced in my last patch for Bug 4208

2010-05-11 Thread Owen Leonard
Resubmitting after overlap with another patch --- .../opac-tmpl/prog/en/modules/opac-results.tmpl|2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tmpl b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tmpl index aa9f45

[Koha-patches] [PATCH] Fix for Bug 3666, Overriding renewal limit means negative count in OPAC

2010-05-11 Thread Owen Leonard
Setting "renewalsleft" variable to zero if it comes out negative. --- C4/Circulation.pm |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index bceee8b..395494f 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -2242,6 +2242,7 @@

[Koha-patches] [PATCH] Fix template errors introduced in my last patch for Bug 4208

2010-05-11 Thread Owen Leonard
--- .../opac-tmpl/prog/en/modules/opac-detail.tmpl |1 + .../opac-tmpl/prog/en/modules/opac-results.tmpl|2 +- 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl

[Koha-patches] [PATCH] Further corrections for Bug 4244, Use "checkouts" instead of "issues"

2010-05-05 Thread Owen Leonard
--- .../prog/en/modules/circ/overdue.tmpl |2 +- .../prog/en/modules/reports/issues_avg_stats.tmpl |2 +- .../prog/en/modules/tools/overduerules.tmpl|2 +- .../prog/en/modules/tools/viewlog.tmpl |2 +- 4 files changed, 4 insertions(+), 4 deletions(

[Koha-patches] [PATCH] Further fixes for Bug 4208, Many submit buttons are not translatable in 3.2

2010-05-05 Thread Owen Leonard
Again, not a fix for a submit button problem, but for a problem with TMPL_IFs nested inside tags, a practice which will break the translation script. --- .../opac-tmpl/prog/en/modules/opac-detail.tmpl | 63 --- .../opac-tmpl/prog/en/modules/opac-opensearch.tmpl |7 ++- ..

[Koha-patches] [PATCH] Fix for Bug 4416, renew all and return all buttons too close together

2010-05-05 Thread Owen Leonard
This patch removes the "return all" button altogether. Returning all items is a step which one wouldn't take lightly or even regularly. Since the interface has a means of selecting all checkboxes in the "Check in" column, removing the "Return all" button wouldn't eliminate the means of doing so, it

[Koha-patches] [PATCH] Fix for Bug 2375, Serials holdings data does not display in opac-detail

2010-05-05 Thread Owen Leonard
- Removing markup to display serial data in the holdings table This functionality (if it worked) would seem to duplicate the data displayed under the 'Subscriptions' tab - Revised again to merge item status display changes --- .../opac-tmpl/prog/en/modules/opac-detail.tmpl |5 - 1

[Koha-patches] [PATCH] Fix for Bug 4453, Improve formatting of batch item operations

2010-05-05 Thread Owen Leonard
- includes fix for Bug 4443 - includes some string changes, could resubmit without if these changes block inclusion in 3.2 --- .../prog/en/modules/tools/batchMod-del.tmpl| 53 .../prog/en/modules/tools/batchMod-edit.tmpl | 152 ++-- .../prog/en/modules/t

[Koha-patches] [PATCH] Style changes to cart popup window more compact display: - compact holdings list - adds list bullet image from the staff client

2010-05-04 Thread Owen Leonard
--- koha-tmpl/opac-tmpl/prog/en/css/opac.css |5 ++ .../opac-tmpl/prog/en/modules/opac-basket.tmpl | 40 ++- koha-tmpl/opac-tmpl/prog/images/item-bullet.gif| Bin 0 -> 59 bytes 3 files changed, 26 insertions(+), 19 deletions(-) create mode 100644 koha-tmpl

[Koha-patches] [PATCH] Fix for Bug 2375, Serials holdings data does not display in opac-detail

2010-05-04 Thread Owen Leonard
- Removing markup to display serial data in the holdings table This functionality (if it worked) would seem to duplicate the data displayed under the 'Subscriptions' tab --- .../opac-tmpl/prog/en/modules/opac-detail.tmpl |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff

[Koha-patches] [PATCH] Fix for Bug 4436, reserve should say 'hold'

2010-05-03 Thread Owen Leonard
--- .../prog/en/modules/circ/circulation.tmpl |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tmpl index 7515dee..390c107 100644 --- a/ko

[Koha-patches] [PATCH] Fix for Bug 4409, I18N/L10N tab not highlighted

2010-04-30 Thread Owen Leonard
--- .../intranet-tmpl/prog/en/includes/prefs-menu.inc |2 +- .../en/modules/admin/preferences/i18n-l10n.pref|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/prefs-m

[Koha-patches] [PATCH] Markup corrections to fix for Bug 4248

2010-04-30 Thread Owen Leonard
- Missing "=" in attribute - TMPL_IF nested in HTML tag, which breaks translation script --- .../prog/en/modules/members/memberentrygen.tmpl|9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tmpl b/k

[Koha-patches] [PATCH] Fix for Bug 4424, MARC Framework deletion incorrectly reports usage count

2010-04-29 Thread Owen Leonard
Thanks to Thomas Dukleth for the fix. --- admin/biblio_framework.pl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/admin/biblio_framework.pl b/admin/biblio_framework.pl index f7a7091..f2c147e 100755 --- a/admin/biblio_framework.pl +++ b/admin/biblio_framework.pl @@ -91,7

[Koha-patches] [PATCH] Fix for Bug 4271, Offer choice of destination for save biblio operation

2010-04-29 Thread Owen Leonard
A follow-up to the fix for Bug 4121, the user should be able to control whether the action of saving a bibliographic record takes them to the add item screen or the detail screen, independently of whether they are adding or modifying the record. The addition of a "split button" would leave the def

[Koha-patches] [PATCH] Fix to enable Amazon cover images in the staff client.

2010-04-27 Thread Owen Leonard
Since this fix enables the previously-missing variable 'AmazonEnabled' in Auth.pm, this will also enable other Amazon content in the staff client like Product Descriptions and Amazon Similar Items (See Bug 3863) --- C4/Auth.pm |2 ++ .../prog/en/modules/

[Koha-patches] [PATCH] A fix for Bug 4208, Many submit buttons are not translatable in 3.2

2010-04-22 Thread Owen Leonard
Not a fix for a submit button problem, but for a problem with TMPL_IFs nested inside tags, a practice which will break the translation script. --- .../opac-tmpl/prog/en/modules/opac-detail.tmpl | 14 -- 1 files changed, 12 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/opa

[Koha-patches] [PATCH] Fix for Bug 4302, shouldn't have to scroll left to right on z search results

2010-04-13 Thread Owen Leonard
Adds inline pop-up menu for each row of Z39.50 search results, similar to the one recently added to the additem screen. This allows the user to click anywhere in the row to display the menu and access the preview/import links. --- .../prog/en/includes/cataloging-toolbar.inc|2 +- .../p

[Koha-patches] [PATCH] Fix for Bug 4173, Statuses not appearing in the OPAC

2010-04-13 Thread Owen Leonard
Adds output of "RESTRICTED" authorized value (an item's "Use Restriction" status) --- C4/Items.pm| 25 .../prog/en/modules/catalogue/detail.tmpl |2 + .../opac-tmpl/prog/en/modules/opac-detail.tmpl |2 +- 3 files c

[Koha-patches] Use CSS3 box-shadow property for Cart tooltip (Bug 4387)

2010-04-13 Thread Owen Leonard
tch attached (long lines) From 9ed6f0eae3dbe34b13519374157898c81a5b4673 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Thu, 25 Feb 2010 09:43:15 -0500 Subject: [PATCH] Use CSS3 box-shadow property for Cart tooltip The OPAC Cart tooltip ("Your cart is empty," "1 item(s) added to

Re: [Koha-patches] [PATCH 19/55] (bug #4018) fix coins support in opac detail and xslt

2010-03-11 Thread Owen Leonard
>  .../opac-tmpl/prog/en/modules/opac-detail.tmpl     |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) ... > -     > +     >         This change wouldn't affect coins support, it would tie the XSLT display on the OPAC to the system preference which controls the XSLT display in the st

[Koha-patches] [PATCH] Improve display of information on Transfers to your library report

2010-03-11 Thread Owen Leonard
- Use GetRecordValue() to show subtitle - Show author - Separate branch and call number display for better sorting - Correct teriminology (reserve -> hold) --- circ/transferstoreceive.pl |5 - .../prog/en/modules/circ/transferstoreceive.tmpl | 20 +++

[Koha-patches] [PATCH] Fix for Bug 4301, OPAC RSS feed link doesn't include sort parameter

2010-03-10 Thread Owen Leonard
--- koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc |2 +- .../opac-tmpl/prog/en/modules/opac-results.tmpl|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc inde

Re: [Koha-patches] [PATCH 5/6] [MT2779] Display ccode, stocknumber and barcode in member checkouts

2010-03-09 Thread Owen Leonard
What is stocknumber? Keep in mind there was a bug filed at one time asking that moremember.pl and circulation.pl be made alike so that they displayed similar information in the list of checkouts and holds. In the case of additions we'll need to: 1. Make sure the addition is strictly necessary (to

[Koha-patches] [PATCH] Fix for Bug 4296, label search printing titles between buttons

2010-03-09 Thread Owen Leonard
- Reformating display for readability - Converting select/clear all buttons to links to match existing patterns - Fixing "Results x of x" display which was broken for single-page sets --- .../prog/en/modules/labels/result.tmpl | 39 +++- 1 files changed, 14 insertions

[Koha-patches] [PATCH] Fix for Bug 4262, changing matching rule add big message box

2010-03-02 Thread Owen Leonard
Fix includes a change to the format of the page to consolidate matching rule settings with matching rule controls. This reduces potential confusion from the placement of the message box. Assuming that matching rule settings and controls were displayed separately for clarity and control, I've added

[Koha-patches] [PATCH] Fix for Bug 4214, "Your Cart is Currently Empty" popup displays underneath News header

2010-02-24 Thread Owen Leonard
--- .../intranet-tmpl/prog/en/css/staff-global.css |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css index 190c9da..cf72ba8 100644 --- a/koha-tmpl/intranet-tmpl/p

[Koha-patches] [PATCH] Fix for Bug 4250, cart missing print button

2010-02-24 Thread Owen Leonard
- Print button was hidden by CSS for some reason (git blame me) - Print formatting was off because of column mismatch - Table style modified in print view for clarity - Redirect from print view corrected by adding missing bib_list and verbose parameters --- koha-tmpl/opac-tmpl/prog/en/css/opac.c

[Koha-patches] [PATCH] Fix for Bug 4251 in the staff client

2010-02-24 Thread Owen Leonard
--- .../intranet-tmpl/prog/en/includes/facets.inc |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc index 6855411..ff67047 100644 --- a/koha-tmpl/intranet-tmp

[Koha-patches] [PATCH] Fix for Bug 4251, click on show more in facet drops limit=branch in query

2010-02-24 Thread Owen Leonard
--- .../opac-tmpl/prog/en/includes/opac-facets.inc |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc b/koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc index aba1e3b..e272906 100644 --- a/koha-tmpl/opac-tmpl/prog

[Koha-patches] [PATCH] Fix for Bug 4167, Tag link styled incorrectly on Cart popup

2010-02-23 Thread Owen Leonard
- Removing DOM creation of tag and hold links: if the Cart is working, the user must have JavaScript enabled. Therefore we can assume tagging and holds will work - Conditionally displaying some JavaScript based on whether tagging or placing holds is allowed --- .../opac-tmpl/prog/en/modules/

[Koha-patches] [PATCH] Fix for Bug 4244, Use "checkouts" instead of "issues"

2010-02-23 Thread Owen Leonard
--- .../prog/en/modules/members/member.tmpl|2 +- .../prog/en/modules/reports/bor_issues_top.tmpl|2 +- .../prog/en/modules/reports/borrowers_out.tmpl |2 +- koha-tmpl/opac-tmpl/prog/en/modules/sco/help.tmpl |2 +- .../opac-tmpl/prog/en/modules/sco/receipt.tmpl

[Koha-patches] [PATCH] Fix for Bug 4235, Date picker broken if placing multiple holds

2010-02-22 Thread Owen Leonard
Also includes minor style change. --- .../opac-tmpl/prog/en/modules/opac-reserve.tmpl| 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tmpl b/koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tmpl index 4e9b022..

[Koha-patches] [PATCH] Removing bogus style declaration

2010-02-19 Thread Owen Leonard
--- .../prog/en/modules/circ/returns.tmpl |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tmpl index 644f4af..fef7c57 100644 --- a/koha-tmpl/int

[Koha-patches] [PATCH] Fix for Bug 4219, strange artifacts showing on lists in the staff client

2010-02-18 Thread Owen Leonard
Recent change to C4/VirtualShelves/Page.pm caused display of subtitles to break in the staff client display of lists --- .../prog/en/modules/virtualshelves/shelves.tmpl|2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshel

[Koha-patches] [PATCH] Changes to further work on Bug 3550, Use GetRecordValue to get the subtitle

2010-02-12 Thread Owen Leonard
- Adding subtitle display to OPAC Cart, lists, and reading record - Minor tweaks to some displays --- C4/VirtualShelves/Page.pm | 12 ++-- .../prog/en/modules/catalogue/detail.tmpl |4 ++-- .../opac-tmpl/prog/en/modules/opac-basket.tmpl |6 ++

[Koha-patches] [PATCH] Perltidy of C4/VirtualShelves/Page.pm

2010-02-11 Thread Owen Leonard
--- C4/VirtualShelves/Page.pm | 619 +++-- 1 files changed, 316 insertions(+), 303 deletions(-) diff --git a/C4/VirtualShelves/Page.pm b/C4/VirtualShelves/Page.pm index 658b9ac..14f9816 100644 --- a/C4/VirtualShelves/Page.pm +++ b/C4/VirtualShelves/Page.pm

[Koha-patches] [PATCH] Fix for Bug 2970, Create a permission for modifying holds priority

2010-02-10 Thread Owen Leonard
Adding two new granular permissions under 'reserveforothers,' place_holds and modify_holds_priority. If a user does not have modify_holds_priority permission, the option to change the priority of a hold is hidden. Revised patch includes changes to mandatory data files including properly translated

[Koha-patches] [PATCH] Fix for Bug 2970, Create a permission for modifying holds priority

2010-02-10 Thread Owen Leonard
Adding two new granular permissions under 'reserveforothers,' place_holds and modify_holds_priority. If a user does not have modify_holds_priority permission, the option to change the priority of a hold is hidden. --- installer/data/mysql/updatedatabase.pl | 13 + .../pro

[Koha-patches] [PATCH] Reformat Keyword to MARC mapping interface according to existing patterns

2010-02-10 Thread Owen Leonard
--- .../prog/en/modules/admin/fieldmapping.tmpl| 58 1 files changed, 34 insertions(+), 24 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/fieldmapping.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/fieldmapping.tmpl index fc9b2e3..378

[Koha-patches] [PATCH] Additional changes to fix Bug 3920, XSLTdetailDisplay syspref controls both OPAC and Intranet

2010-02-10 Thread Owen Leonard
This patch adds XSLTDetailsDisplay and XSLTResultsDisplay variables for the staff client, OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay variables to the OPAC. Note that the XSLTResultsDisplay doesn't actually do anything because no one has added an XSLT version of search results to the staff cl

Re: [Koha-patches] [PATCH] Bugfix: Enabling guide box configuration parameter

2010-02-08 Thread Owen Leonard
> This is invalid. It needs to be -- Owen -- Web Developer Athens County Public Libraries http://www.myacpl.org ___ Koha-patches mailing list Koha-patches@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-patches

[Koha-patches] [PATCH] Fix for Bug 4138, Adding or deleting suggestions in the OPAC does not properly refresh the page

2010-02-08 Thread Owen Leonard
- Using redirect() and adding URL parameter to enable the display of messages on the screen confirming the action. - Also correcting for JavaScript error in form validation routine. --- .../prog/en/modules/opac-suggestions.tmpl |6 +- opac/opac-suggestions.pl

[Koha-patches] [PATCH] Fix for Bug 4093, OPAC Suggestions List has extra column

2010-02-08 Thread Owen Leonard
- This code was added to opac-suggestions.pl at one point by Garry Collum and was subsequently removed. Adding it back. --- opac/opac-suggestions.pl |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/opac/opac-suggestions.pl b/opac/opac-suggestions.pl index 12eea5f.

Re: [Koha-patches] [PATCH] Fix for Bug 2869, 'do not delete' marc framework tag - reverts to 'default' framework

2010-02-08 Thread Owen Leonard
On Thu, Dec 24, 2009 at 9:35 PM, Owen Leonard wrote: > - "Do not delete" form was missing hidden framework code input. > - Also added details to breadcrumb navigation > --- >  .../prog/en/modules/admin/marctagstructure.tmpl    |    4 +++- >  1 files changed, 3 insertions

[Koha-patches] [PATCH] Fix for Bug 4136, Invalid XHTML in spinelabel-print view

2010-02-08 Thread Owen Leonard
--- .../prog/en/modules/labels/spinelabel-print.tmpl | 31 --- 1 files changed, 19 insertions(+), 12 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tmpl index 15

[Koha-patches] [PATCH] Markup error, closing tag missing

2010-02-08 Thread Owen Leonard
--- .../prog/en/modules/catalogue/detail.tmpl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tmpl index c9c1e97..0f6dac9 100644 --- a/koha-t

Re: [Koha-patches] [PATCH] Bug 3663 screen changes to OPAC advanced search

2010-02-06 Thread Owen Leonard
This looks like the patch referred to as the solution to Bug 3663: http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3663 -- Owen ___ Koha-patches mailing list Koha-patches@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-patches

[Koha-patches] [PATCH] Fix for Bug 4113, Failed renewal from circulation screen results in malformed table

2010-02-05 Thread Owen Leonard
Renewal failure message should appear in renewal checkbox column just like it does in moremember.tmpl --- .../prog/en/modules/circ/circulation.tmpl | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circ

[Koha-patches] [PATCH] Fix for Bug 4121, Cataloging record modification should obey IntranetBiblioDefaultView pref

2010-02-05 Thread Owen Leonard
- Re-used redirect logic found in search.pl --- cataloguing/addbiblio.pl | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl index 3828950..4832584 100755 --- a/cataloguing/addbiblio.pl +++ b/cataloguing/addbibl

[Koha-patches] [PATCH] Fix for Bug 2375, Serials holdings data does not display in opac-detail

2010-02-05 Thread Owen Leonard
- Removing markup to display serial data in the holdings table This functionality (if it worked) would seem to duplicate the data displayed under the 'Subscriptions' tab --- .../opac-tmpl/prog/en/modules/opac-detail.tmpl |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff

Re: [Koha-patches] [PATCH] Bug 3691: Invalid XHTML in about.tmpl

2010-02-04 Thread Owen Leonard
On Sat, Oct 3, 2009 at 1:11 PM, Garry Collum wrote: > Fixes several missing closing html tags. > --- >  koha-tmpl/intranet-tmpl/prog/en/modules/about.tmpl |    5 +++-- >  1 files changed, 3 insertions(+), 2 deletions(-) This patch never made it into HEAD but still applies cleanly. Please approve!

[Koha-patches] [PATCH] Style correction

2010-02-04 Thread Owen Leonard
- Use for warnings, not "dialog error" --- .../prog/en/modules/circ/returns.tmpl | 38 ++-- 1 files changed, 19 insertions(+), 19 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/ret

[Koha-patches] [PATCH] Fixes for Bug 2600, HTML tags in titles not escaped in many places

2010-02-03 Thread Owen Leonard
--- .../prog/en/modules/catalogue/MARCdetail.tmpl | 30 ++-- .../prog/en/modules/catalogue/results.tmpl | 42 .../prog/en/modules/reserve/request.tmpl | 50 ++-- .../prog/en/modules/opac-addbybiblionumber.tmpl|4 +- .../

[Koha-patches] [PATCH] Fix for Bug 4086, categorycode on patron search confusing

2010-02-03 Thread Owen Leonard
- Changed 'categorycode' to 'category' - Formatted additional options to be more compact - Returning patron search page to wide layout following removal of patron filter from the sidebar - Corrected some other markup that was causing validation errors --- .../prog/en/includes/patron-search.inc

[Koha-patches] [PATCH] Fixes for Bug 3089, Date entry fields should indicate required date format

2010-02-03 Thread Owen Leonard
- Added include, date-format.inc, which shows format, e.g. "(DD/MM/)" - Hint shows expected date format based on system preference - Removing calendar.inc include from templates which don't use it --- .../intranet-tmpl/prog/en/css/staff-global.css |6 ++- .../intranet-tmpl/prog/en/incl

[Koha-patches] [PATCH] Fix for Bug 4092, suggestion date missing from manage suggestions

2010-02-02 Thread Owen Leonard
Date was missing because of incorrect variable name in opac-suggestions.pl Thanks to HDL for the fix. --- .../prog/en/modules/suggestion/suggestion.tmpl | 24 ++-- opac/opac-suggestions.pl | 10 2 files changed, 17 insertions(+), 17 deleti

[Koha-patches] [PATCH] Fix for Bug 4097, Problems with print stylesheet and add item screen

2010-02-02 Thread Owen Leonard
- consolidating some details in print.css - moving overflow:scroll from additem.tmpl to staff-global.css - overriding overflow:scroll in print.css --- koha-tmpl/intranet-tmpl/prog/en/css/print.css | 23 ++- .../intranet-tmpl/prog/en/css/staff-global.css |3 + .../prog/en/mod

[Koha-patches] [PATCH] Fix for Bug 4089, tools menu floating to bottom of CSV Profiles, and others

2010-02-02 Thread Owen Leonard
- Moving nested TMPL_IFs out of tags (breaks translator) - Fixing markup to match conventions for form structure - Removing duplicate form fields (bad merge?) --- .../prog/en/modules/tools/csv-profiles.tmpl| 337 ++-- 1 files changed, 175 insertions(+), 162 deletions(-)

[Koha-patches] [PATCH] Adding missing images for collapsible syspref sections

2010-01-29 Thread Owen Leonard
--- .../intranet-tmpl/prog/en/css/preferences.css |4 +++- koha-tmpl/intranet-tmpl/prog/img/collapse.gif | Bin 0 -> 57 bytes koha-tmpl/intranet-tmpl/prog/img/expand.gif| Bin 0 -> 57 bytes 3 files changed, 3 insertions(+), 1 deletions(-) create mode 100644 koha-tmpl/intra

[Koha-patches] [PATCH] Fix for Bug 4080, OPAC hold screen doesn't obey OPACDisplayRequestPriority pref

2010-01-29 Thread Owen Leonard
--- .../opac-tmpl/prog/en/modules/opac-reserve.tmpl| 12 +++- opac/opac-reserve.pl | 20 ++-- 2 files changed, 17 insertions(+), 15 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tmpl b/koha-tmpl/opac-tmpl/

[Koha-patches] [PATCH] Markup and formatting corrections.

2010-01-29 Thread Owen Leonard
- XHTML validity - Can't nest TMPL_IF inside --breaks translator --- .../prog/en/modules/admin/currency.tmpl| 25 +++ 1 files changed, 14 insertions(+), 11 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tmpl b/koha-tmpl/intranet-tmp

[Koha-patches] [PATCH] Fix for Bug 3970, Warn user when there is no active currency

2010-01-29 Thread Owen Leonard
- Adds warning to budget admin pages - Adds warning to currency admin page --- admin/currency.pl |9 +++-- .../prog/en/modules/admin/aqbudgetperiods.tmpl |2 +- .../prog/en/modules/admin/aqbudgets.tmpl |8 +--- .../prog/en/modules/

[Koha-patches] [PATCH] Fix for Bug 4073, Add globally template variable for dateformat setting

2010-01-28 Thread Owen Leonard
--- C4/Auth.pm | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/C4/Auth.pm b/C4/Auth.pm index f0be27c..206231d 100755 --- a/C4/Auth.pm +++ b/C4/Auth.pm @@ -323,6 +323,18 @@ sub get_template_and_user { } } +if(C4::Context->preference('da

[Koha-patches] [PATCH] Fix for Bug 3838, Download List Pop Up Needs Margins

2010-01-27 Thread Owen Leonard
--- .../prog/en/modules/basket/downloadcart.tmpl | 26 --- .../en/modules/virtualshelves/downloadshelf.tmpl | 21 +++ .../prog/en/modules/opac-downloadcart.tmpl | 21 +--- 3 files changed, 38 insertions(+), 30 deletions(-) diff --git a

[Koha-patches] [PATCH] Change to correct layout problem when OpacNav is empty.

2010-01-27 Thread Owen Leonard
--- .../prog/en/modules/opac-full-serial-issues.tmpl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-full-serial-issues.tmpl b/koha-tmpl/opac-tmpl/prog/en/modules/opac-full-serial-issues.tmpl index 9b1480b..9995cc5 100644 --- a/

[Koha-patches] [biblibre/3.2_community] Fix for Bug 4065, patron extended attributes error

2010-01-26 Thread Owen Leonard
--- .../prog/en/modules/members/memberentrygen.tmpl|5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tmpl index e56ec0b..63d9c45 100

[Koha-patches] [biblibre/3.2_commu$] Fix for Bug 4061, Improve OPAC maintenance screen

2010-01-26 Thread Owen Leonard
--- .../opac-tmpl/prog/en/modules/maintenance.tmpl | 29 ++- 1 files changed, 21 insertions(+), 8 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/maintenance.tmpl b/koha-tmpl/opac-tmpl/prog/en/modules/maintenance.tmpl index f3854e4..4060e07 100644 --- a/koha-t

[Koha-patches] [biblibre/3.2_commu$] Fixes for Bug 3943, Show add to cart link when lists off in the OPAC

2010-01-26 Thread Owen Leonard
- Also adds some missing conditionals for including javascript - Also Removes an instance of TMPL_IF EXPR --- koha-tmpl/opac-tmpl/prog/en/css/opac.css | 12 + .../opac-tmpl/prog/en/modules/opac-results.tmpl| 49 2 files changed, 51 insertions(+), 10 delet

[Koha-patches] [biblibre/3.2_community] Some new and altered itemtype images for the NPL set

2010-01-25 Thread Owen Leonard
--- .../npl/Adult-nonfiction-book-on-cassette.gif | Bin 0 -> 306 bytes .../itemtypeimg/npl/DVD-Juvenile-nonfiction.gif| Bin 0 -> 337 bytes .../prog/itemtypeimg/npl/DVD-Juvenile.gif | Bin 0 -> 337 bytes .../prog/itemtypeimg/npl/DVD-nonfiction.gif| Bin 0 -> 336 bytes

[Koha-patches] [biblibre/3.2_community] Fix for Bug 4058, opac-auth.tmpl body id causes layout problems

2010-01-25 Thread Owen Leonard
--- koha-tmpl/opac-tmpl/prog/en/modules/opac-auth.tmpl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-auth.tmpl b/koha-tmpl/opac-tmpl/prog/en/modules/opac-auth.tmpl index f598c20..1567450 100644 --- a/koha-tmpl/opac-tmpl/prog/en/

[Koha-patches] [biblibre/3.2_community] Removing obsolete help files (Bug 4059)

2010-01-25 Thread Owen Leonard
--- .../prog/en/modules/help/bull-home.tmpl| 12 --- .../prog/en/modules/help/bull/bull-home.tmpl |8 - .../prog/en/modules/help/bull/statecollection.tmpl | 29 -- .../en/modules/help/bull/subscription-add.tmpl | 32 .../

[Koha-patches] [biblibre/3.2_community] Fixes for Bug 3958, Standardize vendor/supplier/bookseller terminology

2010-01-25 Thread Owen Leonard
Changing instances of "supplier" or "bookseller" to "vendor." --- .../prog/en/modules/acqui/addorderiso2709.tmpl |6 +++--- .../prog/en/modules/acqui/basket.tmpl |4 ++-- .../prog/en/modules/acqui/basketgroup.tmpl |8 .../prog/en/modules/acqui/baskethe

[Koha-patches] [biblibre/3.2_community] Fix for Bug 3984, Confusing note on transfers to receive

2010-01-25 Thread Owen Leonard
- Changing 'check this transfer' message to more informative 'Transfer is XX days late' - Adding note in the case of late transfers: 'Transfers are considered late after XX [TransfersMaxDaysWarning] days.' --- circ/transferstoreceive.pl | 10 -- .../prog/e

[Koha-patches] [biblibre/3.2_community] Improve behavior of manual history checkbox behavior.

2010-01-21 Thread Owen Leonard
--- .../prog/en/modules/serials/subscription-add.tmpl | 15 +++ 1 files changed, 11 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tmpl index f8cad

[Koha-patches] [biblibre/3.2_community] Fix for Bug 3908, Edit subscription page shows manual history block by default

2010-01-21 Thread Owen Leonard
Changing template check for "history" var to check for "manualhistory." --- .../prog/en/modules/serials/subscription-add.tmpl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tmpl b/koha-tmpl/intranet-tmpl

[Koha-patches] [biblibre/3.2_community] Revised for biblibre/3.2_community: Fix for Bug 3939, Issuing rules clone button looks like a submit

2010-01-21 Thread Owen Leonard
This patch incorporates a drop-down for choosing the "clone to" library directly from issuing-rules.pl. This eliminates the extra step of choosing the library after submitting the "clone" action and clarifies the purpose of the two different controls. --- .../prog/en/modules/admin/smart-rules.tmpl

[Koha-patches] [biblibre/3.2_community] Revised for biblibre/3.2_community: Reformat of suggestions management interface (Bug 3844)

2010-01-20 Thread Owen Leonard
Changes and fixes include: - Moving filters forms into left-hand sidebar - Making filter forms collapsed by default (click to show) - Converting "check all" to text link to match similar controls on other pages - Correcting case of tab labels - Fixing display of custom reason field - Converting ra

[Koha-patches] [biblibre/3.2_community] Revised for biblibre/3.2_community: Fix for Bug 3780, various OPAC pages have no unique id

2010-01-20 Thread Owen Leonard
--- .../opac-tmpl/prog/en/modules/opac-ISBDdetail.tmpl |2 +- .../opac-tmpl/prog/en/modules/opac-MARCdetail.tmpl |2 +- .../prog/en/modules/opac-alert-subscribe.tmpl |2 +- koha-tmpl/opac-tmpl/prog/en/modules/opac-auth.tmpl |2 +- .../prog/en/modules/opac-authorities-home.tmpl

[Koha-patches] [biblibre/3.2_community] Revised for biblibre/3.2_community: Putting CSV export sections into tabs

2010-01-20 Thread Owen Leonard
--- .../prog/en/modules/tools/csv-profiles.tmpl| 73 +++ 1 files changed, 42 insertions(+), 31 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/csv-profiles.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/csv-profiles.tmpl index 2b10860..e84f

[Koha-patches] [biblibre/3.2_community] Fix for Bugs 3998, 3968. Includes other markup corrections and reformats

2010-01-20 Thread Owen Leonard
Bug 3998: Confusing warning on budget add page Bug 3968: Empty Blue Box Pop Up - Removed warning, made budget amount a required field. - Added conditional logic to prevent display of tooltip when there is no content - Moved filter form into sidebar - Changed Budgets.pm to pass an ID to a form fiel

[Koha-patches] [biblibre/3.2_community] Markup tweaks to better style the patron search filter

2010-01-20 Thread Owen Leonard
--- .../prog/en/modules/members/member.tmpl|2 +- .../prog/en/modules/members/search.tmpl| 20 +--- 2 files changed, 10 insertions(+), 12 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tmpl b/koha-tmpl/intranet-tmpl/

Re: [Koha-patches] [biblibre/3.2_community] Fixes for Bug 3376, Serials Display in OPAC

2010-01-19 Thread Owen Leonard
This patch is an update to a previously-sent patch for HEAD, now built against biblibre/3.2_community. -- Owen -- Web Developer Athens County Public Libraries http://www.myacpl.org ___ Koha-patches mailing list Koha-patches@lists.koha.org http://list

[Koha-patches] [biblibre/3.2_community] Fixes for Bug 3376, Serials Display in OPAC

2010-01-19 Thread Owen Leonard
- Formatting links to different subscription views as tabs like the links to MARC view, ISBD, etc. - Styling display of brief subscription view for better clarity - Moving filter form on full subscription view to sidebar - jQuery-fying some full subscription view scripts - Adding branch name to ou

[Koha-patches] [biblibre/3.2_community] Fix for Bug 3951, Menu a mess in WebKit browsers

2010-01-19 Thread Owen Leonard
- removing inline image in favor of CSS background (inline image is used in the OPAC to better work with cart button css - adding "display:none" to "more" menu. "visibility:hidden" by itself creates unwanted whitespace in WebKit browsers - adding explicit width to toplevelmenu to correct displa

Re: [Koha-patches] [PATCH] Bugfix: Adding missing package to Makefile.PL

2010-01-15 Thread Owen Leonard
Chris Cormack submitted a similar patch recently. I think it must be still lost in the pile of pending patches. -- Owen -- Web Developer Athens County Public Libraries http://www.myacpl.org ___ Koha-patches mailing list Koha-patches@lists.koha.org ht

[Koha-patches] [PATCH] Fix for Bug 4035: Today's checkouts grouped with previous checkouts

2010-01-12 Thread Owen Leonard
Creating separate variable to be output to the template so that the original issuedate can be used in date comparison. --- circ/circulation.pl|2 +- .../prog/en/modules/circ/circulation.tmpl |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) d

[Koha-patches] [PATCH] Adding inline edit links for additem table. Suggested for Bug 2534

2010-01-07 Thread Owen Leonard
--- koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css |5 + .../prog/en/modules/cataloguing/additem.tmpl | 15 +-- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css b/koha-tmpl/intranet-tmpl/prog/en/css/a

  1   2   3   4   5   >