Re: [Koha-patches] [PATCH] Bugfix bug #2630

2008-10-01 Thread Frédéric DEMIANS
Hi Galen, Did you get my second patch? Will you apply it? Without this patch Amazon book cover functionality doesn't work with UNIMARC DB. Thanks. -- Frédéric DEMIANS http://www.tamil.fr/u/fdemians.html ___ Koha-patches mailing list Koha-patches

Re: [Koha-patches] [PATCH] OPAC new subjects cloud using Zebra scan on Subject field (3rd patch)

2008-10-08 Thread Frédéric DEMIANS
Any feedback on this? Thanks. -- Frédéric DEMIANS http://www.tamil.fr/u/fdemians.html ___ Koha-patches mailing list Koha-patches@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-patches

Re: [Koha-patches] [PATCH] bug 3034: Tag multiple items at once.

2009-03-13 Thread Frédéric DEMIANS
branch for me. Cool feature I'd like to see! -- Frédéric DEMIANS http://www.tamil.fr/u/fdemians.html ___ Koha-patches mailing list Koha-patches@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-patches

[Koha-patches] [PATCH] Add Babeltheque OPAC enhanced content

2009-03-20 Thread Frédéric Demians
www.babeltheque.com is LibraryThings for Libraries equivalent. This patch enables this service on OPAC. --- admin/systempreferences.pl |1 + installer/data/mysql/en/mandatory/sysprefs.sql |1 + .../1-Obligatoire/unimarc_standard_systemprefs.sql |1 +

[Koha-patches] [PATCH 2/2] Add a UNIMARC to Dublin Core XSL

2009-03-26 Thread Frédéric Demians
This XSL transforms XML UNIMARC biblio record into its DC representation. It is the equivalent of MARC21slimOAIDC.xsl. --- .../prog/en/xslt/UNIMARCslim2OAIDC.xsl | 185 1 files changed, 185 insertions(+), 0 deletions(-) create mode 100644

[Koha-patches] [PATCH 1/2] Add another OAI server

2009-03-26 Thread Frédéric Demians
From: Frederic Demians f.demi...@tamil.fr This OAI server has those characteristics: * It doesn't use C4::OAI anymore. * It uses HTTP::OAI library which is easily expandable. * XML result is not build anymore directly but using XML::SAX::Writer. It should solve encoding and XML

[Koha-patches] [PATCH] Add Babeltheque OPAC enhanced content

2009-03-28 Thread Frédéric Demians
www.babeltheque.com is a LibraryThings for Libraries equivalent. This patch enables this service on OPAC. * Replace previous patch in order to apply onto last master HEAD and solve conflicts induced by last pushed pateches: 1bb9f76e66fd962930007964a2f918665dc3a956 * Modify

[Koha-patches] [PATCH] Bug #3071 - Z39.50 search result highlights are mixed

2009-03-29 Thread Frédéric Demians
This patch modifies z3950 search result page in order to use jquery to highlight rows rather than an explicit css class. --- cataloguing/z3950_search.pl|4 ++-- .../prog/en/modules/cataloguing/z3950_search.tmpl |5 +++-- 2 files changed, 5 insertions(+), 4

[Koha-patches] [PATCH 1/2] Fix Amazon cover for UNIMARC

2009-03-30 Thread Frédéric Demians
In UNIMARC, 010 tag contains ISBN. In UNIMARC, ISBN with '-' are valid. This patch modify ISBN normalization in order to automaticaly suppress '-' before sending ISBN to Amazon to get book cover. --- C4/Koha.pm |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/C4/Koha.pm

[Koha-patches] [PATCH 2/2] Internationalize Amazon support

2009-03-30 Thread Frédéric Demians
Without this patch: * On OPAC detail page, Amazon book cover has a banner 'Search Inside' which in untranslatable. * Link on book cover search inside book content in Amazon.com--.com not .fr or .co.uk depending on AmazonLocale syspref. With this patch: * Modfiy book cover

[Koha-patches] [PATCH] Internationalize Amazon support

2009-04-01 Thread Frédéric Demians
With this patch: * On Amazon book cover, 'search inside' text is not displayed anymore because it's not translatable. * Link the image to local Amazon web site 'search inside' service. Based on AmazonLocale syspref. --- C4/External/Amazon.pm | 30

[Koha-patches] [PATCH] Bug #3087 - Improve z39.50 server Unimarc support

2009-04-03 Thread Frédéric Demians
With this patch, it's possible to configure Zebra server in order to return biblio records with a consistent Unimarc 'format'. Some improvements are still required: * Koha installation program need to be modified to pick up koha-conf-unimarc.xml in place of koha-conf.xml. * XSL file

[Koha-patches] [PATCH 1/2] Bugfix #3155 Disabling Amazon Reviews

2009-04-23 Thread Frédéric Demians
Disable Amazon reviews without disabling Amazon book cover. --- .../opac-tmpl/prog/en/modules/opac-detail.tmpl |6 +- opac/opac-detail.pl|1 + 2 files changed, 6 insertions(+), 1 deletions(-) diff --git

[Koha-patches] [PATCH 2/2] DB rev 020 - 021: OPACAmazonReviews syspref

2009-04-23 Thread Frédéric Demians
Add new OPACAmzonReviews syspref --- installer/data/mysql/en/mandatory/sysprefs.sql |1 + .../1-Obligatoire/unimarc_standard_systemprefs.sql |3 ++- installer/data/mysql/updatedatabase.pl |7 +++ kohaversion.pl |2 +- 4 files

Re: [Koha-patches] [PATCH] Bugfix #2920 AmazonSimilarItems OPACAmazonSimilarItems

2009-04-24 Thread Frédéric DEMIANS
. ItemAttributes is not used anywhere. Correct me if I'm wrong. So 3 Amazon contents, server-side retrieved, must be selectable by syspref, combining (OPACAmazonEnabled or AmazonEnabled) and: * OPACAmazonSimilarItems - Similarities * OPACAmzonReviews - EditorialReviews and Reviews -- Frédéric

[Koha-patches] [PATCH] Bugfix #2920 Avoid doing unecessary calls to Amazon Web Services

2009-04-25 Thread Frédéric Demians
This patch modifies how AWS is called. AWS is now called depending on syspref. It works completly for OPAC; it has to be refined for intranet. For OPAC: * If OPACAmazonReviews is set, AWS EditorialReview and Reviews (users) are grabed. * If OPACAmazonSimilarItems is set, AWS Similarities

[Koha-patches] [PATCH 2/2] Bug 2920 DB Rev 028 AmazonReviews syspref

2009-04-26 Thread Frédéric Demians
Add AmazonReviews syspref. DOCUMENTATION: AmazonReviews is OPACAmazonReviews counterpart, except that in staff interface Editorial Review is displayed alone, without reader reviews. --- installer/data/mysql/en/mandatory/sysprefs.sql |1 +

[Koha-patches] [PATCH] Bug 2920 DB Rev 028 AmazonReviews syspref

2009-04-26 Thread Frédéric Demians
Add AmazonReviews syspref. DOCUMENTATION: AmazonReviews is OPACAmazonReviews counterpart, except that in staff interface Editorial Review is displayed alone, without reader reviews. --- installer/data/mysql/en/mandatory/sysprefs.sql |1 +

[Koha-patches] [PATCH] Bug 2920 Fixes Amazon content use in pro interface

2009-04-26 Thread Frédéric Demians
This patch fixes Amazon content use in pro interface : * Control Amazon Editorial Review by a new syspref: AmazonReviews. * /catalogue/detail.tmpl doesn't display Amazon reader reviews. It displays only Editorial review in Description tab. This patch disable request for AWS reader reviews.

Re: [Koha-patches] [PATCH] Bug 2920 DB Rev 028 AmazonReviews syspref

2009-04-27 Thread Frédéric DEMIANS
staff not publisher reviews which is available on Amazon web site. -- Frédéric DEMIANS http://www.tamil.fr/u/fdemians.html ___ Koha-patches mailing list Koha-patches@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-patches

[Koha-patches] [PATCH] Bug 2920 Display AmazonReviews syspref in the enhanced content category

2009-04-27 Thread Frédéric Demians
--- admin/systempreferences.pl |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/admin/systempreferences.pl b/admin/systempreferences.pl index aa5cb5c..1c6ed74 100755 --- a/admin/systempreferences.pl +++ b/admin/systempreferences.pl @@ -226,6 +226,7 @@

[Koha-patches] [PATCH] Bugfix 3176 - Browser selected languages are not use by OPAC

2009-04-30 Thread Frédéric Demians
This patch uses HTTP_ACCEPT_LANGUAGE web browser variable to select OPAC available language. --- C4/Languages.pm | 10 +- C4/Output.pm| 11 --- 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/C4/Languages.pm b/C4/Languages.pm index 5795202..a082b1f 100644

[Koha-patches] [PATCH] Bugfix 3199 - batchRebuildBiblioTables.pl failed due to missing argument [3.0.x]

2009-05-07 Thread Frédéric Demians
Thanks G. Henry --- misc/batchRebuildBiblioTables.pl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/misc/batchRebuildBiblioTables.pl b/misc/batchRebuildBiblioTables.pl index e513550..15873e2 100755 --- a/misc/batchRebuildBiblioTables.pl +++

[Koha-patches] [PATCH] Optimize XSLT.pm

2009-05-07 Thread Frédéric Demians
Avoid reading marc_tag_structure for each biblo record to transform by XSLT. Not totaly useless on OPAC result page. Should be done via application variables rather than request variable, but this is another story. --- C4/XSLT.pm | 25 ++--- 1 files changed, 18

[Koha-patches] [PATCH] Bugfix 3205 - Fix OAI server resonse to Identify request

2009-05-08 Thread Frédéric Demians
--- opac/oai.pl |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/opac/oai.pl b/opac/oai.pl index 37b9f6f..d1fa059 100755 --- a/opac/oai.pl +++ b/opac/oai.pl @@ -123,6 +123,7 @@ sub new { MaxCount= C4::Context-preference(OAI-PMH:MaxCount),

[Koha-patches] [PATCH 1/2] Bug 3213 - UNIMARC/MARC21 selection

2009-05-11 Thread Frédéric Demians
Modify how XSLT stylesheet are choosen depending on 'marcflavour' syspref. DOCUMENTATION: XSLTResultsDisplay and XSLTDetailsDisplay sysprefs aren't MARC21-only anymore. --- C4/Search.pm|4 ++-- C4/XSLT.pm |9 ++--- opac/opac-detail.pl |4 ++-- 3 files changed, 10

[Koha-patches] [PATCH 2/2] Bug 3213 - Add UNIMARC XSLT stylesheet

2009-05-11 Thread Frédéric Demians
With those stylesheets result and detail pages render better UNIMARC biblio record than normal views. But works still have to be done in order to reach UNIMARC-ISBD compliant display. --- .../prog/en/xslt/UNIMARCslim2OPACDetail.xsl| 618

[Koha-patches] [PATCH] Bug 3169 - Comply with new Google Book branding guidelines

2009-05-12 Thread Frédéric Demians
It adds pretty huge image 'Google Preview' on google book jacket. --- koha-tmpl/opac-tmpl/prog/en/js/google-jackets.js |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/js/google-jackets.js b/koha-tmpl/opac-tmpl/prog/en/js/google-jackets.js

[Koha-patches] [PATCH] Improve XSLT.pm performances

2009-05-15 Thread Frédéric Demians
This patch is done in the process of understanding what's going wrong with bug #3226. It improves some processing. --- C4/XSLT.pm | 57 + 1 files changed, 29 insertions(+), 28 deletions(-) diff --git a/C4/XSLT.pm b/C4/XSLT.pm index

[Koha-patches] [PATCH] Bug 3169 - Google jacket display, remove preview image on result page

2009-05-23 Thread Frédéric Demians
--- koha-tmpl/opac-tmpl/prog/en/js/google-jackets.js | 24 --- .../opac-tmpl/prog/en/modules/opac-detail.tmpl |6 ++-- 2 files changed, 18 insertions(+), 12 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/js/google-jackets.js

[Koha-patches] [PATCH] Bug 3301 - Speed up rebuild_zebra script

2009-06-07 Thread Frédéric Demians
With this patch, rebuild_zebra can re-index a whole Koha DB quickly: rebuild_zebra -r -a -b -marcxml Biblio/authority records are dump directly in a file from marcxml field without beeing transformed into MARC::Record object and corrected. --- misc/migration_tools/rebuild_zebra.pl | 25

[Koha-patches] [PATCH] Add +( )+ to make few strings translatable (with Paul Galen fix)

2009-06-09 Thread Frédéric Demians
--- .../opac-tmpl/prog/en/modules/opac-detail.tmpl |2 +- .../opac-tmpl/prog/en/modules/opac-results.tmpl| 18 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl

[Koha-patches] [PATCH] Bug 3301 - Speed up rebuild_zebra script

2009-06-13 Thread Frédéric Demians
With this patch, rebuild_zebra can re-index a whole Koha DB quickly: rebuild_zebra -r -b -nosanitize Biblio (authority) records are dump directly in a file from marcxml field without beeing transformed into MARC::Record object and corrected. DOCUMENTATION: rebuild_zebra.pl new paramater:

[Koha-patches] [PATCH] Caching for authorised values

2009-06-13 Thread Frédéric Demians
Even without mod_perl this caching improve performances on OPAC result page. XSLT.pm decoding authorised values for each record, it results something like about 7000 MySQL fetchrow... With mod_perl, the cache must be emptied after updating an authorized value category in pro interface. ---

[Koha-patches] [PATCH] Fix an unstranslatable string in JavaScript

2009-06-15 Thread Frédéric Demians
For an explanation, see: http://wiki.koha.org/doku.php?id=en:development:codingguidelines#translatable_text This bug blocks entirely serials module. It isn't possible to create/edit a subscription. Brocken JavaScript prevents Search for a vendor and Search for Biblio dialog box to pop-up. ---

[Koha-patches] [PATCH] Fix bug 3330 - Report notes modification

2009-06-15 Thread Frédéric Demians
--- C4/Reports/Guided.pm |5 +++-- .../en/modules/reports/guided_reports_start.tmpl |1 + reports/guided_reports.pl |6 -- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/C4/Reports/Guided.pm

Re: [Koha-patches] [PATCH] Caching for authorised values

2009-06-17 Thread Frédéric DEMIANS
. Sponsors with deep pocket required :-) Thanks. -- Frédéric DEMIANS http://www.tamil.fr/u/fdemians.html ___ Koha-patches mailing list Koha-patches@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-patches

[Koha-patches] [PATCH] Caching for authorised values

2009-06-17 Thread Frédéric Demians
Even without mod_perl this caching improve performances on OPAC result page. XSLT.pm decoding authorised values for each record, it results something like about 7000 MySQL fetchrow... With mod_perl, the cache must be emptied after updating an authorized value category in pro interface. ---

Re: [Koha-patches] [PATCH] Caching for authorised values

2009-06-18 Thread Frédéric DEMIANS
: http://devel.tamil.fr/nytprof-coins/C4-Biblio-pm-line.html#1042 28ms It's better but not perfect. Obviously MARC::Record-subfield take A LOT of time. So, now MARC library has to be profiled and improved :-) or rewrite in C language... -- Frédéric DEMIANS http://www.tamil.fr/u

Re: [Koha-patches] [PATCH] Caching for authorised values

2009-06-18 Thread Frédéric DEMIANS
yep; memoize ++ IF there is no problems occuring with a multiple Koha setup. Did anyone check for this ? (note I haven't investigated how memoize works, so it may be a dummy question) No risk. It's page-level caching. Everything is cleaned at the end of script page execution. -- Frédéric

Re: [Koha-patches] [PATCH] Bug 3226 - Extended characters inconsistantly displayed

2009-06-22 Thread Frédéric DEMIANS
, it will be hardcoded. Once XML record format is asked, Koha code in Search.pm must be modified to construct MARC::Record from XML. So... Thanks. -- Frédéric DEMIANS http://www.tamil.fr/u/fdemians.html ___ Koha-patches mailing list Koha-patches

[Koha-patches] [PATCH] Bug 3351 - Limit Serials Search for Biblio to an item type

2009-06-23 Thread Frédéric Demians
--- serials/subscription-bib-search.pl |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/serials/subscription-bib-search.pl b/serials/subscription-bib-search.pl index 21341db..01c341d 100755 --- a/serials/subscription-bib-search.pl +++

[Koha-patches] [PATCH] Fix bug 3386 - Authority Search on All Headings

2009-07-02 Thread Frédéric Demians
--- .../prog/en/includes/auth-finder-search.inc|2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/auth-finder-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/auth-finder-search.inc index 8a725f0..cdf1fd2 100644 ---

[Koha-patches] [PATCH] Bug 3226 - Extended characters inconsistantly displayed

2009-07-03 Thread Frédéric Demians
When displayed on result page, some UNIMARC biblio records are marc8 to utf8 converted for whatever reason! It appears that iso2709 records in Zebra can't always properly by used to construct MARC::Record. This patch ask Zebra to return xml record rather than iso2709 and use it to create

Re: [Koha-patches] [PATCH] (bug #3412) fix double encoded guided report

2009-07-15 Thread Frédéric DEMIANS
you get Nahuel double-encoding problems. -- Frédéric DEMIANS http://www.tamil.fr/u/fdemians.html ___ Koha-patches mailing list Koha-patches@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-patches

[Koha-patches] [PATCH] Bug 3226 - Extended characters inconsistantly displayed - NoZebra

2009-07-23 Thread Frédéric Demians
Fix errors introduced by previous patch on NoZebra installation. Thanks Lupin. --- C4/Search.pm | 25 + 1 files changed, 13 insertions(+), 12 deletions(-) diff --git a/C4/Search.pm b/C4/Search.pm index 4b113c1..f2f738d 100644 --- a/C4/Search.pm +++ b/C4/Search.pm @@

Re: [Koha-patches] [PATCH] Bug Fixing : encoding from xml records was broke For search

2009-07-24 Thread Frédéric DEMIANS
results have to be checked for correct encoding new_from_xml is good, but with utf8 and marcflavour as parameters. Thanks. I can confirm this is necessary. I was about to send the same patch. And may send it anyway for a tiny improvement. -- Frédéric DEMIANS http://www.tamil.fr/u

[Koha-patches] [PATCH] Bug 3226 - Display correctly accented facets on result page

2009-07-24 Thread Frédéric Demians
--- C4/Search.pm |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/C4/Search.pm b/C4/Search.pm index f2f738d..2c3743d 100644 --- a/C4/Search.pm +++ b/C4/Search.pm @@ -307,6 +307,8 @@ sub getRecords { my @facets_loop;# stores the ref to array of hashes for

[Koha-patches] [PATCH] Bug 3098 - Append OPAC sysprefs into XML biblio record to be passed to XSLT

2009-07-24 Thread Frédéric Demians
MARCXML biblio record looks like that: record ... sysprefs syspref name=OPACURLOpenInNewWindow0/syspref /sysprefs /record --- C4/XSLT.pm |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/C4/XSLT.pm b/C4/XSLT.pm index 76e7ea7..89ab3a0 100644 --- a/C4/XSLT.pm +++

[Koha-patches] [PATCH 2/2] Remove utility script replaced by a test case

2009-08-17 Thread Frédéric Demians
--- misc/syspref-diff.pl | 67 -- 1 files changed, 0 insertions(+), 67 deletions(-) delete mode 100755 misc/syspref-diff.pl diff --git a/misc/syspref-diff.pl b/misc/syspref-diff.pl deleted file mode 100755 index 2b437ab..000 ---

[Koha-patches] [PATCH 1/2] Test case identifying incoherences between 'en' sysprefs and translated ones

2009-08-17 Thread Frédéric Demians
--- xt/syspref.t | 132 ++ 1 files changed, 132 insertions(+), 0 deletions(-) create mode 100755 xt/syspref.t diff --git a/xt/syspref.t b/xt/syspref.t new file mode 100755 index 000..a5174db --- /dev/null +++ b/xt/syspref.t @@ -0,0

[Koha-patches] [PATCH] Improve OAI Server MARC21 and UNIMARC XSL

2009-09-18 Thread Frédéric Demians
Dublin Core schema name space was repeated for each field as attribute rather than at oai_dc:dc level. This reduces significantly the size of OAI server responses. --- .../prog/en/xslt/MARC21slim2OAIDC.xsl |6 +- .../prog/en/xslt/UNIMARCslim2OAIDC.xsl |6

[Koha-patches] [PATCH] Bug 3698 - Improves OPAC shelf browsing for duplicate itemcallnumbers

2009-10-07 Thread Frédéric Demians
OPAC shelf browsing is 'inaccurate' when there are a lot of duplicate itemcallnumbers. Next items have same cn_sort (normalized itemcallnumber) and increasing itemnumber. So it would be expected that previous items have same cn_sort and decreasing itemnumber. This is not the case. ---

[Koha-patches] [PATCH] Bug 2773 - Previous fix seems to have been corrupted

2009-10-19 Thread Frédéric Demians
This but was fixed with XSLT transliteration string function specifying XML entities. It seems that something in the patch process modifyied those entities. --- .../prog/en/xslt/UNIMARCslim2OPACDetail.xsl|2 +- .../prog/en/xslt/UNIMARCslim2OPACResults.xsl |2 +- 2 files

[Koha-patches] [PATCH] Extend Koha OAI Server to support other metadata formats

2009-10-26 Thread Frédéric Demians
Currently Koha OAI server returns records in two formats: marcxml and oai_dc (Dublin Core). This patch adds a new mode of operation where as many as necessary metadata formats can be added via XSLT. Documentation: See the end of oai.pl file to have an explanation of how it works. --- opac/oai.pl

[Koha-patches] [PATCH] Bug 3806 - Holidays improperly sorted by date

2009-11-23 Thread Frédéric Demians
--- .../prog/en/modules/tools/holidays.tmpl|9 - tools/holidays.pl |6 +++--- 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tmpl

[Koha-patches] [PATCH] Bug 3814: SIP2 Server logging doesn't work on OpenSolaris

2009-11-27 Thread Frédéric Demians
This patch put in SIPconfig.xml SIP2 server logging parameters. This is way it's possible to modify where SIP2 logs are sent. And fix OpenSolaris bug. WARNING: After an upgrade, installation using a custom SIP2 server config file will need to copy default SIPconfig.xml added section: !-- Set

[Koha-patches] [PATCH] Bug 3815: SIP2 Invalid Item Information Response 18

2009-11-27 Thread Frédéric Demians
With this patch Koha SIP2 server send back a valid Item Information Response for issued items: ie with due date in the response. --- C4/SIP/ILS/Item.pm |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/C4/SIP/ILS/Item.pm b/C4/SIP/ILS/Item.pm index 2e02c63..f2c0636

[Koha-patches] [PATCH] Bug 3824: Item modif doesn't select default value in combo list

2009-12-01 Thread Frédéric Demians
This patch should also be applied on 3.0.x branch --- cataloguing/additem.pl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl index e25bb44..35fbb13 100755 --- a/cataloguing/additem.pl +++ b/cataloguing/additem.pl @@ -384,7

[Koha-patches] [PATCH] Bug 3827: Impossible to set a subfield mandatory in biblio framework

2009-12-02 Thread Frédéric Demians
This patch is for 3.0.x. 3.2 is correct. --- admin/marc_subfields_structure.pl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/admin/marc_subfields_structure.pl b/admin/marc_subfields_structure.pl index c8ee3df..7bcd0dc 100755 --- a/admin/marc_subfields_structure.pl +++

[Koha-patches] [PATCH] Bug 3784: Don't fail on opac-detail.pl with invalid biblionumber

2009-12-02 Thread Frédéric Demians
Same as Chris patch but without redundant code --- opac/opac-detail.pl |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl index c3b104b..67f5dd0 100755 --- a/opac/opac-detail.pl +++ b/opac/opac-detail.pl @@ -65,6 +65,10 @@

[Koha-patches] [PATCH] [3.0.x] Bug 3784: Don't fail on opac-detail.pl with invalid biblionumber

2009-12-02 Thread Frédéric Demians
--- opac/opac-detail.pl |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl index 0a4983a..553187d 100755 --- a/opac/opac-detail.pl +++ b/opac/opac-detail.pl @@ -62,6 +62,10 @@ $template-param( 'AllowOnShelfHolds' =

[Koha-patches] [PATCH] Bug 3863 - Amazon Content Not Working

2009-12-05 Thread Frédéric Demians
Sysprefs were not sent to templates. --- C4/Auth.pm |5 - opac/opac-detail.pl |2 -- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/C4/Auth.pm b/C4/Auth.pm index 608fd9b..e1f5b9a 100755 --- a/C4/Auth.pm +++ b/C4/Auth.pm @@ -392,7 +392,10 @@ sub

[Koha-patches] [PATCH] Bug 3921 - Add Intranet MARC21 XSL file based on OPAC one

2009-12-14 Thread Frédéric Demians
Tweak also intranet CSS file in order to have the same layout than on OPAC. For the futur: it would be required to group all XSL in one location. For now if someone improve OPAC XSL, he/she will have not to forget to take its modifications back to the intranet XSL. ---

[Koha-patches] [PATCH 2/2] Update Debian Lenny installation procedure

2009-12-21 Thread Frédéric Demians
- Install Debian Lenny packages required by Koha directly with apt-get rather than with dselect. - Update documentation about Zebra indexer configuration via rebuild_zebra.pl rather than zebraqueue_daemon.pl script. --- INSTALL.debian-lenny | 76 +++---

[Koha-patches] [PATCH 1/4] overdue_notices.pl various bugs in HEAD 3.2

2010-01-08 Thread Frédéric Demians
Those bugs must have been introduced by merge? - Overdue to all libraries with overdue rules doesn't work - Overdue to a specific library doesn't work also --- misc/cronjobs/overdue_notices.pl |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git

[Koha-patches] [PATCH 4/4] Add OverdueNoticeBcc syspref required by overdue_notices.pl

2010-01-08 Thread Frédéric Demians
--- admin/systempreferences.pl |1 + installer/data/mysql/en/mandatory/sysprefs.sql |1 + .../1-Obligatoire/unimarc_standard_systemprefs.sql |1 + installer/data/mysql/updatedatabase.pl | 15 +++ kohaversion.pl

Re: [Koha-patches] [PATCH] Rotating Collections

2010-01-19 Thread Frédéric DEMIANS
support your question about the right procedure with revision numbers, which is for RM, especially now that there is an official HEAD branch and a Biblibre community branch somewhere. -- Frédéric DEMIANS http://www.tamil.fr/u/fdemians.html ___ Koha-patches

Re: [Koha-patches] [PATCH] Rotating Collections

2010-01-19 Thread Frédéric DEMIANS
Last but not least. Your patch miss kohaversion.pl modification: you need to upgrade version number to 3.01.00.101. (or 102 who know?) -- Frédéric DEMIANS http://www.tamil.fr/u/fdemians.html ___ Koha-patches mailing list Koha-patches@lists.koha.org

Re: [Koha-patches] [PATCH] Rotating Collections

2010-01-19 Thread Frédéric DEMIANS
. By the way, your rotating collection functionality works like a charm! Thanks. -- Frédéric DEMIANS http://www.tamil.fr/u/fdemians.html ___ Koha-patches mailing list Koha-patches@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-patches

Re: [Koha-patches] [PATCH] Rotating Collections

2010-01-19 Thread Frédéric DEMIANS
Please consider these two points. Thanks. I will resend (from Kyle's name). -- Frédéric ___ Koha-patches mailing list Koha-patches@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-patches

Re: [Koha-patches] [PATCH] Rotating Collections

2010-01-19 Thread Frédéric DEMIANS
mmm this latest patch does not apply on master because of MARC21slimutils edits. Frustrating ;) My mess with MARC intranet XSL files. I fix that. (good night) -- Frédéric ___ Koha-patches mailing list Koha-patches@lists.koha.org

[Koha-patches] [PATCH] Fix updatedatabase.pl mess coming from last merge?

2010-01-28 Thread Frédéric Demians
--- installer/data/mysql/updatedatabase.pl |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl index 7bd1536..9f4c149 100755 --- a/installer/data/mysql/updatedatabase.pl +++

[Koha-patches] [PATCH] Bug 4077 - Tweak UNIMARC default framework

2010-01-29 Thread Frédéric Demians
--- .../Obligatoire/framework_DEFAULT.sql | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/framework_DEFAULT.sql

[Koha-patches] [PATCH] Bug 4077 - Tweak UNIMARC default framework

2010-01-29 Thread Frédéric Demians
--- .../Obligatoire/framework_DEFAULT.sql | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/framework_DEFAULT.sql

[Koha-patches] [PATCH] Bug 4085 - Subscription type length wasn't taken into account

2010-02-01 Thread Frédéric Demians
--- serials/subscription-add.pl |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/serials/subscription-add.pl b/serials/subscription-add.pl index 6ee32f5..7fe93c8 100755 --- a/serials/subscription-add.pl +++ b/serials/subscription-add.pl @@ -158,9 +158,9 @@ if ($op

[Koha-patches] [PATCH] Bug 4085 - Subscription type length wasn't taken into account

2010-02-02 Thread Frédéric Demians
--- serials/subscription-add.pl | 36 ++-- 1 files changed, 14 insertions(+), 22 deletions(-) diff --git a/serials/subscription-add.pl b/serials/subscription-add.pl index 46fd88d..f7f23e7 100755 --- a/serials/subscription-add.pl +++ b/serials/subscription-add.pl

Re: [Koha-patches] [PATCH] Bug 4085 - Subscription type length wasn't taken into account

2010-02-02 Thread Frédéric DEMIANS
This does not apply against HEAD. Thanks. I resubmitted. -- Frédéric ___ Koha-patches mailing list Koha-patches@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-patches

[Koha-patches] [PATCH] Bug 4103 - In Pro Adv Search, superlibrarian search always all libraries

2010-02-03 Thread Frédéric Demians
--- catalogue/search.pl | 22 +- 1 files changed, 13 insertions(+), 9 deletions(-) diff --git a/catalogue/search.pl b/catalogue/search.pl index adb3cc7..bdcdfa8 100755 --- a/catalogue/search.pl +++ b/catalogue/search.pl @@ -205,16 +205,20 @@ if

[Koha-patches] [PATCH] Bug 4125 - Reformat with perldoc bulkmarcimport.pl doc

2010-02-06 Thread Frédéric Demians
--- misc/migration_tools/bulkmarcimport.pl | 179 ++- 1 files changed, 127 insertions(+), 52 deletions(-) diff --git a/misc/migration_tools/bulkmarcimport.pl b/misc/migration_tools/bulkmarcimport.pl index 6a8a16b..da0ebf7 100755 ---

[Koha-patches] [PATCH] Bug 3920 - Add 2 syspref to activate XSLT use in OPAC/Intranet

2010-02-06 Thread Frédéric Demians
- Add two syspref: - OPACXSLTResultsDisplay - OPACXSLDetailsDispay - Add them to .pref files and dispatch them beetween OPAC and Search tab. - Upgrade DB version to 3.2 .113 - Fix something wrong in UNIMARCslim2intranetDetail.xsl - Display OPAC result and detail pages using those syspref.

[Koha-patches] [PATCH] Add 'Series' to UNIMARC XSL

2010-02-09 Thread Frédéric Demians
--- .../prog/en/xslt/UNIMARCslim2intranetDetail.xsl|3 + .../prog/en/xslt/UNIMARCslimUtils.xsl | 52 +++- .../prog/en/xslt/UNIMARCslim2OPACDetail.xsl|7 +-- .../prog/en/xslt/UNIMARCslim2OPACResults.xsl |2 +

[Koha-patches] [PATCH 1/2] Bug 4154 - Add a .po based mechanism to translate preferences

2010-02-10 Thread Frédéric Demians
Cut-and-past from pref-trans script: NAME pref-trans - Handle preferences translation SYNOPSYS pref-trans init fr-FR pref-trans update fr-FR pref-trans install fr-FR USAGE pref-trans init lang Create a .po file in po directory, named

[Koha-patches] [PATCH 1/2] Bug 4154 - Add a .po based mechanism to translate preferences

2010-02-10 Thread Frédéric Demians
Add to previous patch (and replace it): - update function - translation of tab subsection labels - GPL2 Cut-and-past of pref-trans script perldoc: NAME pref-trans - Handle preferences translation SYNOPSYS pref-trans init fr-FR pref-trans update fr-FR

[Koha-patches] [PATCH 1/2] Bug 4154 - Add a .po based mechanism to translate preferences

2010-02-10 Thread Frédéric Demians
Add to previous patch (and replace it): - update function - translation of tab subsection labels - GPL2 - fix last minute bug catched by Galen Cut-and-past of pref-trans script perldoc: NAME pref-trans - Handle preferences translation SYNOPSYS pref-trans init fr-FR

[Koha-patches] [PATCH] Bug 4154 - Include preferences translation into install.pl

2010-02-11 Thread Frédéric Demians
--- misc/translator/install.pl | 66 1 files changed, 24 insertions(+), 42 deletions(-) diff --git a/misc/translator/install.pl b/misc/translator/install.pl index ae5e4b9..b526a6c 100755 --- a/misc/translator/install.pl +++

[Koha-patches] [PATCH] Bug 2959 - Cache already failed URLs to speedup check-url.pl

2010-02-12 Thread Frédéric Demians
Based on David Schuster improvement patch. For David: - To send the output into an HTML file, there is no need to add a paramater to this script, just redirect to a file: check-url --html --host-prot=http://koha-pro.mylib.org \\ /usr/local/koha/koha-tmpl/badurls.html - If you want as

[Koha-patches] [PATCH] Bug 2959 - Add a timeout parameter to the URL checker

2010-02-14 Thread Frédéric Demians
Could improve performances for DB containing URLs which can't be fetched (good or bad) quickly. --- misc/cronjobs/check-url.pl | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/misc/cronjobs/check-url.pl b/misc/cronjobs/check-url.pl index 9700c98..c2f4b5c

[Koha-patches] [PATCH] Add OpacBrowser preference to opac.pref

2010-02-16 Thread Frédéric Demians
--- .../prog/en/modules/admin/preferences/opac.pref|6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref index 81844c0..e0ff70b

[Koha-patches] Request to Pull 'trans' branch for 3.4 but usable for 3.2

2010-02-16 Thread Frédéric DEMIANS
The following changes since commit 84b3c05c0d98fc77f5c859fa084d9491731cb34f: Frédéric Demians (1): Bug 2959 - Add a timeout parameter to the URL checker are available in the git repository at: git://git.tamil.fr/git/koha trans Frédéric Demians (1): [3.4] New wrapper script

Re: [Koha-patches] [PATCH] [3.4] New wrapper script for handling translation process

2010-02-17 Thread Frédéric DEMIANS
Thanks for testing and your sign-off. It could even be possible to include templates/preferences generation into Koha web installer or Koha admin. This would allow to downsize drastically Koha .tar.gz. ___ Koha-patches mailing list

Re: [Koha-patches] [PATCH] [3.4] New wrapper script for handling translation process

2010-02-17 Thread Frédéric DEMIANS
I will be pushing this to 3.2. However, could you send a follow-up patch to have the license match the rest of Koha? Koha currently uses the GPL 2 or later, not the Lesser GPL 2.1, so please replace the license statement with the full text as used in other Koha Perl files: No problem.

[Koha-patches] [PATCH] OAI server fixes

2010-02-17 Thread Frédéric Demians
- Add preference OAI-PMH:ConfFile. I just add it in web-services.pref and not in DB. It's enough. It's not an end-user preference. Without this pref, OAI server operates as previously. And preferences editor allow to add a new value to the DB if necessary. - Fix response to

[Koha-patches] [PATCH] Bug 4155 Can't change the language of the staff client in prefs

2010-02-17 Thread Frédéric Demians
--- .../intranet-tmpl/prog/en/js/pages/preferences.js |8 ++-- .../prog/en/modules/admin/preferences.tmpl |9 - 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js

[Koha-patches] [PATCH 2/3] Add pl-PL to syspref test

2010-02-19 Thread Frédéric Demians
--- xt/syspref.t |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/xt/syspref.t b/xt/syspref.t index a5174db..fb44421 100755 --- a/xt/syspref.t +++ b/xt/syspref.t @@ -30,6 +30,7 @@ my @trans_syspref_files = qw( fr-FR/1-Obligatoire/unimarc_standard_systemprefs.sql

[Koha-patches] [PATCH 3/3] Bug 3609 Fix fr-FR user permissions

2010-02-19 Thread Frédéric Demians
- Translation - Add missing permissions: execute_reports, create_reports - Rename properly: batchmod and batchdel This has to be done for other languages. --- .../mysql/fr-FR/1-Obligatoire/userpermissions.sql | 44 +++- 1 files changed, 24 insertions(+), 20 deletions(-) diff

[Koha-patches] [PATCH] Fixes translated boolean syspref inversion

2010-03-02 Thread Frédéric Demians
For example, for NoZebra syspref in French 'no' means 'yes' and 'yes' mean 'no'. It applies to all boolean sysprefs. The bugs comes from a tricky issue with how YAML parser interprets yes/no value in hash's keys. Those values are surrounded automatically with double quotes which causes translated

[Koha-patches] [PATCH 5/5] Bug 4368 - Avoid reseting UNIMARC 100 tag when importing biblio records

2010-04-03 Thread Frédéric Demians
--- C4/Biblio.pm |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/C4/Biblio.pm b/C4/Biblio.pm index 17796f3..85cbee7 100755 --- a/C4/Biblio.pm +++ b/C4/Biblio.pm @@ -3317,7 +3317,7 @@ sub ModBiblioMarc { # deal with UNIMARC field 100 (encoding) : create it if needed

[Koha-patches] [PATCH] Bug 4374 Improve biblio data entry form regarding hidden/mandatory fields

2010-04-06 Thread Frédéric Demians
--- cataloguing/addbiblio.pl | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl index d519aed..ba54026 100755 --- a/cataloguing/addbiblio.pl +++ b/cataloguing/addbiblio.pl @@ -337,14 +337,14 @@ sub create_input

[Koha-patches] [PATCH] Allow UNIMARC item callnumber splitting

2010-04-09 Thread Frédéric Demians
--- C4/Labels/Label.pm |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/C4/Labels/Label.pm b/C4/Labels/Label.pm index e16e244..9fb09f3 100644 --- a/C4/Labels/Label.pm +++ b/C4/Labels/Label.pm @@ -405,7 +405,8 @@ sub draw_label_text { $field_data =~ s/\r//g;

  1   2   >