---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124094/
---
(Updated March 13, 2016, 3:24 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124094/
---
(Updated March 11, 2016, 3:24 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124094/
---
(Updated Sept. 6, 2015, 7:50 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124094/#review84051
---
Ship it!
approved
- Pali Rohár
On júl 25, 2015, 5:18
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124094/
---
(Updated July 25, 2015, 8:48 p.m.)
Review request for Kopete, Laurent
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124094/
---
(Updated July 25, 2015, 6:10 p.m.)
Review request for Kopete, Laurent
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124094/#review82931
---
plugins/texteffect/texteffectpreferences.cpp (line 160)
On July 25, 2015, 6:43 p.m., Pali Rohár wrote:
plugins/texteffect/texteffectpreferences.cpp, line 160
https://git.reviewboard.kde.org/r/124094/diff/6-7/?file=384109#file384109line160
Are you sure that -1 is working? I did not find anything in
documentation about it...
Neither
On júl 25, 2015, 3:13 popoludní, Pali Rohár wrote:
plugins/texteffect/texteffectpreferences.cpp, line 160
https://git.reviewboard.kde.org/r/124094/diff/6-7/?file=384109#file384109line160
Are you sure that -1 is working? I did not find anything in
documentation about it...
On July 22, 2015, 9:57 p.m., Pali Rohár wrote:
plugins/texteffect/texteffectpreferences.cpp, line 186
https://git.reviewboard.kde.org/r/124094/diff/6/?file=384109#file384109line186
Is not QListWidget::removeItemWidget(i) doing same? Please check if
yes/no.
Yes, they seem to be
On July 22, 2015, 9:57 p.m., Pali Rohár wrote:
plugins/texteffect/texteffectpreferences.cpp, line 160
https://git.reviewboard.kde.org/r/124094/diff/6/?file=384109#file384109line160
Definition of K3ListBox::insertItem from
http://doc.qt.io/qt-4.8/q3listbox.html#insertItem-3:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124094/#review82820
---
plugins/texteffect/texteffectpreferences.cpp (line 160)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124094/#review82747
---
Ship it!
Seems good.
Ship it
- Laurent Montel
On juil.
On July 10, 2015, 12:52 p.m., Laurent Montel wrote:
plugins/texteffect/texteffectpreferences.cpp, line 204
https://git.reviewboard.kde.org/r/124094/diff/5/?file=380817#file380817line204
takeItem(p) is enough no ?
Yes, that is currentRow() isn't it ? I'll update this accordingly.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124094/#review82303
---
plugins/texteffect/texteffectpreferences.cpp (line 204)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124094/
---
(Updated July 10, 2015, 6:24 p.m.)
Review request for Kopete, Laurent
On July 9, 2015, 6 p.m., Laurent Montel wrote:
plugins/texteffect/texteffectpreferences.cpp, line 204
https://git.reviewboard.kde.org/r/124094/diff/5/?file=380817#file380817line204
you want to take currentitem no ?
so why to get item from listWidget()-row(i) ?
My reasoning
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124094/#review82267
---
plugins/texteffect/texteffectpreferences.cpp (line 204)
On June 20, 2015, 9:46 p.m., Laurent Montel wrote:
plugins/texteffect/texteffectpreferences.cpp, line 151
https://git.reviewboard.kde.org/r/124094/diff/4/?file=380500#file380500line151
why don't add directly ret.appent(...-item(f)-text()) ?
Roman Nazarenko wrote:
Too much
On Июнь 20, 2015, 4:16 п.п., Laurent Montel wrote:
plugins/texteffect/texteffectpreferences.cpp, line 149
https://git.reviewboard.kde.org/r/124094/diff/4/?file=380500#file380500line149
better to use ++f
No it's not. It doesn't matter whether post- or pre-increment operator is used
On jún 20, 2015, 6:16 popoludní, Laurent Montel wrote:
plugins/texteffect/texteffectpreferences.cpp, line 149
https://git.reviewboard.kde.org/r/124094/diff/4/?file=380500#file380500line149
better to use ++f
Roman Nazarenko wrote:
No it's not. It doesn't matter whether post-
On Июнь 20, 2015, 4:16 п.п., Laurent Montel wrote:
plugins/texteffect/texteffectpreferences.cpp, line 151
https://git.reviewboard.kde.org/r/124094/diff/4/?file=380500#file380500line151
why don't add directly ret.appent(...-item(f)-text()) ?
Too much operations in a single line.
On Июнь 20, 2015, 4:16 п.п., Laurent Montel wrote:
plugins/texteffect/texteffectpreferences.cpp, line 151
https://git.reviewboard.kde.org/r/124094/diff/4/?file=380500#file380500line151
why don't add directly ret.appent(...-item(f)-text()) ?
Roman Nazarenko wrote:
Too much
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124094/
---
(Updated June 21, 2015, 5:11 p.m.)
Review request for Kopete, Laurent
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124094/#review81595
---
plugins/texteffect/texteffectpreferences.cpp (line 149)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124094/
---
(Updated June 19, 2015, 6:32 p.m.)
Review request for Kopete, Laurent
On June 15, 2015, 10:25 a.m., Laurent Montel wrote:
plugins/texteffect/texteffectprefs.ui, line 85
https://git.reviewboard.kde.org/r/124094/diff/1/?file=379855#file379855line85
Why added indent ?
meh, unintentional. My(editor's ?) bad :\
On June 15, 2015, 10:25 a.m., Laurent
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124094/
---
(Updated June 19, 2015, 7:06 p.m.)
Review request for Kopete, Laurent
On June 15, 2015, 10:25 a.m., Laurent Montel wrote:
plugins/texteffect/texteffectpreferences.cpp, line 171
https://git.reviewboard.kde.org/r/124094/diff/1/?file=379854#file379854line171
this list is single selection or multiselection ?
R.Harish Navnit wrote:
I *think* it's
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124094/
---
(Updated June 20, 2015, 12:43 a.m.)
Review request for Kopete, Laurent
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124094/#review81473
---
plugins/texteffect/texteffectpreferences.cpp (line 101)
31 matches
Mail list logo
