---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124227/
---
(Updated June 18, 2017, 10:29 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124227/
---
(Updated March 11, 2016, 4:24 p.m.)
Status
--
This change has been
> On Jan. 4, 2016, 11:32 p.m., Pali Rohár wrote:
> > Ok, and now please test changes in preferences dialog are OK, e.g. nothing
> > was broken and functionality in GUI is still same.
I built and tested upto this commit in the "test" branch of my scratch repo:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124227/
---
(Updated Jan. 4, 2016, 5:08 p.m.)
Review request for Kopete, Laurent
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124227/#review90335
---
plugins/autoreplace/autoreplacepreferences.cpp (line 91)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124227/
---
(Updated Sept. 2, 2015, 11:30 a.m.)
Review request for Kopete, Laurent
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124227/#review84053
---
plugins/autoreplace/autoreplacepreferences.cpp (line 51)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124227/
---
(Updated July 25, 2015, 10:12 p.m.)
Review request for Kopete, Laurent
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124227/#review82812
---
plugins/autoreplace/autoreplacepreferences.cpp (line 51)
On July 21, 2015, 12:46 a.m., Laurent Montel wrote:
plugins/autoreplace/autoreplacepreferences.cpp, line 120
https://git.reviewboard.kde.org/r/124227/diff/3/?file=386407#file386407line120
What do you think about
for (int i = 0; i prefer...-m_list-toplevelitemcount() ; ++i) {
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124227/
---
(Updated July 21, 2015, 6:40 p.m.)
Review request for Kopete, Laurent
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124227/
---
(Updated July 20, 2015, 10:48 p.m.)
Review request for Kopete, Laurent
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124227/#review82722
---
plugins/autoreplace/autoreplacepreferences.cpp (line 119)
On July 15, 2015, 10:16 a.m., Laurent Montel wrote:
plugins/autoreplace/autoreplacepreferences.cpp, line 50
https://git.reviewboard.kde.org/r/124227/diff/1/?file=385404#file385404line50
Why ?
Why not add directly setColumCount(2) ?
Isn't it better not to hardcode ?
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124227/#review82643
---
plugins/autoreplace/autoreplacepreferences.cpp (line 49)
On July 19, 2015, 6:13 p.m., Laurent Montel wrote:
plugins/autoreplace/autoreplacepreferences.cpp, line 50
https://git.reviewboard.kde.org/r/124227/diff/1/?file=385404#file385404line50
why it's better ?
you know how many column you added.
= so not necessary to
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124227/
---
Review request for Kopete, Laurent Montel and Pali Rohár.
Summary
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124227/#review82520
---
plugins/autoreplace/autoreplacepreferences.cpp (line 49)
18 matches
Mail list logo
