Re: Review Request 124305: Remove K3 classes from kopete main application
> On okt. 3, 2017, 1:08 dopoludnia, Luigi Toscano wrote: > > This was committed as > > https://commits.kde.org/kopete/ea461c02b22681ca50bca40e83c9da6ea517b582 > > > > but for some reason the git hook did not close it (maybe because not on the > > master branch? I don't remember). Luigi, I let open all review requests which were not merged into master. And patch in this review request was not merged into master, because it has open issue. - Pali --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/#review103774 --- On okt. 4, 2017, 11:22 popoludní, R.Harish Navnit wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124305/ > --- > > (Updated okt. 4, 2017, 11:22 popoludní) > > > Review request for Kopete, Laurent Montel and Pali Rohár. > > > Repository: kopete > > > Description > --- > > Removes all occurences of the K3ListBox classes in the kopete main > application. > > > Diffs > - > > kopete/chatwindow/chatview.cpp f92d5fe8c58420ce2d7008d33441e26020cb9dd4 > kopete/contactlist/kopeteaddrbookexport.h > 4774ba8efe89cea5282a9566ec685a913012cece > kopete/contactlist/kopeteaddrbookexport.cpp > 8f285bf23dcad7336bd05b2697a300e983ceca73 > kopete/contactlist/kopeteaddrbookexportui.ui > ec6ec9bc5c693b6df06499062defd1865a0a9c4f > kopete/contactlist/kopetestatusgroupviewitem.h > fb4a20648e1b12d464e98c51b8638f7d618ef53f > kopete/contactlist/kopetestatusgroupviewitem.cpp > 3eb746fbbcad24a562cb9a224186a316b1c9dfe4 > > > Diff: https://git.reviewboard.kde.org/r/124305/diff/4/ > > > Testing > --- > > Build succeeded. > > > Thanks, > > R.Harish Navnit > >
Re: Review Request 124305: Remove K3 classes from kopete main application
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/ --- (Updated Ott. 4, 2017, 11:22 p.m.) Status -- This change has been marked as submitted. Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Removes all occurences of the K3ListBox classes in the kopete main application. Diffs - kopete/chatwindow/chatview.cpp f92d5fe8c58420ce2d7008d33441e26020cb9dd4 kopete/contactlist/kopeteaddrbookexport.h 4774ba8efe89cea5282a9566ec685a913012cece kopete/contactlist/kopeteaddrbookexport.cpp 8f285bf23dcad7336bd05b2697a300e983ceca73 kopete/contactlist/kopeteaddrbookexportui.ui ec6ec9bc5c693b6df06499062defd1865a0a9c4f kopete/contactlist/kopetestatusgroupviewitem.h fb4a20648e1b12d464e98c51b8638f7d618ef53f kopete/contactlist/kopetestatusgroupviewitem.cpp 3eb746fbbcad24a562cb9a224186a316b1c9dfe4 Diff: https://git.reviewboard.kde.org/r/124305/diff/4/ Testing --- Build succeeded. Thanks, R.Harish Navnit
Re: Review Request 124305: Remove K3 classes from kopete main application
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/#review103774 --- This was committed as https://commits.kde.org/kopete/ea461c02b22681ca50bca40e83c9da6ea517b582 but for some reason the git hook did not close it (maybe because not on the master branch? I don't remember). - Luigi Toscano On Mar. 11, 2016, 4:24 p.m., R.Harish Navnit wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124305/ > --- > > (Updated Mar. 11, 2016, 4:24 p.m.) > > > Review request for Kopete, Laurent Montel and Pali Rohár. > > > Repository: kopete > > > Description > --- > > Removes all occurences of the K3ListBox classes in the kopete main > application. > > > Diffs > - > > kopete/chatwindow/chatview.cpp f92d5fe8c58420ce2d7008d33441e26020cb9dd4 > kopete/contactlist/kopeteaddrbookexport.h > 4774ba8efe89cea5282a9566ec685a913012cece > kopete/contactlist/kopeteaddrbookexport.cpp > 8f285bf23dcad7336bd05b2697a300e983ceca73 > kopete/contactlist/kopeteaddrbookexportui.ui > ec6ec9bc5c693b6df06499062defd1865a0a9c4f > kopete/contactlist/kopetestatusgroupviewitem.h > fb4a20648e1b12d464e98c51b8638f7d618ef53f > kopete/contactlist/kopetestatusgroupviewitem.cpp > 3eb746fbbcad24a562cb9a224186a316b1c9dfe4 > > > Diff: https://git.reviewboard.kde.org/r/124305/diff/4/ > > > Testing > --- > > Build succeeded. > > > Thanks, > > R.Harish Navnit > >
Re: Review Request 124305: Remove K3 classes from kopete main application
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/ --- (Updated March 11, 2016, 4:24 p.m.) Status -- This change has been marked as submitted. Review request for Kopete, Laurent Montel and Pali Rohár. Changes --- Submitted with commit ea461c02b22681ca50bca40e83c9da6ea517b582 by R. Harish Navnit to branch kf5. Repository: kopete Description --- Removes all occurences of the K3ListBox classes in the kopete main application. Diffs - kopete/chatwindow/chatview.cpp f92d5fe8c58420ce2d7008d33441e26020cb9dd4 kopete/contactlist/kopeteaddrbookexport.h 4774ba8efe89cea5282a9566ec685a913012cece kopete/contactlist/kopeteaddrbookexport.cpp 8f285bf23dcad7336bd05b2697a300e983ceca73 kopete/contactlist/kopeteaddrbookexportui.ui ec6ec9bc5c693b6df06499062defd1865a0a9c4f kopete/contactlist/kopetestatusgroupviewitem.h fb4a20648e1b12d464e98c51b8638f7d618ef53f kopete/contactlist/kopetestatusgroupviewitem.cpp 3eb746fbbcad24a562cb9a224186a316b1c9dfe4 Diff: https://git.reviewboard.kde.org/r/124305/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124305: Remove K3 classes from kopete main application
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/#review83712 --- kopete/chatwindow/chatview.cpp (line 995) https://git.reviewboard.kde.org/r/124305/#comment57934 Why is !Q3UriDrag::canDecode(event) changed do event-mimeData()-hasText() ? kopete/contactlist/kopeteaddrbookexport.cpp (line 177) https://git.reviewboard.kde.org/r/124305/#comment57935 Who will free this object? - Pali Rohár On júl 26, 2015, 9:19 dopoludnia, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/ --- (Updated júl 26, 2015, 9:19 dopoludnia) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Removes all occurences of the K3ListBox classes in the kopete main application. Diffs - kopete/chatwindow/chatview.cpp f92d5fe8c58420ce2d7008d33441e26020cb9dd4 kopete/contactlist/kopeteaddrbookexport.h 4774ba8efe89cea5282a9566ec685a913012cece kopete/contactlist/kopeteaddrbookexport.cpp 8f285bf23dcad7336bd05b2697a300e983ceca73 kopete/contactlist/kopeteaddrbookexportui.ui ec6ec9bc5c693b6df06499062defd1865a0a9c4f kopete/contactlist/kopetestatusgroupviewitem.h fb4a20648e1b12d464e98c51b8638f7d618ef53f kopete/contactlist/kopetestatusgroupviewitem.cpp 3eb746fbbcad24a562cb9a224186a316b1c9dfe4 Diff: https://git.reviewboard.kde.org/r/124305/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124305: Remove K3 classes from kopete main application
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/#review83409 --- Ship it! Seems good. I hope that it works as expected. - Laurent Montel On juil. 26, 2015, 7:19 matin, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/ --- (Updated juil. 26, 2015, 7:19 matin) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Removes all occurences of the K3ListBox classes in the kopete main application. Diffs - kopete/chatwindow/chatview.cpp f92d5fe8c58420ce2d7008d33441e26020cb9dd4 kopete/contactlist/kopeteaddrbookexport.h 4774ba8efe89cea5282a9566ec685a913012cece kopete/contactlist/kopeteaddrbookexport.cpp 8f285bf23dcad7336bd05b2697a300e983ceca73 kopete/contactlist/kopeteaddrbookexportui.ui ec6ec9bc5c693b6df06499062defd1865a0a9c4f kopete/contactlist/kopetestatusgroupviewitem.h fb4a20648e1b12d464e98c51b8638f7d618ef53f kopete/contactlist/kopetestatusgroupviewitem.cpp 3eb746fbbcad24a562cb9a224186a316b1c9dfe4 Diff: https://git.reviewboard.kde.org/r/124305/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124305: Remove K3 classes from kopete main application
On July 26, 2015, 11:19 a.m., Laurent Montel wrote: kopete/contactlist/kopeteaddrbookexport.cpp, line 109 https://git.reviewboard.kde.org/r/124305/diff/3/?file=387733#file387733line109 Why you don't : QListWidgetItem *item = new QListWidgetITem(QIcon, QString); QListWidget::addITem(item); ? Aah, you're right. Much neater. I'll update the patch. - R.Harish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/#review82968 --- On July 26, 2015, 11:13 a.m., R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/ --- (Updated July 26, 2015, 11:13 a.m.) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Removes all occurences of the K3ListBox classes in the kopete main application. Diffs - kopete/chatwindow/chatview.cpp f92d5fe8c58420ce2d7008d33441e26020cb9dd4 kopete/contactlist/kopeteaddrbookexport.h 4774ba8efe89cea5282a9566ec685a913012cece kopete/contactlist/kopeteaddrbookexport.cpp 8f285bf23dcad7336bd05b2697a300e983ceca73 kopete/contactlist/kopeteaddrbookexportui.ui ec6ec9bc5c693b6df06499062defd1865a0a9c4f kopete/contactlist/kopetestatusgroupviewitem.h fb4a20648e1b12d464e98c51b8638f7d618ef53f kopete/contactlist/kopetestatusgroupviewitem.cpp 3eb746fbbcad24a562cb9a224186a316b1c9dfe4 Diff: https://git.reviewboard.kde.org/r/124305/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124305: Remove K3 classes from kopete main application
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/ --- (Updated July 26, 2015, 12:49 p.m.) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Removes all occurences of the K3ListBox classes in the kopete main application. Diffs (updated) - kopete/chatwindow/chatview.cpp f92d5fe8c58420ce2d7008d33441e26020cb9dd4 kopete/contactlist/kopeteaddrbookexport.h 4774ba8efe89cea5282a9566ec685a913012cece kopete/contactlist/kopeteaddrbookexport.cpp 8f285bf23dcad7336bd05b2697a300e983ceca73 kopete/contactlist/kopeteaddrbookexportui.ui ec6ec9bc5c693b6df06499062defd1865a0a9c4f kopete/contactlist/kopetestatusgroupviewitem.h fb4a20648e1b12d464e98c51b8638f7d618ef53f kopete/contactlist/kopetestatusgroupviewitem.cpp 3eb746fbbcad24a562cb9a224186a316b1c9dfe4 Diff: https://git.reviewboard.kde.org/r/124305/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124305: Remove K3 classes from kopete main application
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/ --- (Updated July 26, 2015, 9:59 a.m.) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Removes all occurences of the K3ListBox classes in the kopete main application. Diffs (updated) - kopete/contactlist/kopeteaddrbookexport.h 4774ba8efe89cea5282a9566ec685a913012cece kopete/contactlist/kopeteaddrbookexport.cpp 8f285bf23dcad7336bd05b2697a300e983ceca73 kopete/contactlist/kopeteaddrbookexportui.ui ec6ec9bc5c693b6df06499062defd1865a0a9c4f Diff: https://git.reviewboard.kde.org/r/124305/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124305: Remove K3 classes from kopete main application
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/ --- (Updated July 26, 2015, 11:13 a.m.) Review request for Kopete, Laurent Montel and Pali Rohár. Changes --- Remove Q3ListViews and Q3UriDrag Repository: kopete Description --- Removes all occurences of the K3ListBox classes in the kopete main application. Diffs (updated) - kopete/chatwindow/chatview.cpp f92d5fe8c58420ce2d7008d33441e26020cb9dd4 kopete/contactlist/kopeteaddrbookexport.h 4774ba8efe89cea5282a9566ec685a913012cece kopete/contactlist/kopeteaddrbookexport.cpp 8f285bf23dcad7336bd05b2697a300e983ceca73 kopete/contactlist/kopeteaddrbookexportui.ui ec6ec9bc5c693b6df06499062defd1865a0a9c4f kopete/contactlist/kopetestatusgroupviewitem.h fb4a20648e1b12d464e98c51b8638f7d618ef53f kopete/contactlist/kopetestatusgroupviewitem.cpp 3eb746fbbcad24a562cb9a224186a316b1c9dfe4 Diff: https://git.reviewboard.kde.org/r/124305/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124305: Remove K3 classes from kopete main application
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/#review82968 --- kopete/contactlist/kopeteaddrbookexport.cpp (line 108) https://git.reviewboard.kde.org/r/124305/#comment57256 Why you don't : QListWidgetItem *item = new QListWidgetITem(QIcon, QString); QListWidget::addITem(item); ? - Laurent Montel On juil. 26, 2015, 5:43 matin, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/ --- (Updated juil. 26, 2015, 5:43 matin) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Removes all occurences of the K3ListBox classes in the kopete main application. Diffs - kopete/chatwindow/chatview.cpp f92d5fe8c58420ce2d7008d33441e26020cb9dd4 kopete/contactlist/kopeteaddrbookexport.h 4774ba8efe89cea5282a9566ec685a913012cece kopete/contactlist/kopeteaddrbookexport.cpp 8f285bf23dcad7336bd05b2697a300e983ceca73 kopete/contactlist/kopeteaddrbookexportui.ui ec6ec9bc5c693b6df06499062defd1865a0a9c4f kopete/contactlist/kopetestatusgroupviewitem.h fb4a20648e1b12d464e98c51b8638f7d618ef53f kopete/contactlist/kopetestatusgroupviewitem.cpp 3eb746fbbcad24a562cb9a224186a316b1c9dfe4 Diff: https://git.reviewboard.kde.org/r/124305/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Review Request 124305: Remove K3 classes from kopete main application
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/ --- Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Removes all occurences of the K3ListBox classes in the kopete main application. Diffs - kopete/contactlist/kopeteaddrbookexport.h 4774ba8efe89cea5282a9566ec685a913012cece kopete/contactlist/kopeteaddrbookexport.cpp 8f285bf23dcad7336bd05b2697a300e983ceca73 kopete/contactlist/kopeteaddrbookexportui.ui ec6ec9bc5c693b6df06499062defd1865a0a9c4f Diff: https://git.reviewboard.kde.org/r/124305/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124305: Remove K3 classes from kopete main application
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/#review82268 --- kopete/contactlist/kopeteaddrbookexport.cpp (line 131) https://git.reviewboard.kde.org/r/124305/#comment56647 -1... = crash. - Laurent Montel On juil. 9, 2015, 12:20 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124305/ --- (Updated juil. 9, 2015, 12:20 après-midi) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Removes all occurences of the K3ListBox classes in the kopete main application. Diffs - kopete/contactlist/kopeteaddrbookexport.h 4774ba8efe89cea5282a9566ec685a913012cece kopete/contactlist/kopeteaddrbookexport.cpp 8f285bf23dcad7336bd05b2697a300e983ceca73 kopete/contactlist/kopeteaddrbookexportui.ui ec6ec9bc5c693b6df06499062defd1865a0a9c4f Diff: https://git.reviewboard.kde.org/r/124305/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
