consumer database

2010-05-05 Thread England hornmouth
Here's some of the healthcare lists we have: Physicians (34 specialties) - 788k records, 17k emails, 200k fax numbers Chiropractors - 108,421 total records * 3,414 emails * 6,553 fax numbers US Surgery Centers - 85k records and 14k emails Theres many more too, just send me an email here for

[COMMIT master] qemu-kvm: event writeback can overwrite interrupts with -no-kvm-irqchip

2010-05-05 Thread Avi Kivity
From: Marcelo Tosatti mtosa...@redhat.com Interrupts that are injected during a vcpu event save/writeback cycle are lost. Fix by writebacking the state before injecting interrupts. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git

[COMMIT master] qemu-kvm: Process exit requests in kvm loop

2010-05-05 Thread Avi Kivity
From: Jan Kiszka jan.kis...@siemens.com This unbreaks the monitor quit command for qemu-kvm. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/qemu-kvm.c b/qemu-kvm.c index 91f0222..43d599d 100644 --- a/qemu-kvm.c +++ b/qemu-kvm.c @@ -2047,6

[COMMIT master] replace set_msr_entry with kvm_msr_entry

2010-05-05 Thread Avi Kivity
From: Glauber Costa glom...@redhat.com this is yet another function that upstream qemu implements, so we can just use its implementation. Signed-off-by: Glauber Costa glom...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/qemu-kvm-x86.c b/qemu-kvm-x86.c index 748ff69..439c31a

[COMMIT master] introduce qemu_ram_map

2010-05-05 Thread Avi Kivity
From: Marcelo Tosatti mtosa...@redhat.com Which allows drivers to register an mmap region into ram block mappings. To be used by device assignment driver. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/cpu-common.h b/cpu-common.h index

[COMMIT master] remove unused kvm_dirty_bitmap array

2010-05-05 Thread Avi Kivity
From: Marcelo Tosatti mtosa...@redhat.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/qemu-kvm.c b/qemu-kvm.c index ae6570a..779bc5b 100644 --- a/qemu-kvm.c +++ b/qemu-kvm.c @@ -2156,7 +2156,6 @@ void

[COMMIT master] use upstream memslot management code

2010-05-05 Thread Avi Kivity
From: Marcelo Tosatti mtosa...@redhat.com Drop qemu-kvm's implementation in favour of qemu's, they are functionally equivalent. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/hw/device-assignment.c b/hw/device-assignment.c index

[COMMIT master] qemu-kvm tests: enhanced msr test

2010-05-05 Thread Avi Kivity
From: Naphtali Sprei nsp...@redhat.com Changed the code structure and added few tests for some of the msr's. Signed-off-by: Naphtali Sprei nsp...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/kvm/user/test/x86/msr.c b/kvm/user/test/x86/msr.c index 0d6f286..662cb4f 100644 ---

[COMMIT master] KVM: Document KVM_GET_MP_STATE and KVM_SET_MP_STATE

2010-05-05 Thread Avi Kivity
From: Avi Kivity a...@redhat.com Acked-by: Pekka Enberg penb...@cs.helsinki.fi Signed-off-by: Avi Kivity a...@redhat.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/Documentation/kvm/api.txt b/Documentation/kvm/api.txt index baa8fde..a237518 100644 ---

[COMMIT master] KVM: Minor MMU documentation edits

2010-05-05 Thread Avi Kivity
From: Avi Kivity a...@redhat.com Reported by Andrew Jones. Signed-off-by: Avi Kivity a...@redhat.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/Documentation/kvm/mmu.txt b/Documentation/kvm/mmu.txt index da04671..0cc28fb 100644 --- a/Documentation/kvm/mmu.txt +++

[COMMIT master] KVM: MMU: fix hashing for TDP and non-paging modes

2010-05-05 Thread Avi Kivity
From: Eric Northup digitale...@google.com For TDP mode, avoid creating multiple page table roots for the single guest-to-host physical address map by fixing the inputs used for the shadow page table hash in mmu_alloc_roots(). Signed-off-by: Eric Northup digitale...@google.com Signed-off-by:

[COMMIT master] KVM: VMX: Add definition for msr autoload entry

2010-05-05 Thread Avi Kivity
From: Avi Kivity a...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h index fb9a080..4497318 100644 --- a/arch/x86/include/asm/vmx.h +++ b/arch/x86/include/asm/vmx.h @@ -25,6 +25,8 @@ * */ +#include linux/types.h +

[COMMIT master] KVM: Fix mmu shrinker error

2010-05-05 Thread Avi Kivity
From: Gui Jianfeng guijianf...@cn.fujitsu.com kvm_mmu_remove_one_alloc_mmu_page() assumes kvm_mmu_zap_page() only reclaims only one sp, but that's not the case. This will cause mmu shrinker returns a wrong number. This patch fix the counting error. Signed-off-by: Gui Jianfeng

[COMMIT master] KVM: MMU: move unsync/sync tracpoints to proper place

2010-05-05 Thread Avi Kivity
From: Xiao Guangrong xiaoguangr...@cn.fujitsu.com Move unsync/sync tracepoints to the proper place, it's good for us to obtain unsync page live time Signed-off-by: Xiao Guangrong xiaoguangr...@cn.fujitsu.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/arch/x86/kvm/mmu.c

[COMMIT master] KVM: VMX: enable VMXON check with SMX enabled (Intel TXT)

2010-05-05 Thread Avi Kivity
From: Shane Wang shane.w...@intel.com Per document, for feature control MSR: Bit 1 enables VMXON in SMX operation. If the bit is clear, execution of VMXON in SMX operation causes a general-protection exception. Bit 2 enables VMXON outside SMX operation. If the bit is clear, execution

[COMMIT master] KVM: VMX: Avoid writing HOST_CR0 every entry

2010-05-05 Thread Avi Kivity
From: Avi Kivity a...@redhat.com cr0.ts may change between entries, so we copy cr0 to HOST_CR0 before each entry. That is slow, so instead, set HOST_CR0 to have TS set unconditionally (which is a safe value), and issue a clts() just before exiting vcpu context if the task indeed owns the fpu.

[COMMIT master] KVM: Fix wallclock version writing race

2010-05-05 Thread Avi Kivity
From: Avi Kivity a...@redhat.com Wallclock writing uses an unprotected global variable to hold the version; this can cause one guest to interfere with another if both write their wallclock at the same time. Acked-by: Glauber Costa glom...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com

[COMMIT master] KVM: x86 emulator: cleanup nop emulation

2010-05-05 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com Make it more explicit what we are checking for. Signed-off-by: Gleb Natapov g...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index a99d49c..03a7291 100644 --- a/arch/x86/kvm/emulate.c +++

[COMMIT master] KVM: x86 emulator: add get_cached_segment_base() callback to x86_emulate_ops

2010-05-05 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com On VMX it is expensive to call get_cached_descriptor() just to get segment base since multiple vmcs_reads are done instead of only one. Introduce new call back get_cached_segment_base() for efficiency. Signed-off-by: Gleb Natapov g...@redhat.com Signed-off-by:

[COMMIT master] KVM: x86 emulator: cleanup xchg emulation

2010-05-05 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com Dst operand is already initialized during decoding stage. No need to reinitialize. Signed-off-by: Gleb Natapov g...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index a81e6bf..a99d49c 100644

[COMMIT master] KVM: handle emulation failure case first

2010-05-05 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com If emulation failed return immediately. Signed-off-by: Gleb Natapov g...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 01bb1f3..4121a9f 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c

[COMMIT master] KVM: x86 emulator: handle far address source operand

2010-05-05 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com ljmp/lcall instruction operand contains address and segment. It can be 10 bytes long. Currently we decode it as two different operands. Fix it by introducing new kind of operand that can hold entire far address. Signed-off-by: Gleb Natapov g...@redhat.com

[COMMIT master] KVM: x86 emulator: set RFLAGS outside x86 emulator code

2010-05-05 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com Removes the need for set_flags() callback. Signed-off-by: Gleb Natapov g...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/arch/x86/include/asm/kvm_emulate.h b/arch/x86/include/asm/kvm_emulate.h index b7e00cb..a87d95f 100644 ---

[COMMIT master] KVM: fill in run-mmio details in (read|write)_emulated function

2010-05-05 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com Fill in run-mmio details in (read|write)_emulated function just like pio does. There is no point in filling only vcpu fields there just to copy them into vcpu-run a little bit later. Signed-off-by: Gleb Natapov g...@redhat.com Signed-off-by: Avi Kivity

[COMMIT master] KVM: x86 emulator: fix X86EMUL_RETRY_INSTR and X86EMUL_CMPXCHG_FAILED values

2010-05-05 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com Currently X86EMUL_PROPAGATE_FAULT, X86EMUL_RETRY_INSTR and X86EMUL_CMPXCHG_FAILED have the same value so caller cannot distinguish why function such as emulator_cmpxchg_emulated() (which can return both X86EMUL_PROPAGATE_FAULT and X86EMUL_CMPXCHG_FAILED) failed.

[COMMIT master] KVM: x86 emulator: cleanup some direct calls into kvm to use existing callbacks

2010-05-05 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com Use callbacks from x86_emulate_ops to access segments instead of calling into kvm directly. Signed-off-by: Gleb Natapov g...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index

[COMMIT master] KVM: x86 emulator: add (set|get)_msr callbacks to x86_emulate_ops

2010-05-05 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com Add (set|get)_msr callbacks to x86_emulate_ops instead of calling them directly. Signed-off-by: Gleb Natapov g...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/arch/x86/include/asm/kvm_emulate.h b/arch/x86/include/asm/kvm_emulate.h index

[COMMIT master] KVM: x86 emulator: move interruptibility state tracking out of emulator

2010-05-05 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com Emulator shouldn't access vcpu directly. Signed-off-by: Gleb Natapov g...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index 97a42e8..c40b405 100644 --- a/arch/x86/kvm/emulate.c +++

[COMMIT master] KVM: x86 emulator: do not inject exception directly into vcpu

2010-05-05 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com Return exception as a result of instruction emulation and handle injection in KVM code. Signed-off-by: Gleb Natapov g...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/arch/x86/include/asm/kvm_emulate.h b/arch/x86/include/asm/kvm_emulate.h

[COMMIT master] KVM: x86 emulator: make (get|set)_dr() callback return error if it fails

2010-05-05 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com Make (get|set)_dr() callback return error if it fails instead of injecting exception behind emulator's back. Signed-off-by: Gleb Natapov g...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c

[COMMIT master] KVM: x86 emulator: handle shadowed registers outside emulator

2010-05-05 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com Emulator shouldn't access vcpu directly. Signed-off-by: Gleb Natapov g...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index 42cb7d7..97a42e8 100644 --- a/arch/x86/kvm/emulate.c +++

[COMMIT master] KVM: x86 emulator: x86_emulate_insn() return -1 only in case of emulation failure

2010-05-05 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com Currently emulator returns -1 when emulation failed or IO is needed. Caller tries to guess whether emulation failed by looking at other variables. Make it easier for caller to recognise error condition by always returning -1 in case of failure. For this new

[COMMIT master] KVM: x86 emulator: advance RIP outside x86 emulator code

2010-05-05 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com Return new RIP as part of instruction emulation result instead of updating KVM's RIP from x86 emulator code. Signed-off-by: Gleb Natapov g...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c

[COMMIT master] KVM: x86 emulator: make set_cr() callback return error if it fails

2010-05-05 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com Make set_cr() callback return error if it fails instead of injecting #GP behind emulator's back. Signed-off-by: Gleb Natapov g...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/arch/x86/include/asm/kvm_emulate.h

[COMMIT master] KVM: x86 emulator: add (set|get)_dr callbacks to x86_emulate_ops

2010-05-05 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com Add (set|get)_dr callbacks to x86_emulate_ops instead of calling them directly. Signed-off-by: Gleb Natapov g...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/arch/x86/include/asm/kvm_emulate.h b/arch/x86/include/asm/kvm_emulate.h index

[COMMIT master] KVM: MMU: Don't read pdptrs with mmu spinlock held in mmu_alloc_roots

2010-05-05 Thread Avi Kivity
From: Avi Kivity a...@redhat.com On svm, kvm_read_pdptr() may require reading guest memory, which can sleep. Push the spinlock into mmu_alloc_roots(), and only take it after we've read the pdptr. Tested-by: Joerg Roedel joerg.roe...@amd.com Signed-off-by: Avi Kivity a...@redhat.com diff --git

[COMMIT master] KVM: x86 emulator: introduce read cache

2010-05-05 Thread Avi Kivity
From: Gleb Natapov g...@redhat.com Introduce read cache which is needed for instruction that require more then one exit to userspace. After returning from userspace the instruction will be re-executed with cached read value. Signed-off-by: Gleb Natapov g...@redhat.com Signed-off-by: Avi Kivity

[COMMIT master] KVM: x86: properly update ready_for_interrupt_injection

2010-05-05 Thread Avi Kivity
From: Marcelo Tosatti mtosa...@redhat.com The recent changes to emulate string instructions without entering guest mode exposed a bug where pending interrupts are not properly reflected in ready_for_interrupt_injection. The result is that userspace overwrites a previously queued interrupt, when

Re: [Qemu-devel] Re: [PATCH] virtio-spec: document block CMD and FLUSH

2010-05-05 Thread Neil Brown
On Wed, 5 May 2010 14:28:41 +0930 Rusty Russell ru...@rustcorp.com.au wrote: On Wed, 5 May 2010 05:47:05 am Jamie Lokier wrote: Jens Axboe wrote: On Tue, May 04 2010, Rusty Russell wrote: ISTR someone mentioning a desire for such an API years ago, so CC'ing the usual I/O

Re: [PATCH 2/2] turn off kvmclock when resetting cpu

2010-05-05 Thread Avi Kivity
On 05/04/2010 09:35 PM, Glauber Costa wrote: Currently, in the linux kernel, we reset kvmclock if we are rebooting into a crash kernel through kexec. The rationale, is that a new kernel won't follow the same memory addresses, and the memory where kvmclock is located in the first kernel, will be

Re: [PATCH 1/2] x86: eliminate TS_XSAVE

2010-05-05 Thread Avi Kivity
On 05/04/2010 09:24 PM, H. Peter Anvin wrote: I would like to request one change, however. I would like to see the alternatives code to be: movb $0,reg movb $1,reg ... instead of using xor (which has to be padded with NOPs, which is of course pointless since the slot is a

[PATCH v2 0/2] x86 FPU API

2010-05-05 Thread Avi Kivity
Currently all fpu accessors are wedded to task_struct. However kvm also uses the fpu in a different context. Introduce an FPU API, and replace the current uses with the new API. While this patchset is oriented towards deeper changes, as a first step it simlifies xsave for kvm. v2:

[PATCH v2 1/2] x86: eliminate TS_XSAVE

2010-05-05 Thread Avi Kivity
The fpu code currently uses current-thread_info-status TS_XSAVE as a way to distinguish between XSAVE capable processors and older processors. The decision is not really task specific; instead we use the task status to avoid a global memory reference - the value should be the same across all

Re: [PATCHv2 00/23] next round of emulator cleanups

2010-05-05 Thread Avi Kivity
On 04/28/2010 07:15 PM, Gleb Natapov wrote: This is the next round of emulator cleanups. Make it even more detached from kvm. First patch introduces IO read cache which is needed to correctly emulate instructions that require more then one IO read exit during emulation. Applied, thanks.

Re: [PATCH][RESEND] intel_txt: enable SMX flag for VMXON in KVM

2010-05-05 Thread Avi Kivity
On 05/05/2010 01:38 PM, Shane Wang wrote: Per Intel SDM 3B 20.7, for IA32_FEATURE_CONTROL MSR Bit 1 enables VMXON in SMX operation. If the bit is clear, execution of VMXON in SMX operation causes a general-protection exception. Bit 2 enables VMXON outside SMX operation. If the bit is clear,

Re: [PATCH v2 4/7] export paravirtual cpuid flags in KVM_GET_SUPPORTED_CPUID

2010-05-05 Thread Avi Kivity
On 05/03/2010 06:52 PM, Glauber Costa wrote: Right now, we were using individual KVM_CAP entities to communicate userspace about which cpuids we support. This is suboptimal, since it generates a delay between the feature arriving in the host, and being available at the guest. A much better

Re: [PATCH v2 6/7] don't compute pvclock adjustments if we trust the tsc

2010-05-05 Thread Avi Kivity
On 05/03/2010 06:52 PM, Glauber Costa wrote: If the HV told us we can fully trust the TSC, skip any correction Signed-off-by: Glauber Costaglom...@redhat.com --- arch/x86/include/asm/kvm_para.h|5 + arch/x86/include/asm/pvclock-abi.h |1 + arch/x86/kernel/kvmclock.c

Re: [PATCH v2 1/7] Enable pvclock flags in vcpu_time_info structure

2010-05-05 Thread Avi Kivity
On 05/03/2010 06:52 PM, Glauber Costa wrote: This patch removes one padding byte and transform it into a flags field. New versions of guests using pvclock will query these flags upon each read. Flags, however, will only be interpreted when the guest decides to. It uses the pvclock_valid_flags

Re: Booting/installing WindowsNT

2010-05-05 Thread Andre Przywara
Avi Kivity wrote: On 05/04/2010 06:27 PM, Andre Przywara wrote: 3. In all other cases so far it BSoDs with STOP 0x3E error right before displaying that kernel message. MSDN talks about a mulitprocessor configuration error: http://msdn.microsoft.com/en-us/library/ms819006.aspx I suspected

Re: Booting/installing WindowsNT

2010-05-05 Thread Avi Kivity
On 05/05/2010 11:32 AM, Andre Przywara wrote: Avi Kivity wrote: On 05/04/2010 06:27 PM, Andre Przywara wrote: 3. In all other cases so far it BSoDs with STOP 0x3E error right before displaying that kernel message. MSDN talks about a mulitprocessor configuration error:

Re: [PATCH 1/2] replace set_msr_entry with kvm_msr_entry

2010-05-05 Thread Avi Kivity
On 05/04/2010 09:35 PM, Glauber Costa wrote: this is yet another function that upstream qemu implements, so we can just use its implementation. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm

Re: vCPU scalability for linux VMs

2010-05-05 Thread Avi Kivity
On 05/05/2010 04:45 AM, Alec Istomin wrote: Gentlemen, Reaching out with a non-development question, sorry if it's not appropriate here. I'm looking for a way to improve Linux SMP VMs performance under KVM. My preliminary results show that single vCPU Linux VMs perform up to 10 times

Re: [PATCH] qemu-kvm: Process exit requests in kvm loop

2010-05-05 Thread Avi Kivity
On 05/04/2010 12:28 PM, Jan Kiszka wrote: This unbreaks the monitor quit command for qemu-kvm. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: qemu-kvm: event writeback can overwrite interrupts with -no-kvm-irqchip

2010-05-05 Thread Avi Kivity
On 05/04/2010 05:15 AM, Marcelo Tosatti wrote: Interrupts that are injected during a vcpu event save/writeback cycle are lost. Fix by writebacking the state before injecting interrupts. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe

Re: [patch 0/6] qemu-kvm: use upstream memslot code

2010-05-05 Thread Avi Kivity
On 05/04/2010 01:48 AM, Marcelo Tosatti wrote: See individual patches for details. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More

Re: Booting/installing WindowsNT

2010-05-05 Thread Michael Tokarev
05.05.2010 12:32, Andre Przywara wrote: Avi Kivity wrote: On 05/04/2010 06:27 PM, Andre Przywara wrote: 3. In all other cases so far it BSoDs with STOP 0x3E error right before displaying that kernel message. MSDN talks about a mulitprocessor configuration error:

Re: Fix -mem-path with hugetlbfs

2010-05-05 Thread Avi Kivity
On 05/04/2010 12:12 AM, Marcelo Tosatti wrote: Avi, please apply to both master and uq/master. --- Fallback to qemu_vmalloc in case file_ram_alloc fails. applied to both, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the

Re: [qemu-kvm tests PATCH] qemu-kvm tests: enhanced msr test

2010-05-05 Thread Avi Kivity
On 05/02/2010 06:10 PM, Naphtali Sprei wrote: Changed the code structure and added few tests for some of the msr's. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: Booting/installing WindowsNT

2010-05-05 Thread Andre Przywara
Avi Kivity wrote: On 05/05/2010 11:32 AM, Andre Przywara wrote: Avi Kivity wrote: On 05/04/2010 06:27 PM, Andre Przywara wrote: 3. In all other cases so far it BSoDs with STOP 0x3E error right before displaying that kernel message. MSDN talks about a mulitprocessor configuration error:

Re: [qemu-kvm tests PATCH] qemu-kvm tests: fix linker script problem

2010-05-05 Thread Avi Kivity
On 05/03/2010 02:34 PM, Naphtali Sprei wrote: This is a fix to a previous patch by me. It's on 'next' branch, as of now. commit 848bd0c89c83814023cf51c72effdbc7de0d18b7 causes the linker script itself (flat.lds) to become part of the linked objects, which messed the output file, one such

Re: Booting/installing WindowsNT

2010-05-05 Thread Avi Kivity
On 05/05/2010 11:51 AM, Michael Tokarev wrote: In the AMD CPUID guide leafs _0002 till _0004 are reserved, the CPU that Michael and I used (K8RevF) actually have a max leaf of 1 here. Default qemu64 has a max leaf of 4. So by saying -cpu qemu64,level=1 (or 2 or 3) it works for me. Modern

Re: [qemu-kvm tests PATCH] qemu-kvm tests: merged stringio into emulator

2010-05-05 Thread Avi Kivity
On 05/03/2010 06:39 PM, Naphtali Sprei wrote: based on 'next' branch. Changed test-case stringio into C code and merged into emulator test-case. Removed traces of stringio test-case. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from

Re: KVM hook for code integrity checking

2010-05-05 Thread Avi Kivity
On 04/30/2010 05:53 PM, Suen Chun Hui wrote: Dear KVM developers, I'm currently working on an open source security patch to use KVM to implement code verification on a guest VM in runtime. Thus, it would be very helpful if someone can point to me the right function or place to look at for

Re: [Autotest] [PATCH 7/9] KVM test: Introduce the local_login()

2010-05-05 Thread Michael Goldish
On 04/29/2010 02:44 AM, Amos Kong wrote: On Wed, Apr 28, 2010 at 03:01:40PM +0300, Michael Goldish wrote: On 04/26/2010 01:04 PM, Jason Wang wrote: This patch introduces a new method which is used to log into the guest through the guest serial console. The serial_mode must be set to session

Re: What changed since kvm-72 resulting in winNT to fail to boot (STOP 0x0000001E) ?

2010-05-05 Thread Michael Tokarev
02.05.2010 10:06, Avi Kivity wrote: On 04/30/2010 11:06 PM, Michael Tokarev wrote: I've a bugreport handy, see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=575439 about the apparent problem booting winNT 4 in kvm 0.12. At least 2 people were hit by this issue. In short, when booting winNT

Re: Booting/installing WindowsNT

2010-05-05 Thread Andre Przywara
Michael Tokarev wrote: 05.05.2010 12:32, Andre Przywara wrote: Avi Kivity wrote: On 05/04/2010 06:27 PM, Andre Przywara wrote: 3. In all other cases so far it BSoDs with STOP 0x3E error right before displaying that kernel message. MSDN talks about a mulitprocessor configuration error:

Re: [PATCH] KVM test: Add new subtest iozone_windows

2010-05-05 Thread Lucas Meneghel Rodrigues
On Wed, 2010-05-05 at 13:17 +0300, Michael Goldish wrote: On 05/04/2010 01:03 AM, Lucas Meneghel Rodrigues wrote: Following the new IOzone postprocessing changes, add a new KVM subtest iozone_windows, which takes advantage of the fact that there's a windows build for the test, so we can

question on virtio

2010-05-05 Thread Michael S. Tsirkin
Hi! I see this in virtio_ring.c: /* Put entry in available array (but don't update avail-idx * until they do sync). */ Why is it done this way? It seems that updating the index straight away would be simpler, while this might allow the host to specilatively look up the buffer

Re: Booting/installing WindowsNT

2010-05-05 Thread Avi Kivity
On 05/05/2010 01:18 PM, Andre Przywara wrote: Michael Tokarev wrote: 05.05.2010 12:32, Andre Przywara wrote: Avi Kivity wrote: On 05/04/2010 06:27 PM, Andre Przywara wrote: 3. In all other cases so far it BSoDs with STOP 0x3E error right before displaying that kernel message. MSDN talks

Re: [PATCH 1/2] x86: eliminate TS_XSAVE

2010-05-05 Thread H. Peter Anvin
Your code is functionally equivalent to the immediate values patch; neither uses a direct branch which would be more efficient. Avi Kivity a...@redhat.com wrote: On 05/04/2010 09:24 PM, H. Peter Anvin wrote: I would like to request one change, however. I would like to see the alternatives

Re: [PATCH 1/2] x86: eliminate TS_XSAVE

2010-05-05 Thread H. Peter Anvin
You don't want to use bool since some gcc versions don't handle bool in asm well; use a u8 instead. Avi Kivity a...@redhat.com wrote: On 05/04/2010 09:24 PM, H. Peter Anvin wrote: I would like to request one change, however. I would like to see the alternatives code to be: movb

Re: [PATCH v3 7/10] KVM MMU: allow more page become unsync at gfn mapping time

2010-05-05 Thread Xiao Guangrong
Marcelo Tosatti wrote: On Wed, Apr 28, 2010 at 11:55:49AM +0800, Xiao Guangrong wrote: In current code, shadow page can become asynchronous only if one shadow page for a gfn, this rule is too strict, in fact, we can let all last mapping page(i.e, it's the pte page) become unsync, and sync

[PATCH 1/2] KVM MMU: fix for forgot mark parent-unsync_children bit

2010-05-05 Thread Xiao Guangrong
When mapping a new parent to unsync shadow page, we should mark parent's unsync_children bit Reported-by: Marcelo Tosatti mtosa...@redhat.com Signed-off-by: Xiao Guangrong xiaoguangr...@cn.fujitsu.com --- arch/x86/kvm/mmu.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff

[PATCH 2/2] KVM MMU: fix race in invlpg code

2010-05-05 Thread Xiao Guangrong
It has race in invlpg code, like below sequences: A: hold mmu_lock and get 'sp' B: release mmu_lock and do other things C: hold mmu_lock and continue use 'sp' if other path freed 'sp' in stage B, then kernel will crash This patch checks 'sp' whether lived before use 'sp' in stage C

Re: [PATCH 1/2] KVM MMU: fix for forgot mark parent-unsync_children bit

2010-05-05 Thread Avi Kivity
On 05/05/2010 03:19 PM, Xiao Guangrong wrote: When mapping a new parent to unsync shadow page, we should mark parent's unsync_children bit Reported-by: Marcelo Tosattimtosa...@redhat.com Signed-off-by: Xiao Guangrongxiaoguangr...@cn.fujitsu.com --- arch/x86/kvm/mmu.c |4 +++- 1 files

Re: [PATCH 2/2] KVM MMU: fix race in invlpg code

2010-05-05 Thread Avi Kivity
On 05/05/2010 03:21 PM, Xiao Guangrong wrote: It has race in invlpg code, like below sequences: A: hold mmu_lock and get 'sp' B: release mmu_lock and do other things C: hold mmu_lock and continue use 'sp' if other path freed 'sp' in stage B, then kernel will crash This patch checks 'sp'

Re: [PATCH 1/2] KVM MMU: fix for forgot mark parent-unsync_children bit

2010-05-05 Thread Xiao Guangrong
Avi Kivity wrote: On 05/05/2010 03:19 PM, Xiao Guangrong wrote: When mapping a new parent to unsync shadow page, we should mark parent's unsync_children bit Reported-by: Marcelo Tosattimtosa...@redhat.com Signed-off-by: Xiao Guangrongxiaoguangr...@cn.fujitsu.com --- arch/x86/kvm/mmu.c

Re: [PATCH 2/2] KVM MMU: fix race in invlpg code

2010-05-05 Thread Xiao Guangrong
Avi Kivity wrote: spin_lock(vcpu-kvm-mmu_lock); +index = kvm_page_table_hashfn(gfn); +bucket =vcpu-kvm-arch.mmu_page_hash[index]; +hlist_for_each_entry_safe(s, node, tmp, bucket, hash_link) +if (s == sp) { +if (s-gfn == gfn s-role.word == role.word)

Re: [PATCH 2/2] KVM MMU: fix race in invlpg code

2010-05-05 Thread Avi Kivity
On 05/05/2010 03:45 PM, Xiao Guangrong wrote: Avi Kivity wrote: spin_lock(vcpu-kvm-mmu_lock); +index = kvm_page_table_hashfn(gfn); +bucket =vcpu-kvm-arch.mmu_page_hash[index]; +hlist_for_each_entry_safe(s, node, tmp, bucket, hash_link) +if (s == sp) { +

Re: [PATCH 4/4] KVM MMU: do not intercept invlpg if 'oos_shadow' is disabled

2010-05-05 Thread Xiao Guangrong
Avi Kivity wrote: On 04/30/2010 12:05 PM, Xiao Guangrong wrote: If 'oos_shadow' == 0, intercepting invlpg command is really unnecessary. And it's good for us to compare the performance between enable 'oos_shadow' and disable 'oos_shadow' @@ -74,8 +74,9 @@ static int dbg = 0;

[qemu-kvm tests PATCH v2] qemu-kvm tests: fix linker script problem

2010-05-05 Thread Naphtali Sprei
commit 848bd0c89c83814023cf51c72effdbc7de0d18b7 causes the linker script itself (flat.lds) to become part of the linked objects, which messed the output file, specifically, the symbol edata is not the last symbol anymore. change v1 - v2 Instead of dropping the dependency, put it on a separate

[PATCH 5/5] KVM: SVM: Don't allow nested guest to VMMCALL into host

2010-05-05 Thread Joerg Roedel
This patch disables the possibility for a l2-guest to do a VMMCALL directly into the host. This would happen if the l1-hypervisor doesn't intercept VMMCALL and the l2-guest executes this instruction. Signed-off-by: Joerg Roedel joerg.roe...@amd.com --- arch/x86/kvm/svm.c |3 +++ 1 files

[PATCH 0/5] Important fixes for KVM-AMD

2010-05-05 Thread Joerg Roedel
Hi Avi, Marcelo, here is a set of patches which fix problems in kvm-amd. Patch 1 fixes a stupid problem with the event-reinjection introduced by me in my previous patchset. Patch 2 was a helper to find the bug patch 3 fixes. I kept it in the patchset because it may be helpful in the future to

[PATCH 1/5] KVM: X86: Fix stupid bug in exception reinjection path

2010-05-05 Thread Joerg Roedel
The patch merged recently which allowed to mark an exception as reinjected has a bug as it always marks the exception as reinjected. This breaks nested-svm shadow-on-shadow implementation. Signed-off-by: Joerg Roedel joerg.roe...@amd.com --- arch/x86/kvm/x86.c |2 +- 1 files changed, 1

[PATCH 4/5] KVM: SVM: Allow EFER.LMSLE to be set with nested svm

2010-05-05 Thread Joerg Roedel
This patch enables setting of efer bit 13 which is allowed in all SVM capable processors. This is necessary for the SLES11 version of Xen 4.0 to boot with nested svm. Signed-off-by: Joerg Roedel joerg.roe...@amd.com --- arch/x86/include/asm/msr-index.h |2 ++ arch/x86/kvm/svm.c

[PATCH 2/5] KVM: SVM: Dump vmcb contents on failed vmrun

2010-05-05 Thread Joerg Roedel
This patch adds a function to dump the vmcb into the kernel log and calls it after a failed vmrun to ease debugging. Signed-off-by: Joerg Roedel joerg.roe...@amd.com --- arch/x86/kvm/svm.c | 95 1 files changed, 95 insertions(+), 0

[PATCH 3/5] KVM: SVM: Fix wrong intercept masks on 32 bit

2010-05-05 Thread Joerg Roedel
This patch makes KVM on 32 bit SVM working again by correcting the masks used for iret interception. With the wrong masks the upper 32 bits of the intercepts are masked out which leaves vmrun unintercepted. This is not legal on svm and the vmrun fails. Bug was introduced by commits 95ba827313 and

Re: [PATCH 4/4] KVM MMU: do not intercept invlpg if 'oos_shadow' is disabled

2010-05-05 Thread Avi Kivity
On 05/05/2010 03:54 PM, Xiao Guangrong wrote: Avi Kivity wrote: On 04/30/2010 12:05 PM, Xiao Guangrong wrote: If 'oos_shadow' == 0, intercepting invlpg command is really unnecessary. And it's good for us to compare the performance between enable 'oos_shadow' and disable

Re: [PATCH 4/5] KVM: SVM: Allow EFER.LMSLE to be set with nested svm

2010-05-05 Thread Avi Kivity
On 05/05/2010 05:04 PM, Joerg Roedel wrote: This patch enables setting of efer bit 13 which is allowed in all SVM capable processors. This is necessary for the SLES11 version of Xen 4.0 to boot with nested svm. Interesting, why does it require it? Obviously it isn't needed since it

Re: [PATCH 4/5] KVM: SVM: Allow EFER.LMSLE to be set with nested svm

2010-05-05 Thread Joerg Roedel
On Wed, May 05, 2010 at 05:46:59PM +0300, Avi Kivity wrote: On 05/05/2010 05:04 PM, Joerg Roedel wrote: This patch enables setting of efer bit 13 which is allowed in all SVM capable processors. This is necessary for the SLES11 version of Xen 4.0 to boot with nested svm. Interesting, why

Re: [qemu-kvm tests PATCH v2] qemu-kvm tests: fix linker script problem

2010-05-05 Thread Avi Kivity
On 05/05/2010 04:53 PM, Naphtali Sprei wrote: commit 848bd0c89c83814023cf51c72effdbc7de0d18b7 causes the linker script itself (flat.lds) to become part of the linked objects, which messed the output file, specifically, the symbol edata is not the last symbol anymore. change v1 - v2 Instead of

Re: [PATCH 4/5] KVM: SVM: Allow EFER.LMSLE to be set with nested svm

2010-05-05 Thread Avi Kivity
On 05/05/2010 06:04 PM, Joerg Roedel wrote: Because there is no cpuid bit for this feature. That is sad. You can roughly check for it using the svm cpuid bit. Doesn't it kill cross-vendor migration? -- error compiling committee.c: too many arguments to function -- To unsubscribe from

Re: [PATCH 4/5] KVM: SVM: Allow EFER.LMSLE to be set with nested svm

2010-05-05 Thread Roedel, Joerg
On Wed, May 05, 2010 at 11:06:59AM -0400, Avi Kivity wrote: On 05/05/2010 06:04 PM, Joerg Roedel wrote: You can roughly check for it using the svm cpuid bit. Doesn't it kill cross-vendor migration? Enabling Nested SVM kills it anyway, so this is not an issue. AFAIK the feature is not

Re: [PATCH 2/2] turn off kvmclock when resetting cpu

2010-05-05 Thread Glauber Costa
On Wed, May 05, 2010 at 10:26:43AM +0300, Avi Kivity wrote: +msr_data.info.nmsrs = n; + +return kvm_vcpu_ioctl(env, KVM_SET_MSRS,msr_data); +} + + How about a different approach? Query the supported MSRs (KVM_GET_MSR_LIST or thereabout) and reset them (with special cases for

Re: [PATCH 2/2] turn off kvmclock when resetting cpu

2010-05-05 Thread Avi Kivity
On 05/05/2010 06:24 PM, Glauber Costa wrote: On Wed, May 05, 2010 at 10:26:43AM +0300, Avi Kivity wrote: +msr_data.info.nmsrs = n; + +return kvm_vcpu_ioctl(env, KVM_SET_MSRS,msr_data); +} + + How about a different approach? Query the supported MSRs (KVM_GET_MSR_LIST or

Re: vCPU scalability for linux VMs

2010-05-05 Thread Alec Istomin
On Wednesday, May 5, 2010 at 04:43:32 -0400, Avi Kivity wrote: So you have a total of 32 vcpus on 8 cores? This is known to be problematic. You may see some improvement by enabling hyperthreading. exactly, 32 vCPUs on 8 core hardware that doesn't support hyperthreading (Clovertown E5335)

[qemu-kvm tests PATCH v3] qemu-kvm tests: fix linker script problem

2010-05-05 Thread Naphtali Sprei
commit 848bd0c89c83814023cf51c72effdbc7de0d18b7 causes the linker script itself (flat.lds) to become part of the linked objects, which messed the output file, specifically, the symbol edata is not the last symbol anymore. changes v2 - v3 Instead of using a separate rule, which doesn't really

Re: [PATCH 2/2] turn off kvmclock when resetting cpu

2010-05-05 Thread Glauber Costa
On Wed, May 05, 2010 at 06:34:22PM +0300, Avi Kivity wrote: On 05/05/2010 06:24 PM, Glauber Costa wrote: On Wed, May 05, 2010 at 10:26:43AM +0300, Avi Kivity wrote: +msr_data.info.nmsrs = n; + +return kvm_vcpu_ioctl(env, KVM_SET_MSRS,msr_data); +} + + How about a different

Re: [patch uq/master 0/9] enable smp 1 and related fixes

2010-05-05 Thread Anthony Liguori
On 05/04/2010 07:45 AM, Marcelo Tosatti wrote: -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html How does this work without an in-kernel apic (or does

Re: RFC: Network Plugin Architecture (NPA) for vmxnet3

2010-05-05 Thread Pankaj Thakkar
On Tue, May 04, 2010 at 05:58:52PM -0700, Chris Wright wrote: Date: Tue, 4 May 2010 17:58:52 -0700 From: Chris Wright chr...@sous-sol.org To: Pankaj Thakkar pthak...@vmware.com CC: linux-ker...@vger.kernel.org linux-ker...@vger.kernel.org, net...@vger.kernel.org net...@vger.kernel.org,

  1   2   >